#12415 fix(VCombobox): don't reset value to null if search is empty

Merged Kael KaelWD
Coverage Reach
components/VCalendar/mixins/calendar-with-events.ts components/VCalendar/mixins/calendar-with-intervals.ts components/VCalendar/mixins/calendar-base.ts components/VCalendar/mixins/times.ts components/VCalendar/mixins/mouse.ts components/VCalendar/util/timestamp.ts components/VCalendar/util/props.ts components/VCalendar/util/events.ts components/VCalendar/modes/stack.ts components/VCalendar/modes/common.ts components/VCalendar/modes/column.ts components/VCalendar/modes/index.ts components/VCalendar/VCalendar.ts components/VCalendar/VCalendarDaily.ts components/VCalendar/VCalendarWeekly.ts components/VCalendar/VCalendarCategory.ts components/VCalendar/VCalendarMonthly.ts components/VCalendar/index.ts components/VDatePicker/VDatePicker.ts components/VDatePicker/mixins/date-picker-table.ts components/VDatePicker/util/createNativeLocaleFormatter.ts components/VDatePicker/util/pad.ts components/VDatePicker/util/eventHelpers.ts components/VDatePicker/util/index.ts components/VDatePicker/util/monthChange.ts components/VDatePicker/util/isDateAllowed.ts components/VDatePicker/VDatePickerDateTable.ts components/VDatePicker/VDatePickerHeader.ts components/VDatePicker/VDatePickerYears.ts components/VDatePicker/VDatePickerTitle.ts components/VDatePicker/VDatePickerMonthTable.ts components/VDatePicker/index.ts components/VDataTable/VDataTable.ts components/VDataTable/VVirtualTable.ts components/VDataTable/VDataTableHeaderDesktop.ts components/VDataTable/VEditDialog.ts components/VDataTable/VDataTableHeaderMobile.ts components/VDataTable/MobileRow.ts components/VDataTable/Row.ts components/VDataTable/mixins/header.ts components/VDataTable/VDataTableHeader.ts components/VDataTable/RowGroup.ts components/VDataTable/VSimpleTable.ts components/VDataTable/index.ts components/VSelect/VSelect.ts components/VSelect/VSelectList.ts components/VSelect/index.ts components/VTimePicker/VTimePicker.ts components/VTimePicker/VTimePickerClock.ts components/VTimePicker/VTimePickerTitle.ts components/VTimePicker/index.ts components/VTimePicker/SelectingTimes.ts components/VTreeview/VTreeview.ts components/VTreeview/VTreeviewNode.ts components/VTreeview/util/filterTreeItems.ts components/VTreeview/index.ts components/VColorPicker/util/index.ts components/VColorPicker/VColorPickerEdit.ts components/VColorPicker/VColorPickerCanvas.ts components/VColorPicker/VColorPicker.ts components/VColorPicker/VColorPickerSwatches.ts components/VColorPicker/VColorPickerPreview.ts components/VColorPicker/index.ts components/VSlider/VSlider.ts components/VSlider/index.ts components/VAutocomplete/VAutocomplete.ts components/VAutocomplete/index.ts components/VMenu/VMenu.ts components/VMenu/index.ts components/VTextField/VTextField.ts components/VTextField/index.ts components/VNavigationDrawer/VNavigationDrawer.ts components/VNavigationDrawer/index.ts components/VList/VListGroup.ts components/VList/VListItem.ts components/VList/VList.ts components/VList/index.ts components/VList/VListItemGroup.ts components/VList/VListItemAvatar.ts components/VList/VListItemAction.ts components/VList/VListItemIcon.ts components/VSparkline/VSparkline.ts components/VSparkline/helpers/core.ts components/VSparkline/helpers/path.ts components/VSparkline/helpers/math.ts components/VSparkline/index.ts components/VDataIterator/VDataIterator.ts components/VDataIterator/VDataFooter.ts components/VDataIterator/index.ts components/VTabs/VTabs.ts components/VTabs/VTab.ts components/VTabs/VTabsBar.ts components/VTabs/VTabsItems.ts components/VTabs/index.ts components/VTabs/VTabItem.ts components/VTabs/VTabsSlider.ts components/VWindow/VWindow.ts components/VWindow/VWindowItem.ts components/VWindow/index.ts components/VStepper/VStepperContent.ts components/VStepper/VStepper.ts components/VStepper/VStepperStep.ts components/VStepper/index.ts components/VGrid/VCol.ts components/VGrid/VRow.ts components/VGrid/VContainer.ts components/VGrid/grid.ts components/VGrid/index.ts components/VGrid/VFlex.ts components/VGrid/VSpacer.ts components/VGrid/VLayout.ts components/VData/VData.ts components/VData/index.ts components/VSlideGroup/VSlideGroup.ts components/VSlideGroup/index.ts components/VSlideGroup/VSlideItem.ts components/VItemGroup/VItemGroup.ts components/VItemGroup/VItem.ts components/VItemGroup/index.ts components/VAppBar/VAppBar.ts components/VAppBar/VAppBarNavIcon.ts components/VAppBar/index.ts components/VDialog/VDialog.ts components/VDialog/index.ts components/VCombobox/VCombobox.ts components/VCombobox/index.ts components/VInput/VInput.ts components/VInput/index.ts components/VFileInput/VFileInput.ts components/VFileInput/index.ts components/VExpansionPanel/VExpansionPanelHeader.ts components/VExpansionPanel/VExpansionPanel.ts components/VExpansionPanel/VExpansionPanelContent.ts components/VExpansionPanel/VExpansionPanels.ts components/VExpansionPanel/index.ts components/VRangeSlider/VRangeSlider.ts components/VRangeSlider/index.ts components/VImg/VImg.ts components/VImg/index.ts components/VIcon/VIcon.ts components/VIcon/index.ts components/VRadioGroup/VRadio.ts components/VRadioGroup/VRadioGroup.ts components/VRadioGroup/index.ts components/VTooltip/VTooltip.ts components/VTooltip/index.ts components/VRating/VRating.ts components/VRating/index.ts components/VPagination/VPagination.ts components/VPagination/index.ts components/VAlert/VAlert.ts components/VAlert/index.ts components/transitions/expand-transition.ts components/transitions/createTransition.ts components/transitions/index.ts components/VProgressLinear/VProgressLinear.ts components/VProgressLinear/index.ts components/VCarousel/VCarousel.ts components/VCarousel/VCarouselItem.ts components/VCarousel/index.ts components/index.ts components/VBadge/VBadge.ts components/VBadge/index.ts components/VSnackbar/VSnackbar.ts components/VSnackbar/index.ts components/VBtn/VBtn.ts components/VBtn/index.ts components/VCheckbox/VCheckbox.ts components/VCheckbox/VSimpleCheckbox.ts components/VCheckbox/index.ts components/VSkeletonLoader/VSkeletonLoader.ts components/VSkeletonLoader/index.ts components/VToolbar/VToolbar.ts components/VToolbar/index.ts components/VChip/VChip.ts components/VChip/index.ts components/VForm/VForm.ts components/VForm/index.ts components/VOverflowBtn/VOverflowBtn.ts components/VOverflowBtn/index.ts components/VBanner/VBanner.ts components/VBanner/index.ts components/VFooter/VFooter.ts components/VFooter/index.ts components/VTimeline/VTimelineItem.ts components/VTimeline/VTimeline.ts components/VTimeline/index.ts components/VBottomNavigation/VBottomNavigation.ts components/VBottomNavigation/index.ts components/VProgressCircular/VProgressCircular.ts components/VProgressCircular/index.ts components/VSwitch/VSwitch.ts components/VSwitch/index.ts components/VTextarea/VTextarea.ts components/VTextarea/index.ts components/VBreadcrumbs/VBreadcrumbs.ts components/VBreadcrumbs/VBreadcrumbsItem.ts components/VBreadcrumbs/index.ts components/VBreadcrumbs/VBreadcrumbsDivider.ts components/VVirtualScroll/VVirtualScroll.ts components/VVirtualScroll/index.ts components/VCard/VCard.ts components/VCard/index.ts components/VSpeedDial/VSpeedDial.ts components/VSpeedDial/index.ts components/VParallax/VParallax.ts components/VParallax/index.ts components/VHover/VHover.ts components/VHover/index.ts components/VPicker/VPicker.ts components/VPicker/index.ts components/VSystemBar/VSystemBar.ts components/VSystemBar/index.ts components/VOverlay/VOverlay.ts components/VOverlay/index.ts components/VLazy/VLazy.ts components/VLazy/index.ts components/VResponsive/VResponsive.ts components/VResponsive/index.ts components/VSheet/VSheet.ts components/VSheet/index.ts components/VChipGroup/VChipGroup.ts components/VChipGroup/index.ts components/VMessages/VMessages.ts components/VMessages/index.ts components/VAvatar/VAvatar.ts components/VAvatar/index.ts components/VApp/VApp.ts components/VApp/index.ts components/VBtnToggle/VBtnToggle.ts components/VBtnToggle/index.ts components/VLabel/VLabel.ts components/VLabel/index.ts components/VCounter/VCounter.ts components/VCounter/index.ts components/VMain/VMain.ts components/VMain/index.ts components/VContent/VContent.ts components/VContent/index.ts components/VThemeProvider/VThemeProvider.ts components/VThemeProvider/index.ts components/VDivider/VDivider.ts components/VDivider/index.ts components/VSubheader/VSubheader.ts components/VSubheader/index.ts components/VBottomSheet/VBottomSheet.ts components/VBottomSheet/index.ts mixins/menuable/index.ts mixins/validatable/index.ts mixins/overlayable/index.ts mixins/activatable/index.ts mixins/selectable/index.ts mixins/detachable/index.ts mixins/routable/index.ts mixins/themeable/index.ts mixins/dependent/index.ts mixins/scrollable/index.ts mixins/applicationable/index.ts mixins/translatable/index.ts mixins/picker/index.ts mixins/colorable/index.ts mixins/mobile/index.ts mixins/stackable/index.ts mixins/groupable/index.ts mixins/intersectable/index.ts mixins/measurable/index.ts mixins/roundable/index.ts mixins/proxyable/index.ts mixins/picker-button/index.ts mixins/registrable/index.ts mixins/binds-attrs/index.ts mixins/bootable/index.ts mixins/toggleable/index.ts mixins/delayable/index.ts mixins/returnable/index.ts mixins/sizeable/index.ts mixins/rippleable/index.ts mixins/loadable/index.ts mixins/elevatable/index.ts mixins/positionable/index.ts mixins/ssr-bootable/index.ts mixins/button-group/index.ts mixins/localable/index.ts mixins/comparable/index.ts mixins/filterable/index.ts mixins/transitionable/index.ts util/helpers.ts util/colorUtils.ts util/mergeData.ts util/console.ts util/color/transformSRGB.ts util/color/transformCIELAB.ts util/dateTimeUtils.ts util/colors.ts util/dedupeModelListeners.ts util/rebuildFunctionalSlots.ts util/mixins.ts util/component.ts services/theme/index.ts services/theme/utils.ts services/breakpoint/index.ts services/goto/index.ts services/goto/util.ts services/goto/easing-patterns.ts services/lang/index.ts services/icons/presets/fa-svg.ts services/icons/presets/index.ts services/icons/presets/fa.ts services/icons/presets/mdi-svg.ts services/icons/presets/md.ts services/icons/presets/fa4.ts services/icons/presets/mdi.ts services/icons/index.ts services/application/index.ts services/presets/index.ts services/index.ts services/service/index.ts directives/ripple/index.ts directives/touch/index.ts directives/color/index.ts directives/intersect/index.ts directives/mutate/index.ts directives/click-outside/index.ts directives/scroll/index.ts directives/resize/index.ts directives/index.ts locale/index.ts locale/cs.ts locale/uk.ts locale/no.ts locale/hr.ts locale/lt.ts locale/sv.ts locale/sk.ts locale/he.ts locale/et.ts locale/id.ts locale/el.ts locale/de.ts locale/es.ts locale/hu.ts locale/tr.ts locale/it.ts locale/sl.ts locale/ro.ts locale/fr.ts locale/zh-Hans.ts locale/th.ts locale/sr-Cyrl.ts locale/ru.ts locale/nl.ts locale/pl.ts locale/ar.ts locale/pt.ts locale/lv.ts locale/fa.ts locale/fi.ts locale/en.ts locale/ja.ts locale/af.ts locale/ca.ts locale/zh-Hant.ts locale/ko.ts install.ts framework.ts index.ts presets/default/index.ts entry-lib.ts

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.


@@ -177,18 +177,15 @@
Loading
177 177
      this.editingIndex = -1
178 178
    },
179 179
    updateCombobox () {
180 -
      const isUsingSlot = Boolean(this.$scopedSlots.selection) || this.hasChips
181 -
182 -
      // If search is not dirty and is
183 -
      // using slot, do nothing
184 -
      if (isUsingSlot && !this.searchIsDirty) return
180 +
      // If search is not dirty, do nothing
181 +
      if (!this.searchIsDirty) return
185 182
186 183
      // The internal search is not matching
187 184
      // the internal value, update the input
188 185
      if (this.internalSearch !== this.getText(this.internalValue)) this.setValue()
189 186
190 -
      // Reset search if using slot
191 -
      // to avoid a double input
187 +
      // Reset search if using slot to avoid a double input
188 +
      const isUsingSlot = Boolean(this.$scopedSlots.selection) || this.hasChips
192 189
      if (isUsingSlot) this.internalSearch = undefined
193 190
    },
194 191
    updateSelf () {

@@ -134,8 +134,7 @@
Loading
134 134
      }
135 135
    },
136 136
    searchIsDirty (): boolean {
137 -
      return this.internalSearch != null &&
138 -
        this.internalSearch !== ''
137 +
      return this.internalSearch != null
139 138
    },
140 139
    selectedItem (): any {
141 140
      if (this.multiple) return null

Everything is accounted for!

No changes detected that need to be reviewed.
What changes does Codecov check for?
Lines, not adjusted in diff, that have changed coverage data.
Files that introduced coverage data that had none before.
Files that have missing coverage data that once were tracked.
Files Coverage
packages/vuetify/src -<.01% 86.43%
Project Totals (368 files) 86.43%
Loading