nekosaur
No flags found
Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.
e.g., #unittest #integration
#production #enterprise
#frontend #backend
#12357
fix(VCarousel): incorrect transition direction when using touch
Showing 2 of 4 files from the diff.
Other files ignored by Codecov
@@ -44,10 +44,7 @@
Loading
| 44 | 44 | type: [Boolean, String], |
|
| 45 | 45 | default: '$prev', |
|
| 46 | 46 | }, |
|
| 47 | - | reverse: { |
|
| 48 | - | type: Boolean, |
|
| 49 | - | default: undefined, |
|
| 50 | - | }, |
|
| 47 | + | reverse: Boolean, |
|
| 51 | 48 | showArrows: Boolean, |
|
| 52 | 49 | showArrowsOnHover: Boolean, |
|
| 53 | 50 | touch: Object as PropType<TouchHandlers>, |
@@ -60,7 +57,6 @@
Loading
| 60 | 57 | ||
| 61 | 58 | data () { |
|
| 62 | 59 | return { |
|
| 63 | - | changedByDelimiters: false, |
|
| 64 | 60 | internalHeight: undefined as undefined | string, // This can be fixed by child class. |
|
| 65 | 61 | transitionHeight: undefined as undefined | string, // Intermediate height during transition. |
|
| 66 | 62 | transitionCount: 0, // Number of windows in transition state. |
@@ -83,7 +79,7 @@
Loading
| 83 | 79 | if (!this.isBooted) return '' |
|
| 84 | 80 | ||
| 85 | 81 | const axis = this.vertical ? 'y' : 'x' |
|
| 86 | - | const reverse = this.$vuetify.rtl && axis === 'x' ? !this.internalReverse : this.internalReverse |
|
| 82 | + | const reverse = this.internalReverse ? !this.isReverse : this.isReverse |
|
| 87 | 83 | const direction = reverse ? '-reverse' : '' |
|
| 88 | 84 | ||
| 89 | 85 | return `v-window-${axis}${direction}-transition` |
@@ -105,12 +101,14 @@
Loading
| 105 | 101 | }) |
|
| 106 | 102 | }, |
|
| 107 | 103 | internalReverse (): boolean { |
|
| 108 | - | return this.reverse ? !this.isReverse : this.isReverse |
|
| 104 | + | return this.$vuetify.rtl ? !this.reverse : this.reverse |
|
| 109 | 105 | }, |
|
| 110 | 106 | }, |
|
| 111 | 107 | ||
| 112 | 108 | watch: { |
|
| 113 | - | internalIndex: 'updateReverse', |
|
| 109 | + | internalIndex (val, oldVal) { |
|
| 110 | + | this.isReverse = this.updateReverse(val, oldVal) |
|
| 111 | + | }, |
|
| 114 | 112 | }, |
|
| 115 | 113 | ||
| 116 | 114 | mounted () { |
@@ -138,7 +136,7 @@
Loading
| 138 | 136 | genIcon ( |
|
| 139 | 137 | direction: 'prev' | 'next', |
|
| 140 | 138 | icon: string, |
|
| 141 | - | fn: () => void |
|
| 139 | + | click: () => void |
|
| 142 | 140 | ) { |
|
| 143 | 141 | return this.$createElement('div', { |
|
| 144 | 142 | staticClass: `v-window__${direction}`, |
@@ -148,12 +146,7 @@
Loading
| 148 | 146 | attrs: { |
|
| 149 | 147 | 'aria-label': this.$vuetify.lang.t(`$vuetify.carousel.${direction}`), |
|
| 150 | 148 | }, |
|
| 151 | - | on: { |
|
| 152 | - | click: () => { |
|
| 153 | - | this.changedByDelimiters = true |
|
| 154 | - | fn() |
|
| 155 | - | }, |
|
| 156 | - | }, |
|
| 149 | + | on: { click }, |
|
| 157 | 150 | }, [ |
|
| 158 | 151 | this.$createElement(VIcon, { |
|
| 159 | 152 | props: { large: true }, |
@@ -211,8 +204,6 @@
Loading
| 211 | 204 | return prevIndex |
|
| 212 | 205 | }, |
|
| 213 | 206 | next () { |
|
| 214 | - | this.isReverse = this.$vuetify.rtl |
|
| 215 | - | ||
| 216 | 207 | /* istanbul ignore if */ |
|
| 217 | 208 | if (!this.hasActiveItems || !this.hasNext) return |
|
| 218 | 209 |
@@ -222,8 +213,6 @@
Loading
| 222 | 213 | this.internalValue = this.getValue(item, nextIndex) |
|
| 223 | 214 | }, |
|
| 224 | 215 | prev () { |
|
| 225 | - | this.isReverse = !this.$vuetify.rtl |
|
| 226 | - | ||
| 227 | 216 | /* istanbul ignore if */ |
|
| 228 | 217 | if (!this.hasActiveItems || !this.hasPrev) return |
|
| 229 | 218 |
@@ -233,12 +222,15 @@
Loading
| 233 | 222 | this.internalValue = this.getValue(item, lastIndex) |
|
| 234 | 223 | }, |
|
| 235 | 224 | updateReverse (val: number, oldVal: number) { |
|
| 236 | - | if (this.changedByDelimiters) { |
|
| 237 | - | this.changedByDelimiters = false |
|
| 238 | - | return |
|
| 225 | + | const lastIndex = this.items.length - 1 |
|
| 226 | + | ||
| 227 | + | if (val === lastIndex && oldVal === 0) { |
|
| 228 | + | return true |
|
| 229 | + | } else if (val === 0 && oldVal === lastIndex) { |
|
| 230 | + | return false |
|
| 231 | + | } else { |
|
| 232 | + | return val < oldVal |
|
| 239 | 233 | } |
|
| 240 | - | ||
| 241 | - | this.isReverse = val < oldVal |
|
| 242 | 234 | }, |
|
| 243 | 235 | }, |
|
| 244 | 236 |
Learn more Showing 64 files with coverage changes found.
Changes in
→
packages/vuetify/src/components/VColorPicker/VColorPickerPreview.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/components/VSlideGroup/VSlideGroup.ts
+1
+5
Loading file...
Changes in
→
packages/vuetify/src/components/VDataTable/VDataTableHeaderDesktop.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/components/VAlert/VAlert.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/util/console.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/components/VImg/VImg.ts
+1
+1
Loading file...
Changes in
→
packages/vuetify/src/components/VNavigationDrawer/VNavigationDrawer.ts
+53
+7
Loading file...
Changes in
→
packages/vuetify/src/directives/color/index.ts
+5
+1
Loading file...
Changes in
→
packages/vuetify/src/install.ts
+1
+14
Loading file...
Changes in
→
packages/vuetify/src/components/VLazy/VLazy.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/components/VCalendar/VCalendarCategory.ts
-1
+1
Loading file...
Changes in
→
packages/vuetify/src/components/VTreeview/util/filterTreeItems.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/components/VDatePicker/util/createNativeLocaleFormatter.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/components/transitions/createTransition.ts
+2
+1
Loading file...
Changes in
→
packages/vuetify/src/services/theme/utils.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/directives/mutate/index.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/util/color/transformSRGB.ts
+2
Loading file...
Changes in
→
packages/vuetify/src/components/VItemGroup/VItemGroup.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/components/VCalendar/mixins/mouse.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/util/color/transformCIELAB.ts
+2
Loading file...
Changes in
→
packages/vuetify/src/mixins/proxyable/index.ts
+8
Loading file...
Changes in
→
packages/vuetify/src/mixins/picker-button/index.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/services/icons/presets/fa-svg.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/components/VSparkline/helpers/core.ts
+2
Loading file...
Changes in
→
packages/vuetify/src/mixins/groupable/index.ts
+10
Loading file...
Changes in
→
packages/vuetify/src/components/VSnackbar/VSnackbar.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/directives/intersect/index.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/components/VDataTable/VSimpleTable.ts
+4
Loading file...
Changes in
→
packages/vuetify/src/services/lang/index.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/services/application/index.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/mixins/toggleable/index.ts
+5
Loading file...
Changes in
→
packages/vuetify/src/directives/click-outside/index.ts
+12
Loading file...
Changes in
→
packages/vuetify/src/services/theme/index.ts
+2
Loading file...
Changes in
→
packages/vuetify/src/components/VWindow/VWindow.ts
+2
Loading file...
Changes in
→
packages/vuetify/src/components/VDataTable/VDataTable.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/util/colorUtils.ts
+2
Loading file...
Changes in
→
packages/vuetify/src/components/VCalendar/util/timestamp.ts
+2
Loading file...
Changes in
→
packages/vuetify/src/components/VCheckbox/VCheckbox.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/util/mergeData.ts
+2
Loading file...
Changes in
→
packages/vuetify/src/components/VInput/VInput.ts
+3
Loading file...
Changes in
→
packages/vuetify/src/components/VSparkline/VSparkline.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/components/VSwitch/VSwitch.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/components/VSelect/VSelectList.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/components/VIcon/VIcon.ts
+21
Loading file...
Changes in
→
packages/vuetify/src/directives/ripple/index.ts
+2
Loading file...
Changes in
→
packages/vuetify/src/components/VCalendar/VCalendarWeekly.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/components/VCalendar/util/events.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/services/presets/index.ts
+1
Loading file...
Changes in
→
packages/vuetify/src/services/goto/index.ts
+4
Loading file...
Changes in
→
packages/vuetify/src/components/VColorPicker/VColorPickerEdit.ts
+11
Loading file...
Changes in
→
packages/vuetify/src/components/VDatePicker/VDatePicker.ts
+47
Loading file...
Changes in
→
packages/vuetify/src/components/VMenu/VMenu.ts
+22
+3
Loading file...
Changes in
→
packages/vuetify/src/util/helpers.ts
+92
+1
Loading file...
Changes in
→
packages/vuetify/src/components/VTabs/VTabs.ts
+30
+2
Loading file...
Changes in
→
packages/vuetify/src/components/VAutocomplete/VAutocomplete.ts
+32
Loading file...
Changes in
→
packages/vuetify/src/components/VTimePicker/VTimePicker.ts
-1
+4
Loading file...
Changes in
→
packages/vuetify/src/components/VSlider/VSlider.ts
+87
Loading file...
Changes in
→
packages/vuetify/src/components/VDialog/VDialog.ts
+44
+13
Loading file...
Changes in
→
packages/vuetify/src/components/VSelect/VSelect.ts
+129
+5
Loading file...
Changes in
→
packages/vuetify/src/components/VData/VData.ts
+54
+2
Loading file...
Changes in
→
packages/vuetify/src/components/VTextField/VTextField.ts
-1
-1
+69
Loading file...
Changes in
→
packages/vuetify/src/mixins/themeable/index.ts
+20
Loading file...
Changes in
→
packages/vuetify/src/components/VColorPicker/util/index.ts
-2
+8
Loading file...
Changes in
→
packages/vuetify/src/components/VCalendar/mixins/calendar-with-events.ts
-11
+12
Loading file...
2
Commits
| Files | Coverage |
|---|---|
| packages/vuetify/src | 0.56% 87.00% |
| Project Totals (368 files) | 87.00% |
#123577ce2cebadf3ed75077c3c