Commit ⋅ uktrade/directory-client-core

Showing 2 of 6 files from the diff.

100.00% 100.00% ø

directory_client_core/helpers.py changed.

100.00% 100.00% ø

tests/test_helpers.py changed.

Other files ignored by Codecov

.circleci/config.yml has changed.

CHANGELOG.md has changed.

setup.py has changed.

README.md has changed.

@@ -4,7 +4,7 @@

Loading

from urllib.parse import urlencode

import requests
from requests.exceptions import HTTPError, RequestException
from requests.exceptions import RequestException
from w3lib.url import canonicalize_url

from django.conf import settings

@@ -128,7 +128,7 @@

Loading

    assert response_two.content == expected_data
    assert isinstance(response_two, helpers.CacheResponse)

    log = caplog.records()[-1]
    log = caplog.records[-1]
    assert log.levelname == 'ERROR'
    assert log.msg == helpers.MESSAGE_CACHE_HIT
    assert log.status_code == 400

@@ -146,7 +146,7 @@

Loading

    assert response.status_code == 400
    assert isinstance(response, helpers.FailureResponse)

    log = caplog.records()[-1]
    log = caplog.records[-1]
    assert log.levelname == 'ERROR'
    assert log.msg == helpers.MESSAGE_CACHE_MISS
    assert log.status_code == 400

@@ -164,7 +164,7 @@

Loading

    assert response.status_code == 404
    assert isinstance(response, helpers.LiveResponse)

    log = caplog.records()[-1]
    log = caplog.records[-1]
    assert log.levelname == 'ERROR'
    assert log.msg == helpers.MESSAGE_NOT_FOUND
    assert log.status_code == 404

@@ -192,7 +192,7 @@

Loading

    assert response_two.content == expected_data
    assert isinstance(response_two, helpers.CacheResponse)

    log = caplog.records()[-1]
    log = caplog.records[-1]
    assert log.levelname == 'ERROR'
    assert log.msg == helpers.MESSAGE_CACHE_HIT
    assert log.url == path

@@ -205,7 +205,7 @@

Loading

        with pytest.raises(requests.exceptions.ConnectionError):
            cached_client.retrieve('thing')

    assert len(caplog.records()) == 0
    assert len(caplog.records) == 0


def test_cache_querystrings(cached_client, fallback_cache):

@@ -234,7 +234,7 @@

Loading

        mock_get.side_effect = requests.exceptions.ConnectionError()
        cached_client.retrieve('thing')

    errors = [item for item in caplog.records() if item.levelname == 'ERROR']
    errors = [item for item in caplog.records if item.levelname == 'ERROR']
    assert len(errors) == 1

    with patch('directory_client_core.base.AbstractAPIClient.get') as mock_get:

@@ -242,7 +242,7 @@

Loading

        cached_client.retrieve('thing')

    # second log entry was filtered out
    errors = [item for item in caplog.records() if item.levelname == 'ERROR']
    errors = [item for item in caplog.records if item.levelname == 'ERROR']
    assert len(errors) == 1



Files		•	•	Coverage
directory_client_core	168	164	4	97.62%
tests	270	270	0	100.00%
Project Totals (9 files)	438	434	4	99.09%

View CI Build Download

No yaml found.

Create your codecov.yml to customize your Codecov experience

Read the docs

Interact now

The inner-most circle is the entire project, moving away from the center are folders then, finally, a single file. The size and color of each slice is representing the number of statements and the coverage, respectively.

SVG

The top section represents the entire project. Proceeding with folders and finally individual files. The size and color of each slice is representing the number of statements and the coverage, respectively.

SVG

Each block represents a single file in the project. The size and color of each block is represented by the number of statements and the coverage, respectively.

SVG

Learn more about the coverage sunburst graph

128	128		assert response_two.content == expected_data
129	129		assert isinstance(response_two, helpers.CacheResponse)
130	130
131		-	log = caplog.records()[-1]
	131	+	log = caplog.records[-1]
132	132		assert log.levelname == 'ERROR'
133	133		assert log.msg == helpers.MESSAGE_CACHE_HIT
134	134		assert log.status_code == 400

146	146		assert response.status_code == 400
147	147		assert isinstance(response, helpers.FailureResponse)
148	148
149		-	log = caplog.records()[-1]
	149	+	log = caplog.records[-1]
150	150		assert log.levelname == 'ERROR'
151	151		assert log.msg == helpers.MESSAGE_CACHE_MISS
152	152		assert log.status_code == 400

192	192		assert response_two.content == expected_data
193	193		assert isinstance(response_two, helpers.CacheResponse)
194	194
195		-	log = caplog.records()[-1]
	195	+	log = caplog.records[-1]
196	196		assert log.levelname == 'ERROR'
197	197		assert log.msg == helpers.MESSAGE_CACHE_HIT
198	198		assert log.url == path

205	205		with pytest.raises(requests.exceptions.ConnectionError):
206	206		cached_client.retrieve('thing')
207	207
208		-	assert len(caplog.records()) == 0
	208	+	assert len(caplog.records) == 0
209	209
210	210
211	211		def test_cache_querystrings(cached_client, fallback_cache):

234	234		mock_get.side_effect = requests.exceptions.ConnectionError()
235	235		cached_client.retrieve('thing')
236	236
237		-	errors = [item for item in caplog.records() if item.levelname == 'ERROR']
	237	+	errors = [item for item in caplog.records if item.levelname == 'ERROR']
238	238		assert len(errors) == 1
239	239
240	240		with patch('directory_client_core.base.AbstractAPIClient.get') as mock_get:

4	4		from urllib.parse import urlencode
5	5
6	6		import requests
7		-	from requests.exceptions import HTTPError, RequestException
	7	+	from requests.exceptions import RequestException
8	8		from w3lib.url import canonicalize_url
9	9
10	10		from django.conf import settings

164	164		assert response.status_code == 404
165	165		assert isinstance(response, helpers.LiveResponse)
166	166
167		-	log = caplog.records()[-1]
	167	+	log = caplog.records[-1]
168	168		assert log.levelname == 'ERROR'
169	169		assert log.msg == helpers.MESSAGE_NOT_FOUND
170	170		assert log.status_code == 404

242	242		cached_client.retrieve('thing')
243	243
244	244		# second log entry was filtered out
245		-	errors = [item for item in caplog.records() if item.levelname == 'ERROR']
	245	+	errors = [item for item in caplog.records if item.levelname == 'ERROR']
246	246		assert len(errors) == 1
247	247
248	248

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Updating our web app

No yaml found.