gh typeorm typeorm
Log in
Sign up

#6982 fix: findRoots should get the defined primary key column

74.75% ø +0.02%
Merged Ilyas Foo ilyasfoo
Overview Diff Coverage Changes
1
 Files Commits
Coverage Reach
driver/postgres/PostgresQueryRunner.ts driver/postgres/PostgresDriver.ts driver/sqlserver/SqlServerQueryRunner.ts driver/sqlserver/SqlServerDriver.ts driver/sqlserver/MssqlParameter.ts driver/sap/SapQueryRunner.ts driver/sap/SapDriver.ts driver/cockroachdb/CockroachQueryRunner.ts driver/cockroachdb/CockroachDriver.ts driver/mysql/MysqlQueryRunner.ts driver/mysql/MysqlDriver.ts driver/aurora-data-api/AuroraDataApiQueryRunner.ts driver/aurora-data-api/AuroraDataApiDriver.ts driver/aurora-data-api/AuroraDataApiConnection.ts driver/oracle/OracleQueryRunner.ts driver/oracle/OracleDriver.ts driver/sqlite-abstract/AbstractSqliteQueryRunner.ts driver/sqlite-abstract/AbstractSqliteDriver.ts driver/mongodb/MongoQueryRunner.ts driver/mongodb/MongoDriver.ts driver/mongodb/typings.ts driver/sqljs/SqljsDriver.ts driver/sqljs/SqljsQueryRunner.ts driver/better-sqlite3/BetterSqlite3QueryRunner.ts driver/better-sqlite3/BetterSqlite3Driver.ts driver/sqlite/SqliteDriver.ts driver/sqlite/SqliteQueryRunner.ts driver/expo/ExpoQueryRunner.ts driver/expo/ExpoDriver.ts driver/aurora-data-api-pg/AuroraDataApiPostgresQueryRunner.ts driver/aurora-data-api-pg/AuroraDataApiPostgresDriver.ts driver/nativescript/NativescriptDriver.ts driver/nativescript/NativescriptQueryRunner.ts driver/react-native/ReactNativeDriver.ts driver/react-native/ReactNativeQueryRunner.ts driver/cordova/CordovaDriver.ts driver/cordova/CordovaQueryRunner.ts driver/DriverFactory.ts driver/DriverUtils.ts driver/SqlInMemory.ts driver/Query.ts query-builder/SelectQueryBuilder.ts query-builder/QueryBuilder.ts query-builder/transformer/RawSqlResultsToEntityTransformer.ts query-builder/transformer/PlainObjectToDatabaseEntityTransformer.ts query-builder/transformer/DocumentToEntityTransformer.ts query-builder/transformer/PlainObjectToNewEntityTransformer.ts query-builder/InsertQueryBuilder.ts query-builder/UpdateQueryBuilder.ts query-builder/SoftDeleteQueryBuilder.ts query-builder/relation-id/RelationIdLoader.ts query-builder/relation-id/RelationIdAttribute.ts query-builder/relation-id/RelationIdMetadataToAttributeTransformer.ts query-builder/RelationIdLoader.ts query-builder/QueryExpressionMap.ts query-builder/relation-count/RelationCountLoader.ts query-builder/relation-count/RelationCountAttribute.ts query-builder/relation-count/RelationCountMetadataToAttributeTransformer.ts query-builder/DeleteQueryBuilder.ts query-builder/RelationLoader.ts query-builder/ReturningResultsEntityUpdator.ts query-builder/JoinAttribute.ts query-builder/RelationQueryBuilder.ts query-builder/RelationUpdater.ts query-builder/RelationRemover.ts query-builder/Alias.ts query-builder/QueryBuilderUtils.ts query-builder/result/InsertResult.ts query-builder/result/UpdateResult.ts query-builder/result/DeleteResult.ts query-builder/Brackets.ts persistence/SubjectExecutor.ts persistence/subject-builder/ManyToManySubjectBuilder.ts persistence/subject-builder/OneToManySubjectBuilder.ts persistence/subject-builder/CascadesSubjectBuilder.ts persistence/subject-builder/OneToOneInverseSideSubjectBuilder.ts persistence/SubjectChangedColumnsComputer.ts persistence/Subject.ts persistence/tree/ClosureSubjectExecutor.ts persistence/tree/NestedSetSubjectExecutor.ts persistence/tree/MaterializedPathSubjectExecutor.ts persistence/SubjectTopoligicalSorter.ts persistence/EntityPersistExecutor.ts persistence/SubjectDatabaseEntityLoader.ts metadata/ColumnMetadata.ts metadata/EntityMetadata.ts metadata/RelationMetadata.ts metadata/EmbeddedMetadata.ts metadata/IndexMetadata.ts metadata/UniqueMetadata.ts metadata/RelationIdMetadata.ts metadata/EntityListenerMetadata.ts metadata/ForeignKeyMetadata.ts metadata/RelationCountMetadata.ts metadata/CheckMetadata.ts metadata/ExclusionMetadata.ts metadata/types/EventListenerTypes.ts schema-builder/RdbmsSchemaBuilder.ts schema-builder/table/Table.ts schema-builder/table/TableColumn.ts schema-builder/table/TableForeignKey.ts schema-builder/table/TableIndex.ts schema-builder/table/TableCheck.ts schema-builder/table/TableUnique.ts schema-builder/table/TableExclusion.ts schema-builder/MongoSchemaBuilder.ts schema-builder/view/View.ts schema-builder/util/TableUtils.ts entity-manager/EntityManager.ts entity-manager/MongoEntityManager.ts entity-manager/EntityManagerFactory.ts entity-manager/SqljsEntityManager.ts commands/InitCommand.ts commands/MigrationGenerateCommand.ts commands/MigrationRunCommand.ts commands/MigrationRevertCommand.ts commands/SchemaLogCommand.ts commands/MigrationCreateCommand.ts commands/QueryCommand.ts commands/EntityCreateCommand.ts commands/VersionCommand.ts commands/SubscriberCreateCommand.ts commands/CacheClearCommand.ts commands/MigrationShowCommand.ts commands/SchemaSyncCommand.ts commands/SchemaDropCommand.ts commands/CommandUtils.ts metadata-builder/EntityMetadataBuilder.ts metadata-builder/JunctionEntityMetadataBuilder.ts metadata-builder/EntityMetadataValidator.ts metadata-builder/RelationJoinColumnBuilder.ts metadata-builder/ClosureJunctionEntityMetadataBuilder.ts metadata-builder/MetadataUtils.ts util/OrmUtils.ts util/DepGraph.ts util/RandomGenerator.ts util/DateUtils.ts util/DirectoryExportedClassesLoader.ts util/StringUtils.ts util/ApplyValueTransformers.ts util/VersionUtils.ts util/ObjectUtils.ts error/EntityNotFoundError.ts error/RepositoryNotTreeError.ts error/RepositoryNotFoundError.ts error/EntityMetadataNotFoundError.ts error/CannotCreateEntityIdMapError.ts error/MissingJoinTableError.ts error/MissingJoinColumnError.ts error/QueryFailedError.ts error/DataTypeNotSupportedError.ts error/FindRelationsNotFoundError.ts error/MetadataAlreadyExistsError.ts error/NamingStrategyNotFoundError.ts error/CannotDetermineEntityError.ts error/CustomRepositoryCannotInheritRepositoryError.ts error/AlreadyHasActiveConnectionError.ts error/UsingJoinTableOnlyOnOneSideAllowedError.ts error/CannotConnectAlreadyConnectedError.ts error/NoConnectionForRepositoryError.ts error/MissingDeleteDateColumnError.ts error/CustomRepositoryNotFoundError.ts error/MissingDriverError.ts error/UsingJoinTableIsNotAllowedError.ts error/UsingJoinColumnIsNotAllowedError.ts error/DriverPackageNotInstalledError.ts error/MustBeEntityError.ts error/UsingJoinColumnOnlyOnOneSideAllowedError.ts error/ColumnTypeUndefinedError.ts error/SubjectWithoutIdentifierError.ts error/OptimisticLockVersionMismatchError.ts error/CannotGetEntityManagerNotConnectedError.ts error/CannotReflectMethodParameterTypeError.ts error/MissingPrimaryColumnError.ts error/PrimaryColumnCannotBeNullableError.ts error/ConnectionIsNotSetError.ts error/MetadataWithSuchNameAlreadyExistsError.ts error/ConnectionNotFoundError.ts error/SubjectRemovedAndUpdatedError.ts error/NoVersionOrUpdateDateColumnError.ts error/TreeRepositoryNotSupportedError.ts error/CannotAttachTreeChildrenEntityError.ts error/DriverOptionNotSetError.ts error/EntityColumnNotFound.ts error/CannotExecuteNotConnectedError.ts error/CircularRelationsError.ts error/CustomRepositoryDoesNotHaveEntityError.ts error/NoConnectionOptionError.ts error/InitializedRelationError.ts error/LimitOnUpdateNotSupportedError.ts error/TransactionNotStartedError.ts error/PessimisticLockTransactionRequiredError.ts error/QueryRunnerAlreadyReleasedError.ts error/UpdateValuesMissingError.ts error/OptimisticLockCanNotBeUsedError.ts error/LockNotSupportedOnGivenDriverError.ts error/OffsetWithoutLimitNotSupportedError.ts error/QueryRunnerProviderAlreadyReleasedError.ts error/InsertValuesMissingError.ts error/NoNeedToReleaseEntityManagerError.ts error/ReturningStatementNotSupportedError.ts error/TransactionAlreadyStartedError.ts error/PersistedEntityNotFoundError.ts connection/Connection.ts connection/ConnectionOptionsReader.ts connection/options-reader/ConnectionOptionsEnvReader.ts connection/options-reader/ConnectionOptionsXmlReader.ts connection/options-reader/ConnectionOptionsYmlReader.ts connection/ConnectionMetadataBuilder.ts connection/ConnectionManager.ts decorator/columns/Column.ts decorator/columns/PrimaryGeneratedColumn.ts decorator/columns/PrimaryColumn.ts decorator/columns/ObjectIdColumn.ts decorator/columns/CreateDateColumn.ts decorator/columns/UpdateDateColumn.ts decorator/columns/DeleteDateColumn.ts decorator/columns/VersionColumn.ts decorator/columns/ViewColumn.ts decorator/relations/ManyToOne.ts decorator/relations/ManyToMany.ts decorator/relations/OneToOne.ts decorator/relations/OneToMany.ts decorator/relations/JoinTable.ts decorator/relations/JoinColumn.ts decorator/relations/RelationId.ts decorator/relations/RelationCount.ts decorator/transaction/Transaction.ts decorator/transaction/TransactionRepository.ts decorator/transaction/TransactionManager.ts decorator/listeners/AfterUpdate.ts decorator/listeners/BeforeRemove.ts decorator/listeners/AfterInsert.ts decorator/listeners/AfterRemove.ts decorator/listeners/BeforeInsert.ts decorator/listeners/BeforeUpdate.ts decorator/listeners/AfterLoad.ts decorator/listeners/EventSubscriber.ts decorator/tree/TreeChildren.ts decorator/tree/TreeParent.ts decorator/tree/Tree.ts decorator/tree/TreeLevelColumn.ts decorator/entity/Entity.ts decorator/entity/TableInheritance.ts decorator/entity/ChildEntity.ts decorator/Index.ts decorator/Unique.ts decorator/Exclusion.ts decorator/entity-view/ViewEntity.ts decorator/Check.ts decorator/Generated.ts decorator/EntityRepository.ts repository/TreeRepository.ts repository/MongoRepository.ts repository/BaseEntity.ts repository/Repository.ts repository/AbstractRepository.ts repository/RepositoryFactory.ts find-options/FindOptionsUtils.ts find-options/operator/Raw.ts find-options/operator/LessThanOrEqual.ts find-options/operator/In.ts find-options/operator/LessThan.ts find-options/operator/IsNull.ts find-options/operator/MoreThanOrEqual.ts find-options/operator/MoreThan.ts find-options/operator/Like.ts find-options/operator/Not.ts find-options/operator/Between.ts find-options/operator/Equal.ts find-options/operator/ILike.ts find-options/operator/Any.ts find-options/FindOperator.ts migration/MigrationExecutor.ts migration/Migration.ts logger/DebugLogger.ts logger/FileLogger.ts logger/AdvancedConsoleLogger.ts logger/SimpleConsoleLogger.ts logger/LoggerFactory.ts cache/RedisQueryResultCache.ts cache/DbQueryResultCache.ts cache/QueryResultCacheFactory.ts index.ts subscriber/Broadcaster.ts subscriber/BroadcasterResult.ts query-runner/BaseQueryRunner.ts metadata-args/MetadataArgsStorage.ts entity-schema/EntitySchemaTransformer.ts entity-schema/EntitySchema.ts entity-schema/EntitySchemaOptions.ts platform/PlatformTools.ts naming-strategy/DefaultNamingStrategy.ts container.ts cli.ts

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.

Showing 1 of 3 files from the diff.

@@ -33,7 +33,7 @@
Loading
33 33 
        const escapeAlias = (alias: string) => this.manager.connection.driver.escape(alias);
34 34 
        const escapeColumn = (column: string) => this.manager.connection.driver.escape(column);
35 35 
        const parentPropertyName = this.manager.connection.namingStrategy.joinColumnName(
36 - 
          this.metadata.treeParentRelation!.propertyName, "id"
36 + 
          this.metadata.treeParentRelation!.propertyName, this.metadata.primaryColumns[0].propertyName
37 37 
        );
38 38 










39
39
                             
                            
        return this.createQueryBuilder("treeEntity")







 
 













































Learn more

Showing 1 files with coverage changes found.












Changes in src/driver/cockroachdb/CockroachQueryRunner.ts











-5





→





+5


















Loading file...






































2

Commits






















Ilyas Foo


























74.75%



ø






+0.02%




























fix: findRoots should get the actual primary key column, fixes #6948











ilyasfoo













#6982






51b4aa0





 CI Passed





















Ilyas Foo
















Contextual



















test: added failing test for github issue #6948











ilyasfoo














b8b5e9b














Hiding 1 contexual commits

















+5







-5

















Pull Request Base Commit










Wilson Pena


























74.73%



ø



ø


























fix: support multiple row insert on oracle (#6927)











wfpena














a5eb946













































repository












































Files






Coverage
























AbstractRepository.ts


















37.50%




















BaseEntity.ts


















69.23%




















MongoRepository.ts


















62.06%




















Repository.ts


















100.00%




















RepositoryFactory.ts


















100.00%




















TreeRepository.ts


















83.03%











Folder Totals (6 files)






74.93%






Project Totals (295 files)






74.75%
































Loading