Compare ⋅ trustwallet/wallet-core

Overview Diff Coverage Changes Files Commits

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.

Showing 1 of 3 files from the diff.

97.81% 100.00% +0.04%

src/Binance/Serialization.cpp changed.

Other files ignored by Codecov

tests/Binance/SignerTests.cpp has changed.

swift/Tests/Blockchains/BinanceChainTests.swift has changed.

@@ -125,14 +125,19 @@

Loading

        j["amount"] = tokensJSON(input.time_lock_order().amount());
        j["lock_time"] = input.time_lock_order().lock_time();
    } else if (input.has_time_relock_order()) {
        const auto amount = input.time_relock_order().amount();
        j["from"] = addressString(input.time_relock_order().from_address());
        j["id"] = input.time_relock_order().id();
        j["time_lock_id"] = input.time_relock_order().id();
        j["description"] = input.time_relock_order().description();
        j["amount"] = tokensJSON(input.time_relock_order().amount());
        // if amount is empty or omitted, set null to avoid signature verification error
        j["amount"] = nullptr;
        if (amount.size() > 0) {
            j["amount"] = tokensJSON(amount);
        }
        j["lock_time"] = input.time_relock_order().lock_time();
    } else if (input.has_time_unlock_order()) {
        j["from"] = addressString(input.time_unlock_order().from_address());
        j["id"] = input.time_unlock_order().id();
        j["time_lock_id"] = input.time_unlock_order().id();
    }
    return j;
}

Everything is accounted for!

No changes detected that need to be reviewed.

What changes does Codecov check for?

Lines, not adjusted in diff, that have changed coverage data.

Files that introduced coverage data that had none before.

Files that have missing coverage data that once were tracked.

95.25% 100.00% +<.01%

[Binance] Fix timelock unlock signature error (#1143)

hewigovens

ba9654f

CI Passed

+3

95.25% ø ø

filter deprecated chain in coins.md and fix quote include (#1140)

hewigovens

fd5770a

CI Passed

Files		•	•	•	Coverage
src	+3	+3	ø	ø	^+<.01% 95.25%
walletconsole/lib	ø	ø	ø	ø	95.09%
Project Totals (430 files)	12,719	12,115	0	604	95.25%

125	125		j["amount"] = tokensJSON(input.time_lock_order().amount());
126	126		j["lock_time"] = input.time_lock_order().lock_time();
127	127		} else if (input.has_time_relock_order()) {
	128	+	const auto amount = input.time_relock_order().amount();
128	129		j["from"] = addressString(input.time_relock_order().from_address());
129		-	j["id"] = input.time_relock_order().id();
	130	+	j["time_lock_id"] = input.time_relock_order().id();
130	131		j["description"] = input.time_relock_order().description();
131		-	j["amount"] = tokensJSON(input.time_relock_order().amount());
	132	+	// if amount is empty or omitted, set null to avoid signature verification error
	133	+	j["amount"] = nullptr;
	134	+	if (amount.size() > 0) {
	135	+	j["amount"] = tokensJSON(amount);
	136	+	}
132	137		j["lock_time"] = input.time_relock_order().lock_time();
133	138		} else if (input.has_time_unlock_order()) {
134	139		j["from"] = addressString(input.time_unlock_order().from_address());
135		-	j["id"] = input.time_unlock_order().id();
	140	+	j["time_lock_id"] = input.time_unlock_order().id();
136	141		}
137	142		return j;
138	143		}

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Compare `fd5770a ... +0 ... ba9654f`

No flags found

Everything is accounted for!

What changes does Codecov check for?

2 Commits

Compare fd5770a ... +0 ... ba9654f

No flags found

Everything is accounted for!

What changes does Codecov check for?

2 Commits

Compare `fd5770a ... +0 ... ba9654f`