Compare ⋅ testing-library/user-event

Overview Diff Coverage Changes Files Commits

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.

Showing 1 of 3 files from the diff.

100.00% 100.00% ø

src/select-options.js changed.

Other files ignored by Codecov

src/__tests__/helpers/utils.js has changed.

src/__tests__/select-options.js has changed.

@@ -1,6 +1,7 @@

Loading

import {createEvent, getConfig, fireEvent} from '@testing-library/dom'
import {click} from './click'
import {focus} from './focus'
import {hover, unhover} from './hover'

function selectOptionsBase(newValue, select, values, init) {
  if (!newValue && !select.multiple) {

@@ -18,7 +19,9 @@

Loading

      if (allOptions.includes(val)) {
        return val
      } else {
        const matchingOption = allOptions.find(o => o.value === val)
        const matchingOption = allOptions.find(
          o => o.value === val || o.innerHTML === val,
        )
        if (matchingOption) {
          return matchingOption
        } else {

@@ -61,17 +64,25 @@

Loading

  }

  function selectOption(option) {
    option.selected = newValue
    fireEvent(
      select,
      createEvent('input', select, {
        bubbles: true,
        cancelable: false,
        composed: true,
        ...init,
      }),
    )
    fireEvent.change(select, init)
    if (option.getAttribute('role') === 'option') {
      option?.setAttribute?.('aria-selected', newValue)

      hover(option, init)
      click(option, init)
      unhover(option, init)
    } else {
      option.selected = newValue
      fireEvent(
        select,
        createEvent('input', select, {
          bubbles: true,
          cancelable: false,
          composed: true,
          ...init,
        }),
      )
      fireEvent.change(select, init)
    }
  }
}


Everything is accounted for!

No changes detected that need to be reviewed.

What changes does Codecov check for?

Lines, not adjusted in diff, that have changed coverage data.

Files that introduced coverage data that had none before.

Files that have missing coverage data that once were tracked.

100.00% ø ø

Merge branch 'master' into master

kentcdodds

#473 508ef4b

CI Passed

Hiding 6 contexual commits

+6

Pull Request Base Commit

100.00% ø ø

chore: fix npx command for node 15

kentcdodds

2d19a65

CI Passed

Files		•	•	•	Coverage
src	+6	+6	ø	ø	100.00%
Project Totals (12 files)	482	482	0	0	100.00%

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

#473 Added listbox options support in selectOptions

No flags found

Everything is accounted for!

What changes does Codecov check for?

Show failed CI and contexual commits `c`

7 Commits

1	1		import {createEvent, getConfig, fireEvent} from '@testing-library/dom'
2	2		import {click} from './click'
3	3		import {focus} from './focus'
	4	+	import {hover, unhover} from './hover'
4	5
5	6		function selectOptionsBase(newValue, select, values, init) {
6	7		if (!newValue && !select.multiple) {

18	19		if (allOptions.includes(val)) {
19	20		return val
20	21		} else {
21		-	const matchingOption = allOptions.find(o => o.value === val)
	22	+	const matchingOption = allOptions.find(
	23	+	o => o.value === val \|\| o.innerHTML === val,
	24	+	)
22	25		if (matchingOption) {
23	26		return matchingOption
24	27		} else {

61	64		}
62	65
63	66		function selectOption(option) {
64		-	option.selected = newValue
65		-	fireEvent(
66		-	select,
67		-	createEvent('input', select, {
68		-	bubbles: true,
69		-	cancelable: false,
70		-	composed: true,
71		-	...init,
72		-	}),
73		-	)
74		-	fireEvent.change(select, init)
	67	+	if (option.getAttribute('role') === 'option') {
	68	+	option?.setAttribute?.('aria-selected', newValue)
	69	+
	70	+	hover(option, init)
	71	+	click(option, init)
	72	+	unhover(option, init)
	73	+	} else {
	74	+	option.selected = newValue
	75	+	fireEvent(
	76	+	select,
	77	+	createEvent('input', select, {
	78	+	bubbles: true,
	79	+	cancelable: false,
	80	+	composed: true,
	81	+	...init,
	82	+	}),
	83	+	)
	84	+	fireEvent.change(select, init)
	85	+	}
75	86		}
76	87		}
77	88

#473 Added listbox options support in selectOptions

No flags found

Everything is accounted for!

What changes does Codecov check for?

Show failed CI and contexual commits c 7 Commits

Show failed CI and contexual commits `c`

7 Commits