Compare `da95f7f ... +33 ... e3b64d5`

use SilverStripe\ORM\DataExtension;
use SilverStripe\ORM\DataQuery;
use SilverStripe\ORM\FieldType\DBDatetime;
use SilverStripe\ORM\FieldType\DBHTMLText;
use SilverStripe\ORM\Queries\SQLSelect;
use SilverStripe\Security\Member;
use SilverStripe\Security\Permission;

@@ -126,20 +127,20 @@

                    'DesiredPublishDate',
                    _t('WorkflowEmbargoExpiryExtension.REQUESTED_PUBLISH_DATE', 'Requested publish date')
                )->setRightTitle(
                    _t(
                    DBHTMLText::create()->setValue(_t(
                        'WorkflowEmbargoExpiryExtension.REQUESTED_PUBLISH_DATE_RIGHT_TITLE',
                        'To request this page to be <strong>published immediately</strong> '
                        . 'leave the date and time fields blank'
                    )
                    ))
                ),
                $ut = DatetimeField::create(
                    'DesiredUnPublishDate',
                    _t('WorkflowEmbargoExpiryExtension.REQUESTED_UNPUBLISH_DATE', 'Requested un-publish date')
                )->setRightTitle(
                    _t(
                    DBHTMLText::create()->setValue(_t(
                        'WorkflowEmbargoExpiryExtension.REQUESTED_UNPUBLISH_DATE_RIGHT_TITLE',
                        'To request this page to <strong>never expire</strong> leave the date and time fields blank'
                    )
                    ))
                ),
                DatetimeField::create(
                    'PublishOnDate',

@@ -430,7 +430,7 @@

        $tmp = [];

        foreach ($defs as $def) {
            $parts = preg_split("#\s#", $def, -1, PREG_SPLIT_NO_EMPTY);
            $parts = preg_split("#\s#", preg_quote($def, '#'), -1, PREG_SPLIT_NO_EMPTY);
            $lastPart = array_pop($parts);
            $match = implode(' ', $parts);
            // @todo do all this in one preg_match_all() call

Learn more Showing 5 files with coverage changes found.

Changes in src/Extensions/WorkflowEmbargoExpiryExtension.php

-103

→

+103

Loading file...

Changes in src/Jobs/WorkflowPublishTargetJob.php

-12

→

+12

Loading file...

Changes in src/Actions/PublishItemWorkflowAction.php

-10

→

+10

Loading file...

Changes in src/Services/WorkflowService.php

-20

→

+20

Loading file...

Changes in src/Extensions/WorkflowApplicable.php

-9

→

Loading file...

16.40% ø ø 870 0

Merge branch '5.3' into 5

Cheddam

e3b64d5

CI Passed

16.40% ø -5.63% 870 0

Merge pull request #437 from creative-commoners/pulls/5.3/travis-shared

Cheddam

140e79b

CI Passed

16.40% ø -5.63% 870 0

MNT Travis shared config, use sminnee/phpunit

emteknetnz

#437 8c65f00

CI Passed

Hiding 1 contexual commits

-20

-155

+135

22.02% ø ø 870 ø

Bump node-sass from 4.7.2 to 4.14.1

Unknown

#429 f3cae3f

22.02% ø ø 870 ø

Merge pull request #428 from symbiote/dependabot/npm_and_yarn/elliptic-6.5.3

robbieaverill

4e32a96

22.02% ø ø 870 ø

Bump elliptic from 6.4.0 to 6.5.3

Unknown

#428 d8e4d38

22.02% ø ø 870 ø

Merge pull request #415 from silverstripe/pulls/5/build-docs-action

nglasl

8a64ebb

22.02% ø ø 870 ø

Merge pull request #427 from creative-commoners/pulls/5.3/merge-up

maxime-rainville

36e3b04

22.02% ø ø 870 ø

Merge branch '5.2' into 5.3

maxime-rainville

#427 a69fda5

22.02% ø ø 870 ø

Merge pull request #424 from symbiote/dependabot/npm_and_yarn/jquery-3.5.0

Unknown

7a52cd7

22.02% ø ø 870 ø

Merge pull request #410 from symbiote/dependabot/npm_and_yarn/sshpk-1.16.1

Unknown

eca47d0

Hiding 2 contexual commits

22.02% ø ø 870 ø

Merge pull request #411 from symbiote/dependabot/npm_and_yarn/extend-3.0.2

Unknown

c28035b

22.02% ø ø 870 ø

Merge pull request #426 from creative-commoners/pulls/5.2/travis

cc1dbf1

#426 669ce19

Merge branch '5.3' into 5

1b1f166

754cedd

Merge pull request #425 from creative-commoners/5.3

59a5030

#425 5fa29f0

Bump jquery from 3.3.1 to 3.5.0

Unknown

#424 a166c04

CI Passed

22.02% 0.00% ø 870 0

Merge pull request #421 from silverstripe-terraformers/bugfix/create-workflow-without-title

dhensby

f0ec1b5

CI Passed

22.02% 0.00% ø 870 0

Merge pull request #423 from silverstripe-terraformers/bugfix/html-tags

robbieaverill

71e1351

CI Passed

22.02% 0.00% ø 870 0

Update fields containing tags to use `DBHTMLText`

shoosah

#423 314cff6

CI Passed

22.02% ø ø 870 ø

Unable to find commit in GitHub

Unknown

#421 468f939

Hiding 1 contexual commits

22.02% ø ø 870 0

Update travis config. Remove <=7.0 php tests and add 7.4 php test

dhensby

#422 a77b358

CI Passed

22.02% ø ø 870 ø

Unable to find commit in GitHub

Unknown

#421 e20545d

22.02% ø ø 870 0

META: Add action to build docs on Netlify

unclecheese

#415 c485a5a

CI Passed

22.02% ø ø 870 0

Bump macaddress from 0.2.8 to 0.2.9

Unknown

#409 635d744

CI Passed

22.02% ø ø 870 0

Bump sshpk from 1.13.1 to 1.16.1

Unknown

#410 e07d033

CI Passed

22.02% ø ø 870 0

Bump merge from 1.2.0 to 1.2.1

Unknown

#408 27fe2f1

CI Passed

22.02% ø ø 870 0

Bump extend from 3.0.1 to 3.0.2

Unknown

#411 ff31bc4

CI Passed

+20

+19

22.15% ø ø 870 ø

Merge pull request #413 from silverstripe/pulls/master/new-docs

nglasl

da95f7f

Files		•	•	•	Complexity	Coverage
src	ø	-154	ø	+154	ø	^-5.75% 16.40%
Project Totals (35 files)	2,677	439	0	2,238	870	16.40%

126	127		'DesiredPublishDate',
127	128		_t('WorkflowEmbargoExpiryExtension.REQUESTED_PUBLISH_DATE', 'Requested publish date')
128	129		)->setRightTitle(
129		-	_t(
	130	+	DBHTMLText::create()->setValue(_t(
130	131		'WorkflowEmbargoExpiryExtension.REQUESTED_PUBLISH_DATE_RIGHT_TITLE',
131	132		'To request this page to be <strong>published immediately</strong> '
132	133		. 'leave the date and time fields blank'
133		-	)
	134	+	))
134	135		),
135	136		$ut = DatetimeField::create(
136	137		'DesiredUnPublishDate',
137	138		_t('WorkflowEmbargoExpiryExtension.REQUESTED_UNPUBLISH_DATE', 'Requested un-publish date')
138	139		)->setRightTitle(
139		-	_t(
	140	+	DBHTMLText::create()->setValue(_t(
140	141		'WorkflowEmbargoExpiryExtension.REQUESTED_UNPUBLISH_DATE_RIGHT_TITLE',
141	142		'To request this page to <strong>never expire</strong> leave the date and time fields blank'
142		-	)
	143	+	))
143	144		),
144	145		DatetimeField::create(
145	146		'PublishOnDate',

430	430		$tmp = [];
431	431
432	432		foreach ($defs as $def) {
433		-	$parts = preg_split("#\s#", $def, -1, PREG_SPLIT_NO_EMPTY);
	433	+	$parts = preg_split("#\s#", preg_quote($def, '#'), -1, PREG_SPLIT_NO_EMPTY);
434	434		$lastPart = array_pop($parts);
435	435		$match = implode(' ', $parts);
436	436		// @todo do all this in one preg_match_all() call

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Compare `da95f7f ... +33 ... e3b64d5`

No flags found

Show failed CI and contexual commits `c`

35 Commits

13	13		use SilverStripe\ORM\DataExtension;
14	14		use SilverStripe\ORM\DataQuery;
15	15		use SilverStripe\ORM\FieldType\DBDatetime;
	16	+	use SilverStripe\ORM\FieldType\DBHTMLText;
16	17		use SilverStripe\ORM\Queries\SQLSelect;
17	18		use SilverStripe\Security\Member;
18	19		use SilverStripe\Security\Permission;

Compare da95f7f ... +33 ... e3b64d5

No flags found

Show failed CI and contexual commits c 35 Commits

Compare `da95f7f ... +33 ... e3b64d5`

Show failed CI and contexual commits `c`

35 Commits