spring-cloud / spring-cloud-dataflow-ui

Compare b01039a ... +18 ... e8eaf9e

Coverage Reach
app/streams/components/flo/editor.service.ts app/streams/components/flo/support/view-helper.ts app/streams/components/flo/support/utils.ts app/streams/components/flo/support/node-helper.ts app/streams/components/flo/support/layout.ts app/streams/components/flo/support/shapes.ts app/streams/components/flo/text-to-graph.ts app/streams/components/flo/graph-to-text.ts app/streams/components/flo/render.service.ts app/streams/components/flo/metamodel.service.ts app/streams/components/flo/properties/stream-properties-dialog.component.ts app/streams/components/flo/properties/stream-properties-source.ts app/streams/components/flo/node/node.component.ts app/streams/components/flo/message-rate/message-rate.component.ts app/streams/components/flo/content-assist.service.ts app/streams/components/flo/instance-dot/instance-dot.component.ts app/streams/components/stream-graph-definition/stream-graph-definition.component.ts app/streams/components/stream-status/stream-status.component.ts app/streams/components/stream-history-status/stream-status.component.ts app/streams/stream-deploy/builder/builder.component.ts app/streams/stream-deploy/builder/errors/errors.component.ts app/streams/stream-deploy/stream-deploy.component.ts app/streams/stream-deploy/stream-deploy.service.ts app/streams/stream-deploy/stream-deploy.validator.ts app/streams/stream-deploy/free-text/free-text.component.ts app/streams/stream-deploy/app-properties/app-properties.component.ts app/streams/streams/streams.component.ts app/streams/streams/deployment-properties/deployment-properties.component.ts app/streams/streams/deployment-properties-info/deployment-properties-info.component.ts app/streams/stream-create/create-dialog/create-dialog.component.ts app/streams/stream-create/stream-create.component.ts app/streams/stream/stream.component.ts app/streams/stream/history/stream-history.component.ts app/streams/stream/graph/stream-graph.component.ts app/streams/stream/summary/stream-summary.component.ts app/streams/streams.service.ts app/streams/model/stream-metrics.ts app/streams/model/stream-history.ts app/streams/model/stream-definition.ts app/streams/model/stream-deploy-config.ts app/streams/streams-destroy/streams-destroy.component.ts app/streams/streams-deploy/streams-deploy.component.ts app/streams/streams-undeploy/streams-undeploy.component.ts app/shared/services/parser.ts app/shared/services/tokenizer.ts app/shared/services/shared-about.service.ts app/shared/services/shared-apps.service.ts app/shared/services/routing-state.service.ts app/shared/services/group-route.service.ts app/shared/services/logger.service.ts app/shared/services/notification.service.ts app/shared/services/parser.service.ts app/shared/components/truncator/truncator.component.ts app/shared/components/truncator/truncator-width-provider.directive.ts app/shared/components/truncator/trail-position-type.model.ts app/shared/components/list/list-bar.component.ts app/shared/components/list/list-row-actions.component.ts app/shared/components/list/list-pagination.component.ts app/shared/components/list/list-empty.component.ts app/shared/components/list/list-no-result.component.ts app/shared/components/list/list.component.ts app/shared/components/kv-rich-text/kv-rich-text.component.ts app/shared/components/kv-rich-text/kv-rich-text.validator.ts app/shared/components/http-loader/http-loader.service.ts app/shared/components/http-loader/http-loader.interceptor.ts app/shared/components/http-loader/http-loader.component.ts app/shared/components/page/page-head-back.component.ts app/shared/components/page/page.component.ts app/shared/components/page/page-actions.component.ts app/shared/components/page/page-head-actions.component.ts app/shared/components/page/page-head.component.ts app/shared/components/page/page-head-subtitle.component.ts app/shared/components/page/page-head-title.component.ts app/shared/components/pager/pager.component.ts app/shared/components/confirm/confirm.service.ts app/shared/components/confirm/confirm.component.ts app/shared/components/master-checkbox.component.ts app/shared/components/sort/sort.component.ts app/shared/components/tabs.component.ts app/shared/components/blocker/blocker.service.ts app/shared/components/blocker/blocker.component.ts app/shared/components/modal/modal-abstract.ts app/shared/components/shared.interface.ts app/shared/components/loader/loader.component.ts app/shared/components/dsl/dsl.component.ts app/shared/model/about/security-info.model.ts app/shared/model/about/feature-info.model.ts app/shared/model/about/about-info.model.ts app/shared/model/about/runtime-environment-details.model.ts app/shared/model/about/grafana.model.ts app/shared/model/about/dependency.model.ts app/shared/model/about/runtime-environment.model.ts app/shared/model/about/version-info.model.ts app/shared/model/audit-record.model.ts app/shared/model/detailed-app-registration.model.ts app/shared/model/page.ts app/shared/model/app-registration.model.ts app/shared/model/error-handler.ts app/shared/model/platform.ts app/shared/model/error.model.ts app/shared/model/app-version.ts app/shared/model/application-type.ts app/shared/model/index.ts app/shared/model/pagination/page-request.model.ts app/shared/flo/support/app-metadata.ts app/shared/flo/support/properties-group-model.ts app/shared/flo/support/shared-shapes.ts app/shared/flo/support/graph-node-properties-source.ts app/shared/flo/support/utils.ts app/shared/flo/support/shape-component.ts app/shared/flo/properties-groups/properties-groups-dialog.component.ts app/shared/flo/properties/properties-dialog.component.ts app/shared/flo/handle/handle.component.ts app/shared/flo/graph-view/graph-view.component.ts app/shared/flo/decoration/decoration.component.ts app/shared/directives/auto-resize.directive.ts app/shared/directives/layout-type.directive.ts app/shared/directives/focus.directive.ts app/shared/pipes/orderby.pipe.ts app/shared/pipes/search-filter.pipe.ts app/shared/pipes/dataflow-date-time.pipe.ts app/shared/pipes/truncate.pipe.ts app/shared/pipes/dataflow-duration.pipe.ts app/shared/pipes/capitalize.pipe.ts app/shared/shared.module.ts app/shared/grafana/grafana.service.ts app/shared/grafana/grafana.module.ts app/shared/support/encoder.utils.ts app/shared/support/object.utils.ts app/shared/support/http.utils.ts app/shared/support/date-time.utils.ts app/tasks/components/flo/editor.service.ts app/tasks/components/flo/render.service.ts app/tasks/components/flo/metamodel.service.ts app/tasks/components/flo/support/layout.ts app/tasks/components/flo/support/shapes.ts app/tasks/components/flo/tools.service.ts app/tasks/components/flo/properties/task-properties-dialog-component.ts app/tasks/components/flo/properties/task-properties-source.ts app/tasks/components/flo/node/node.component.ts app/tasks/components/flo/model/models.ts app/tasks/components/flo/task-graph-view/task-graph-view.component.ts app/tasks/components/flo/content-assist.service.ts app/tasks/components/tasks-tabulation/tasks-tabulation.component.ts app/tasks/components/task-status/task-status.component.ts app/tasks/task-definition/schedules/task-definition-schedules.component.ts app/tasks/task-definition/task-definition.component.ts app/tasks/task-definition/executions/task-definition-executions.component.ts app/tasks/task-definition/summary/task-summary.component.ts app/tasks/task-definitions/task-definitions.component.ts app/tasks/task-definition-create/task-definition-create.component.ts app/tasks/task-definition-create/create-dialog/create-dialog.component.ts app/tasks/task-schedules/task-schedules.component.ts app/tasks/task-schedules/task-schedules.filter.ts app/tasks/tasks.service.ts app/tasks/task-schedule-create/task-schedule-create.component.ts app/tasks/task-schedule-create/task-schedule-create.validator.ts app/tasks/task-launch/task-launch.component.ts app/tasks/task-launch/task-launch.validator.ts app/tasks/task-executions/task-executions.component.ts app/tasks/model/task-execution.ts app/tasks/model/task-schedule.ts app/tasks/model/task-definition.ts app/tasks/task-schedule/task-schedule.component.ts app/tasks/task-schedule/summary/task-schedule-summary.component.ts app/tasks/task-definitions-destroy/task-definitions-destroy.component.ts app/tasks/task-schedules-destroy/task-schedules-destroy.component.ts app/tasks/task-execution/task-execution.component.ts app/tasks/tasks/tasks.components.ts app/apps/apps-add/register/apps-register.component.ts app/apps/apps-add/register/apps-register.validator.ts app/apps/apps-add/properties/apps-bulk-import-properties.component.ts app/apps/apps-add/uri/apps-bulk-import-uri.component.ts app/apps/apps-add/apps-add.validator.ts app/apps/apps-add/apps-add.component.ts app/apps/apps/apps.component.ts app/apps/components/app-list-bar/app-list-bar.component.ts app/apps/components/app-versions-label/app-versions-label.component.ts app/apps/components/app-type/app-type.component.ts app/apps/apps.workaround.service.ts app/apps/app-details/app-details.component.ts app/apps/app-versions/app-versions.component.ts app/apps/apps.service.ts app/apps/apps-unregister/apps-unregister.component.ts app/tests/mocks/about.ts app/tests/mocks/apps.ts app/tests/mocks/jobs.ts app/tests/mocks/tasks.ts app/tests/mocks/streams.ts app/tests/mocks/notification.ts app/tests/mocks/shared-app.ts app/tests/mocks/audit.ts app/tests/mocks/group-route.ts app/tests/mocks/shared-about.ts app/tests/mocks/mock-data.ts app/tests/mocks/auth.ts app/tests/mocks/activated-route.ts app/tests/mocks/mock-tools.ts app/tests/mocks/runtime.ts app/tests/mocks/confirm.ts app/tests/mocks/mock-component.ts app/tests/mocks/modal.ts app/tests/mocks/routing-state.ts app/jobs/model/job-execution.model.ts app/jobs/model/step-execution.model.ts app/jobs/model/step-execution-progress.model.ts app/jobs/model/step-execution-resource.model.ts app/jobs/model/execution-context.model.ts app/jobs/jobs/jobs.component.ts app/jobs/step-execution-details/step-execution-details.component.ts app/jobs/components/job-execution-status.component.ts app/jobs/components/definition-status.component.ts app/jobs/jobs.service.ts app/jobs/step-execution-progress/step-execution-progress.component.ts app/jobs/job-execution-details/job-execution-details.component.ts app/audit/components/audit-record-list-bar/audit-record-list-bar.component.ts app/audit/components/audit-record-action/audit-record-action.component.ts app/audit/components/audit-record-operation/audit-record-operation.component.ts app/audit/audit-record/audit-record.component.ts app/audit/audit-record.service.ts app/audit/audit-record-details/audit-record-details.component.ts app/layout/navigation/search/search.component.ts app/layout/navigation/navigation.component.ts app/layout/sidebar/sidebar.component.ts app/layout/body/body.component.ts app/layout/logo/logo.component.ts app/runtime/runtime-apps/runtime-apps.component.ts app/runtime/runtime-app/runtime-app.component.ts app/runtime/model/runtime-app.ts app/runtime/model/runtime-app-instance.ts app/runtime/components/runtime-app-state/runtime-app-state.component.ts app/runtime/runtime-apps.service.ts app/auth/auth.service.ts app/auth/logout.component.ts app/auth/directives/roles.directive.ts app/auth/feature-disabled.component.ts app/auth/authentication-required.component.ts app/about/components/about-more/about-details.component.ts app/about/about.service.ts app/about/about/about.component.ts app/app.component.ts polyfills.ts test.ts environments/environment.ts

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.

Showing 33 of 66 files from the diff.
Other files ignored by Codecov
pom.xml has changed.
README_DEV.md has changed.
ui/package.json has changed.
README.md has changed.
.travis.yml has changed.

@@ -2,7 +2,7 @@
Loading
2 2
import { BsModalRef } from 'ngx-bootstrap';
3 3
import { FormBuilder, FormControl, FormGroup } from '@angular/forms';
4 4
import { TasksService } from '../../tasks.service';
5 -
import { takeUntil } from 'rxjs/operators';
5 +
import { finalize, takeUntil } from 'rxjs/operators';
6 6
import { Subject } from 'rxjs';
7 7
import { NotificationService } from '../../../shared/services/notification.service';
8 8
import { LoggerService } from '../../../shared/services/logger.service';
@@ -107,7 +107,7 @@
Loading
107 107
    } else {
108 108
      this.blockerService.lock();
109 109
      this.tasksService.createDefinition({ name: this.taskName.value, definition: this.dsl })
110 -
        .pipe(takeUntil(this.ngUnsubscribe$))
110 +
        .pipe(takeUntil(this.ngUnsubscribe$), finalize(() => this.blockerService.unlock()))
111 111
        .subscribe(
112 112
          () => {
113 113
            this.loggerService.log('Succesfully created task', this.taskName.value, this.dsl);
@@ -120,8 +120,6 @@
Loading
120 120
          (error) => {
121 121
            this.notificationService.error(AppError.is(error) ? error.getMessage() : error);
122 122
            this.bsModalRef.hide();
123 -
          }, () => {
124 -
            this.blockerService.unlock();
125 123
          }
126 124
        );
127 125
    }

@@ -20,6 +20,7 @@
Loading
20 20
 * Provides {@link StreamDeployConfig} related services.
21 21
 *
22 22
 * @author Damien Vitrac
23 +
 * @author Janne Valkealahti
23 24
 */
24 25
@Injectable()
25 26
export class StreamDeployService {
@@ -150,7 +151,8 @@
Loading
150 151
            return {
151 152
              key: platform.name,
152 153
              name: platform.name,
153 -
              type: platform.type
154 +
              type: platform.type,
155 +
              options: platform.options
154 156
            };
155 157
          })
156 158
        };

@@ -50,7 +50,7 @@
Loading
50 50
  /**
51 51
   * List Bar Component
52 52
   */
53 -
  @ViewChild('listBar')
53 +
  @ViewChild('listBar', { static: true })
54 54
  listBar: ListBarComponent;
55 55
56 56
  /**

@@ -34,7 +34,7 @@
Loading
34 34
  /**
35 35
   * List Bar Component
36 36
   */
37 -
  @ViewChild('listBar')
37 +
  @ViewChild('listBar', { static: true })
38 38
  listBar: ListBarComponent;
39 39
40 40
  /**

@@ -2,7 +2,7 @@
Loading
2 2
import { StreamsService } from '../streams.service';
3 3
import { StreamDefinition } from '../model/stream-definition';
4 4
import { BsModalRef } from 'ngx-bootstrap';
5 -
import { takeUntil } from 'rxjs/operators';
5 +
import { finalize, takeUntil } from 'rxjs/operators';
6 6
import { Modal } from '../../shared/components/modal/modal-abstract';
7 7
import { Observable, Subject } from 'rxjs';
8 8
import { NotificationService } from '../../shared/services/notification.service';
@@ -83,15 +83,13 @@
Loading
83 83
    this.loggerService.log(`Proceeding to deploy ${this.streamDefinitions.length} stream definition(s).`, this.streamDefinitions);
84 84
    this.blockerService.lock();
85 85
    this.streamsService.deployMultipleStreamDefinitions(this.streamDefinitions)
86 -
      .pipe(takeUntil(this.ngUnsubscribe$))
86 +
      .pipe(takeUntil(this.ngUnsubscribe$), finalize(() => this.blockerService.unlock()))
87 87
      .subscribe((data) => {
88 88
        this.notificationService.success(`${data.length} stream definition(s) deployed.`);
89 89
        this.confirm.emit(data);
90 90
        this.cancel();
91 91
      }, (error) => {
92 92
        this.notificationService.error(AppError.is(error) ? error.getMessage() : error);
93 -
      }, () => {
94 -
        this.blockerService.unlock();
95 93
      });
96 94
  }
97 95

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Click to load this diff.
Loading diff...

Learn more Showing 8 files with coverage changes found.

Changes in ui/src/app/shared/components/list/list-bar.component.ts
-2
+2
Loading file...
Changes in ui/src/app/tasks/task-definitions/task-definitions.component.ts
-3
+3
Loading file...
Changes in ui/src/app/streams/streams/streams.component.ts
-3
+3
Loading file...
Changes in ui/src/app/tasks/components/flo/render.service.ts
-1
Loading file...
New file ui/src/app/shared/flo/properties-groups/properties-groups-dialog.component.ts
New
Loading file...
Changes in ui/src/app/tasks/components/flo/support/layout.ts
-3
+4
Loading file...
Changes in ui/src/app/streams/stream-deploy/stream-deploy.service.ts
-20
+20
Loading file...
Changes in ui/src/app/streams/stream-deploy/builder/builder.component.ts
-102
+92
+10
Loading file...

20 Commits

Hiding 19 contexual commits
Files Coverage
ui/src 0.68% 72.71%
Project Totals (244 files) 72.71%
Loading