- Fix case where property value is actually boolean and
its default value true and then setting it to false.
Now simply doing using
property.value !== nullinstead ofproperty.valuewhich would naturally might be false with a boolean type. - Added test for these two functions getDeploymentProperties and getAppProperties.
- Fixes #1191
jvalkeal
Showing 1 of 2 files from the diff.
Other files ignored by Codecov
@@ -625,14 +625,14 @@
Loading
| 625 | 625 | * @param {string} appId |
|
| 626 | 626 | * @returns {Array} |
|
| 627 | 627 | */ |
|
| 628 | - | getDeploymentProperties(builderDeploymentProperties: {global: [], apps: {}}, appId?: string): Array<{ key: string, value: string }> { |
|
| 628 | + | getDeploymentProperties(builderDeploymentProperties: {global: any[], apps: any}, appId?: string): Array<{ key: string, value: any }> { |
|
| 629 | 629 | const deploymentProperties = appId ? builderDeploymentProperties.apps[appId] : builderDeploymentProperties.global; |
|
| 630 | 630 | if (!deploymentProperties) { |
|
| 631 | 631 | return []; |
|
| 632 | 632 | } |
|
| 633 | 633 | ||
| 634 | 634 | return deploymentProperties.map((property: Properties.Property) => { |
|
| 635 | - | if (property.value && property.value !== undefined && property.value.toString() !== '' |
|
| 635 | + | if (property.value !== null && property.value !== undefined && property.value.toString() !== '' |
|
| 636 | 636 | && property.value !== property.defaultValue) { |
|
| 637 | 637 | return { |
|
| 638 | 638 | key: `${property.id}`, |
@@ -704,13 +704,13 @@
Loading
| 704 | 704 | * @param {string} appId |
|
| 705 | 705 | * @returns {Array} |
|
| 706 | 706 | */ |
|
| 707 | - | getAppProperties(builderAppsProperties: {}, appId: string): Array<{ key: string, value: string }> { |
|
| 707 | + | getAppProperties(builderAppsProperties: {}, appId: string): Array<{ key: string, value: any }> { |
|
| 708 | 708 | const appProperties = builderAppsProperties[appId]; |
|
| 709 | 709 | if (!appProperties) { |
|
| 710 | 710 | return []; |
|
| 711 | 711 | } |
|
| 712 | 712 | return appProperties.map((property: Properties.Property) => { |
|
| 713 | - | if (property.value && property.value !== undefined && property.value.toString() !== '' |
|
| 713 | + | if (property.value !== null && property.value !== undefined && property.value.toString() !== '' |
|
| 714 | 714 | && property.value !== property.defaultValue) { |
|
| 715 | 715 | if (property.id.startsWith(`${appId}.`)) { |
|
| 716 | 716 | return { |
| Files | Coverage |
|---|---|
| ui/src | 72.80% |
| Project Totals (244 files) | 72.80% |
1913.1
TRAVIS_JDK_VERSION=oraclejdk8 TRAVIS_OS_NAME=linux
Sunburst
The inner-most circle is the entire project, moving away from the center are folders then, finally, a single file.
The size and color of each slice is representing the number of statements and the coverage, respectively.
Icicle
The top section represents the entire project. Proceeding with folders and finally individual files.
The size and color of each slice is representing the number of statements and the coverage, respectively.
