#239 fix custom binary location fails on macOS

Merged tommysitu
Coverage Reach
core/Hoverfly.java core/model/Request.java core/model/Response.java core/model/RequestFieldMatcher.java core/model/RequestDetails.java core/model/HoverflyMetaData.java core/model/Simulation.java core/model/JournalEntry.java core/model/DelaySettings.java core/model/Journal.java core/model/RequestResponsePair.java core/model/HoverflyData.java core/model/GlobalActions.java core/config/HoverflyConfiguration.java core/config/LocalHoverflyConfig.java core/config/HoverflyConfigValidator.java core/config/RemoteHoverflyConfig.java core/config/LogLevel.java core/config/LocalMiddleware.java core/SslConfigurer.java core/TempFileManager.java core/ProxyConfigurer.java core/SimulationSource.java core/SystemConfigFactory.java core/LoggingOutputStream.java core/HoverflyConfig.java core/HoverflyUtils.java core/SystemConfig.java core/HoverflyMode.java core/SystemInfo.java api/OkHttpHoverflyClient.java api/view/HoverflyInfoView.java api/view/ResponseDiffForRequestView.java api/view/DiffReport.java api/view/SimpleRequestDefinitionView.java api/view/StateView.java api/view/DiffReportEntry.java api/view/DiffView.java api/command/ModeCommand.java api/command/SortParams.java api/command/DestinationCommand.java api/command/JournalSearchCommand.java api/model/ModeArguments.java api/HoverflyClient.java api/AuthHeaderInterceptor.java api/HoverflyClientException.java dsl/StubServiceBuilder.java dsl/RequestMatcherBuilder.java dsl/matchers/HoverflyMatchers.java dsl/ResponseBuilder.java dsl/SingleQuoteHttpBodyConverter.java dsl/HttpBodyConverter.java dsl/ResponseCreators.java dsl/AbstractDelaySettingsBuilder.java dsl/StubServiceDelaySettingsBuilder.java dsl/ResponseDelaySettingsBuilder.java dsl/HoverflyDsl.java dsl/HoverflyDslException.java rule/HoverflyRule.java rule/NoDiffAssertionRule.java rule/HoverflyRuleUtils.java verification/HoverflyVerifications.java verification/VerificationUtils.java verification/VerificationData.java verification/HoverflyVerificationError.java

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.


@@ -110,7 +110,7 @@
Loading
110 110
    }
111 111
112 112
    void setBinaryLocation(String binaryLocation) {
113 -
        this.tempDirectory = Paths.get(binaryLocation);
113 +
        this.tempDirectory = Paths.get(binaryLocation).toAbsolutePath();
114 114
    }
115 115
116 116
}

@@ -32,7 +32,7 @@
Loading
32 32
 */
33 33
class HoverflyUtils {
34 34
35 -
    private static ObjectWriter OBJECT_WRITER = new ObjectMapper().writerFor(Simulation.class);
35 +
    private static final ObjectWriter OBJECT_WRITER = new ObjectMapper().writerFor(Simulation.class);
36 36
    private static final ObjectReader SIMULATION_READER = new ObjectMapper().readerFor(Simulation.class);
37 37
38 38
    static void checkPortInUse(int port) {

@@ -9,7 +9,7 @@
Loading
9 9
10 10
    static final String DEFAULT_BINARY_NAME_FORMAT = "hoverfly_%s_%s%s";
11 11
12 -
    private SystemInfo systemInfo = new SystemInfo();
12 +
    private final SystemInfo systemInfo = new SystemInfo();
13 13
    private HoverflyConfiguration configs;
14 14
15 15
    SystemConfigFactory() {

Learn more Showing 2 files with coverage changes found.

Changes in src/main/java/io/specto/hoverfly/junit/core/Hoverfly.java
-1
-1
+2
Loading file...
Changes in src/main/java/io/specto/hoverfly/junit/core/config/LocalHoverflyConfig.java
-2
+2
Loading file...
Files Complexity Coverage
src/main/java/io/specto/hoverfly/junit 84.13% 0.32% 85.58%
Project Totals (65 files) 84.13% 85.58%
Loading