No flags found
Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.
e.g., #unittest #integration
#production #enterprise
#frontend #backend
Compare
2967d6e
... +244 ...
37da047
2967d6e
... +244 ...
37da047
Showing 7 of 10 files from the diff.
src/Entity/BaseEntityManager.php
changed.
src/Model/BaseManager.php
changed.
src/Adapter/AdapterChain.php
changed.
src/Document/BaseDocumentManager.php
changed.
src/Model/ManagerInterface.php
changed.
src/Document/BasePHPCRManager.php
changed.
Other files ignored by Codecov
@@ -13,8 +13,11 @@
Loading
| 13 | 13 | ||
| 14 | 14 | namespace Sonata\Doctrine\Entity; |
|
| 15 | 15 | ||
| 16 | + | use Doctrine\DBAL\Connection; |
|
| 16 | 17 | use Doctrine\ORM\EntityManagerInterface; |
|
| 17 | 18 | use Doctrine\ORM\EntityRepository; |
|
| 19 | + | use Doctrine\Persistence\ObjectManager; |
|
| 20 | + | use Doctrine\Persistence\ObjectRepository; |
|
| 18 | 21 | use Sonata\Doctrine\Model\BaseManager; |
|
| 19 | 22 | ||
| 20 | 23 | /** |
@@ -55,7 +58,7 @@
Loading
| 55 | 58 | * |
|
| 56 | 59 | * @deprecated since sonata-project/sonata-doctrine-extensions 1.15 |
|
| 57 | 60 | */ |
|
| 58 | - | public function getConnection() |
|
| 61 | + | public function getConnection(): Connection |
|
| 59 | 62 | { |
|
| 60 | 63 | @trigger_error(sprintf( |
|
| 61 | 64 | 'The "%s()" method is deprecated since sonata-project/sonata-doctrine-extensions 1.15' |
@@ -70,7 +73,7 @@
Loading
| 70 | 73 | /** |
|
| 71 | 74 | * @return EntityManagerInterface |
|
| 72 | 75 | */ |
|
| 73 | - | public function getEntityManager() |
|
| 76 | + | public function getEntityManager(): ObjectManager |
|
| 74 | 77 | { |
|
| 75 | 78 | $objectManager = $this->getObjectManager(); |
|
| 76 | 79 | \assert($objectManager instanceof EntityManagerInterface); |
@@ -81,7 +84,7 @@
Loading
| 81 | 84 | /** |
|
| 82 | 85 | * @phpstan-return EntityRepository<T> |
|
| 83 | 86 | */ |
|
| 84 | - | protected function getRepository(): EntityRepository |
|
| 87 | + | protected function getRepository(): ObjectRepository |
|
| 85 | 88 | { |
|
| 86 | 89 | return $this->getEntityManager()->getRepository($this->class); |
|
| 87 | 90 | } |
@@ -39,22 +39,18 @@
Loading
| 39 | 39 | protected $class; |
|
| 40 | 40 | ||
| 41 | 41 | /** |
|
| 42 | - | * @param string $class |
|
| 43 | - | * |
|
| 44 | 42 | * @phpstan-param class-string<T> $class |
|
| 45 | 43 | */ |
|
| 46 | - | public function __construct($class, ManagerRegistry $registry) |
|
| 44 | + | public function __construct(string $class, ManagerRegistry $registry) |
|
| 47 | 45 | { |
|
| 48 | 46 | $this->registry = $registry; |
|
| 49 | 47 | $this->class = $class; |
|
| 50 | 48 | } |
|
| 51 | 49 | ||
| 52 | 50 | /** |
|
| 53 | 51 | * @throws \RuntimeException |
|
| 54 | - | * |
|
| 55 | - | * @return ObjectManager |
|
| 56 | 52 | */ |
|
| 57 | - | public function getObjectManager() |
|
| 53 | + | public function getObjectManager(): ObjectManager |
|
| 58 | 54 | { |
|
| 59 | 55 | $manager = $this->registry->getManagerForClass($this->class); |
|
| 60 | 56 |
@@ -71,22 +67,22 @@
Loading
| 71 | 67 | return $manager; |
|
| 72 | 68 | } |
|
| 73 | 69 | ||
| 74 | - | public function getClass() |
|
| 70 | + | public function getClass(): string |
|
| 75 | 71 | { |
|
| 76 | 72 | return $this->class; |
|
| 77 | 73 | } |
|
| 78 | 74 | ||
| 79 | - | public function findAll() |
|
| 75 | + | public function findAll(): array |
|
| 80 | 76 | { |
|
| 81 | 77 | return $this->getRepository()->findAll(); |
|
| 82 | 78 | } |
|
| 83 | 79 | ||
| 84 | - | public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null) |
|
| 80 | + | public function findBy(array $criteria, ?array $orderBy = null, ?int $limit = null, ?int $offset = null): array |
|
| 85 | 81 | { |
|
| 86 | 82 | return $this->getRepository()->findBy($criteria, $orderBy, $limit, $offset); |
|
| 87 | 83 | } |
|
| 88 | 84 | ||
| 89 | - | public function findOneBy(array $criteria, ?array $orderBy = null) |
|
| 85 | + | public function findOneBy(array $criteria, ?array $orderBy = null): ?object |
|
| 90 | 86 | { |
|
| 91 | 87 | if (null !== $orderBy) { |
|
| 92 | 88 | @trigger_error( |
@@ -98,17 +94,17 @@
Loading
| 98 | 94 | return $this->getRepository()->findOneBy($criteria); |
|
| 99 | 95 | } |
|
| 100 | 96 | ||
| 101 | - | public function find($id) |
|
| 97 | + | public function find($id): ?object |
|
| 102 | 98 | { |
|
| 103 | 99 | return $this->getRepository()->find($id); |
|
| 104 | 100 | } |
|
| 105 | 101 | ||
| 106 | - | public function create() |
|
| 102 | + | public function create(): object |
|
| 107 | 103 | { |
|
| 108 | 104 | return new $this->class(); |
|
| 109 | 105 | } |
|
| 110 | 106 | ||
| 111 | - | public function save($entity, $andFlush = true) |
|
| 107 | + | public function save(object $entity, bool $andFlush = true): void |
|
| 112 | 108 | { |
|
| 113 | 109 | $this->checkObject($entity); |
|
| 114 | 110 |
@@ -119,7 +115,7 @@
Loading
| 119 | 115 | } |
|
| 120 | 116 | } |
|
| 121 | 117 | ||
| 122 | - | public function delete($entity, $andFlush = true) |
|
| 118 | + | public function delete(object $entity, bool $andFlush = true): void |
|
| 123 | 119 | { |
|
| 124 | 120 | $this->checkObject($entity); |
|
| 125 | 121 |
@@ -135,7 +131,7 @@
Loading
| 135 | 131 | * |
|
| 136 | 132 | * @deprecated since sonata-project/sonata-doctrine-extensions 1.15 |
|
| 137 | 133 | */ |
|
| 138 | - | public function getTableName() |
|
| 134 | + | public function getTableName(): string |
|
| 139 | 135 | { |
|
| 140 | 136 | @trigger_error(sprintf( |
|
| 141 | 137 | 'The "%s()" method is deprecated since sonata-project/sonata-doctrine-extensions 1.15' |
@@ -161,7 +157,7 @@
Loading
| 161 | 157 | * |
|
| 162 | 158 | * @phpstan-return ObjectRepository<T> |
|
| 163 | 159 | */ |
|
| 164 | - | protected function getRepository() |
|
| 160 | + | protected function getRepository(): ObjectRepository |
|
| 165 | 161 | { |
|
| 166 | 162 | return $this->getObjectManager()->getRepository($this->class); |
|
| 167 | 163 | } |
@@ -171,11 +167,9 @@
Loading
| 171 | 167 | * |
|
| 172 | 168 | * @throws \InvalidArgumentException |
|
| 173 | 169 | * |
|
| 174 | - | * @return void |
|
| 175 | - | * |
|
| 176 | 170 | * @phpstan-param T $object |
|
| 177 | 171 | */ |
|
| 178 | - | protected function checkObject($object) |
|
| 172 | + | protected function checkObject($object): void |
|
| 179 | 173 | { |
|
| 180 | 174 | if (!$object instanceof $this->class) { |
|
| 181 | 175 | throw new \InvalidArgumentException(sprintf( |
@@ -13,7 +13,9 @@
Loading
| 13 | 13 | ||
| 14 | 14 | namespace Sonata\Doctrine\Document; |
|
| 15 | 15 | ||
| 16 | + | use Doctrine\DBAL\Connection; |
|
| 16 | 17 | use Doctrine\ODM\MongoDB\DocumentManager; |
|
| 18 | + | use Doctrine\Persistence\ObjectManager; |
|
| 17 | 19 | use Sonata\Doctrine\Model\BaseManager; |
|
| 18 | 20 | ||
| 19 | 21 | /** |
@@ -54,15 +56,15 @@
Loading
| 54 | 56 | * |
|
| 55 | 57 | * @deprecated since sonata-project/sonata-doctrine-extensions 1.15 |
|
| 56 | 58 | */ |
|
| 57 | - | public function getConnection() |
|
| 59 | + | public function getConnection(): Connection |
|
| 58 | 60 | { |
|
| 59 | 61 | throw new \LogicException('MongoDB does not use a database connection.'); |
|
| 60 | 62 | } |
|
| 61 | 63 | ||
| 62 | 64 | /** |
|
| 63 | 65 | * @return DocumentManager |
|
| 64 | 66 | */ |
|
| 65 | - | public function getDocumentManager() |
|
| 67 | + | public function getDocumentManager(): ObjectManager |
|
| 66 | 68 | { |
|
| 67 | 69 | $dm = $this->getObjectManager(); |
|
| 68 | 70 |
@@ -25,11 +25,9 @@
Loading
| 25 | 25 | /** |
|
| 26 | 26 | * Return the Entity class name. |
|
| 27 | 27 | * |
|
| 28 | - | * @return string |
|
| 29 | - | * |
|
| 30 | 28 | * @phpstan-return class-string<T> |
|
| 31 | 29 | */ |
|
| 32 | - | public function getClass(); |
|
| 30 | + | public function getClass(): string; |
|
| 33 | 31 | ||
| 34 | 32 | /** |
|
| 35 | 33 | * Find all entities in the repository. |
@@ -38,95 +36,79 @@
Loading
| 38 | 36 | * |
|
| 39 | 37 | * @phpstan-return T[] |
|
| 40 | 38 | */ |
|
| 41 | - | public function findAll(); |
|
| 39 | + | public function findAll(): array; |
|
| 42 | 40 | ||
| 43 | 41 | /** |
|
| 44 | 42 | * Find entities by a set of criteria. |
|
| 45 | 43 | * |
|
| 46 | 44 | * @param array<string, mixed> $criteria |
|
| 47 | 45 | * @param array<string, 'asc'|'ASC'|'desc'|'DESC'>|null $orderBy |
|
| 48 | - | * @param int|null $limit |
|
| 49 | - | * @param int|null $offset |
|
| 50 | 46 | * |
|
| 51 | 47 | * @return object[] |
|
| 52 | 48 | * |
|
| 53 | 49 | * @phpstan-return T[] |
|
| 54 | 50 | */ |
|
| 55 | - | public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null); |
|
| 51 | + | public function findBy(array $criteria, ?array $orderBy = null, ?int $limit = null, ?int $offset = null): array; |
|
| 56 | 52 | ||
| 57 | 53 | /** |
|
| 58 | 54 | * Find a single entity by a set of criteria. |
|
| 59 | 55 | * |
|
| 60 | 56 | * @param array<string, mixed> $criteria |
|
| 61 | 57 | * @param array<string, string>|null $orderBy |
|
| 62 | 58 | * |
|
| 63 | - | * @return object|null |
|
| 64 | - | * |
|
| 65 | 59 | * @phpstan-return T|null |
|
| 66 | 60 | */ |
|
| 67 | - | public function findOneBy(array $criteria, ?array $orderBy = null); |
|
| 61 | + | public function findOneBy(array $criteria, ?array $orderBy = null): ?object; |
|
| 68 | 62 | ||
| 69 | 63 | /** |
|
| 70 | 64 | * Finds an entity by its primary key / identifier. |
|
| 71 | 65 | * |
|
| 72 | 66 | * @param mixed $id The identifier |
|
| 73 | 67 | * |
|
| 74 | - | * @return object|null |
|
| 75 | - | * |
|
| 76 | 68 | * @phpstan-return T|null |
|
| 77 | 69 | */ |
|
| 78 | - | public function find($id); |
|
| 70 | + | public function find($id): ?object; |
|
| 79 | 71 | ||
| 80 | 72 | /** |
|
| 81 | 73 | * Create an empty Entity instance. |
|
| 82 | 74 | * |
|
| 83 | - | * @return object |
|
| 84 | - | * |
|
| 85 | 75 | * @phpstan-return T |
|
| 86 | 76 | */ |
|
| 87 | - | public function create(); |
|
| 77 | + | public function create(): object; |
|
| 88 | 78 | ||
| 89 | 79 | /** |
|
| 90 | 80 | * Save an Entity. |
|
| 91 | 81 | * |
|
| 92 | 82 | * @param object $entity The Entity to save |
|
| 93 | 83 | * @param bool $andFlush Flush the EntityManager after saving the object? |
|
| 94 | 84 | * |
|
| 95 | - | * @return void |
|
| 96 | - | * |
|
| 97 | 85 | * @phpstan-param T $entity |
|
| 98 | 86 | */ |
|
| 99 | - | public function save($entity, $andFlush = true); |
|
| 87 | + | public function save(object $entity, bool $andFlush = true): void; |
|
| 100 | 88 | ||
| 101 | 89 | /** |
|
| 102 | 90 | * Delete an Entity. |
|
| 103 | 91 | * |
|
| 104 | 92 | * @param object $entity The Entity to delete |
|
| 105 | 93 | * @param bool $andFlush Flush the EntityManager after deleting the object? |
|
| 106 | 94 | * |
|
| 107 | - | * @return void |
|
| 108 | - | * |
|
| 109 | 95 | * @phpstan-param T $entity |
|
| 110 | 96 | */ |
|
| 111 | - | public function delete($entity, $andFlush = true); |
|
| 97 | + | public function delete(object $entity, bool $andFlush = true): void; |
|
| 112 | 98 | ||
| 113 | 99 | /** |
|
| 114 | 100 | * Get the related table name. |
|
| 115 | 101 | * |
|
| 116 | 102 | * NEXT_MAJOR: Remove this ORM-related method from the interface. |
|
| 117 | - | * |
|
| 118 | - | * @return string |
|
| 119 | 103 | */ |
|
| 120 | - | public function getTableName(); |
|
| 104 | + | public function getTableName(): string; |
|
| 121 | 105 | ||
| 122 | 106 | /** |
|
| 123 | 107 | * Get the DB driver connection. |
|
| 124 | 108 | * |
|
| 125 | 109 | * NEXT_MAJOR: Remove this ORM-related method from the interface. |
|
| 126 | - | * |
|
| 127 | - | * @return Connection |
|
| 128 | 110 | */ |
|
| 129 | - | public function getConnection(); |
|
| 111 | + | public function getConnection(): Connection; |
|
| 130 | 112 | } |
|
| 131 | 113 | ||
| 132 | 114 | interface_exists(\Sonata\CoreBundle\Model\ManagerInterface::class); |
Click to load this diff.
Loading diff...
Click to load this diff.
Loading diff...
246
Commits
| Files | Complexity | Coverage |
|---|---|---|
| src | ø | 63.48% |
| Project Totals (27 files) | 211 | 63.48% |
37da047f5ab52657cf21ce494e073c253fe879947487b01c4a067a281ede6cf48b887dcc505ae37fe36f794b125807b897c4169aa7d3b56282d28ddc417908d1287dba4d21a3a6ef5c2035cc4c61542dbf11dfe2972d524db73db9fd2384e94a7454b206abd98d03cf5cdceb15ef36bceea261f04d9084065c3b29aede778b9e4df01c9c3e5b3a7c0397b0f2599ee11ba01e658cdb6efa551a92252ca4fc3e8b63d2276bcd1c31086fde51fe124ad9552a5fd0d8e3832c02ae55691dc32c704d25e4117f9a99231b8755f9e5e86427a08f19994144a7c67ae36038b988af804224afbc245a947bf5f6a5a928e07d93c2a965d0e55dfdda2770507d7f7e67e888c86cb707b967b99102819cd264ada8addd3e84aacb49a5cd9bb7df097663f662db047a43e4479511530de89b3a56c2abcf814111598a2f39048f7ce58f44136d74b558cf1354497fe554895c580ff8c4bad91c5c35751c49bdf0fe88d5a3588dea7329087262bb7bafdedbb02411e5f579dff7b109dd176a0a171cfd790f4a4dcb2ea43fa39f228cfaaf36bd099c407c2f39a9720a51e654a12629e2392579b46a4526732897618a71d514c23839e28117b0890ad4238914e35d631b8d1e68086d922c0ba6979d2d237aab075deeec24c929f3835800c12668d8bb8b458bf61b26a5217c1d2e410ab1d5617f9ef14b7516c2108df90d8046ab8f2a7f54ace08fdcd48c4cd23e4fc99afe4c5d117860e62bbe23e48dc00be726c72c630cd8ebf63c4c8f05005c015c5609181adc583a5f58519982337987eaded43ca2804887950619e7500901d2fd29e4db82c55a5fc874bacb3772283c37b9131f0c18241ff23108534ed47f6d2a50a6e288815965733d7ad8ec844ae54f71514d304668d20d99b82c3996f6cd0363dd1f23d35cc0496abffabeec2b394f058969d2b0fdbe6d491533cc1945840d487f26a9bacf87b8a0ba723d0ebd74c332fa7f3fef2a06db969484a2f4720b67a0f278c1344b2ed365bd1c4b02dffc3cb9b19b1a5decdadeaf033f6cc38b878b65d8ef933052a0f2959be29e31892d0aec01f1b41e06cf7a9131fbaff001cf619710eae4879f67f6c7de6b9c1fa54c7bb373b5772150536fe628c59582a964beb5c9d746ae0a5f4ade19087f666aa732d9b5e91c7ff79fd49824cfa8f8d8813ea1da8a2469dd76d84c5caeff4f972b947ce2967d6e