socialresearchcentre / dialr

Compare dc0fe20 ... +1 ... d991cc5

93.36% 100.00% +0.06%

Overview Diff Coverage Changes Files Commits
Coverage Reach
phone.R phoneNumberUtil.R example.R match.R timezone.R carrier.R type.R cc.R region.R geocoder.R pillar.R

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.

Showing 1 of 3 files from the diff.
96.65% 100.00% +0.08%
R/phone.R changed.
Other files ignored by Codecov
NEWS.md has changed.
man/dialr-package.Rd has changed.

@@ -90,28 +90,36 @@
Loading
90 90 
           r)
91 91 
  }
92 92
93 + 
  # create vector of "valid" numbers based on the regex in Java
94 + 
  valid_regex <- paste0("^", .jfield(phone_util, "S", "VALID_PHONE_NUMBER"), "$")
95 + 
  x_valid <- grepl(valid_regex, x, perl = TRUE)
96 +
93 97 
  show_pb <- isTRUE(show_progress) && interactive()
94 98
95 99 
  if (show_pb) pb <- txtProgressBar(min = 0, max = length(x), style = 3)
96 100 
  out <- structure(
97 101 
    mapply(
98 - 
      function(p, r) {
102 + 
      function(p, r, v) {
99 103 
        if (show_pb) setTxtProgressBar(pb, getTxtProgressBar(pb) + 1)
100 - 
        pn <- tryCatch({
101 - 
          jfunc(p, r)
102 - 
        }, error = function(e) {
103 - 
          return(NULL)
104 - 
        })
105 - 
        if (is.null(pn))
104 + 
        if (!v) {
106 105 
          pn <- NA
107 - 
        else
108 - 
          .jcache(pn)
106 + 
        } else {
107 + 
          pn <- tryCatch({
108 + 
            jfunc(p, r)
109 + 
          }, error = function(e) {
110 + 
            return(NULL)
111 + 
          })
112 + 
          if (is.null(pn))
113 + 
            pn <- NA
114 + 
          else
115 + 
            .jcache(pn)
116 + 
        }
109 117
110 118 
        list(raw = p,
111 119 
             region = r,
112 120 
             jobj = pn)
113 121 
      },
114 - 
      x, region,
122 + 
      x, region, x_valid,
115 123 
      SIMPLIFY = FALSE
116 124 
    ),
117 125 
    class = c("phone", "list")

Everything is accounted for!

No changes detected that need to be reviewed.
What changes does Codecov check for?
Lines, not adjusted in diff, that have changed coverage data.
Files that introduced coverage data that had none before.
Files that have missing coverage data that once were tracked.

3 Commits

Danny Smith
93.36% ø +0.06%
Minor doc updates
gorcha
d991cc5
CI Passed
Danny Smith
Contextual
Pre-process NOT_A_NUMBER values in phone().
gorcha
6f7b42f
Hiding 1 contexual commits
+4
+4
Danny Smith
93.30% 100.00% ø
Add show_progress option to phone() and timezone(). Close #25
gorcha
dc0fe20
CI Passed
Files Coverage
R 0.06% 93.36%
Project Totals (11 files) 93.36%
Loading