#198 Reject trailing bytes

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.

Showing 7 of 8 files from the diff.

77.78% ø ø

src/de/mod.rs changed.

0.00% ø ø

src/config/legacy.rs changed.

54.55% 100.00% +1.72%

src/de/read.rs changed.

97.22% 100.00% +0.35%

src/internal.rs changed.

75.00% ø ø

src/lib.rs changed.

40.35% 28.57% +0.35%

src/config/mod.rs changed.

Newly tracked file

57.14% 57.14% ø

src/config/trailing.rs created.

Other files ignored by Codecov

tests/test.rs has changed.

@@ -26,7 +26,7 @@

/// let bytes_read = d.bytes_read();
/// ```
pub struct Deserializer<R, O: Options> {
    reader: R,
    pub(crate) reader: R,
    options: O,
}


@@ -49,20 +49,23 @@

            (Unlimited, Little) => {
                let $opts = DefaultOptions::new()
                    .with_fixint_encoding()
                    .allow_trailing_bytes()
                    .with_no_limit()
                    .with_little_endian();
                $call
            }
            (Unlimited, Big) => {
                let $opts = DefaultOptions::new()
                    .with_fixint_encoding()
                    .allow_trailing_bytes()
                    .with_no_limit()
                    .with_big_endian();
                $call
            }
            (Unlimited, Native) => {
                let $opts = DefaultOptions::new()
                    .with_fixint_encoding()
                    .allow_trailing_bytes()
                    .with_no_limit()
                    .with_native_endian();
                $call

@@ -71,20 +74,23 @@

            (Limited(l), Little) => {
                let $opts = DefaultOptions::new()
                    .with_fixint_encoding()
                    .allow_trailing_bytes()
                    .with_limit(l)
                    .with_little_endian();
                $call
            }
            (Limited(l), Big) => {
                let $opts = DefaultOptions::new()
                    .with_fixint_encoding()
                    .allow_trailing_bytes()
                    .with_limit(l)
                    .with_big_endian();
                $call
            }
            (Limited(l), Native) => {
                let $opts = DefaultOptions::new()
                    .with_fixint_encoding()
                    .allow_trailing_bytes()
                    .with_limit(l)
                    .with_native_endian();
                $call

@@ -52,6 +52,10 @@

        self.slice = remaining;
        Ok(read_slice)
    }

    pub(crate) fn is_finished(&self) -> bool {
        self.slice.is_empty()
    }
}

impl<R> IoReader<R> {

@@ -2,7 +2,7 @@

use std::io::{Read, Write};
use std::marker::PhantomData;

use config::{Infinite, InternalOptions, Options, SizeLimit};
use config::{Infinite, InternalOptions, Options, SizeLimit, TrailingBytes};
use de::read::BincodeRead;
use Result;


@@ -111,7 +111,14 @@

    T: serde::de::DeserializeSeed<'a>,
    O: InternalOptions,
{
    let reader = ::de::read::SliceReader::new(bytes);
    let options = ::config::WithOtherLimit::new(options, Infinite);
    deserialize_from_custom_seed(seed, reader, options)

    let reader = ::de::read::SliceReader::new(bytes);
    let mut deserializer = ::de::Deserializer::with_bincode_read(reader, options);
    let val = seed.deserialize(&mut deserializer)?;

    match O::Trailing::check_end(&deserializer.reader) {
        Ok(_) => Ok(val),
        Err(err) => Err(err),
    }
}

@@ -94,6 +94,7 @@

{
    DefaultOptions::new()
        .with_fixint_encoding()
        .allow_trailing_bytes()
        .serialize(value)
}


@@ -107,6 +108,7 @@

{
    DefaultOptions::new()
        .with_fixint_encoding()
        .allow_trailing_bytes()
        .deserialize_from(reader)
}


@@ -122,6 +124,7 @@

{
    DefaultOptions::new()
        .with_fixint_encoding()
        .allow_trailing_bytes()
        .deserialize_from_custom(reader)
}


@@ -136,6 +139,7 @@

{
    DefaultOptions::new()
        .with_fixint_encoding()
        .allow_trailing_bytes()
        .deserialize_in_place(reader, place)
}


@@ -146,6 +150,7 @@

{
    DefaultOptions::new()
        .with_fixint_encoding()
        .allow_trailing_bytes()
        .deserialize(bytes)
}


@@ -156,5 +161,6 @@

{
    DefaultOptions::new()
        .with_fixint_encoding()
        .allow_trailing_bytes()
        .serialized_size(value)
}

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Learn more Showing 1 files with coverage changes found.

New file src/config/trailing.rs

New

Loading file...

61.43% 100.00% +0.05%

fix formatting

ZoeyR

7188d6b

CI Passed

61.38% 57.89% +0.04%

switch to config based approach

ZoeyR

67e10ac

CI Passed

Hiding 1 contexual commits

+1 Files

+19

+12

Pull Request Base Commit

61.34% ø ø

haha json go brrr (#324)

ZoeyR

131b2b2

CI Passed

Files		•	•	•	Coverage
src	+20	+13	ø	+7	^0.09% 61.43%
Project Totals (11 files)	827	508	0	319	61.43%

111	111		T: serde::de::DeserializeSeed<'a>,
112	112		O: InternalOptions,
113	113		{
114		-	let reader = ::de::read::SliceReader::new(bytes);
115	114		let options = ::config::WithOtherLimit::new(options, Infinite);
116		-	deserialize_from_custom_seed(seed, reader, options)
	115	+
	116	+	let reader = ::de::read::SliceReader::new(bytes);
	117	+	let mut deserializer = ::de::Deserializer::with_bincode_read(reader, options);
	118	+	let val = seed.deserialize(&mut deserializer)?;
	119	+
	120	+	match O::Trailing::check_end(&deserializer.reader) {
	121	+	Ok(_) => Ok(val),
	122	+	Err(err) => Err(err),
	123	+	}
117	124		}

122	124		{
123	125		DefaultOptions::new()
124	126		.with_fixint_encoding()
	127	+	.allow_trailing_bytes()
125	128		.deserialize_from_custom(reader)
126	129		}
127	130

136	139		{
137	140		DefaultOptions::new()
138	141		.with_fixint_encoding()
	142	+	.allow_trailing_bytes()
139	143		.deserialize_in_place(reader, place)
140	144		}
141	145

146	150		{
147	151		DefaultOptions::new()
148	152		.with_fixint_encoding()
	153	+	.allow_trailing_bytes()
149	154		.deserialize(bytes)
150	155		}
151	156

156	161		{
157	162		DefaultOptions::new()
158	163		.with_fixint_encoding()
	164	+	.allow_trailing_bytes()
159	165		.serialized_size(value)
160	166		}

26	26		/// let bytes_read = d.bytes_read();
27	27		/// ```
28	28		pub struct Deserializer<R, O: Options> {
29		-	reader: R,
	29	+	pub(crate) reader: R,
30	30		options: O,
31	31		}
32	32

49	49		(Unlimited, Little) => {
50	50		let $opts = DefaultOptions::new()
51	51		.with_fixint_encoding()
	52	+	.allow_trailing_bytes()
52	53		.with_no_limit()
53	54		.with_little_endian();
54	55		$call
55	56		}
56	57		(Unlimited, Big) => {
57	58		let $opts = DefaultOptions::new()
58	59		.with_fixint_encoding()
	60	+	.allow_trailing_bytes()
59	61		.with_no_limit()
60	62		.with_big_endian();
61	63		$call
62	64		}
63	65		(Unlimited, Native) => {
64	66		let $opts = DefaultOptions::new()
65	67		.with_fixint_encoding()
	68	+	.allow_trailing_bytes()
66	69		.with_no_limit()
67	70		.with_native_endian();
68	71		$call

71	74		(Limited(l), Little) => {
72	75		let $opts = DefaultOptions::new()
73	76		.with_fixint_encoding()
	77	+	.allow_trailing_bytes()
74	78		.with_limit(l)
75	79		.with_little_endian();
76	80		$call
77	81		}
78	82		(Limited(l), Big) => {
79	83		let $opts = DefaultOptions::new()
80	84		.with_fixint_encoding()
	85	+	.allow_trailing_bytes()
81	86		.with_limit(l)
82	87		.with_big_endian();
83	88		$call
84	89		}
85	90		(Limited(l), Native) => {
86	91		let $opts = DefaultOptions::new()
87	92		.with_fixint_encoding()
	93	+	.allow_trailing_bytes()
88	94		.with_limit(l)
89	95		.with_native_endian();
90	96		$call

52	52		self.slice = remaining;
53	53		Ok(read_slice)
54	54		}
	55	+
	56	+	pub(crate) fn is_finished(&self) -> bool {
	57	+	self.slice.is_empty()
	58	+	}
55	59		}
56	60
57	61		impl<R> IoReader<R> {

2	2		use std::io::{Read, Write};
3	3		use std::marker::PhantomData;
4	4
5		-	use config::{Infinite, InternalOptions, Options, SizeLimit};
	5	+	use config::{Infinite, InternalOptions, Options, SizeLimit, TrailingBytes};
6	6		use de::read::BincodeRead;
7	7		use Result;
8	8

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

#198 Reject trailing bytes

No flags found

Show failed CI and contexual commits c 3 Commits

Show failed CI and contexual commits `c`

3 Commits