Compare ⋅ scrapy/scrapy

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.

Showing 1 of 1 files from the diff.

95.16% 100.00% -0.19%

scrapy/http/request/form.py changed.

@@ -12,7 +12,6 @@

Loading

from w3lib.html import strip_html5_whitespace

from scrapy.http.request import Request
from scrapy.utils.python import to_bytes, is_listlike
from scrapy.utils.response import get_base_url



@@ -27,8 +26,7 @@

Loading

        super().__init__(*args, **kwargs)

        if formdata:
            items = formdata.items() if isinstance(formdata, dict) else formdata
            querystr = _urlencode(items, self.encoding)
            querystr = urlencode(formdata, doseq=1, encoding=self.encoding)
            if self.method == 'POST':
                self.headers.setdefault(b'Content-Type', b'application/x-www-form-urlencoded')
                self._set_body(querystr)

@@ -67,13 +65,6 @@

Loading

    return urljoin(form.base_url, url)


def _urlencode(seq, enc):
    values = [(to_bytes(k, enc), to_bytes(v, enc))
              for k, vs in seq
              for v in (vs if is_listlike(vs) else [vs])]
    return urlencode(values, doseq=1)


def _get_form(response, formname, formid, formnumber, formxpath):
    """Find the form element """
    root = create_root_node(response.text, lxml.html.HTMLParser,

Learn more Showing 1 files with coverage changes found.

Changes in scrapy/extensions/memusage.py

-1

→

+1

Loading file...

88.02% 100.00% +<.01%

updated urlencode

AKSHAYSHARMAJS

#4953 c58f3cd

CI Passed

-5

-4

-1

Pull Request Base Commit

88.01% ø +0.11%

Merge pull request #4814 from dswij/tox-pip20.2

Gallaecio

39bc9a4

CI Passed

Files		•	•	•	Coverage
scrapy	-5	-4	-1	ø	^+<.01% 88.02%
Project Totals (158 files)	9,714	8,550	254	910	88.02%

27	26		super().__init__(args, *kwargs)
28	27
29	28		if formdata:
30		-	items = formdata.items() if isinstance(formdata, dict) else formdata
31		-	querystr = _urlencode(items, self.encoding)
	29	+	querystr = urlencode(formdata, doseq=1, encoding=self.encoding)
32	30		if self.method == 'POST':
33	31		self.headers.setdefault(b'Content-Type', b'application/x-www-form-urlencoded')
34	32		self._set_body(querystr)

67	65		return urljoin(form.base_url, url)
68	66
69	67
70		-	def _urlencode(seq, enc):
71		-	values = [(to_bytes(k, enc), to_bytes(v, enc))
72		-	for k, vs in seq
73		-	for v in (vs if is_listlike(vs) else [vs])]
74		-	return urlencode(values, doseq=1)
75		-
76		-
77	68		def _get_form(response, formname, formid, formnumber, formxpath):
78	69		"""Find the form element """
79	70		root = create_root_node(response.text, lxml.html.HTMLParser,

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

#4953 adding variable type values support to 'scrapy.FormRequest()'

No flags found

1 Commits

12	12		from w3lib.html import strip_html5_whitespace
13	13
14	14		from scrapy.http.request import Request
15		-	from scrapy.utils.python import to_bytes, is_listlike
16	15		from scrapy.utils.response import get_base_url
17	16
18	17