scrapy / scrapy

Compare bbb8294 ... +0 ... b7c39f5

Coverage Reach
core/downloader/handlers/http11.py core/downloader/handlers/http2.py core/downloader/handlers/ftp.py core/downloader/handlers/__init__.py core/downloader/handlers/s3.py core/downloader/handlers/http10.py core/downloader/handlers/datauri.py core/downloader/handlers/file.py core/downloader/handlers/http.py core/downloader/__init__.py core/downloader/webclient.py core/downloader/middleware.py core/downloader/contextfactory.py core/downloader/tls.py core/http2/protocol.py core/http2/stream.py core/http2/agent.py core/engine.py core/scraper.py core/scheduler.py core/spidermw.py utils/python.py utils/misc.py utils/conf.py utils/iterators.py utils/defer.py utils/log.py utils/datatypes.py utils/deprecate.py utils/test.py utils/request.py utils/console.py utils/reactor.py utils/curl.py utils/project.py utils/url.py utils/signal.py utils/response.py utils/ssl.py utils/testproc.py utils/trackref.py utils/spider.py utils/benchserver.py utils/testsite.py utils/serialize.py utils/decorators.py utils/display.py utils/sitemap.py utils/gz.py utils/ftp.py utils/engine.py utils/boto.py utils/template.py utils/ossignal.py utils/versions.py utils/reqser.py utils/httpobj.py utils/job.py utils/asyncgen.py utils/py36.py extensions/feedexport.py extensions/httpcache.py extensions/memusage.py extensions/postprocessing.py extensions/telnet.py extensions/throttle.py extensions/closespider.py extensions/debug.py extensions/logstats.py extensions/corestats.py extensions/spiderstate.py extensions/statsmailer.py extensions/memdebug.py commands/parse.py commands/genspider.py commands/startproject.py commands/__init__.py commands/check.py commands/runspider.py commands/fetch.py commands/shell.py commands/bench.py commands/settings.py commands/edit.py commands/crawl.py commands/version.py commands/view.py commands/list.py http/request/form.py http/request/__init__.py http/request/json_request.py http/request/rpc.py http/response/text.py http/response/__init__.py http/response/html.py http/response/xml.py http/cookies.py http/headers.py http/__init__.py http/common.py downloadermiddlewares/httpcache.py downloadermiddlewares/cookies.py downloadermiddlewares/robotstxt.py downloadermiddlewares/httpcompression.py downloadermiddlewares/redirect.py downloadermiddlewares/retry.py downloadermiddlewares/decompression.py downloadermiddlewares/httpproxy.py downloadermiddlewares/ajaxcrawl.py downloadermiddlewares/stats.py downloadermiddlewares/httpauth.py downloadermiddlewares/useragent.py downloadermiddlewares/downloadtimeout.py downloadermiddlewares/defaultheaders.py pipelines/files.py pipelines/media.py pipelines/images.py pipelines/__init__.py settings/__init__.py settings/default_settings.py spidermiddlewares/referer.py spidermiddlewares/offsite.py spidermiddlewares/depth.py spidermiddlewares/httperror.py spidermiddlewares/urllength.py spiders/crawl.py spiders/feed.py spiders/sitemap.py spiders/__init__.py spiders/init.py exporters.py contracts/__init__.py contracts/default.py crawler.py linkextractors/lxmlhtml.py linkextractors/__init__.py shell.py cmdline.py pqueues.py squeues.py mail.py robotstxt.py item.py resolver.py responsetypes.py dupefilters.py middleware.py statscollectors.py spiderloader.py logformatter.py selector/unified.py selector/__init__.py exceptions.py loader/__init__.py loader/processors.py loader/common.py signals.py signalmanager.py __init__.py link.py extension.py interfaces.py __main__.py

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.

Showing 1 of 1 files from the diff.

@@ -5,7 +5,7 @@
Loading
5 5
See documentation in docs/topics/request-response.rst
6 6
"""
7 7
8 -
from typing import Iterable, List, Optional, Tuple, Type, TypeVar, Union
8 +
from typing import List, Optional, Tuple, Type, TypeVar, Union
9 9
from urllib.parse import urljoin, urlencode, urlsplit, urlunsplit
10 10
11 11
from lxml.html import FormElement, HtmlElement, HTMLParser, SelectElement
@@ -14,7 +14,6 @@
Loading
14 14
15 15
from scrapy.http.request import Request
16 16
from scrapy.http.response.text import TextResponse
17 -
from scrapy.utils.python import to_bytes, is_listlike
18 17
from scrapy.utils.response import get_base_url
19 18
20 19
@@ -33,8 +32,7 @@
Loading
33 32
        super().__init__(*args, **kwargs)
34 33
35 34
        if formdata:
36 -
            items = formdata.items() if isinstance(formdata, dict) else formdata
37 -
            form_query_str = urlencode(formdata, doseq=1, encoding=self.encoding)
35 +
            form_query_str = urlencode(formdata, doseq=True, encoding=self.encoding)
38 36
            if self.method == 'POST':
39 37
                self.headers.setdefault(b'Content-Type', b'application/x-www-form-urlencoded')
40 38
                self._set_body(form_query_str)

Everything is accounted for!

No changes detected that need to be reviewed.
What changes does Codecov check for?
Lines, not adjusted in diff, that have changed coverage data.
Files that introduced coverage data that had none before.
Files that have missing coverage data that once were tracked.
Files Coverage
scrapy -<.01% 88.47%
Project Totals (163 files) 88.47%
Loading