Compare ⋅ scalalandio/chimney

Overview Diff Coverage Changes Files Commits

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.

Showing 2 of 4 files from the diff.

99.24% 100.00% +0.01%

...nd/chimney/internal/macros/TransformerMacros.scala changed.

100.00% 100.00% ø

...ney/internal/macros/TransformerConfigSupport.scala changed.

Other files ignored by Codecov

...src/test/scala/io/scalaland/chimney/DslFSpec.scala has changed.

.../scalaland/chimney/internal/TransformerFlags.scala has changed.

@@ -757,16 +757,19 @@

Loading


      (implicitTransformerF, implicitTransformer) match {
        case (Some(localImplicitTreeF), Some(localImplicitTree)) =>
          c.abort(
            c.enclosingPosition,
            s"""Ambiguous implicits while resolving Chimney recursive transformation:
          if (config.flags.preferPureTransformer)
            Right(TransformerBodyTree(localImplicitTree.callTransform(srcPrefixTree), isWrapped = false))
          else
            c.abort(
              c.enclosingPosition,
              s"""Ambiguous implicits while resolving Chimney recursive transformation:
               |
               |TransformerF[${config.wrapperType.get}, $From, $To]: $localImplicitTreeF
               |Transformer[$From, $To]: $localImplicitTree
               |
               |Please eliminate ambiguity from implicit scope or use withFieldComputed/withFieldComputedF to decide which one should be used
               |""".stripMargin
          )
            )
        case (Some(localImplicitTreeF), None) =>
          Right(TransformerBodyTree(localImplicitTreeF.callTransform(srcPrefixTree), isWrapped = true))
        case (None, Some(localImplicitTree)) =>

@@ -141,7 +141,8 @@

Loading

      beanSetters: Boolean = false,
      beanGetters: Boolean = false,
      optionDefaultsToNone: Boolean = false,
      unsafeOption: Boolean = false
      unsafeOption: Boolean = false,
      preferPureTransformer: Boolean = false
  ) {
    def setFlag(flagTpe: Type, value: Boolean): TransformerFlags = {
      if (flagTpe =:= FlagsTpes.methodAccessorsT) {

@@ -156,6 +157,8 @@

Loading

        copy(optionDefaultsToNone = value)
      } else if (flagTpe =:= FlagsTpes.unsafeOptionT) {
        copy(unsafeOption = value)
      } else if (flagTpe =:= FlagsTpes.preferPureTransformerT) {
        copy(preferPureTransformer = value)
      } else {
        // $COVERAGE-OFF$
        c.abort(c.enclosingPosition, s"Invalid transformer flag type: $flagTpe!")

@@ -178,6 +181,7 @@

Loading

    val beanGettersT: Type = typeOf[BeanGetters]
    val optionDefaultsToNoneT: Type = typeOf[OptionDefaultsToNone]
    val unsafeOptionT: Type = typeOf[UnsafeOption]
    val preferPureTransformerT: Type = typeOf[PreferPureTransformer]
  }

  def captureTransformerFlags(

Everything is accounted for!

No changes detected that need to be reviewed.

What changes does Codecov check for?

Lines, not adjusted in diff, that have changed coverage data.

Files that introduced coverage data that had none before.

Files that have missing coverage data that once were tracked.

99.56% 100.00% +<.01%

WIP Resolving TransformerF and Transformer ambiguity

ulanzetz

#197 459d38d

CI Passed

+5

Pull Request Base Commit

99.55% ø ø

bump sbt-sonatype to 3.9.5

krzemin

577707a

CI Passed

Files		•	•	•	Coverage
chimney/src/main/scala/io/scalaland/chimney	+5	+5	ø	ø	^+<.01% 99.56%
Project Totals (25 files)	679	676	0	3	99.56%

757	757
758	758		(implicitTransformerF, implicitTransformer) match {
759	759		case (Some(localImplicitTreeF), Some(localImplicitTree)) =>
760		-	c.abort(
761		-	c.enclosingPosition,
762		-	s"""Ambiguous implicits while resolving Chimney recursive transformation:
	760	+	if (config.flags.preferPureTransformer)
	761	+	Right(TransformerBodyTree(localImplicitTree.callTransform(srcPrefixTree), isWrapped = false))
	762	+	else
	763	+	c.abort(
	764	+	c.enclosingPosition,
	765	+	s"""Ambiguous implicits while resolving Chimney recursive transformation:
763	766		\|
764	767		\|TransformerF[${config.wrapperType.get}, $From, $To]: $localImplicitTreeF
765	768		\|Transformer[$From, $To]: $localImplicitTree
766	769		\|
767	770		\|Please eliminate ambiguity from implicit scope or use withFieldComputed/withFieldComputedF to decide which one should be used
768	771		\|""".stripMargin
769		-	)
	772	+	)
770	773		case (Some(localImplicitTreeF), None) =>
771	774		Right(TransformerBodyTree(localImplicitTreeF.callTransform(srcPrefixTree), isWrapped = true))
772	775		case (None, Some(localImplicitTree)) =>

141	141		beanSetters: Boolean = false,
142	142		beanGetters: Boolean = false,
143	143		optionDefaultsToNone: Boolean = false,
144		-	unsafeOption: Boolean = false
	144	+	unsafeOption: Boolean = false,
	145	+	preferPureTransformer: Boolean = false
145	146		) {
146	147		def setFlag(flagTpe: Type, value: Boolean): TransformerFlags = {
147	148		if (flagTpe =:= FlagsTpes.methodAccessorsT) {

178	181		val beanGettersT: Type = typeOf[BeanGetters]
179	182		val optionDefaultsToNoneT: Type = typeOf[OptionDefaultsToNone]
180	183		val unsafeOptionT: Type = typeOf[UnsafeOption]
	184	+	val preferPureTransformerT: Type = typeOf[PreferPureTransformer]
181	185		}
182	186
183	187		def captureTransformerFlags(

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

#197 WIP Resolving TransformerF and Transformer ambiguity

No flags found

Everything is accounted for!

What changes does Codecov check for?

1 Commits

156	157		copy(optionDefaultsToNone = value)
157	158		} else if (flagTpe =:= FlagsTpes.unsafeOptionT) {
158	159		copy(unsafeOption = value)
	160	+	} else if (flagTpe =:= FlagsTpes.preferPureTransformerT) {
	161	+	copy(preferPureTransformer = value)
159	162		} else {
160	163		// $COVERAGE-OFF$
161	164		c.abort(c.enclosingPosition, s"Invalid transformer flag type: $flagTpe!")