Compare `5e0038c ... +9 ... 97ad71e`

  
  ## FIXME FISHBASE uses mixed-case names for cols that should be case-insensitive
  ## Consider lowercasing all column names (though makes many camelCase names hard to read...)
  suppressWarnings({
  arkdb::unark(local_tbl, 
               db, 
               arkdb::streamable_readr_tsv(), 
               lines = 1e6,
               overwrite = overwrite,
               guess_max = 1e6
  )
  })
}



@@ -41,39 +41,20 @@

#' options(FISHBASE_VERSION=NULL)
#' @importFrom stats na.omit
available_releases <- function(){
  
  avail_releases <- tryCatch({
    readLines(paste0(
    "https://raw.githubusercontent.com/ropensci/",
     "rfishbase/master/inst/extdata/rfishbase_available_releases.txt"))
    }, 
    error = function(e){
      readLines(system.file("extdata", 
                            "rfishbase_available_releases.txt",
                            package = "rfishbase", mustWork = TRUE))
    },
    finally = readLines(system.file("extdata", 
                                    "rfishbase_available_releases.txt",
                                    package = "rfishbase", mustWork = TRUE)))

  ## check for cached version first
  avail_releases <- mget("avail_releases", 
                         envir = db_cache, 
                         ifnotfound = NA)[[1]]
  if(!all(is.na(avail_releases)))
    return(avail_releases)
  
  
  ## Okay, check GH for a release
  token <- Sys.getenv("GITHUB_TOKEN", 
                      Sys.getenv("GITHUB_PAT", 
                                 paste0("b2b7441d", 
                                        "aeeb010b", 
                                        "1df26f1f6", 
                                        "0a7f1ed",
                                        "c485e443")))
  avail_releases <- gh::gh("/repos/:owner/:repo/releases", 
         owner = "ropensci",
         repo="rfishbase", 
         .token = token) %>%
    purrr::map_chr("tag_name") %>%
    stringr::str_extract("\\d\\d\\.\\d\\d") %>% 
    as.numeric() %>% 
    stats::na.omit() %>%
    unique() %>% 
    sort(decreasing = TRUE) %>% 
    as.character()
  
  ## Cache this so we don't hit GH every single time!
  assign("avail_releases", avail_releases, envir = db_cache)
  
  avail_releases
}


Everything is accounted for!

No changes detected that need to be reviewed.

What changes does Codecov check for?

Lines, not adjusted in diff, that have changed coverage data.

Files that introduced coverage data that had none before.

Files that have missing coverage data that once were tracked.

81.76% 100.00% -1.52%

streamline tests

cboettig

97ad71e

CI Passed

Hiding 9 contexual commits

-11

-14

83.28% 87.50% +0.10%

load_taxa() should not collect() in internal use

cboettig

5e0038c

CI Passed

Files		•	•	•	Coverage
R	-11	-14	ø	+3	^-1.52% 81.76%
Project Totals (14 files)	318	260	0	58	81.76%

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

16	16
17	17		## FIXME FISHBASE uses mixed-case names for cols that should be case-insensitive
18	18		## Consider lowercasing all column names (though makes many camelCase names hard to read...)
	19	+	suppressWarnings({
19	20		arkdb::unark(local_tbl,
20	21		db,
21	22		arkdb::streamable_readr_tsv(),
	23	+	lines = 1e6,
22	24		overwrite = overwrite,
23	25		guess_max = 1e6
24	26		)
	27	+	})
25	28		}
26	29
27	30

41	41		#' options(FISHBASE_VERSION=NULL)
42	42		#' @importFrom stats na.omit
43	43		available_releases <- function(){
44		-
	44	+	avail_releases <- tryCatch({
	45	+	readLines(paste0(
	46	+	"https://raw.githubusercontent.com/ropensci/",
	47	+	"rfishbase/master/inst/extdata/rfishbase_available_releases.txt"))
	48	+	},
	49	+	error = function(e){
	50	+	readLines(system.file("extdata",
	51	+	"rfishbase_available_releases.txt",
	52	+	package = "rfishbase", mustWork = TRUE))
	53	+	},
	54	+	finally = readLines(system.file("extdata",
	55	+	"rfishbase_available_releases.txt",
	56	+	package = "rfishbase", mustWork = TRUE)))
45	57
46		-	## check for cached version first
47		-	avail_releases <- mget("avail_releases",
48		-	envir = db_cache,
49		-	ifnotfound = NA)[[1]]
50		-	if(!all(is.na(avail_releases)))
51		-	return(avail_releases)
52		-
53		-
54		-	## Okay, check GH for a release
55		-	token <- Sys.getenv("GITHUB_TOKEN",
56		-	Sys.getenv("GITHUB_PAT",
57		-	paste0("b2b7441d",
58		-	"aeeb010b",
59		-	"1df26f1f6",
60		-	"0a7f1ed",
61		-	"c485e443")))
62		-	avail_releases <- gh::gh("/repos/:owner/:repo/releases",
63		-	owner = "ropensci",
64		-	repo="rfishbase",
65		-	.token = token) %>%
66		-	purrr::map_chr("tag_name") %>%
67		-	stringr::str_extract("\\d\\d\\.\\d\\d") %>%
68		-	as.numeric() %>%
69		-	stats::na.omit() %>%
70		-	unique() %>%
71		-	sort(decreasing = TRUE) %>%
72		-	as.character()
73		-
74		-	## Cache this so we don't hit GH every single time!
75		-	assign("avail_releases", avail_releases, envir = db_cache)
76		-
77	58		avail_releases
78	59		}
79	60

Compare 5e0038c ... +9 ... 97ad71e

No flags found

Everything is accounted for!

What changes does Codecov check for?

Show failed CI and contexual commits c 11 Commits

Compare `5e0038c ... +9 ... 97ad71e`

Show failed CI and contexual commits `c`

11 Commits