#3883 feat: bundle closing

	}

	await Promise.all(outputOptions.map(bundle.write));
	await bundle.close();
	if (!silent) {
		warnings.flush();
		stderr(green(`created ${bold(files.join(', '))} in ${bold(ms(Date.now() - start))}`));

@@ -2,7 +2,7 @@

import Bundle from '../Bundle';
import Graph from '../Graph';
import { ensureArray } from '../utils/ensureArray';
import { errCannotEmitFromOptionsHook, error } from '../utils/error';
import { errAlreadyClosed, errCannotEmitFromOptionsHook, error } from '../utils/error';
import { writeFile } from '../utils/fs';
import { normalizeInputOptions } from '../utils/options/normalizeInputOptions';
import { normalizeOutputOptions } from '../utils/options/normalizeOutputOptions';

@@ -56,6 +56,7 @@

			err.watchFiles = watchFiles;
		}
		await graph.pluginDriver.hookParallel('buildEnd', [err]);
		await graph.pluginDriver.hookParallel('closeBundle', []);
		throw err;
	}


@@ -65,7 +66,17 @@


	const result: RollupBuild = {
		cache: useCache ? graph.getCache() : undefined,
		closed: false,
		async close() {
			if (result.closed) return;

			result.closed = true;

			await graph.pluginDriver.hookParallel('closeBundle', []);
		},
		async generate(rawOutputOptions: OutputOptions) {
			if (result.closed) return error(errAlreadyClosed());

			return handleGenerateWrite(
				false,
				inputOptions,

@@ -76,6 +87,8 @@

		},
		watchFiles: Object.keys(graph.watchFiles),
		async write(rawOutputOptions: OutputOptions) {
			if (result.closed) return error(errAlreadyClosed());

			return handleGenerateWrite(
				true,
				inputOptions,

@@ -129,6 +129,7 @@

					if (event.result && event.result.getTimings) {
						printTimings(event.result.getTimings());
					}
					event.result.close().catch(error => handleError(error, true));
					break;

				case 'END':

@@ -47,6 +47,7 @@

} = {
	buildEnd: 1,
	buildStart: 1,
	closeBundle: 1,
	closeWatcher: 1,
	load: 1,
	moduleParsed: 1,

@@ -37,6 +37,7 @@

}

export enum Errors {
	ALREADY_CLOSED = 'ALREADY_CLOSED',
	ASSET_NOT_FINALISED = 'ASSET_NOT_FINALISED',
	ASSET_NOT_FOUND = 'ASSET_NOT_FOUND',
	ASSET_SOURCE_ALREADY_SET = 'ASSET_SOURCE_ALREADY_SET',

@@ -45,8 +46,9 @@

	CANNOT_EMIT_FROM_OPTIONS_HOOK = 'CANNOT_EMIT_FROM_OPTIONS_HOOK',
	CHUNK_NOT_GENERATED = 'CHUNK_NOT_GENERATED',
	DEPRECATED_FEATURE = 'DEPRECATED_FEATURE',
	FILE_NOT_FOUND = 'FILE_NOT_FOUND',
	EXTERNAL_SYNTHETIC_EXPORTS = 'EXTERNAL_SYNTHETIC_EXPORTS',
	FILE_NAME_CONFLICT = 'FILE_NAME_CONFLICT',
	FILE_NOT_FOUND = 'FILE_NOT_FOUND',
	INPUT_HOOK_IN_OUTPUT_PLUGIN = 'INPUT_HOOK_IN_OUTPUT_PLUGIN',
	INVALID_CHUNK = 'INVALID_CHUNK',
	INVALID_EXPORT_OPTION = 'INVALID_EXPORT_OPTION',

@@ -60,12 +62,11 @@

	NO_TRANSFORM_MAP_OR_AST_WITHOUT_CODE = 'NO_TRANSFORM_MAP_OR_AST_WITHOUT_CODE',
	PLUGIN_ERROR = 'PLUGIN_ERROR',
	PREFER_NAMED_EXPORTS = 'PREFER_NAMED_EXPORTS',
	SYNTHETIC_NAMED_EXPORTS_NEED_NAMESPACE_EXPORT = 'SYNTHETIC_NAMED_EXPORTS_NEED_NAMESPACE_EXPORT',
	UNEXPECTED_NAMED_IMPORT = 'UNEXPECTED_NAMED_IMPORT',
	UNRESOLVED_ENTRY = 'UNRESOLVED_ENTRY',
	UNRESOLVED_IMPORT = 'UNRESOLVED_IMPORT',
	VALIDATION_ERROR = 'VALIDATION_ERROR',
	EXTERNAL_SYNTHETIC_EXPORTS = 'EXTERNAL_SYNTHETIC_EXPORTS',
	SYNTHETIC_NAMED_EXPORTS_NEED_NAMESPACE_EXPORT = 'SYNTHETIC_NAMED_EXPORTS_NEED_NAMESPACE_EXPORT'
	VALIDATION_ERROR = 'VALIDATION_ERROR'
}

export function errAssetNotFinalisedForFileName(name: string) {

@@ -377,6 +378,13 @@

	};
}

export function errAlreadyClosed() {
	return {
		code: Errors.ALREADY_CLOSED,
		message: 'Bundle is already closed, no more calls to "generate" or "write" are allowed.'
	};
}

export function warnDeprecation(
	deprecation: string | RollupWarning,
	activeDeprecation: boolean,

Everything is accounted for!

No changes detected that need to be reviewed.

What changes does Codecov check for?

Lines, not adjusted in diff, that have changed coverage data.

Files that introduced coverage data that had none before.

Files that have missing coverage data that once were tracked.

97.08% ø ø

#3883 0805d3b

Update and extend documentation.

lukastaegert

#3883 4ccb224

CI Passed

+4595

-360

-4235

26.91% 100.00% -70.16%

Test closeBundle errors are displayed on the CLI

lukastaegert

#3883 83e205c

CI Passed

-1

-4595

+360

+4234

97.07% ø ø

Merge branch 'master' into feat-bundle-close

lukastaegert

#3883 a6050fc

CI Passed

97.07% 0.00% -0.01%

bundle close errors are recoverable

intrnl

#3883 7d82b73

CI Passed

Hiding 2 contexual commits

97.08% 100.00% +<.01%

Merge branch 'master' into feat-bundle-close

intrnl

#3883 df170e7

CI Passed

-1

97.08% 100.00% +0.01%

Merge branch 'master' into feat-bundle-close

lukastaegert

#3883 4453172

CI Passed

+2 Files

+16

97.08% ø +0.06%

Add test for generating/writing closed bundles

lukastaegert

#3883 0d25a8c

CI Passed

-3

-1

97.01% 100.00% ø

always run closeBundle even on watch mode

intrnl

#3883 6e7116f

CI Passed

Hiding 1 contexual commits

97.01% ø ø

Update docs/02-javascript-api.md

#3883 841fa29

97.01% ø ø

#3883 6525b18

97.01% ø ø

#3883 c142536

Hiding 1 contexual commits

97.01% 100.00% +0.03%

close bundle on cli build completion

intrnl

#3883 b2b6156

CI Passed

Hiding 2 contexual commits

-3

96.98% ø -0.09%

add closeBundle hook to PluginDriver

intrnl

#3883 bc350f2

CI Passed

Hiding 1 contexual commits

-2 Files

-8

-14

Pull Request Base Commit

97.08% ø ø

2.34.2

lukastaegert

92a2dfa

CI Passed

Files		•	•	•	Coverage
cli	+2	+2	ø	ø	^0.02% 94.29%
src	+8	+8	ø	ø	^+<.01% 97.34%
browser/path.ts	ø	ø	ø	ø	76.92%
Project Totals (187 files)	6,548	6,357	90	101	97.08%

129	129		if (event.result && event.result.getTimings) {
130	130		printTimings(event.result.getTimings());
131	131		}
	132	+	event.result.close().catch(error => handleError(error, true));
132	133		break;
133	134
134	135		case 'END':

377	378		};
378	379		}
379	380
	381	+	export function errAlreadyClosed() {
	382	+	return {
	383	+	code: Errors.ALREADY_CLOSED,
	384	+	message: 'Bundle is already closed, no more calls to "generate" or "write" are allowed.'
	385	+	};
	386	+	}
	387	+
380	388		export function warnDeprecation(
381	389		deprecation: string \| RollupWarning,
382	390		activeDeprecation: boolean,

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

#3883 feat: bundle closing

No flags found

Everything is accounted for!

What changes does Codecov check for?

Show failed CI and contexual commits `c`

21 Commits

62	62		}
63	63
64	64		await Promise.all(outputOptions.map(bundle.write));
	65	+	await bundle.close();
65	66		if (!silent) {
66	67		warnings.flush();
67	68		stderr(green(`created ${bold(files.join(', '))} in ${bold(ms(Date.now() - start))}`));

2	2		import Bundle from '../Bundle';
3	3		import Graph from '../Graph';
4	4		import { ensureArray } from '../utils/ensureArray';
5		-	import { errCannotEmitFromOptionsHook, error } from '../utils/error';
	5	+	import { errAlreadyClosed, errCannotEmitFromOptionsHook, error } from '../utils/error';
6	6		import { writeFile } from '../utils/fs';
7	7		import { normalizeInputOptions } from '../utils/options/normalizeInputOptions';
8	8		import { normalizeOutputOptions } from '../utils/options/normalizeOutputOptions';

56	56		err.watchFiles = watchFiles;
57	57		}
58	58		await graph.pluginDriver.hookParallel('buildEnd', [err]);
	59	+	await graph.pluginDriver.hookParallel('closeBundle', []);
59	60		throw err;
60	61		}
61	62

65	66
66	67		const result: RollupBuild = {
67	68		cache: useCache ? graph.getCache() : undefined,
	69	+	closed: false,
	70	+	async close() {
	71	+	if (result.closed) return;
	72	+
	73	+	result.closed = true;
	74	+
	75	+	await graph.pluginDriver.hookParallel('closeBundle', []);
	76	+	},
68	77		async generate(rawOutputOptions: OutputOptions) {
	78	+	if (result.closed) return error(errAlreadyClosed());
	79	+
69	80		return handleGenerateWrite(
70	81		false,
71	82		inputOptions,

76	87		},
77	88		watchFiles: Object.keys(graph.watchFiles),
78	89		async write(rawOutputOptions: OutputOptions) {
	90	+	if (result.closed) return error(errAlreadyClosed());
	91	+
79	92		return handleGenerateWrite(
80	93		true,
81	94		inputOptions,

47	47		} = {
48	48		buildEnd: 1,
49	49		buildStart: 1,
	50	+	closeBundle: 1,
50	51		closeWatcher: 1,
51	52		load: 1,
52	53		moduleParsed: 1,

37	37		}
38	38
39	39		export enum Errors {
	40	+	ALREADY_CLOSED = 'ALREADY_CLOSED',
40	41		ASSET_NOT_FINALISED = 'ASSET_NOT_FINALISED',
41	42		ASSET_NOT_FOUND = 'ASSET_NOT_FOUND',
42	43		ASSET_SOURCE_ALREADY_SET = 'ASSET_SOURCE_ALREADY_SET',

45	46		CANNOT_EMIT_FROM_OPTIONS_HOOK = 'CANNOT_EMIT_FROM_OPTIONS_HOOK',
46	47		CHUNK_NOT_GENERATED = 'CHUNK_NOT_GENERATED',
47	48		DEPRECATED_FEATURE = 'DEPRECATED_FEATURE',
48		-	FILE_NOT_FOUND = 'FILE_NOT_FOUND',
	49	+	EXTERNAL_SYNTHETIC_EXPORTS = 'EXTERNAL_SYNTHETIC_EXPORTS',
49	50		FILE_NAME_CONFLICT = 'FILE_NAME_CONFLICT',
	51	+	FILE_NOT_FOUND = 'FILE_NOT_FOUND',
50	52		INPUT_HOOK_IN_OUTPUT_PLUGIN = 'INPUT_HOOK_IN_OUTPUT_PLUGIN',
51	53		INVALID_CHUNK = 'INVALID_CHUNK',
52	54		INVALID_EXPORT_OPTION = 'INVALID_EXPORT_OPTION',

60	62		NO_TRANSFORM_MAP_OR_AST_WITHOUT_CODE = 'NO_TRANSFORM_MAP_OR_AST_WITHOUT_CODE',
61	63		PLUGIN_ERROR = 'PLUGIN_ERROR',
62	64		PREFER_NAMED_EXPORTS = 'PREFER_NAMED_EXPORTS',
	65	+	SYNTHETIC_NAMED_EXPORTS_NEED_NAMESPACE_EXPORT = 'SYNTHETIC_NAMED_EXPORTS_NEED_NAMESPACE_EXPORT',
63	66		UNEXPECTED_NAMED_IMPORT = 'UNEXPECTED_NAMED_IMPORT',
64	67		UNRESOLVED_ENTRY = 'UNRESOLVED_ENTRY',
65	68		UNRESOLVED_IMPORT = 'UNRESOLVED_IMPORT',
66		-	VALIDATION_ERROR = 'VALIDATION_ERROR',
67		-	EXTERNAL_SYNTHETIC_EXPORTS = 'EXTERNAL_SYNTHETIC_EXPORTS',
68		-	SYNTHETIC_NAMED_EXPORTS_NEED_NAMESPACE_EXPORT = 'SYNTHETIC_NAMED_EXPORTS_NEED_NAMESPACE_EXPORT'
	69	+	VALIDATION_ERROR = 'VALIDATION_ERROR'
69	70		}
70	71
71	72		export function errAssetNotFinalisedForFileName(name: string) {

#3883 feat: bundle closing

No flags found

Everything is accounted for!

What changes does Codecov check for?

Show failed CI and contexual commits c 21 Commits

Show failed CI and contexual commits `c`

21 Commits