Compare `afeb08f ... +40 ... 30eb4d6`


  old <- setwd(dir)
  on.exit(setwd(old))
  files <- dir(dir, ..., recursive = recursive, full.names = full.names)
  files <- dir(".", ..., recursive = recursive, full.names = full.names)

  archive_write_files(archive, files, format = format, filter = filter, options = options)


@@ -1,5 +1,4 @@

.onLoad <- function(libname, pkgname) {
  loadNamespace("cli")
  lib_path <- system.file("lib", .Platform$r_arch, paste0("libconnection", .Platform$dynlib.ext), package = "archive")
  res <- dyn.load(lib_path)


@@ -48,7 +48,16 @@

  for (std::string file : files) {
    stat(file.c_str(), &st);
    entry = archive_entry_new();
#if defined(_WIN32) || (!defined(__GNUC__) && !defined(__clang__))
    // there are quite many CRT dialects and passing struct stat to 3rdparty library could be unstable.
    archive_entry_set_size(entry, st.st_size);
    archive_entry_set_mtime(entry, st.st_mtime, 0);
    archive_entry_set_ctime(entry, st.st_ctime, 0);
    archive_entry_set_atime(entry, st.st_atime, 0);
    archive_entry_set_mode(entry, st.st_mode); // seems required as not defaulting to S_IFREG.
#else
    archive_entry_copy_stat(entry, &st);
#endif
    archive_entry_set_pathname(entry, file.c_str());
    call(archive_write_header, a, entry);
    if ((fd = open(file.c_str(), O_RDONLY)) != -1) {

@@ -70,5 +79,7 @@

  }
  call(archive_write_free, a);

  cli_progress_done(progress_bar);

  return R_NilValue;
}

@@ -1,6 +1,7 @@

## usethis namespace: start
#' @useDynLib archive, .registration = TRUE
#' @importFrom tibble as_tibble
#' @importFrom cli cli_progress_bar
## usethis namespace: end
NULL


@@ -15,7 +16,7 @@

#' @seealso [archive_read()], [archive_write()] to read and write archive files
#' using R connections, [archive_extract()], [archive_write_files()],
#' [archive_write_dir()] to add or extract files from an archive.
#' @returns @return A [tibble][tibble::tibble-package] with details about files in the archive.
#' @return A [tibble][tibble::tibble-package] with details about files in the archive.
#' @examples
#' a <- archive(system.file(package = "archive", "extdata", "data.zip"))
#' a

@@ -156,3 +157,12 @@

156	157		}
157	158		package_version("0.0.0")
158	159		}
	160	+
	161	+	print_versions <- function(){
	162	+	cat("Linked to:\n")
	163	+	cat("libarchive", as.character(libarchive_version()), '\n')
	164	+	cat("zlib", as.character(libarchive_zlib_version()), '\n')
	165	+	cat("lzma", as.character(libarchive_liblzma_version()), '\n')
	166	+	cat("bzlib", as.character(libarchive_bzlib_version()), '\n')
	167	+	cat("zsstd", as.character(libarchive_libzstd_version()), '\n')
	168	+	}

Learn more Showing 7 files with coverage changes found.

Changes in src/r_archive.h

-2

→

Loading file...

Changes in src/r_archive.cpp

-1

→

Loading file...

Changes in src/archive_extract.cpp

-1

→

Loading file...

Changes in src/archive_read.cpp

-1

→

Loading file...

Changes in R/zzz.R

→

Loading file...

Changes in src/archive.cpp

-8

→

Loading file...

Changes in R/archive.R

-8

→

Loading file...

89.47% ø ø

Fix typo in GHA workflow

gaborcsardi

30eb4d6

CI Passed

89.47% ø ø

GHA: fix rtools version

gaborcsardi

4d65d2c

CI Passed

89.47% ø ø

Merge remote-tracking branch 'origin/main'

gaborcsardi

962363c

CI Passed

89.47% ø ø

Rethink CI runs on Windows

gaborcsardi

f638b5b

CI Passed

Hiding 2 contexual commits

89.47% ø ø

Merge pull request #74 from r-lib/rwinlib2

gaborcsardi

48129b7

CI Passed

89.47% ø ø

Windows: update to libarchive 3.6.1

jeroen

cbc0db3

CI Passed

89.47% ø ø

Merge pull request #72 from cielavenir/fixLibArchive352

gaborcsardi

7803644

CI Passed

89.47% ø ø

Revert "Downgrade to 3.3.3 due to performance bug"

cielavenir

6282215

CI Passed

Hiding 1 contexual commits

89.47% ø ø

Increment version number to 1.1.4.9000

gaborcsardi

4f65a2e

CI Passed

89.47% ø ø

Increment version number to 1.1.4

gaborcsardi

85d6dd7

CI Passed

Hiding 1 contexual commits

89.47% ø ø

Test for archive_write_dir w/ absolute paths

gaborcsardi

4b87059

CI Passed

89.47% 100.00% ø

`archive_write_dir()` fix for relative paths

gaborcsardi

bb14f0c

CI Passed

Hiding 1 contexual commits

89.47% ø ø

R and git ignore /dev-lib

gaborcsardi

62597ff

CI Passed

89.47% ø ø

Unable to find commit in GitHub

Unknown

c570c9f

CI Passed

89.47% ø ø

Do not use ucrt patch

gaborcsardi

1f9387e

CI Passed

89.47% ø ø

Merge pull request #65 from r-lib/rwinlib

gaborcsardi

e6b5ce0

CI Passed

89.47% ø ø

Unable to find commit in GitHub

Unknown

bad2e52

CI Passed

89.47% 100.00% +2.30%

Merge pull request #66 from r-lib/showversion2

gaborcsardi

d4e1c3f

CI Passed

89.47% 100.00% +2.30%

Show libarchive versions in CMD-check output

jeroen

957d6ce

CI Passed

+19

-16

87.17% ø ø

Unable to find commit in GitHub

Unknown

1791f69

87.17% ø ø

Merge pull request #64 from arisp99/docs-typo

gaborcsardi

52b2f1e

CI Passed

Hiding 1 contexual commits

87.17% ø ø

Test ucrt w/o extra env var setup

2c764be

87.17% ø ø

1473ef4

87.17% ø ø

Merge pull request #63 from r-lib/fix/gha-v2

7b60d65

87.17% ø ø

#63 d983154

-4

87.24% ø +0.12%

Increment version number to 1.1.3.9000

jimhester

dfbd4ea

CI Passed

87.24% ø ø

Increment version number to 1.1.3

jimhester

c35c8f4

Hiding 1 contexual commits

87.24% ø ø

Make gabor the maintainer

jimhester

c6f771c

CI Passed

87.24% ø +0.12%

Remove instances of master

jimhester

c290517

CI Passed

Hiding 4 contexual commits

-1

87.11% 100.00% +0.02%

Fix unterminated progress bars (#60)

Unknown

0ad142f

CI Passed

87.22% ø +0.12%

Explicitly import from CLI to avoid a note from R CMD check

jimhester

afeb08f

CI Passed

Files		•	•	•	Coverage
R	+6	+14	ø	-8	^+5.34% 80.34%
src	-6	+2	ø	-8	^+1.40% 92.51%
Project Totals (19 files)	712	637	0	75	89.47%

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Compare `afeb08f ... +40 ... 30eb4d6`

No flags found

Show failed CI and contexual commits `c`

42 Commits

14	14
15	15		old <- setwd(dir)
16	16		on.exit(setwd(old))
17		-	files <- dir(dir, ..., recursive = recursive, full.names = full.names)
	17	+	files <- dir(".", ..., recursive = recursive, full.names = full.names)
18	18
19	19		archive_write_files(archive, files, format = format, filter = filter, options = options)
20	20

1	1		.onLoad <- function(libname, pkgname) {
2		-	loadNamespace("cli")
3	2		lib_path <- system.file("lib", .Platform$r_arch, paste0("libconnection", .Platform$dynlib.ext), package = "archive")
4	3		res <- dyn.load(lib_path)
5	4

48	48		for (std::string file : files) {
49	49		stat(file.c_str(), &st);
50	50		entry = archive_entry_new();
	51	+	#if defined(_WIN32) \|\| (!defined(__GNUC__) && !defined(__clang__))
	52	+	// there are quite many CRT dialects and passing struct stat to 3rdparty library could be unstable.
	53	+	archive_entry_set_size(entry, st.st_size);
	54	+	archive_entry_set_mtime(entry, st.st_mtime, 0);
	55	+	archive_entry_set_ctime(entry, st.st_ctime, 0);
	56	+	archive_entry_set_atime(entry, st.st_atime, 0);
	57	+	archive_entry_set_mode(entry, st.st_mode); // seems required as not defaulting to S_IFREG.
	58	+	#else
51	59		archive_entry_copy_stat(entry, &st);
	60	+	#endif
52	61		archive_entry_set_pathname(entry, file.c_str());
53	62		call(archive_write_header, a, entry);
54	63		if ((fd = open(file.c_str(), O_RDONLY)) != -1) {

70	79		}
71	80		call(archive_write_free, a);
72	81
	82	+	cli_progress_done(progress_bar);
	83	+
73	84		return R_NilValue;
74	85		}

1	1		## usethis namespace: start
2	2		#' @useDynLib archive, .registration = TRUE
3	3		#' @importFrom tibble as_tibble
	4	+	#' @importFrom cli cli_progress_bar
4	5		## usethis namespace: end
5	6		NULL
6	7

15	16		#' @seealso [archive_read()], [archive_write()] to read and write archive files
16	17		#' using R connections, [archive_extract()], [archive_write_files()],
17	18		#' [archive_write_dir()] to add or extract files from an archive.
18		-	#' @returns @return A [tibble][tibble::tibble-package] with details about files in the archive.
	19	+	#' @return A [tibble][tibble::tibble-package] with details about files in the archive.
19	20		#' @examples
20	21		#' a <- archive(system.file(package = "archive", "extdata", "data.zip"))
21	22		#' a

Compare afeb08f ... +40 ... 30eb4d6

No flags found

Show failed CI and contexual commits c 42 Commits

Compare `afeb08f ... +40 ... 30eb4d6`

Show failed CI and contexual commits `c`

42 Commits