paritytech / ink
78.83% 52.94% -0.17%

Allow specifying payable constructors (#1065)

  • Add payable constructor support to IR

  • Add payable associated type to DispatchableConstructorInfo

  • Allow constructors to be payable in dispatcher codegen

  • Add UI tests

  • Remove test related to constructors being implicitly payable

  • Add some failing UI tests

  • Deny payments on deploy if there are no payable constructors

  • Appease Clippy

  • Deny payments when executing constructors

  • s/message/constructor/g

  • RustFmt

  • Address unnecessary_to_owned lint

Reference: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessarytoowned

  • Address needless_borrow lint

Reference: https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

  • Make a note about this PR in the RELEASES doc

  • Allow clippy::nonminimal_bool for deploy()

  • Remove any_payable_* checks from individual Config creation

It looks like this was meant to be part of an optimization, however it doesn't look like this is necessary anymore. If no constructor or message is payable we already do early deny payment checks in deploy() and call() respectively.

  • Add UI test for multiple non-payable constructors
HCastano CI Failed

e646ddd master d9c17b6

Files Coverage
crates/allocator/src/bump.rs 62.50%
crates/engine/src/database.rs 100.00%
crates/engine/src/exec_context.rs 100.00%
crates/engine/src/ext.rs 72.41%
crates/engine/src/hashing.rs 100.00%
crates/engine/src/test_api.rs 94.05%
crates/engine/src/tests.rs 100.00%
crates/engine/src/types.rs 66.67%
crates/env/src/api.rs 36.36%
crates/env/src/arithmetic.rs 100.00%
crates/env/src/backend.rs 80.65%
crates/env/src/call/call_builder.rs 0.00%
crates/env/src/call/common.rs 0.00%
crates/env/src/call/create_builder.rs 0.00%
crates/env/src/call/execution_input.rs 76.92%
crates/env/src/call/selector.rs 100.00%
crates/env/src/chain_extension.rs 0.00%
crates/env/src/engine/experimental_off_chain/impls.rs 54.13%
crates/env/src/engine/experimental_off_chain/mod.rs 100.00%
crates/env/src/engine/experimental_off_chain/test_api.rs 83.67%
crates/env/src/engine/experimental_off_chain/types.rs 0.00%
crates/env/src/engine/off_chain/call_data.rs 23.53%
crates/env/src/engine/off_chain/chain_extension.rs 65.00%
crates/env/src/engine/off_chain/db/accounts.rs 86.42%
crates/env/src/engine/off_chain/db/block.rs 36.84%
crates/env/src/engine/off_chain/db/chain_spec.rs 94.59%
crates/env/src/engine/off_chain/db/debug_buf.rs 26.32%
crates/env/src/engine/off_chain/db/events.rs 100.00%
crates/env/src/engine/off_chain/db/exec_context.rs 77.36%
crates/env/src/engine/off_chain/hashing.rs 100.00%
crates/env/src/engine/off_chain/impls.rs 42.37%
crates/env/src/engine/off_chain/mod.rs 89.47%
crates/env/src/engine/off_chain/test_api.rs 80.85%
crates/env/src/engine/off_chain/tests.rs 100.00%
crates/env/src/engine/off_chain/typed_encoded.rs 73.33%
crates/env/src/topics.rs 100.00%
crates/env/src/types.rs 22.22%
crates/eth_compatibility/src/lib.rs 74.07%
crates/lang/codegen/src/enforced_error.rs 100.00%
crates/lang/codegen/src/generator/arg_list.rs 100.00%
crates/lang/codegen/src/generator/as_dependency/call_builder.rs 100.00%
crates/lang/codegen/src/generator/as_dependency/contract_ref.rs 100.00%
crates/lang/codegen/src/generator/as_dependency/mod.rs 66.67%
crates/lang/codegen/src/generator/blake2b.rs 100.00%
crates/lang/codegen/src/generator/chain_extension.rs 95.74%
crates/lang/codegen/src/generator/contract.rs 100.00%
crates/lang/codegen/src/generator/dispatch.rs 94.57%
crates/lang/codegen/src/generator/env.rs 100.00%
crates/lang/codegen/src/generator/events.rs 97.26%
crates/lang/codegen/src/generator/ink_test.rs 75.00%
crates/lang/codegen/src/generator/item_impls.rs 97.27%
crates/lang/codegen/src/generator/metadata.rs 97.37%
crates/lang/codegen/src/generator/mod.rs 100.00%
crates/lang/codegen/src/generator/selector.rs 100.00%
crates/lang/codegen/src/generator/storage.rs 100.00%
crates/lang/codegen/src/generator/trait_def/call_builder.rs 100.00%
crates/lang/codegen/src/generator/trait_def/call_forwarder.rs 100.00%
crates/lang/codegen/src/generator/trait_def/definition.rs 100.00%
crates/lang/codegen/src/generator/trait_def/mod.rs 100.00%
crates/lang/codegen/src/generator/trait_def/trait_registry.rs 98.81%
crates/lang/codegen/src/lib.rs 100.00%
crates/lang/codegen/src/traits.rs 100.00%
crates/lang/ir/src/ast/attr_args.rs 82.61%
crates/lang/ir/src/error.rs 100.00%
crates/lang/ir/src/ir/attrs.rs 82.27%
crates/lang/ir/src/ir/blake2.rs 80.00%
crates/lang/ir/src/ir/chain_extension.rs 93.46%
crates/lang/ir/src/ir/config.rs 91.49%
crates/lang/ir/src/ir/contract.rs 100.00%
crates/lang/ir/src/ir/idents_lint.rs 71.43%
crates/lang/ir/src/ir/ink_test.rs 87.50%
crates/lang/ir/src/ir/item/event.rs 89.55%
crates/lang/ir/src/ir/item/mod.rs 60.71%
crates/lang/ir/src/ir/item/storage.rs 80.65%
crates/lang/ir/src/ir/item_impl/callable.rs 91.92%
crates/lang/ir/src/ir/item_impl/constructor.rs 93.85%
crates/lang/ir/src/ir/item_impl/impl_item.rs 57.45%
crates/lang/ir/src/ir/item_impl/iter.rs 100.00%
crates/lang/ir/src/ir/item_impl/message.rs 92.13%
crates/lang/ir/src/ir/item_impl/mod.rs 90.68%
crates/lang/ir/src/ir/item_impl/tests.rs 100.00%
crates/lang/ir/src/ir/item_mod.rs 89.71%
crates/lang/ir/src/ir/selector.rs 88.00%
crates/lang/ir/src/ir/trait_def/config.rs 46.15%
crates/lang/ir/src/ir/trait_def/item/iter.rs 100.00%
crates/lang/ir/src/ir/trait_def/item/mod.rs 90.16%
crates/lang/ir/src/ir/trait_def/item/trait_item.rs 89.06%
crates/lang/ir/src/ir/trait_def/mod.rs 66.67%
crates/lang/ir/src/ir/trait_def/tests.rs 100.00%
crates/lang/ir/src/ir/utils.rs 84.62%
crates/lang/ir/src/literal.rs 100.00%
crates/lang/macro/src/blake2b.rs 85.71%
crates/lang/macro/src/chain_extension.rs 85.71%
crates/lang/macro/src/contract.rs 85.71%
crates/lang/macro/src/ink_test.rs 85.71%
crates/lang/macro/src/lib.rs 100.00%
crates/lang/macro/src/selector.rs 85.71%
crates/lang/macro/src/trait_def.rs 85.71%
crates/lang/src/codegen/dispatch/execution.rs 0.00%
crates/lang/src/env_access.rs 12.00%
crates/lang/src/reflect/dispatch.rs 0.00%
crates/lang/src/result_info.rs 100.00%
crates/lang/tests/ui/blake2b/pass/bytestring_input.rs 100.00%
crates/lang/tests/ui/blake2b/pass/no_implicit_prelude.rs 100.00%
crates/lang/tests/ui/blake2b/pass/string_input.rs 100.00%
crates/lang/tests/ui/chain_extension/E-01-simple.rs 2.50%
crates/lang/tests/ui/contract/pass/config-compile-as-dependency-false.rs 16.67%
crates/lang/tests/ui/contract/pass/config-compile-as-dependency-true.rs 16.67%
crates/lang/tests/ui/contract/pass/config-custom-env.rs 16.67%
...rates/lang/tests/ui/contract/pass/config-dynamic-storage-allocator-false.rs 16.67%
crates/lang/tests/ui/contract/pass/config-dynamic-storage-allocator-true.rs 16.67%
crates/lang/tests/ui/contract/pass/constructor-many-inputs.rs 6.25%
crates/lang/tests/ui/contract/pass/constructor-non-payable-multiple.rs 33.33%
crates/lang/tests/ui/contract/pass/constructor-non-payable.rs 28.57%
crates/lang/tests/ui/contract/pass/constructor-payable-multiple.rs 33.33%
crates/lang/tests/ui/contract/pass/constructor-payable.rs 28.57%
crates/lang/tests/ui/contract/pass/constructor-selector.rs 46.15%
crates/lang/tests/ui/contract/pass/constructor-wildcard-selector.rs 16.67%
crates/lang/tests/ui/contract/pass/dispatch-decoder-works.rs 89.66%
crates/lang/tests/ui/contract/pass/env-access.rs 3.85%
crates/lang/tests/ui/contract/pass/event-anonymous.rs 1.89%
crates/lang/tests/ui/contract/pass/event-config-more-topics.rs 3.45%
crates/lang/tests/ui/contract/pass/event-many-definitions.rs 2.56%
crates/lang/tests/ui/contract/pass/event-single-definition.rs 14.29%
crates/lang/tests/ui/contract/pass/event-topics.rs 1.89%
crates/lang/tests/ui/contract/pass/example-erc20-works.rs 1.52%
crates/lang/tests/ui/contract/pass/example-erc721-works.rs 0.68%
crates/lang/tests/ui/contract/pass/example-flipper-works.rs 78.57%
crates/lang/tests/ui/contract/pass/example-incrementer-works.rs 81.25%
crates/lang/tests/ui/contract/pass/example-trait-flipper-works.rs 47.62%
crates/lang/tests/ui/contract/pass/example-trait-incrementer-works.rs 50.00%
crates/lang/tests/ui/contract/pass/impl-alias-storage.rs 16.67%
crates/lang/tests/ui/contract/pass/impl-block-namespace.rs 16.67%
crates/lang/tests/ui/contract/pass/impl-block-using-env.rs 8.33%
crates/lang/tests/ui/contract/pass/impl-with-property.rs 16.67%
crates/lang/tests/ui/contract/pass/message-many-inputs.rs 3.70%
crates/lang/tests/ui/contract/pass/message-many-outputs.rs 3.70%
crates/lang/tests/ui/contract/pass/message-payable.rs 33.33%
crates/lang/tests/ui/contract/pass/message-selector.rs 46.15%
crates/lang/tests/ui/contract/pass/message-wildcard-selector.rs 12.50%
crates/lang/tests/ui/contract/pass/minimal-contract.rs 16.67%
crates/lang/tests/ui/contract/pass/module-env-types.rs 14.29%
crates/lang/tests/ui/contract/pass/module-non-ink-items.rs 58.33%
crates/lang/tests/ui/contract/pass/no-implicit-prelude.rs 16.67%
crates/lang/tests/ui/contract/pass/storage-many-fields.rs 14.29%
crates/lang/tests/ui/contract/pass/storage-packed-fields.rs 12.50%
crates/lang/tests/ui/contract/pass/storage-single-field.rs 14.29%
crates/lang/tests/ui/contract/pass/storage-with-derives.rs 57.14%
crates/lang/tests/ui/contract/pass/trait-message-payable-guard.rs 9.09%
crates/lang/tests/ui/contract/pass/trait-message-selector-guard.rs 9.09%
crates/lang/tests/ui/selector_bytes/pass/bytestring_input.rs 100.00%
crates/lang/tests/ui/selector_bytes/pass/no_implicit_prelude.rs 100.00%
crates/lang/tests/ui/selector_bytes/pass/string_input.rs 100.00%
crates/lang/tests/ui/selector_id/pass/bytestring_input.rs 100.00%
crates/lang/tests/ui/selector_id/pass/no_implicit_prelude.rs 100.00%
crates/lang/tests/ui/selector_id/pass/string_input.rs 100.00%
crates/lang/tests/ui/trait_def/pass/avoid_overlap_with_namespace.rs 100.00%
crates/lang/tests/ui/trait_def/pass/many_inputs.rs 100.00%
crates/lang/tests/ui/trait_def/pass/many_outputs.rs 100.00%
crates/lang/tests/ui/trait_def/pass/no-implicit-prelude.rs 100.00%
crates/lang/tests/ui/trait_def/pass/payable_message.rs 100.00%
crates/lang/tests/ui/trait_def/pass/simple_definition.rs 100.00%
crates/lang/tests/ui/trait_def/pass/using-env-types.rs 100.00%
crates/lang/tests/ui/trait_def/pass/valid_selectors.rs 100.00%
crates/lang/tests/ui/trait_def/pass/valid_selectors_namespace.rs 100.00%
crates/lang/tests/ui/trait_def/pass/with_namespace.rs 100.00%
crates/lang/tests/unique_topics.rs 50.00%
crates/metadata/src/layout/mod.rs 77.01%
crates/metadata/src/layout/tests.rs 100.00%
crates/metadata/src/lib.rs 0.00%
crates/metadata/src/specs.rs 73.33%
crates/metadata/src/utils.rs 66.67%
crates/primitives/src/key.rs 93.42%
crates/primitives/src/key_ptr.rs 100.00%
crates/storage/derive/src/packed_layout.rs 100.00%
crates/storage/derive/src/spread_allocate.rs 92.86%
crates/storage/derive/src/spread_layout.rs 98.51%
crates/storage/derive/src/storage_layout.rs 94.12%
crates/storage/src/alloc/allocation.rs 82.14%
crates/storage/src/alloc/allocator.rs 82.35%
crates/storage/src/alloc/boxed/impls.rs 100.00%
crates/storage/src/alloc/boxed/mod.rs 100.00%
crates/storage/src/alloc/boxed/storage.rs 100.00%
crates/storage/src/alloc/boxed/tests.rs 100.00%
crates/storage/src/alloc/init.rs 61.90%
crates/storage/src/alloc/mod.rs 75.00%
crates/storage/src/alloc/tests.rs 100.00%
crates/storage/src/collections/binary_heap/children.rs 88.57%
crates/storage/src/collections/binary_heap/children_vec.rs 95.37%
crates/storage/src/collections/binary_heap/impls.rs 100.00%
crates/storage/src/collections/binary_heap/mod.rs 100.00%
crates/storage/src/collections/binary_heap/reverse.rs 22.22%
crates/storage/src/collections/binary_heap/storage.rs 100.00%
crates/storage/src/collections/binary_heap/tests.rs 96.97%
crates/storage/src/collections/bitstash/counts.rs 92.86%
crates/storage/src/collections/bitstash/fuzz_tests.rs 100.00%
crates/storage/src/collections/bitstash/mod.rs 97.92%
crates/storage/src/collections/bitstash/storage.rs 40.00%
crates/storage/src/collections/bitstash/tests.rs 100.00%
crates/storage/src/collections/bitvec/bitref.rs 90.00%
crates/storage/src/collections/bitvec/bits256.rs 85.42%
crates/storage/src/collections/bitvec/bitsref.rs 100.00%
crates/storage/src/collections/bitvec/impls.rs 70.00%
crates/storage/src/collections/bitvec/iter.rs 82.20%
crates/storage/src/collections/bitvec/mod.rs 90.00%
crates/storage/src/collections/bitvec/storage.rs 41.38%
crates/storage/src/collections/bitvec/tests.rs 100.00%
crates/storage/src/collections/hashmap/fuzz_tests.rs 100.00%
crates/storage/src/collections/hashmap/impls.rs 94.12%
crates/storage/src/collections/hashmap/iter.rs 100.00%
crates/storage/src/collections/hashmap/mod.rs 96.69%
crates/storage/src/collections/hashmap/storage.rs 100.00%
crates/storage/src/collections/hashmap/tests.rs 100.00%
crates/storage/src/collections/mod.rs 100.00%
crates/storage/src/collections/smallvec/impls.rs 95.65%
crates/storage/src/collections/smallvec/iter.rs 100.00%
crates/storage/src/collections/smallvec/mod.rs 96.47%
crates/storage/src/collections/smallvec/storage.rs 100.00%
crates/storage/src/collections/smallvec/tests.rs 100.00%
crates/storage/src/collections/stash/impls.rs 96.67%
crates/storage/src/collections/stash/iter.rs 100.00%
crates/storage/src/collections/stash/mod.rs 97.44%
crates/storage/src/collections/stash/storage.rs 71.43%
crates/storage/src/collections/stash/tests.rs 100.00%
crates/storage/src/collections/vec/fuzz_tests.rs 100.00%
crates/storage/src/collections/vec/impls.rs 96.00%
crates/storage/src/collections/vec/iter.rs 100.00%
crates/storage/src/collections/vec/mod.rs 97.30%
crates/storage/src/collections/vec/storage.rs 52.38%
crates/storage/src/collections/vec/tests.rs 100.00%
crates/storage/src/hashmap_entry_api_tests.rs 94.21%
crates/storage/src/lazy/cache_cell.rs 100.00%
crates/storage/src/lazy/entry.rs 94.74%
crates/storage/src/lazy/lazy_array.rs 96.23%
crates/storage/src/lazy/lazy_cell.rs 94.81%
crates/storage/src/lazy/lazy_hmap.rs 98.47%
crates/storage/src/lazy/lazy_imap.rs 90.80%
crates/storage/src/lazy/mapping.rs 54.29%
crates/storage/src/lazy/mod.rs 85.29%
crates/storage/src/memory.rs 100.00%
crates/storage/src/pack.rs 100.00%
crates/storage/src/test_utils.rs 98.91%
crates/storage/src/traits/impls/arrays.rs 100.00%
crates/storage/src/traits/impls/fuzz_tests.rs 100.00%
crates/storage/src/traits/impls/mod.rs 77.78%
crates/storage/src/traits/impls/prims.rs 96.92%
crates/storage/src/traits/impls/tuples.rs 94.74%
crates/storage/src/traits/keyptr.rs 100.00%
crates/storage/src/traits/layout/impls.rs 25.00%
crates/storage/src/traits/layout/mod.rs 0.00%
crates/storage/src/traits/mod.rs 100.00%
crates/storage/src/traits/optspec.rs 93.10%
Project Totals (252 files) 78.83%
Loading