#561 feat(dashboard): Add graphic obs drag parameters

Open Keiichiro Amemiya Hoishin
Coverage Reach
lib/replicant/shared.js lib/replicant/replicant.js lib/replicant/schema-hacks.js lib/replicant/index.js lib/bundle-parser/panels.js lib/bundle-parser/config.js lib/bundle-parser/index.js lib/bundle-parser/graphics.js lib/bundle-parser/manifest.js lib/bundle-parser/sounds.js lib/bundle-parser/mounts.js lib/bundle-parser/assets.js lib/bundle-parser/git.js lib/bundle-parser/extension.js lib/server/index.js lib/server/extensions.js lib/api.js lib/browser/replicant.js lib/browser/logger.js lib/browser/config.js lib/login/index.js lib/login/tokens.js lib/login/UnauthorizedError.js lib/graphics/registration.js lib/graphics/index.js lib/bundle-manager.js lib/assets/index.js lib/assets/AssetFile.js lib/util/injectscripts.js lib/util/authcheck.js lib/util/raven-config.js lib/util/debounce-name.js lib/util/index.js lib/logger/browser.js lib/logger/server.js lib/logger/index.js lib/replicator.js lib/dashboard.js lib/sounds.js lib/config/loader.js lib/config/index.js lib/shared-sources.js lib/mounts.js src/dashboard/elements/graphics/ncg-graphic-instance.js src/dashboard/elements/graphics/ncg-graphic.js src/dashboard/elements/graphics/ncg-graphic-instance-diff.js src/dashboard/elements/graphics/ncg-graphics.js src/dashboard/elements/graphics/ncg-graphics-bundle.js src/dashboard/elements/ncg-workspace.js src/dashboard/elements/mixer/ncg-sound-cue.js src/dashboard/elements/mixer/ncg-sounds.js src/dashboard/elements/mixer/ncg-mixer.js src/dashboard/elements/ncg-dashboard.js src/dashboard/elements/assets/ncg-asset-category.js src/dashboard/elements/assets/ncg-asset-file.js src/dashboard/elements/assets/ncg-assets.js src/dashboard/elements/ncg-dialog.js src/dashboard/elements/ncg-dashboard-panel.js src/dashboard/elements/ui/ui-select.js src/dashboard/elements/settings/ncg-settings.js src/dashboard/elements/util-scrollable.js src/dashboard/js/dialog_opener.js src/dashboard/css/nodecg-theme.js src/instance/client_registration.js

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.

Showing 1 of 3 files from the diff.

@@ -272,6 +272,7 @@
Loading
272 272
273 273
		const clipboard = new window.ClipboardJS(this.$.copyButton);
274 274
		this._initClipboard(clipboard);
275 +
		this.$.url.addEventListener('dragstart', this._onDrag.bind(this));
275 276
	}
276 277
277 278
	reloadAll() {
@@ -357,6 +358,14 @@
Loading
357 358
	_calcReloadAllDisabled(instances) {
358 359
		return !instances || instances.length <= 0;
359 360
	}
361 +
362 +
	_onDrag(event) {
363 +
		const dragged = event.target;
364 +
		const obsURL = `${dragged.href}?layer-name=${this.graphic.file.replace('.html', '')}&layer-height=${
365 +
			this.graphic.height
366 +
		}&layer-width=${this.graphic.width}`;
367 +
		event.dataTransfer.setData('text/uri-list', obsURL);
368 +
	}
360 369
}
361 370
362 371
customElements.define(NcgGraphic.is, NcgGraphic);

Everything is accounted for!

No changes detected that need to be reviewed.
What changes does Codecov check for?
Lines, not adjusted in diff, that have changed coverage data.
Files that introduced coverage data that had none before.
Files that have missing coverage data that once were tracked.
Files Coverage
lib 91.98%
src 0.09% 86.12%
Project Totals (64 files) 90.73%
Loading