nextcloud / deck

Compare 7ca5a95 ... +73 ... 124cc94

Coverage Reach
Service/BoardService.php Service/CardService.php Service/StackService.php Service/AttachmentService.php Service/PermissionService.php Service/CommentService.php Service/FileService.php Service/OverviewService.php Service/FullTextSearchService.php Service/ConfigService.php Service/LabelService.php Service/AssignmentService.php Service/DefaultBoardService.php Db/CardMapper.php Db/BoardMapper.php Db/AttachmentMapper.php Db/Card.php Db/LabelMapper.php Db/RelationalEntity.php Db/AssignedUsersMapper.php Db/ChangeHelper.php Db/Board.php Db/StackMapper.php Db/Stack.php Db/Acl.php Db/AclMapper.php Db/User.php Db/RelationalObject.php Db/Circle.php Db/Attachment.php Db/Group.php Db/Label.php Db/AssignedUsers.php Db/DeckMapper.php Activity/ActivityManager.php Activity/DeckProvider.php Activity/ChangeSet.php Activity/CommentEventHandler.php Activity/Filter.php Activity/Setting.php Activity/SettingComment.php Activity/DescriptionSetting.php Migration/Version1000Date20200306161713.php Migration/UnknownUsers.php Migration/Version1000Date20200308073933.php Controller/BoardApiController.php Controller/BoardController.php Controller/CardApiController.php Controller/CardController.php Controller/StackApiController.php Controller/PageController.php Controller/AttachmentApiController.php Controller/AttachmentController.php Controller/StackController.php Controller/LabelApiController.php Controller/ConfigController.php Controller/CommentsApiController.php Controller/LabelController.php Controller/OverviewApiController.php AppInfo/ApplicationLegacy.php AppInfo/Application20.php AppInfo/Application.php DAV/Calendar.php DAV/CalendarObject.php DAV/CalendarPlugin.php DAV/DeckCalendarBackend.php Notification/Notifier.php Notification/NotificationHelper.php Collaboration/Resources/ResourceProviderCard.php Collaboration/Resources/ResourceProvider.php Provider/DeckProvider.php Middleware/ExceptionMiddleware.php Middleware/DefaultBoardMiddleware.php Cron/CardDescriptionActivity.php Cron/ScheduledNotifications.php Cron/DeleteCron.php Search/DeckProvider.php Search/BoardSearchResultEntry.php Search/CardSearchResultEntry.php Command/UserExport.php Dashboard/DeckWidget.php Exceptions/ConflictException.php Event/FTSEvent.php NoPermissionException.php Listeners/BeforeTemplateRenderedListener.php Capabilities.php NotFoundException.php BadRequestException.php StatusException.php InvalidAttachmentType.php ArchivedItemException.php

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.


@@ -42,7 +42,7 @@
Loading
42 42
	}
43 43
44 44
	public function getArgument($key) {
45 -
		if ($this->hasArgument($key)) {
45 +
		if (isset($this->arguments[$key])) {
46 46
			return $this->arguments[$key];
47 47
		}
48 48

@@ -97,13 +97,13 @@
Loading
97 97
		// FIXME: One moving to QBMapper we should allow filtering the boards probably by method chaining for additional where clauses
98 98
		$sql = 'SELECT id, title, owner, color, archived, deleted_at, 0 as shared, last_modified FROM `*PREFIX*deck_boards` WHERE owner = ? AND last_modified > ?';
99 99
		if (!$includeArchived) {
100 -
			$sql .= ' AND NOT archived';
100 +
			$sql .= ' AND NOT archived AND deleted_at = 0';
101 101
		}
102 102
		$sql .= ' UNION ' .
103 103
			'SELECT boards.id, title, owner, color, archived, deleted_at, 1 as shared, last_modified FROM `*PREFIX*deck_boards` as boards ' .
104 104
			'JOIN `*PREFIX*deck_board_acl` as acl ON boards.id=acl.board_id WHERE acl.participant=? AND acl.type=? AND boards.owner != ? AND last_modified > ?';
105 105
		if (!$includeArchived) {
106 -
			$sql .= ' AND NOT archived';
106 +
			$sql .= ' AND NOT archived AND deleted_at = 0';
107 107
		}
108 108
		$entries = $this->findEntities($sql, [$userId, $since, $userId, Acl::PERMISSION_TYPE_USER, $userId, $since], $limit, $offset);
109 109
		/* @var Board $entry */
@@ -142,7 +142,7 @@
Loading
142 142
		}
143 143
		$sql .= ')';
144 144
		if (!$includeArchived) {
145 -
			$sql .= ' AND NOT archived';
145 +
			$sql .= ' AND NOT archived AND deleted_at = 0';
146 146
		}
147 147
		$entries = $this->findEntities($sql, array_merge([$userId, Acl::PERMISSION_TYPE_GROUP], $groups), $limit, $offset);
148 148
		/* @var Board $entry */
@@ -174,7 +174,7 @@
Loading
174 174
		}
175 175
		$sql .= ')';
176 176
		if (!$includeArchived) {
177 -
			$sql .= ' AND NOT archived';
177 +
			$sql .= ' AND NOT archived AND deleted_at = 0';
178 178
		}
179 179
		$entries = $this->findEntities($sql, array_merge([$userId, Acl::PERMISSION_TYPE_CIRCLE], $circles), $limit, $offset);
180 180
		/* @var Board $entry */

Learn more Showing 13 files with coverage changes found.

Changes in lib/AppInfo/Application20.php
+15
Loading file...
Changes in lib/Db/Card.php
+1
Loading file...
Changes in lib/Db/BoardMapper.php
+1
+2
Loading file...
Changes in lib/Db/CardMapper.php
+1
Loading file...
Changes in lib/Service/FullTextSearchService.php
+1
Loading file...
Changes in lib/Search/DeckProvider.php
+2
Loading file...
Changes in lib/Service/OverviewService.php
+3
Loading file...
Changes in lib/Service/ConfigService.php
+1
Loading file...
Changes in lib/DAV/Calendar.php
+2
Loading file...
Changes in lib/DAV/CalendarPlugin.php
+2
Loading file...
Changes in lib/Service/AssignmentService.php
+1
Loading file...
Changes in lib/Db/AssignedUsersMapper.php
+1
Loading file...
Changes in lib/AppInfo/ApplicationLegacy.php
-39
+53
Loading file...

75 Commits

Hiding 4 contexual commits Hiding 2 contexual commits
Hiding 1 contexual commits
Hiding 1 contexual commits
Hiding 1 contexual commits
Hiding 1 contexual commits
+8
+53
-45
+39
+3
+36
Files Coverage
lib 0.72% 49.68%
Project Totals (91 files) 49.68%
Loading