fixes #1272
fdintino
Showing 1 of 4 files from the diff.
nunjucks/src/environment.js
changed.
Other files ignored by Codecov
@@ -476,14 +476,15 @@
Loading
| 476 | 476 | let didError = false; |
|
| 477 | 477 | ||
| 478 | 478 | this.rootRenderFunc(this.env, context, frame, globalRuntime, (err, res) => { |
|
| 479 | - | if (didError) { |
|
| 479 | + | // TODO: this is actually a bug in the compiled template (because waterfall |
|
| 480 | + | // tasks are both not passing errors up the chain of callbacks AND are not |
|
| 481 | + | // causing a return from the top-most render function). But fixing that |
|
| 482 | + | // will require a more substantial change to the compiler. |
|
| 483 | + | if (didError && cb && typeof res !== 'undefined') { |
|
| 480 | 484 | // prevent multiple calls to cb |
|
| 481 | - | if (cb) { |
|
| 482 | - | return; |
|
| 483 | - | } else { |
|
| 484 | - | throw err; |
|
| 485 | - | } |
|
| 485 | + | return; |
|
| 486 | 486 | } |
|
| 487 | + | ||
| 487 | 488 | if (err) { |
|
| 488 | 489 | err = lib._prettifyError(this.path, this.env.opts.dev, err); |
|
| 489 | 490 | didError = true; |
| Files | Coverage |
|---|---|
| nunjucks | 89.61% |
| Project Totals (22 files) | 89.61% |
x87568cmsffi9nlt
00cv9yfpdkt3y7ks
qmbj5973wvm3iy96
g5gd6u23meebr00a
lf5305vff70nxkgk
vtkf2mr5win19937
smgs9vbw2f5kckp8
6esebojqbbs3813p
3br7qomie71u8vkf
gbxxs47iilvs0xkg
1387.1
1387.2
hniv0uth72q75hnb
1387.3
gquyynpao0yqkna2
ynkxtjo6a540764q
98yqaocrax6wlwgr
447iotf3o48ogpvb
1388.2
yl99orre373y45ni
1388.1
1388.3
oc7qc2esnh3thy3y
vrch2wt3pd15y4rr
Sunburst
The inner-most circle is the entire project, moving away from the center are folders then, finally, a single file.
The size and color of each slice is representing the number of statements and the coverage, respectively.
Icicle
The top section represents the entire project. Proceeding with folders and finally individual files.
The size and color of each slice is representing the number of statements and the coverage, respectively.
