Compare ⋅ mopidy/mopidy

Overview Diff Coverage Changes Files Commits

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.

Showing 1 of 5 files from the diff.

32.41% 21.74% -2.89%

mopidy/file/library.py changed.

Other files ignored by Codecov

mopidy/file/__init__.py has changed.

tests/file/test_get_images.py is new.

tests/file/test_lookup.py has changed.

mopidy/file/ext.conf has changed.

@@ -1,9 +1,12 @@

Loading

import base64
import logging
import os

from mopidy import backend, exceptions, models
from mopidy.audio import scan, tags
from mopidy.exceptions import ScannerError
from mopidy.internal import path
from mopidy.models import Image

logger = logging.getLogger(__name__)


@@ -36,6 +39,8 @@

Loading


        self._scanner = scan.Scanner(timeout=config["file"]["metadata_timeout"])

        self._folder_image_names = config["file"].get("folder_image_names", [])

    def browse(self, uri):
        logger.debug("Browsing files at: %s", uri)
        result = []

@@ -146,3 +151,32 @@

Loading

146	151		path.is_path_inside_base_dir(local_path, media_dir["path"])
147	152		for media_dir in self._media_dirs
148	153		)
	154	+
	155	+	def get_images(self, uris):
	156	+	images = {}
	157	+	for uri in uris:
	158	+	images[uri] = ()
	159	+	try:
	160	+	result = self._scanner.scan(uri)
	161	+	except ScannerError as e:
	162	+	logger.warning(str(e))
	163	+	continue
	164	+	if len(result.tags.get("image", [])) > 0:
	165	+	image = result.tags["image"][0]
	166	+	images[uri] = (
	167	+	Image(
	168	+	uri=f"data:;base64, {base64.b64encode(image).decode('utf-8')}"
	169	+	),
	170	+	)
	171	+	continue
	172	+	for i in self._folder_image_names:
	173	+	if (path.uri_to_path(uri).parent / i).exists():
	174	+	with open(path.uri_to_path(uri).parent / i, "rb",) as f:
	175	+	images[uri] = (
	176	+	Image(
	177	+	uri=f"data:;base64,"
	178	+	f"{base64.b64encode(f.read()).decode('utf-8')}"
	179	+	),
	180	+	)
	181	+	break
	182	+	return images

Everything is accounted for!

No changes detected that need to be reviewed.

What changes does Codecov check for?

Lines, not adjusted in diff, that have changed coverage data.

Files that introduced coverage data that had none before.

Files that have missing coverage data that once were tracked.

#1925 b021af6

76.52% ø ø

#1925 8cd289e

76.52% ø ø

#1925 808e8a4

Changed image uris from file to base64

parth-verma

#1925 1d36eb4

CI Passed

+1

76.51% 18.18% -0.27%

File: Implemented get_images for file library

parth-verma

#1925 7f189d2

CI Passed

+22

+4

+18

Pull Request Base Commit

76.79% 100.00% ø

Remove unnecessary comprehensions (#1917)

salonigupta1

c52bfba

CI Passed

Files		•	•	•	Coverage
mopidy	+23	+5	ø	+18	^-0.27% 76.52%
Project Totals (55 files)	4,714	3,607	0	1,107	76.52%

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

#1925 File: Implemented get_images for file library

No flags found

Everything is accounted for!

What changes does Codecov check for?

5 Commits

	1	+	import base64
1	2		import logging
2	3		import os
3	4
4	5		from mopidy import backend, exceptions, models
5	6		from mopidy.audio import scan, tags
	7	+	from mopidy.exceptions import ScannerError
6	8		from mopidy.internal import path
	9	+	from mopidy.models import Image
7	10
8	11		logger = logging.getLogger(__name__)
9	12

36	39
37	40		self._scanner = scan.Scanner(timeout=config["file"]["metadata_timeout"])
38	41
	42	+	self._folder_image_names = config["file"].get("folder_image_names", [])
	43	+
39	44		def browse(self, uri):
40	45		logger.debug("Browsing files at: %s", uri)
41	46		result = []