No flags found
Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.
e.g., #unittest #integration
#production #enterprise
#frontend #backend
Compare
de7d9bc
... +2 ...
3b7a676
de7d9bc
... +2 ...
3b7a676
Showing 1 of 2 files from the diff.
jwt/jwt.go
changed.
Other files ignored by Codecov
jwt/jwt_test.go
has changed.
@@ -263,29 +263,22 @@
Loading
| 263 | 263 | } |
|
| 264 | 264 | ||
| 265 | 265 | if ctx.inferAlgorithm { |
|
| 266 | - | // Okay, we couldn't deterministically find the single key to use. |
|
| 267 | - | // fallback to heuristics. |
|
| 268 | - | for i := 0; i < ks.Len(); i++ { |
|
| 269 | - | key, _ := ks.Get(i) |
|
| 270 | - | algs, err := jws.AlgorithmsForKey(key) |
|
| 271 | - | if err != nil { |
|
| 272 | - | return nil, _JwsVerifyInvalid, errors.Wrapf(err, `failed to get a list of signature methods for key type %s`, key.KeyType()) |
|
| 273 | - | } |
|
| 274 | - | ||
| 275 | - | for _, alg := range algs { |
|
| 276 | - | // bail out if the JWT has a `alg` field, and it doesn't match |
|
| 277 | - | if tokAlg := headers.Algorithm(); tokAlg != "" { |
|
| 278 | - | if tokAlg != alg { |
|
| 279 | - | continue |
|
| 280 | - | } |
|
| 281 | - | } |
|
| 266 | + | // Check whether the JWT headers specify a valid |
|
| 267 | + | // algorithm, use it if it's compatible. |
|
| 268 | + | algs, err := jws.AlgorithmsForKey(key) |
|
| 269 | + | if err != nil { |
|
| 270 | + | return nil, _JwsVerifyInvalid, errors.Wrapf(err, `failed to get a list of signature methods for key type %s`, key.KeyType()) |
|
| 271 | + | } |
|
| 282 | 272 | ||
| 283 | - | // Yippeeeeeee! we found a key that matches both kid and alg! |
|
| 284 | - | v, state, err := verifyJWSWithParams(ctx, payload, alg, key) |
|
| 285 | - | if err == nil { |
|
| 286 | - | return v, state, nil |
|
| 273 | + | for _, alg := range algs { |
|
| 274 | + | // bail out if the JWT has a `alg` field, and it doesn't match |
|
| 275 | + | if tokAlg := headers.Algorithm(); tokAlg != "" { |
|
| 276 | + | if tokAlg != alg { |
|
| 277 | + | continue |
|
| 287 | 278 | } |
|
| 288 | 279 | } |
|
| 280 | + | ||
| 281 | + | return verifyJWSWithParams(ctx, payload, alg, key) |
|
| 289 | 282 | } |
|
| 290 | 283 | } |
|
| 291 | 284 |
Learn more Showing 2 files with coverage changes found.
Changes in
→
jwk/ecdsa_gen.go
-1
+1
Loading file...
Changes in
→
jwk/set.go
-1
-1
+2
Loading file...
4
Commits
| Files | Coverage |
|---|---|
| internal | 80.92% |
| jwa | 100.00% |
| jwe | 64.22% |
| jwk | 0.08% 73.28% |
| jws | 75.99% |
| jwt | -0.04% 74.56% |
| cmd/jwx/jwx.go | 100.00% |
| format.go | 84.62% |
| formatkind_string_gen.go | 100.00% |
| options.go | 66.67% |
| x25519/x25519.go | 82.35% |
| Project Totals (83 files) | 72.75% |
#5233b7a676723c5063b89541de7d9bc