#460 Allow bid and lockup with 0 value in wallet-http

Open Matthew Zipkin pinheadmz
Coverage Reach
wallet/wallet.js wallet/txdb.js wallet/rpc.js wallet/http.js wallet/walletdb.js wallet/account.js wallet/masterkey.js wallet/records.js wallet/path.js wallet/nodeclient.js wallet/common.js wallet/walletcoinview.js wallet/walletkey.js wallet/nullclient.js wallet/plugin.js wallet/paths.js wallet/layout.js net/pool.js net/peer.js net/hostlist.js net/packets.js net/brontide.js net/bip152.js net/netaddress.js net/parser.js net/lookup.js net/slidingwindow.js net/common.js net/framer.js net/seeds/index.js net/seeds/testnet.js net/seeds/main.js primitives/tx.js primitives/mtx.js primitives/airdropproof.js primitives/airdropkey.js primitives/merkleblock.js primitives/keyring.js primitives/covenant.js primitives/abstractblock.js primitives/block.js primitives/address.js primitives/coin.js primitives/claim.js primitives/txmeta.js primitives/input.js primitives/output.js primitives/outpoint.js primitives/memblock.js primitives/headers.js primitives/invitem.js blockchain/chain.js blockchain/chaindb.js blockchain/chainentry.js blockchain/common.js blockchain/layout.js node/rpc.js node/http.js node/fullnode.js node/node.js node/spvnode.js mempool/mempool.js mempool/fees.js mempool/contractstate.js mempool/mempoolentry.js mempool/claimentry.js mempool/airdropentry.js mempool/layout.js script/script.js script/opcode.js script/stack.js script/witness.js script/scriptnum.js script/common.js script/scripterror.js covenants/rules.js covenants/namestate.js covenants/namedelta.js covenants/ownership.js covenants/reserved.js covenants/bitfield.js covenants/view.js covenants/undo.js mining/template.js mining/miner.js mining/cpuminer.js mining/common.js mining/mine.js workers/packets.js workers/workerpool.js workers/parser.js workers/child.js workers/jobs.js workers/framer.js dns/resource.js dns/server.js dns/key.js hd/private.js hd/mnemonic.js hd/public.js hd/hd.js hd/common.js hd/wordlist.js hd/words/french.js hd/words/japanese.js hd/words/chinese-simplified.js hd/words/italian.js hd/words/chinese-traditional.js hd/words/english.js hd/nfkd.js hd/index.js protocol/networks.js protocol/network.js protocol/consensus.js protocol/policy.js protocol/timedata.js protocol/errors.js protocol/genesis.js coins/coinview.js coins/coinentry.js coins/coins.js coins/compress.js coins/undocoins.js utils/fixed.js utils/util.js utils/binary.js ui/amount.js hsd.js pkg.js

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.

Showing 1 of 2 files from the diff.
Other files ignored by Codecov

@@ -1046,8 +1046,8 @@
Loading
1046 1046
      const sign = valid.bool('sign', true);
1047 1047
1048 1048
      assert(name, 'Name is required.');
1049 -
      assert(bid, 'Bid is required.');
1050 -
      assert(lockup, 'Lockup is required.');
1049 +
      assert(bid != null, 'Bid is required.');
1050 +
      assert(lockup != null, 'Lockup is required.');
1051 1051
      assert(broadcast ? sign : true, 'Must sign when broadcasting.');
1052 1052
1053 1053
      const options = TransactionOptions.fromValidator(valid);

Learn more Showing 2 files with coverage changes found.

Changes in lib/utils/binary.js
-1
+1
Loading file...
Changes in lib/covenants/rules.js
-1
+1
Loading file...
Files Coverage
lib 62.47%
Project Totals (129 files) 62.47%
Loading