gaearon / react-hot-loader

Compare 9c87cbc ... +2 ... c703d2e


@@ -57,8 +57,7 @@
Loading
57 57
      id,
58 58
      merge({}, renderOptions, { proxy: componentOptions.get(type) || {} }, options),
59 59
    );
60 -
  } else {
61 -
    proxiesByID[id].update(type);
60 +
  } else if (proxiesByID[id].update(type)) {
62 61
    // proxy could be registered again only in case of HMR
63 62
    incrementHotGeneration();
64 63
  }

@@ -341,13 +341,13 @@
Loading
341 341
    }
342 342
343 343
    if (NextComponent === CurrentComponent) {
344 -
      return;
344 +
      return false;
345 345
    }
346 346
347 347
    // Prevent proxy cycles
348 348
    const existingProxy = proxies.get(NextComponent);
349 349
    if (existingProxy) {
350 -
      return;
350 +
      return false;
351 351
    }
352 352
353 353
    isFunctionalComponent = !isReactClass(NextComponent);
@@ -412,6 +412,8 @@
Loading
412 412
        classUpdatePostponed = classHotReplacement;
413 413
      }
414 414
    }
415 +
416 +
    return true;
415 417
  }
416 418
417 419
  update(InitialComponent);

Everything is accounted for!

No changes detected that need to be reviewed.
What changes does Codecov check for?
Lines, not adjusted in diff, that have changed coverage data.
Files that introduced coverage data that had none before.
Files that have missing coverage data that once were tracked.
Files Coverage
src 0.01% 79.64%
testConfig 85.00%
index.js 20.83%
test/proxy/helper.js 100.00%
Project Totals (39 files) 79.03%
Loading