Compare ⋅ fail2ban/fail2ban

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.

Showing 3 of 3 files from the diff.

100.00% 100.00% ø

fail2ban/tests/fail2banregextestcase.py changed.

93.16% 100.00% -0.62%

fail2ban/server/strptime.py changed.

98.13% ø ø

fail2ban/server/datedetector.py changed.

@@ -384,7 +384,17 @@

Loading

			"Found a match but no valid date/time found",
			"Match without a timestamp:", all=True)

		self.pruneLog()
	def testIncompleteDateTime(self):
		# datepattern in followed lines doesn't match previously known pattern + line is too short
		# (logging break-off, no flush, etc):
		self.assertTrue(_test_exec(
			'-o', 'Found-ADDR:<ip>',
			'192.0.2.1 - - [02/May/2021:18:40:55 +0100] "GET / HTTP/1.1" 302 328 "-" "Mozilla/5.0" "-"\n'
			'192.0.2.2 - - [02/May/2021:18:40:55 +0100\n'
			'192.0.2.3 - - [02/May/2021:18:40:55',
			'^<ADDR>'))
		self.assertLogged(
			"Found-ADDR:192.0.2.1", "Found-ADDR:192.0.2.2", "Found-ADDR:192.0.2.3", all=True)	

	def testFrmtOutputWrapML(self):
		unittest.F2B.SkipIfCfgMissing(stock=True)

@@ -104,14 +104,14 @@

Loading


	# more precise year patterns, within same century of last year and
	# the next 3 years (for possible long uptime of fail2ban); thereby
	# respect possible run in the test-cases (alternate date used there):
	if MyTime.alternateNowTime != 0:
		timeRE['ExY'] = r"(?P<Y>%s\d)" % _getYearCentRE(cent=(0,3), distance=3)
		timeRE['Exy'] = r"(?P<y>%s\d)" % _getYearCentRE(cent=(2,3), distance=3)
	else: # accept years: 19xx|2xxx up to current century
		timeRE['ExY'] = r"(?P<Y>(?:19\d{2}|%s\d))" % _getYearCentRE(cent=(0,3), distance=3, 
			now=(MyTime.now(), datetime.datetime.fromtimestamp(978393600)))
		timeRE['Exy'] = r"(?P<y>\d{2})"
	# consider possible run in the test-cases (alternate date used there),
	# so accept years: 20xx (from test-date or 2001 up to current century)
	timeRE['ExY'] = r"(?P<Y>%s\d)" % _getYearCentRE(cent=(0,3), distance=3, 
		now=(datetime.datetime.now(), datetime.datetime.fromtimestamp(
					min(MyTime.alternateNowTime or 978393600, 978393600))
				)
		)
	timeRE['Exy'] = r"(?P<y>\d{2})"

_updateTimeRE()


@@ -365,10 +365,10 @@

Loading

				# with space or some special char), otherwise possible collision/pattern switch:
				if ((
					line[distance-1:distance] == self.__lastPos[1] or
						(line[distance] == self.__lastPos[2] and not self.__lastPos[2].isalnum())
						(line[distance:distance+1] == self.__lastPos[2] and not self.__lastPos[2].isalnum())
					) and (
					line[endpos:endpos+1] == self.__lastEndPos[2] or
						(line[endpos-1] == self.__lastEndPos[1] and not self.__lastEndPos[1].isalnum())
						(line[endpos-1:endpos] == self.__lastEndPos[1] and not self.__lastEndPos[1].isalnum())
				)):
					# search in line part only:
					log(logLevel-1, "  boundaries are correct, search in part %r", line[distance:endpos])

Learn more Showing 2 files with coverage changes found.

Changes in fail2ban/server/strptime.py

-1

→

+1

Loading file...

Changes in fail2ban/server/utils.py

-1

→

+1

Loading file...

95.47% 100.00% -0.01%

fixes search for the best datepattern (gh-3020) - e. g. if line is too short, boundaries check for previously known unprecise pattern may fail on incomplete lines (logging break-off, no flush, etc)

sebres

ef5c826

CI Passed

Hiding 1 contexual commits

-1

-3

+1

95.49% ø ø

fix travis build (unsupported pythons and pypy versions), update 3.10 in GH actions

sebres

319cfef

CI Passed

Files		•	•	•	Coverage
config	ø	ø	ø	ø	97.37%
fail2ban	-1	-3	+1	+1	^-0.01% 95.49%
setup.py	ø	ø	ø	ø	68.75%
Project Totals (75 files)	14,819	14,148	284	387	95.47%

104	104
105	105		# more precise year patterns, within same century of last year and
106	106		# the next 3 years (for possible long uptime of fail2ban); thereby
107		-	# respect possible run in the test-cases (alternate date used there):
108		-	if MyTime.alternateNowTime != 0:
109		-	timeRE['ExY'] = r"(?P<Y>%s\d)" % _getYearCentRE(cent=(0,3), distance=3)
110		-	timeRE['Exy'] = r"(?P<y>%s\d)" % _getYearCentRE(cent=(2,3), distance=3)
111		-	else: # accept years: 19xx\|2xxx up to current century
112		-	timeRE['ExY'] = r"(?P<Y>(?:19\d{2}\|%s\d))" % _getYearCentRE(cent=(0,3), distance=3,
113		-	now=(MyTime.now(), datetime.datetime.fromtimestamp(978393600)))
114		-	timeRE['Exy'] = r"(?P<y>\d{2})"
	107	+	# consider possible run in the test-cases (alternate date used there),
	108	+	# so accept years: 20xx (from test-date or 2001 up to current century)
	109	+	timeRE['ExY'] = r"(?P<Y>%s\d)" % _getYearCentRE(cent=(0,3), distance=3,
	110	+	now=(datetime.datetime.now(), datetime.datetime.fromtimestamp(
	111	+	min(MyTime.alternateNowTime or 978393600, 978393600))
	112	+	)
	113	+	)
	114	+	timeRE['Exy'] = r"(?P<y>\d{2})"
115	115
116	116		_updateTimeRE()
117	117

365	365		# with space or some special char), otherwise possible collision/pattern switch:
366	366		if ((
367	367		line[distance-1:distance] == self.__lastPos[1] or
368		-	(line[distance] == self.__lastPos[2] and not self.__lastPos[2].isalnum())
	368	+	(line[distance:distance+1] == self.__lastPos[2] and not self.__lastPos[2].isalnum())
369	369		) and (
370	370		line[endpos:endpos+1] == self.__lastEndPos[2] or
371		-	(line[endpos-1] == self.__lastEndPos[1] and not self.__lastEndPos[1].isalnum())
	371	+	(line[endpos-1:endpos] == self.__lastEndPos[1] and not self.__lastEndPos[1].isalnum())
372	372		)):
373	373		# search in line part only:
374	374		log(logLevel-1, " boundaries are correct, search in part %r", line[distance:endpos])

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Compare `319cfef ... +1 ... ef5c826`

No flags found

Show failed CI and contexual commits `c`

3 Commits

384	384		"Found a match but no valid date/time found",
385	385		"Match without a timestamp:", all=True)
386	386
387		-	self.pruneLog()
	387	+	def testIncompleteDateTime(self):
	388	+	# datepattern in followed lines doesn't match previously known pattern + line is too short
	389	+	# (logging break-off, no flush, etc):
	390	+	self.assertTrue(_test_exec(
	391	+	'-o', 'Found-ADDR:<ip>',
	392	+	'192.0.2.1 - - [02/May/2021:18:40:55 +0100] "GET / HTTP/1.1" 302 328 "-" "Mozilla/5.0" "-"\n'
	393	+	'192.0.2.2 - - [02/May/2021:18:40:55 +0100\n'
	394	+	'192.0.2.3 - - [02/May/2021:18:40:55',
	395	+	'^<ADDR>'))
	396	+	self.assertLogged(
	397	+	"Found-ADDR:192.0.2.1", "Found-ADDR:192.0.2.2", "Found-ADDR:192.0.2.3", all=True)
388	398
389	399		def testFrmtOutputWrapML(self):
390	400		unittest.F2B.SkipIfCfgMissing(stock=True)

Compare 319cfef ... +1 ... ef5c826

No flags found

Show failed CI and contexual commits c 3 Commits

Compare `319cfef ... +1 ... ef5c826`

Show failed CI and contexual commits `c`

3 Commits