Compare ⋅ denizzzka/dpq2

Overview Diff Coverage Changes Files Commits

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.

Showing 1 of 1 files from the diff.

89.39% 66.67% ø

src/dpq2/query_gen.d changed.

@@ -14,11 +14,11 @@

Loading

    UPDATE, // looks like "FieldName" = $3 and passes value into appropriate dollar variable
}

private struct Arg(ArgLikeIn _argLikeIn, string _name, T)
private struct Arg(ArgLikeIn _argLikeIn, T)
{
    enum argLikeIn = _argLikeIn;
    enum name = _name;

    string name;
    T value;
}


@@ -28,15 +28,15 @@

Loading

}

/// INSERT-like argument
auto i(string statementArgName, T)(T value)
auto i(T)(string statementArgName, T value)
{
    return Arg!(ArgLikeIn.INSERT, statementArgName, T)(value);
    return Arg!(ArgLikeIn.INSERT, T)(statementArgName, value);
}

/// UPDATE-like argument
auto u(string statementArgName, T)(T value)
auto u(T)(string statementArgName, T value)
{
    return Arg!(ArgLikeIn.UPDATE, statementArgName, T)(value);
    return Arg!(ArgLikeIn.UPDATE, T)(statementArgName, value);
}

/// Argument representing dollar, usable in SELECT statements

@@ -204,9 +204,9 @@

Loading

    auto stmnt = wrapStatement(
        `UPDATE table1`,
        `SET`,
            u!`boolean_field`(true),
            u!`integer_field`(123),
            u!`text_field`(`abc`),
            u(`boolean_field`, true),
            u(`integer_field`, 123),
            u(`text_field`, `abc`),
    );

    assert(stmnt.qp.sqlCommand.length > 10);

@@ -224,10 +224,10 @@

Loading


    auto stmnt = wrapStatement(
        `INSERT INTO table1 (`,
            i!`integer_field`(integer),
            i!`text_field`(text),
            i(`integer_field`, integer),
            i(`text_field`, text),
        `) WHERE`,
            u!`integer_field`(another_integer),
            u(`integer_field`, another_integer),
        `VALUES(`, Dollars(),`)`
    );


@@ -241,7 +241,7 @@

Loading

void _integration_test(string connParam)
{
    auto conn = new Connection(connParam);
    auto stmnt = wrapStatement(conn, i!"Some Integer"(123));
    auto stmnt = wrapStatement(conn, i("Some Integer", 123));

    assert(stmnt.qp.sqlCommand == `"Some Integer"`);
    assert(stmnt.qp.args.length == 1);

Everything is accounted for!

No changes detected that need to be reviewed.

What changes does Codecov check for?

Lines, not adjusted in diff, that have changed coverage data.

Files that introduced coverage data that had none before.

Files that have missing coverage data that once were tracked.

55.81% 66.67% ø

arg names is in RT now

denizzzka

8762719

CI Passed

55.81% 50.00% -0.19%

escaping by libpq added

denizzzka

889cb1b

CI Passed

Files		•	•	•	Coverage
src/dpq2	ø	ø	ø	ø	56.09%
integration_tests/integration_tests.d	ø	ø	ø	ø	0.00%
Project Totals (20 files)	1,824	1,018	0	806	55.81%

28	28		}
29	29
30	30		/// INSERT-like argument
31		-	auto i(string statementArgName, T)(T value)
	31	+	auto i(T)(string statementArgName, T value)
32	32		{
33		-	return Arg!(ArgLikeIn.INSERT, statementArgName, T)(value);
	33	+	return Arg!(ArgLikeIn.INSERT, T)(statementArgName, value);
34	34		}
35	35
36	36		/// UPDATE-like argument
37		-	auto u(string statementArgName, T)(T value)
	37	+	auto u(T)(string statementArgName, T value)
38	38		{
39		-	return Arg!(ArgLikeIn.UPDATE, statementArgName, T)(value);
	39	+	return Arg!(ArgLikeIn.UPDATE, T)(statementArgName, value);
40	40		}
41	41
42	42		/// Argument representing dollar, usable in SELECT statements

204	204		auto stmnt = wrapStatement(
205	205		`UPDATE table1`,
206	206		`SET`,
207		-	u!`boolean_field`(true),
208		-	u!`integer_field`(123),
209		-	u!`text_field`(`abc`),
	207	+	u(`boolean_field`, true),
	208	+	u(`integer_field`, 123),
	209	+	u(`text_field`, `abc`),
210	210		);
211	211
212	212		assert(stmnt.qp.sqlCommand.length > 10);

224	224
225	225		auto stmnt = wrapStatement(
226	226		`INSERT INTO table1 (`,
227		-	i!`integer_field`(integer),
228		-	i!`text_field`(text),
	227	+	i(`integer_field`, integer),
	228	+	i(`text_field`, text),
229	229		`) WHERE`,
230		-	u!`integer_field`(another_integer),
	230	+	u(`integer_field`, another_integer),
231	231		`VALUES(`, Dollars(),`)`
232	232		);
233	233

241	241		void _integration_test(string connParam)
242	242		{
243	243		auto conn = new Connection(connParam);
244		-	auto stmnt = wrapStatement(conn, i!"Some Integer"(123));
	244	+	auto stmnt = wrapStatement(conn, i("Some Integer", 123));
245	245
246	246		assert(stmnt.qp.sqlCommand == `"Some Integer"`);
247	247		assert(stmnt.qp.args.length == 1);

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Compare `889cb1b ... +0 ... 8762719`

No flags found

Everything is accounted for!

What changes does Codecov check for?

2 Commits

14	14		UPDATE, // looks like "FieldName" = $3 and passes value into appropriate dollar variable
15	15		}
16	16
17		-	private struct Arg(ArgLikeIn _argLikeIn, string _name, T)
	17	+	private struct Arg(ArgLikeIn _argLikeIn, T)
18	18		{
19	19		enum argLikeIn = _argLikeIn;
20		-	enum name = _name;
21	20
	21	+	string name;
22	22		T value;
23	23		}
24	24

Compare 889cb1b ... +0 ... 8762719

No flags found

Everything is accounted for!

What changes does Codecov check for?

2 Commits

Compare `889cb1b ... +0 ... 8762719`