Commit ⋅ cnpm/cnpmjs.org

Showing 3 of 4 files from the diff.

89.19% 100.00% ø

lib/common.js changed.

94.12% 100.00% +0.43%

controllers/registry/package/update.js changed.

77.06% 69.23% -0.14%

controllers/sync_module_worker.js changed.

Other files ignored by Codecov

test/controllers/registry/package/update.test.js has changed.

@@ -39,11 +39,11 @@

};

exports.getSyncTagDir = function (name) {
  return `${name}/sync/tags`;
  return `${name}/sync/tags/`;
};

exports.getSyncPackageDir = function (name) {
  return `${name}/sync/packages`;
  return `${name}/sync/packages/`;
};

const TAG_NAME_REG = /^tag-(.+)\.json$/;

@@ -4,6 +4,7 @@

var packageService = require('../../../services/package');
var userService = require('../../../services/user');
var config = require('../../../config');
var hook = require('../../../services/hook');

// PUT /:name/-rev/:rev
//

@@ -158,6 +159,31 @@


  var r = yield packageService.updatePrivateModuleMaintainers(name, usernames);
  debug('result: %j', r);
  if (r.add && r.add.length) {
    const envelope = {
      event: 'package:owner',
      name: name,
      type: 'package',
      version: null,
      hookOwner: null,
      payload: null,
      change: null,
    };
    hook.trigger(envelope);
  }
  if (r.remove && r.remove.length) {
    const envelope = {
      event: 'package:owner-rm',
      name: name,
      type: 'package',
      version: null,
      hookOwner: null,
      payload: null,
      change: null,
    };
    hook.trigger(envelope);
  }


  this.status = 201;
  this.body = {

@@ -360,22 +360,36 @@

    const distTagDirFiles = yield nfs.list(distTagDir);
    const distTagFileNames = distTagDirFiles.filter(fileName => common.isBackupTagFile(fileName));

    packageJsons = yield packageJsonFileNames.map(function* (packageJsonFileName) {
    const packageJsonRes = yield gather(packageJsonFileNames.map(function* (packageJsonFileName) {
      const version = common.getVersionFromFileName(packageJsonFileName);
      return yield readPackage(name, version);
    }), 5);
    packageJsons = packageJsonRes.map(({ isError, error, value}) => {
      if (isError) {
        error.message = '[sync] read package.json failed: ' + error.message;
        throw error;
      }
      return value;
    });

    packageJsons = packageJsons.sort((a, b) => {
      return a.publish_time - b.publish_time;
    });

    tags = yield distTagFileNames.map(function* (tagFileName) {
    const tagRes = yield gather(distTagFileNames.map(function* (tagFileName) {
      const tag = common.getTagNameFromFileName(tagFileName);
      const version = yield readDistTag(name, tag);
      return {
        tag,
        version,
      };
    }));
    tags = tagRes.map(({ isError, error, value}) => {
      if (isError) {
        error.message = '[sync] read dist-tag failed: ' + error.message;
        throw error;
      }
      return value;
    });
  } catch (err) {
    if (retryCount < 3) {

@@ -471,6 +485,7 @@

    try {
      yield nfs.download(packageJsonKey, filePath);
      const packageJSONFile = yield mzFs.readFile(filePath, 'utf8');
      console.log('file: ', filePath, packageJSONFile);
      const packageJSON = JSON.parse(packageJSONFile);
      return packageJSON;
    } finally {

Files		•	•	Coverage
common	138	92	46	66.67%
controllers	2,471	2,110	361	85.39%
middleware	265	250	15	94.34%
models	240	217	23	90.42%
routes	125	125	0	100.00%
servers	132	120	12	90.91%
services	839	773	66	92.13%
sync	154	138	16	89.61%
config/index.js	49	37	12	75.51%
lib/common.js	74	66	8	89.19%
Project Totals (97 files)	4,487	3,928	559	87.54%

View CI Build Download

No yaml found.

Create your codecov.yml to customize your Codecov experience

Read the docs

Interact now

The inner-most circle is the entire project, moving away from the center are folders then, finally, a single file. The size and color of each slice is representing the number of statements and the coverage, respectively.

SVG

The top section represents the entire project. Proceeding with folders and finally individual files. The size and color of each slice is representing the number of statements and the coverage, respectively.

SVG

Each block represents a single file in the project. The size and color of each block is represented by the number of statements and the coverage, respectively.

SVG

Learn more about the coverage sunburst graph

158	159
159	160		var r = yield packageService.updatePrivateModuleMaintainers(name, usernames);
160	161		debug('result: %j', r);
	162	+	if (r.add && r.add.length) {
	163	+	const envelope = {
	164	+	event: 'package:owner',
	165	+	name: name,
	166	+	type: 'package',
	167	+	version: null,
	168	+	hookOwner: null,
	169	+	payload: null,
	170	+	change: null,
	171	+	};
	172	+	hook.trigger(envelope);
	173	+	}
	174	+	if (r.remove && r.remove.length) {
	175	+	const envelope = {
	176	+	event: 'package:owner-rm',
	177	+	name: name,
	178	+	type: 'package',
	179	+	version: null,
	180	+	hookOwner: null,
	181	+	payload: null,
	182	+	change: null,
	183	+	};
	184	+	hook.trigger(envelope);
	185	+	}
	186	+
161	187
162	188		this.status = 201;
163	189		this.body = {

360	360		const distTagDirFiles = yield nfs.list(distTagDir);
361	361		const distTagFileNames = distTagDirFiles.filter(fileName => common.isBackupTagFile(fileName));
362	362
363		-	packageJsons = yield packageJsonFileNames.map(function* (packageJsonFileName) {
	363	+	const packageJsonRes = yield gather(packageJsonFileNames.map(function* (packageJsonFileName) {
364	364		const version = common.getVersionFromFileName(packageJsonFileName);
365	365		return yield readPackage(name, version);
	366	+	}), 5);
	367	+	packageJsons = packageJsonRes.map(({ isError, error, value}) => {
	368	+	if (isError) {
	369	+	error.message = '[sync] read package.json failed: ' + error.message;
	370	+	throw error;
	371	+	}
	372	+	return value;
366	373		});
367	374
368	375		packageJsons = packageJsons.sort((a, b) => {
369	376		return a.publish_time - b.publish_time;
370	377		});
371	378
372		-	tags = yield distTagFileNames.map(function* (tagFileName) {
	379	+	const tagRes = yield gather(distTagFileNames.map(function* (tagFileName) {
373	380		const tag = common.getTagNameFromFileName(tagFileName);
374	381		const version = yield readDistTag(name, tag);
375	382		return {
376	383		tag,
377	384		version,
378	385		};
	386	+	}));
	387	+	tags = tagRes.map(({ isError, error, value}) => {
	388	+	if (isError) {
	389	+	error.message = '[sync] read dist-tag failed: ' + error.message;
	390	+	throw error;
	391	+	}
	392	+	return value;
379	393		});
380	394		} catch (err) {
381	395		if (retryCount < 3) {

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

39	39		};
40	40
41	41		exports.getSyncTagDir = function (name) {
42		-	return `${name}/sync/tags`;
	42	+	return `${name}/sync/tags/`;
43	43		};
44	44
45	45		exports.getSyncPackageDir = function (name) {
46		-	return `${name}/sync/packages`;
	46	+	return `${name}/sync/packages/`;
47	47		};
48	48
49	49		const TAG_NAME_REG = /^tag-(.+)\.json$/;

4	4		var packageService = require('../../../services/package');
5	5		var userService = require('../../../services/user');
6	6		var config = require('../../../config');
	7	+	var hook = require('../../../services/hook');
7	8
8	9		// PUT /:name/-rev/:rev
9	10		//

471	485		try {
472	486		yield nfs.download(packageJsonKey, filePath);
473	487		const packageJSONFile = yield mzFs.readFile(filePath, 'utf8');
	488	+	console.log('file: ', filePath, packageJSONFile);
474	489		const packageJSON = JSON.parse(packageJSONFile);
475	490		return packageJSON;
476	491		} finally {

Updating our web app

No yaml found.