Compare `2ca0c69 ... +5 ... a348d6f`

        {
            var result = _nativeSdkMethods.Init();
            if (!result)
            {
                throw new NativeCallException("Init", result);
            }

            return TaskHelper.CompletedTask;
        }


@@ -83,7 +86,9 @@

        {
            var result = _nativeSdkMethods.UnInit();
            if (!result)
            {
                throw new NativeCallException("UnInit", result);
            }

            return TaskHelper.CompletedTask;
        }

@@ -113,7 +118,9 @@

                }

                if (ptr == IntPtr.Zero)
                {
                    throw new ColoreException("Device query failed, ptr NULL.");
                }

                var info = Marshal.PtrToStructure<SdkDeviceInfo>(ptr);


@@ -134,12 +141,18 @@

        {
            var result = _nativeSdkMethods.SetEffect(effectId);
            if (result)
            {
                return TaskHelper.CompletedTask;
            }

            if (result == Result.RzResourceDisabled || result == Result.RzAccessDenied)
            {
                Log.WarnFormat("Ambiguous {0} error thrown from call to native function SetEffect.", result);
            }
            else
            {
                throw new NativeCallException("SetEffect", result);
            }

            return TaskHelper.CompletedTask;
        }

@@ -153,7 +166,10 @@

        {
            var result = _nativeSdkMethods.DeleteEffect(effectId);
            if (!result)
            {
                throw new NativeCallException("DeleteEffect", result);
            }

            return TaskHelper.CompletedTask;
        }


@@ -404,7 +420,9 @@

        {
            var result = _nativeSdkMethods.RegisterEventNotification(hwnd);
            if (!result)
            {
                throw new NativeCallException("RegisterEventNotification", result);
            }
        }

        /// <inheritdoc />

@@ -415,7 +433,9 @@

        {
            var result = _nativeSdkMethods.UnregisterEventNotification();
            if (!result)
            {
                throw new NativeCallException("UnregisterEventNotification", result);
            }
        }

        /// <summary>

@@ -430,8 +450,12 @@

        {
            var guid = Guid.Empty;
            var result = _nativeSdkMethods.CreateEffect(device, effectType, param, ref guid);

            if (!result)
            {
                throw new NativeCallException("CreateEffect", result);
            }

            return guid;
        }


@@ -446,8 +470,12 @@

        {
            var guid = Guid.Empty;
            var result = _nativeSdkMethods.CreateKeyboardEffect(effectType, param, ref guid);

            if (!result)
            {
                throw new NativeCallException("CreateKeyboardEffect", result);
            }

            return guid;
        }


@@ -462,8 +490,12 @@

        {
            var guid = Guid.Empty;
            var result = _nativeSdkMethods.CreateMouseEffect(effectType, param, ref guid);

            if (!result)
            {
                throw new NativeCallException("CreateMouseEffect", result);
            }

            return guid;
        }


@@ -477,8 +509,12 @@

        {
            var guid = Guid.Empty;
            var result = _nativeSdkMethods.CreateHeadsetEffect(effectType, param, ref guid);

            if (!result)
            {
                throw new NativeCallException("CreateHeadsetEffect", result);
            }

            return guid;
        }


@@ -492,8 +528,12 @@

        {
            var guid = Guid.Empty;
            var result = _nativeSdkMethods.CreateMousepadEffect(effectType, param, ref guid);

            if (!result)
            {
                throw new NativeCallException("CreateMousepadEffect", result);
            }

            return guid;
        }


@@ -507,8 +547,12 @@

        {
            var guid = Guid.Empty;
            var result = _nativeSdkMethods.CreateKeypadEffect(effectType, param, ref guid);

            if (!result)
            {
                throw new NativeCallException("CreateKeypadEffect", result);
            }

            return guid;
        }


@@ -522,8 +566,12 @@

        {
            var guid = Guid.Empty;
            var result = _nativeSdkMethods.CreateChromaLinkEffect(effectType, param, ref guid);

            if (!result)
            {
                throw new NativeCallException("CreateChromaLinkEffect", result);
            }

            return guid;
        }
    }

@@ -311,7 +311,9 @@

        public override bool Equals(object? obj)
        {
            if (obj is null)
            {
                return false;
            }

            return obj is ExtendedCustomKeyboardEffect custom && Equals(custom);
        }

@@ -226,7 +226,9 @@

        public override bool Equals(object? other)
        {
            if (other is null)
            {
                return false;
            }

            switch (other)
            {

@@ -214,7 +214,9 @@

        public override bool Equals(object? obj)
        {
            if (obj is null)
            {
                return false;
            }

            return obj is DeathstalkerGridEffect custom && Equals(custom);
        }

@@ -233,7 +235,9 @@

            for (var index = 0; index < KeyboardConstants.MaxKeys; index++)
            {
                if (_colors[index] != other._colors[index])
                {
                    return false;
                }
            }

            return true;

@@ -107,7 +107,9 @@

        public override bool Equals(object? obj)
        {
            if (obj is null)
            {
                return false;
            }

            return obj is StaticHeadsetEffect effect && Equals(effect);
        }

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Everything is accounted for!

No changes detected that need to be reviewed.

What changes does Codecov check for?

Lines, not adjusted in diff, that have changed coverage data.

Files that introduced coverage data that had none before.

Files that have missing coverage data that once were tracked.

61.90% 20.00% ø

Merge pull request #293 from fasetto/code-refactor

Sharparam

a348d6f

CI Passed

61.90% ø ø

Revert "Use `is` keyword for null checking" for tests

fasetto

d27090f

CI Passed

Hiding 4 contexual commits

2ca0c69

Files		•	•	•	Coverage
src/Colore	ø	ø	ø	ø	61.90%
Project Totals (75 files)	1,688	1,045	0	643	61.90%

71	71		{
72	72		var result = _nativeSdkMethods.Init();
73	73		if (!result)
	74	+	{
74	75		throw new NativeCallException("Init", result);
	76	+	}
	77	+
75	78		return TaskHelper.CompletedTask;
76	79		}
77	80

113	118		}
114	119
115	120		if (ptr == IntPtr.Zero)
	121	+	{
116	122		throw new ColoreException("Device query failed, ptr NULL.");
	123	+	}
117	124
118	125		var info = Marshal.PtrToStructure<SdkDeviceInfo>(ptr);
119	126

134	141		{
135	142		var result = _nativeSdkMethods.SetEffect(effectId);
136	143		if (result)
	144	+	{
137	145		return TaskHelper.CompletedTask;
	146	+	}
138	147
139	148		if (result == Result.RzResourceDisabled \|\| result == Result.RzAccessDenied)
	149	+	{
140	150		Log.WarnFormat("Ambiguous {0} error thrown from call to native function SetEffect.", result);
	151	+	}
141	152		else
	153	+	{
142	154		throw new NativeCallException("SetEffect", result);
	155	+	}
143	156
144	157		return TaskHelper.CompletedTask;
145	158		}

153	166		{
154	167		var result = _nativeSdkMethods.DeleteEffect(effectId);
155	168		if (!result)
	169	+	{
156	170		throw new NativeCallException("DeleteEffect", result);
	171	+	}
	172	+
157	173		return TaskHelper.CompletedTask;
158	174		}
159	175

404	420		{
405	421		var result = _nativeSdkMethods.RegisterEventNotification(hwnd);
406	422		if (!result)
	423	+	{
407	424		throw new NativeCallException("RegisterEventNotification", result);
	425	+	}
408	426		}
409	427
410	428		/// <inheritdoc />

Compare `2ca0c69 ... +5 ... a348d6f`

No flags found

Everything is accounted for!

What changes does Codecov check for?

Show failed CI and contexual commits `c`

7 Commits

83	86		{
84	87		var result = _nativeSdkMethods.UnInit();
85	88		if (!result)
	89	+	{
86	90		throw new NativeCallException("UnInit", result);
	91	+	}
87	92
88	93		return TaskHelper.CompletedTask;
89	94		}

415	433		{
416	434		var result = _nativeSdkMethods.UnregisterEventNotification();
417	435		if (!result)
	436	+	{
418	437		throw new NativeCallException("UnregisterEventNotification", result);
	438	+	}
419	439		}
420	440
421	441		/// <summary>

430	450		{
431	451		var guid = Guid.Empty;
432	452		var result = _nativeSdkMethods.CreateEffect(device, effectType, param, ref guid);
	453	+
433	454		if (!result)
	455	+	{
434	456		throw new NativeCallException("CreateEffect", result);
	457	+	}
	458	+
435	459		return guid;
436	460		}
437	461

446	470		{
447	471		var guid = Guid.Empty;
448	472		var result = _nativeSdkMethods.CreateKeyboardEffect(effectType, param, ref guid);
	473	+
449	474		if (!result)
	475	+	{
450	476		throw new NativeCallException("CreateKeyboardEffect", result);
	477	+	}
	478	+
451	479		return guid;
452	480		}
453	481

462	490		{
463	491		var guid = Guid.Empty;
464	492		var result = _nativeSdkMethods.CreateMouseEffect(effectType, param, ref guid);
	493	+
465	494		if (!result)
	495	+	{
466	496		throw new NativeCallException("CreateMouseEffect", result);
	497	+	}
	498	+
467	499		return guid;
468	500		}
469	501

477	509		{
478	510		var guid = Guid.Empty;
479	511		var result = _nativeSdkMethods.CreateHeadsetEffect(effectType, param, ref guid);
	512	+
480	513		if (!result)
	514	+	{
481	515		throw new NativeCallException("CreateHeadsetEffect", result);
	516	+	}
	517	+
482	518		return guid;
483	519		}
484	520

522	566		{
523	567		var guid = Guid.Empty;
524	568		var result = _nativeSdkMethods.CreateChromaLinkEffect(effectType, param, ref guid);
	569	+
525	570		if (!result)
	571	+	{
526	572		throw new NativeCallException("CreateChromaLinkEffect", result);
	573	+	}
	574	+
527	575		return guid;
528	576		}
529	577		}

311	311		public override bool Equals(object? obj)
312	312		{
313	313		if (obj is null)
	314	+	{
314	315		return false;
	316	+	}
315	317
316	318		return obj is ExtendedCustomKeyboardEffect custom && Equals(custom);
317	319		}

226	226		public override bool Equals(object? other)
227	227		{
228	228		if (other is null)
	229	+	{
229	230		return false;
	231	+	}
230	232
231	233		switch (other)
232	234		{

233	235		for (var index = 0; index < KeyboardConstants.MaxKeys; index++)
234	236		{
235	237		if (_colors[index] != other._colors[index])
	238	+	{
236	239		return false;
	240	+	}
237	241		}
238	242
239	243		return true;

214	214		public override bool Equals(object? obj)
215	215		{
216	216		if (obj is null)
	217	+	{
217	218		return false;
	219	+	}
218	220
219	221		return obj is DeathstalkerGridEffect custom && Equals(custom);
220	222		}

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Compare 2ca0c69 ... +5 ... a348d6f

No flags found

Everything is accounted for!

What changes does Codecov check for?

Show failed CI and contexual commits c 7 Commits

Compare `2ca0c69 ... +5 ... a348d6f`

Show failed CI and contexual commits `c`

7 Commits