gh buildbot buildbot
Log in
Sign up

#5568 Fix known hosts for wrapper script

89.96% 100.00% +<.01%
Merged jsonar-cpapke
Overview Diff Coverage Changes Files Commits
Coverage Reach
master/buildbot/steps/source/git.py master/buildbot/steps/source/svn.py master/buildbot/steps/source/repo.py master/buildbot/steps/source/cvs.py master/buildbot/steps/source/mercurial.py master/buildbot/steps/source/mtn.py master/buildbot/steps/source/p4.py master/buildbot/steps/source/bzr.py master/buildbot/steps/source/darcs.py master/buildbot/steps/source/base.py master/buildbot/steps/source/gerrit.py master/buildbot/steps/source/gitlab.py master/buildbot/steps/source/github.py master/buildbot/steps/source/__init__.py master/buildbot/steps/package/rpm/mock.py master/buildbot/steps/package/rpm/rpmbuild.py master/buildbot/steps/package/rpm/rpmlint.py master/buildbot/steps/package/rpm/__init__.py master/buildbot/steps/package/deb/pbuilder.py master/buildbot/steps/package/deb/lintian.py master/buildbot/steps/package/util.py master/buildbot/steps/package/__init__.py master/buildbot/steps/shell_oldstyle.py master/buildbot/steps/shell.py master/buildbot/steps/vstudio.py master/buildbot/steps/transfer.py master/buildbot/steps/python.py master/buildbot/steps/python_twisted.py master/buildbot/steps/mtrlogobserver.py master/buildbot/steps/trigger.py master/buildbot/steps/worker.py master/buildbot/steps/master.py master/buildbot/steps/http_oldstyle.py master/buildbot/steps/http.py master/buildbot/steps/master_oldstyle.py master/buildbot/steps/subunit.py master/buildbot/steps/shellsequence.py master/buildbot/steps/cppcheck.py master/buildbot/steps/mswin.py master/buildbot/steps/download_secret_to_worker.py master/buildbot/steps/maxq.py master/buildbot/steps/cmake.py master/buildbot/process/buildstep.py master/buildbot/process/properties.py master/buildbot/process/build.py master/buildbot/process/metrics.py master/buildbot/process/buildrequestdistributor.py master/buildbot/process/builder.py master/buildbot/process/remotecommand.py master/buildbot/process/users/manual.py master/buildbot/process/users/users.py master/buildbot/process/users/manager.py master/buildbot/process/botmaster.py master/buildbot/process/buildrequest.py master/buildbot/process/factory.py master/buildbot/process/workerforbuilder.py master/buildbot/process/log.py master/buildbot/process/logobserver.py master/buildbot/process/remotetransfer.py master/buildbot/process/results.py master/buildbot/process/debug.py master/buildbot/process/cache.py master/buildbot/process/measured_service.py master/buildbot/process/subunitlogobserver.py master/buildbot/process/base.py master/buildbot/reporters/words.py master/buildbot/reporters/telegram.py master/buildbot/reporters/irc.py master/buildbot/reporters/gerrit.py master/buildbot/reporters/generators/utils.py master/buildbot/reporters/generators/worker.py master/buildbot/reporters/generators/build.py master/buildbot/reporters/generators/buildset.py master/buildbot/reporters/bitbucketserver.py master/buildbot/reporters/mail.py master/buildbot/reporters/message.py master/buildbot/reporters/utils.py master/buildbot/reporters/github.py master/buildbot/reporters/gitlab.py master/buildbot/reporters/gerrit_verify_status.py master/buildbot/reporters/notifier.py master/buildbot/reporters/http.py master/buildbot/reporters/hipchat.py master/buildbot/reporters/bitbucket.py master/buildbot/reporters/pushover.py master/buildbot/reporters/pushjet.py master/buildbot/reporters/zulip.py master/buildbot/db/migrate/versions/045_worker_transition.py master/buildbot/db/migrate/versions/046_mysql_innodb_compatibility.py master/buildbot/db/migrate/versions/052_cascading_set_null.py master/buildbot/db/migrate/versions/047_cascading_deletes.py master/buildbot/db/migrate/versions/050_cascading_deletes_all.py master/buildbot/db/migrate/versions/056_add_test_result_tables.py master/buildbot/db/migrate/versions/041_add_N_N_tagsbuilders.py master/buildbot/db/migrate/versions/057_add_build_data_tables.py master/buildbot/db/migrate/versions/042_add_build_properties_table.py master/buildbot/db/migrate/versions/051_add_worker_status.py master/buildbot/db/migrate/versions/044_add_step_hidden.py master/buildbot/db/migrate/versions/053_add_changes_committer.py master/buildbot/db/migrate/versions/048_change_properties_to_text.py master/buildbot/db/migrate/versions/054_add_index_to_steps.py master/buildbot/db/migrate/versions/049_add_schedulers_enabled.py master/buildbot/db/migrate/versions/058_add_build_data_length.py master/buildbot/db/migrate/versions/043_changes_parent.py master/buildbot/db/migrate/versions/040_add_builder_tags.py master/buildbot/db/migrate/versions/055_fix_changes_committer.py master/buildbot/db/logs.py master/buildbot/db/changes.py master/buildbot/db/model.py master/buildbot/db/test_results.py master/buildbot/db/enginestrategy.py master/buildbot/db/workers.py master/buildbot/db/builds.py master/buildbot/db/pool.py master/buildbot/db/buildrequests.py master/buildbot/db/users.py master/buildbot/db/buildsets.py master/buildbot/db/schedulers.py master/buildbot/db/steps.py master/buildbot/db/state.py master/buildbot/db/sourcestamps.py master/buildbot/db/build_data.py master/buildbot/db/base.py master/buildbot/db/connector.py master/buildbot/db/builders.py master/buildbot/db/test_result_sets.py master/buildbot/db/masters.py master/buildbot/db/dbconfig.py master/buildbot/db/changesources.py master/buildbot/db/migrate_utils.py master/buildbot/db/types/json.py master/buildbot/db/tags.py master/buildbot/db/exceptions.py master/buildbot/db/__init__.py master/buildbot/util/__init__.py master/buildbot/util/service.py master/buildbot/util/croniter.py master/buildbot/util/git.py master/buildbot/util/kubeclientservice.py master/buildbot/util/lru.py master/buildbot/util/httpclientservice.py master/buildbot/util/test_result_submitter.py master/buildbot/util/maildir.py master/buildbot/util/poll.py master/buildbot/util/raml.py master/buildbot/util/debounce.py master/buildbot/util/deferwaiter.py master/buildbot/util/subscription.py master/buildbot/util/eventual.py master/buildbot/util/pathmatch.py master/buildbot/util/config.py master/buildbot/util/lineboundaries.py master/buildbot/util/sautils.py master/buildbot/util/identifiers.py master/buildbot/util/protocol.py master/buildbot/util/netstrings.py master/buildbot/util/bbcollections.py master/buildbot/util/misc.py master/buildbot/util/latent.py master/buildbot/util/giturlparse.py master/buildbot/util/codebase.py master/buildbot/util/private_tempdir.py master/buildbot/util/ssl.py master/buildbot/util/logger.py master/buildbot/util/state.py master/buildbot/util/_notifier.py master/buildbot/util/tuplematch.py master/buildbot/www/hooks/github.py master/buildbot/www/hooks/gitlab.py master/buildbot/www/hooks/bitbucketserver.py master/buildbot/www/hooks/bitbucketcloud.py master/buildbot/www/hooks/base.py master/buildbot/www/hooks/poller.py master/buildbot/www/hooks/gitorious.py master/buildbot/www/hooks/bitbucket.py master/buildbot/www/rest.py master/buildbot/www/authz/endpointmatchers.py master/buildbot/www/authz/roles.py master/buildbot/www/authz/authz.py master/buildbot/www/authz/__init__.py master/buildbot/www/oauth2.py master/buildbot/www/service.py master/buildbot/www/auth.py master/buildbot/www/change_hook.py master/buildbot/www/sse.py master/buildbot/www/config.py master/buildbot/www/ldapuserinfo.py master/buildbot/www/ws.py master/buildbot/www/resource.py master/buildbot/www/avatar.py master/buildbot/www/plugin.py master/buildbot/worker/base.py master/buildbot/worker/ec2.py master/buildbot/worker/protocols/pb.py master/buildbot/worker/protocols/null.py master/buildbot/worker/protocols/base.py master/buildbot/worker/latent.py master/buildbot/worker/docker.py master/buildbot/worker/openstack.py master/buildbot/worker/libvirt.py master/buildbot/worker/upcloud.py master/buildbot/worker/manager.py master/buildbot/worker/kubernetes.py master/buildbot/worker/marathon.py master/buildbot/worker/local.py master/buildbot/worker/__init__.py master/buildbot/data/resultspec.py master/buildbot/data/types.py master/buildbot/data/buildrequests.py master/buildbot/data/buildsets.py master/buildbot/data/builds.py master/buildbot/data/changes.py master/buildbot/data/base.py master/buildbot/data/masters.py master/buildbot/data/workers.py master/buildbot/data/steps.py master/buildbot/data/logs.py master/buildbot/data/schedulers.py master/buildbot/data/connector.py master/buildbot/data/builders.py master/buildbot/data/logchunks.py master/buildbot/data/test_result_sets.py master/buildbot/data/forceschedulers.py master/buildbot/data/changesources.py master/buildbot/data/build_data.py master/buildbot/data/properties.py master/buildbot/data/test_results.py master/buildbot/data/sourcestamps.py master/buildbot/data/root.py master/buildbot/data/patches.py master/buildbot/data/exceptions.py master/buildbot/changes/mail.py master/buildbot/changes/gitpoller.py master/buildbot/changes/gerritchangesource.py master/buildbot/changes/svnpoller.py master/buildbot/changes/p4poller.py master/buildbot/changes/hgpoller.py master/buildbot/changes/github.py master/buildbot/changes/changes.py master/buildbot/changes/pb.py master/buildbot/changes/bitbucket.py master/buildbot/changes/base.py master/buildbot/changes/filter.py master/buildbot/changes/manager.py master/buildbot/schedulers/forcesched.py master/buildbot/schedulers/trysched.py master/buildbot/schedulers/timed.py master/buildbot/schedulers/base.py master/buildbot/schedulers/basic.py master/buildbot/schedulers/dependent.py master/buildbot/schedulers/triggerable.py master/buildbot/schedulers/manager.py master/buildbot/schedulers/filter.py master/buildbot/scripts/runner.py master/buildbot/scripts/base.py master/buildbot/scripts/logwatcher.py master/buildbot/scripts/upgrade_master.py master/buildbot/scripts/start.py master/buildbot/scripts/create_master.py master/buildbot/scripts/stop.py master/buildbot/scripts/cleanupdb.py master/buildbot/scripts/reconfig.py master/buildbot/scripts/sendchange.py master/buildbot/scripts/checkconfig.py master/buildbot/scripts/user.py master/buildbot/scripts/tryserver.py master/buildbot/scripts/sample.cfg master/buildbot/scripts/restart.py master/buildbot/scripts/trycmd.py master/buildbot/status/master.py master/buildbot/status/builder.py master/buildbot/status/build.py master/buildbot/status/buildrequest.py master/buildbot/status/worker.py master/buildbot/status/buildset.py master/buildbot/status/base.py master/buildbot/status/event.py master/buildbot/status/__init__.py master/buildbot/status/client.py master/buildbot/clients/tryclient.py master/buildbot/clients/base.py master/buildbot/clients/sendchange.py master/buildbot/clients/usersclient.py master/buildbot/config.py master/buildbot/master.py master/buildbot/statistics/capture.py master/buildbot/statistics/stats_service.py master/buildbot/statistics/storage_backends/influxdb_client.py master/buildbot/statistics/storage_backends/base.py master/buildbot/statistics/__init__.py master/buildbot/machine/generic.py master/buildbot/machine/latent.py master/buildbot/machine/base.py master/buildbot/machine/manager.py master/buildbot/plugins/db.py master/buildbot/plugins/__init__.py master/buildbot/locks.py master/buildbot/mq/wamp.py master/buildbot/mq/simple.py master/buildbot/mq/base.py master/buildbot/mq/connector.py master/buildbot/interfaces.py master/buildbot/secrets/providers/vault.py master/buildbot/secrets/providers/file.py master/buildbot/secrets/providers/passwordstore.py master/buildbot/secrets/providers/base.py master/buildbot/secrets/secret.py master/buildbot/secrets/manager.py master/buildbot/buildbot_net_usage_data.py master/buildbot/pbmanager.py master/buildbot/wamp/connector.py master/buildbot/configurators/janitor.py master/buildbot/configurators/__init__.py master/buildbot/monkeypatches/__init__.py master/buildbot/monkeypatches/servicechecks.py master/buildbot/monkeypatches/decorators.py master/buildbot/pbutil.py master/buildbot/__init__.py master/buildbot/revlinks.py master/buildbot/scheduler.py master/buildbot/warnings.py master/buildbot/errors.py master/buildbot/buildrequest.py worker/buildbot_worker/runprocess.py worker/buildbot_worker/commands/transfer.py worker/buildbot_worker/commands/fs.py worker/buildbot_worker/commands/base.py worker/buildbot_worker/commands/shell.py worker/buildbot_worker/commands/utils.py worker/buildbot_worker/commands/registry.py worker/buildbot_worker/scripts/runner.py worker/buildbot_worker/scripts/create_worker.py worker/buildbot_worker/scripts/logwatcher.py worker/buildbot_worker/scripts/start.py worker/buildbot_worker/scripts/stop.py worker/buildbot_worker/scripts/restart.py worker/buildbot_worker/scripts/base.py worker/buildbot_worker/base.py worker/buildbot_worker/pb.py worker/buildbot_worker/util/__init__.py worker/buildbot_worker/util/_hangcheck.py worker/buildbot_worker/util/_notifier.py worker/buildbot_worker/__init__.py worker/buildbot_worker/pbutil.py worker/buildbot_worker/monkeypatches/testcase_assert.py worker/buildbot_worker/monkeypatches/__init__.py worker/buildbot_worker/compat.py worker/buildbot_worker/null.py worker/buildbot_worker/interfaces.py worker/buildbot_worker/bot.py worker/buildbot_worker/backports/__init__.py worker/buildbot_worker/exceptions.py

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.

Showing 1 of 3 files from the diff.

@@ -278,20 +278,12 @@
Loading
278 278 
        ssh_data_path = self._getSshDataPath()
279 279 
        yield self.runMkdir(ssh_data_path)
280 280 










281
                            
                            -
                            
        if not self.supportsSshPrivateKeyAsEnvOption:









282
                            
                            -
                            
            script_path = self._getSshWrapperScriptPath(ssh_data_path)









283
                            
                            -
                            
            script_contents = getSshWrapperScriptContents(









284
                            
                            -
                            
                self._getSshPrivateKeyPath(ssh_data_path))









285
                            
                            -
                            









286
                            
                            -
                            
            yield self.downloadFileContentToWorker(script_path,









287
                            
                            -
                            
                                                   script_contents,









288
                            
                            -
                            
                                                   workdir=workdir, mode=0o700)









289
                            
                            -
                            









290
281
                             
                            
        private_key_path = self._getSshPrivateKeyPath(ssh_data_path)










291
282
                             
                            
        yield self.downloadFileContentToWorker(private_key_path,










292
283
                             
                            
                                               private_key,










293
284
                             
                            
                                               workdir=workdir, mode=0o400)










294
285
                             
                            












286
                            +
                            
        known_hosts_path = None









295
287
                             
                            
        if self.sshHostKey is not None or self.sshKnownHosts is not None:










296
288
                             
                            
            known_hosts_path = self._getSshHostKeyPath(ssh_data_path)










297
289
                             
                            


















@@ -301,6 +293,14 @@

 Loading















301
293
                             
                            
                                                   known_hosts_contents,










302
294
                             
                            
                                                   workdir=workdir, mode=0o400)










303
295
                             
                            












296
                            +
                            
        if not self.supportsSshPrivateKeyAsEnvOption:











297
                            +
                            
            script_path = self._getSshWrapperScriptPath(ssh_data_path)











298
                            +
                            
            script_contents = getSshWrapperScriptContents(private_key_path, known_hosts_path)











299
                            +
                            











300
                            +
                            
            yield self.downloadFileContentToWorker(script_path,











301
                            +
                            
                                                   script_contents,











302
                            +
                            
                                                   workdir=workdir, mode=0o700)











303
                            +
                            









304
304
                             
                            
        self.didDownloadSshPrivateKey = True










305
305
                             
                            
        return RC_SUCCESS










306
306
                             
                            







 
 


























































Everything is accounted for!

No changes detected that need to be reviewed.



What changes does Codecov check for?




Lines, not adjusted in diff, that have changed coverage data.


Files that introduced coverage data that had none before.


Files that have missing coverage data that once were tracked.









































5

Commits

















































89.96%




92.48%







+<.01%




























Merge remote-tracking branch 'upstream/master' into fix-known-hosts-for-wrapper-script











jsonar-cpapke













#5568






acd00f6





 CI Passed





















Christopher Papke
















Contextual



















use format for git wrapper file tests











jsonar-cpapke














e1a7b72






















Christopher Papke
















Contextual



















added bugfix news fragment











jsonar-cpapke














e6c0876






















Christopher Papke
















Contextual



















fix broken tests and updated some tests to check wrapper contents











jsonar-cpapke














8bfed63






















Christopher Papke
















Contextual



















git: make sure to pass in the known_hosts_path to getSshWrapperScriptContents if the path exists











jsonar-cpapke














41c83df

















Pull Request Base Commit










Povilas Kanapickas


























89.96%



ø



ø


























Merge pull request #5589 from p12tic/docs-reporters-split











p12tic














89f092e





 CI Failed












































buildbot












































Files






Coverage
























changes


















86.99%




















clients


















60.00%




















configurators


















97.62%




















data


















96.22%




















db


















96.00%




















machine


















92.34%




















monkeypatches


















88.61%




















mq


















96.91%




















plugins


















94.63%




















process


















91.38%




















reporters


















91.97%




















schedulers


















92.62%




















scripts


















88.48%




















secrets


















98.17%




















statistics


















98.89%




















status


















48.74%




















steps


















92.13%




















util



















+<.01%






93.11%




















worker


















86.62%




















www


















93.68%




















__init__.py


















76.92%




















buildbot_net_usage_data.py


















76.98%




















buildrequest.py


















100.00%




















config.py


















98.03%




















errors.py


















100.00%




















interfaces.py


















98.90%




















locks.py


















97.06%




















master.py


















85.31%




















pbmanager.py


















95.50%




















pbutil.py


















45.07%




















revlinks.py


















96.67%




















scheduler.py


















100.00%




















wamp/connector.py


















91.21%




















warnings.py


















100.00%











Folder Totals (34 files)






90.26%






Project Totals (352 files)






89.96%
































Loading