Compare ⋅ btraceio/btrace

Overview Diff Coverage Changes Files Commits

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.

Showing 1 of 1 files from the diff.

68.70% 100.00% +0.25% 64.63% +0.31%

...sun/btrace/runtime/InstrumentingMethodVisitor.java changed.

@@ -348,7 +348,7 @@

Loading

    private final LocalVarTypes localTypes = new LocalVarTypes();
    private final Set<Integer> frameOffsets = new HashSet<>();
    private final Map<Label, SavedState> jumpTargetStates = new HashMap<>();
    private final Map<Label, Label> tryCatchHandlerMap = new HashMap<>();
    private final Map<Label, Set<Label>> tryCatchHandlerMap = new HashMap<>();

    private int argsSize = 0;
    private int localsTailPtr = 0;

@@ -1205,10 +1205,12 @@

Loading

            newLocals.clear();
            newLocals.addAll(ss.newLocals);
        }
        Label handler = tryCatchHandlerMap.get(label);
        if (handler != null) {
            if (!jumpTargetStates.containsKey(handler)) {
                jumpTargetStates.put(handler, new SavedState(variableMapper, localTypes, stack, newLocals, SavedState.EXCEPTION));
        Set<Label> handlers = tryCatchHandlerMap.get(label);
        if (handlers != null) {
            for (Label handler:handlers){
                if (!jumpTargetStates.containsKey(handler)) {
                    jumpTargetStates.put(handler, new SavedState(variableMapper, localTypes, stack, newLocals, SavedState.EXCEPTION));
                }
            }
        }
        super.visitLabel(label);

@@ -1284,7 +1286,12 @@

Loading


    @Override
    public void addTryCatchHandler(Label start, Label handler) {
        tryCatchHandlerMap.put(start, handler);
        Set<Label> handlers = tryCatchHandlerMap.get(start);
        if (handlers == null){
            handlers = new HashSet<>();
        }
        handlers.add(handler);
        tryCatchHandlerMap.put(start,handlers);
    }

    @Override

Everything is accounted for!

No changes detected that need to be reviewed.

What changes does Codecov check for?

Lines, not adjusted in diff, that have changed coverage data.

Files that introduced coverage data that had none before.

Files that have missing coverage data that once were tracked.

29.77% 100.00% +0.03% 23.80% +0.03%

fix class verify failure due to mismatch locals, of multi try-catch (#397)

zizon

0cc7edb

+6

a4195db

Files		•	•	•	Complexity	Coverage
src/share/classes/com/sun/btrace	+6	+6	ø	ø	^+2.00% 23.80%	^0.03% 29.77%
Project Totals (160 files)	15,225	4,532	605	10,088	23.80%	29.77%

348	348		private final LocalVarTypes localTypes = new LocalVarTypes();
349	349		private final Set<Integer> frameOffsets = new HashSet<>();
350	350		private final Map<Label, SavedState> jumpTargetStates = new HashMap<>();
351		-	private final Map<Label, Label> tryCatchHandlerMap = new HashMap<>();
	351	+	private final Map<Label, Set<Label>> tryCatchHandlerMap = new HashMap<>();
352	352
353	353		private int argsSize = 0;
354	354		private int localsTailPtr = 0;

1205	1205		newLocals.clear();
1206	1206		newLocals.addAll(ss.newLocals);
1207	1207		}
1208		-	Label handler = tryCatchHandlerMap.get(label);
1209		-	if (handler != null) {
1210		-	if (!jumpTargetStates.containsKey(handler)) {
1211		-	jumpTargetStates.put(handler, new SavedState(variableMapper, localTypes, stack, newLocals, SavedState.EXCEPTION));
	1208	+	Set<Label> handlers = tryCatchHandlerMap.get(label);
	1209	+	if (handlers != null) {
	1210	+	for (Label handler:handlers){
	1211	+	if (!jumpTargetStates.containsKey(handler)) {
	1212	+	jumpTargetStates.put(handler, new SavedState(variableMapper, localTypes, stack, newLocals, SavedState.EXCEPTION));
	1213	+	}
1212	1214		}
1213	1215		}
1214	1216		super.visitLabel(label);

1284	1286
1285	1287		@Override
1286	1288		public void addTryCatchHandler(Label start, Label handler) {
1287		-	tryCatchHandlerMap.put(start, handler);
	1289	+	Set<Label> handlers = tryCatchHandlerMap.get(start);
	1290	+	if (handlers == null){
	1291	+	handlers = new HashSet<>();
	1292	+	}
	1293	+	handlers.add(handler);
	1294	+	tryCatchHandlerMap.put(start,handlers);
1288	1295		}
1289	1296
1290	1297		@Override

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Compare `a4195db ... +0 ... 0cc7edb`

No flags found

Everything is accounted for!

What changes does Codecov check for?

2 Commits

Compare a4195db ... +0 ... 0cc7edb

No flags found

Everything is accounted for!

What changes does Codecov check for?

2 Commits

Compare `a4195db ... +0 ... 0cc7edb`