Compare ⋅ briannesbitt/Carbon

Overview Diff Coverage Changes Files Commits

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.

Showing 1 of 2 files from the diff.

100.00% 100.00% ø 22 5

src/Carbon/Traits/Test.php changed.

Other files ignored by Codecov

tests/Carbon/TestingAidsTest.php has changed.

@@ -12,9 +12,12 @@

Loading

namespace Carbon\Traits;

use Carbon\CarbonInterface;
use Carbon\CarbonTimeZone;
use Closure;
use DateTimeImmutable;
use DateTimeInterface;
use InvalidArgumentException;
use Throwable;

trait Test
{

@@ -84,13 +87,14 @@

Loading

        $useDateInstanceTimezone = $testNow instanceof DateTimeInterface;

        if ($useDateInstanceTimezone) {
            date_default_timezone_set($testNow->getTimezone()->getName());
            self::setDefaultTimezone($testNow->getTimezone()->getName(), $testNow);
        }

        static::setTestNow($testNow);

        if (!$useDateInstanceTimezone) {
            date_default_timezone_set(static::getMockedTestNow(\func_num_args() === 1 ? null : $tz)->timezone);
            $now = static::getMockedTestNow(\func_num_args() === 1 ? null : $tz);
            self::setDefaultTimezone($now->tzName, $now);
        }
    }


@@ -175,4 +179,30 @@

Loading

175	179		? $testInstance->rawFormat(static::MOCK_DATETIME_FORMAT)
176	180		: $testInstance->format(static::MOCK_DATETIME_FORMAT);
177	181		}
	182	+
	183	+	private static function setDefaultTimezone($timezone, DateTimeInterface $date = null)
	184	+	{
	185	+	$previous = null;
	186	+	$success = false;
	187	+
	188	+	try {
	189	+	$success = date_default_timezone_set($timezone);
	190	+	} catch (Throwable $exception) {
	191	+	$previous = $exception;
	192	+	}
	193	+
	194	+	if (!$success) {
	195	+	$suggestion = @CarbonTimeZone::create($timezone)->toRegionName($date);
	196	+
	197	+	throw new InvalidArgumentException(
	198	+	"Timezone ID '$timezone' is invalid".
	199	+	($suggestion && $suggestion !== $timezone ? ", did you mean '$suggestion'?" : '.')."\n".
	200	+	"It must be one of the IDs from DateTimeZone::listIdentifiers(),\n".
	201	+	'For the record, hours/minutes offset are relevant only for a particular moment, '.
	202	+	'but not as a default timezone.',
	203	+	0,
	204	+	$previous
	205	+	);
	206	+	}
	207	+	}
178	208		}

Everything is accounted for!

No changes detected that need to be reviewed.

What changes does Codecov check for?

Lines, not adjusted in diff, that have changed coverage data.

Files that introduced coverage data that had none before.

Files that have missing coverage data that once were tracked.

100.00% 100.00% ø 2158 5

Throw exception on invalid timezone ID

kylekatarnls

#2501 35a688b

CI Passed

+16

100.00% 100.00% ø 2153 0

Merge pull request #2492 from kylekatarnls/fix/issue-2480-polish-declension

kylekatarnls

c37370b

CI Passed

Files		•	•	•	Complexity	Coverage
Carbon	+16	+16	ø	ø	ø	100.00%
Project Totals (886 files)	9,301	9,301	0	0	2158	100.00%

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Compare `c37370b ... +0 ... 35a688b`

No flags found

Everything is accounted for!

What changes does Codecov check for?

2 Commits

12	12		namespace Carbon\Traits;
13	13
14	14		use Carbon\CarbonInterface;
	15	+	use Carbon\CarbonTimeZone;
15	16		use Closure;
16	17		use DateTimeImmutable;
17	18		use DateTimeInterface;
	19	+	use InvalidArgumentException;
	20	+	use Throwable;
18	21
19	22		trait Test
20	23		{

84	87		$useDateInstanceTimezone = $testNow instanceof DateTimeInterface;
85	88
86	89		if ($useDateInstanceTimezone) {
87		-	date_default_timezone_set($testNow->getTimezone()->getName());
	90	+	self::setDefaultTimezone($testNow->getTimezone()->getName(), $testNow);
88	91		}
89	92
90	93		static::setTestNow($testNow);
91	94
92	95		if (!$useDateInstanceTimezone) {
93		-	date_default_timezone_set(static::getMockedTestNow(\func_num_args() === 1 ? null : $tz)->timezone);
	96	+	$now = static::getMockedTestNow(\func_num_args() === 1 ? null : $tz);
	97	+	self::setDefaultTimezone($now->tzName, $now);
94	98		}
95	99		}
96	100

Compare c37370b ... +0 ... 35a688b

No flags found

Everything is accounted for!

What changes does Codecov check for?

2 Commits

Compare `c37370b ... +0 ... 35a688b`