bonclay7 / aws-amicleaner
91.55% ø ø

Errors if LaunchConfigurationName is empty string

Got the following error where zeroed_lcs = [''] and gave the below error. Likely because of the use of LaunchTemplates instead of LaunchConfigurations.

Fixes the below error: File "/usr/local/lib/python3.5/dist-packages/amicleaner/cli.py", line 53, in fetch_candidates excluded_amis += f.fetch_zeroed_asg() File "/usr/local/lib/python3.5/dist-packages/amicleaner/fetch.py", line 72, in fetch_zeroed_asg LaunchConfigurationNames=zeroed_lcs File "/usr/local/lib/python3.5/dist-packages/botocore/client.py", line 276, in _api_call return self._make_api_call(operation_name, kwargs) File "/usr/local/lib/python3.5/dist-packages/botocore/client.py", line 559, in _make_api_call api_params, operation_model, context=request_context) File "/usr/local/lib/python3.5/dist-packages/botocore/client.py", line 607, in _convert_to_request_dict api_params, operation_model) File "/usr/local/lib/python3.5/dist-packages/botocore/validate.py", line 297, in serialize_to_request raise ParamValidationError(report=report.generate_report()) botocore.exceptions.ParamValidationError: Parameter validation failed: Invalid length for parameter LaunchConfigurationNames[0], value: 0, valid range: 1-inf

devgrok CI Passed

69b9a14 #107 70627e5

Showing 1 of 1 files from the diff.
Newly tracked file
100.00% ø ø
amicleaner/fetch.py changed.

@@ -67,7 +67,7 @@
Loading
67 67 
        resp = self.asg.describe_auto_scaling_groups()
68 68 
        zeroed_lcs = [asg.get("LaunchConfigurationName", "")
69 69 
                      for asg in resp.get("AutoScalingGroups", [])
70 - 
                      if asg.get("DesiredCapacity", 0) == 0]
70 + 
                      if asg.get("DesiredCapacity", 0) == 0 and asg.get("LaunchConfigurationName", "")]
71 71 










72
72
                             
                            
        resp = self.asg.describe_launch_configurations(










73
73
                             
                            
            LaunchConfigurationNames=zeroed_lcs







 
 



































































Files






Coverage
























amicleaner
















86.94%




















tests
















100.00%




















setup.py
















0.00%











Project Totals (11 files)






91.55%






















Uploads


Yaml




























82.2












            

              
TRAVIS_PYTHON_VERSION=3.5
TRAVIS_OS_NAME=linux















View CI Build






Download




















No yaml found.




Create your codecov.yml

to customize your Codecov experience









Read the docs
























Interact now








Sunburst



The inner-most circle is the entire project, moving away from the center are folders then, finally, a single file.
The size and color of each slice is representing the number of statements and the coverage, respectively.









SVG





















Icicle



The top section represents the entire project. Proceeding with folders and finally individual files.
The size and color of each slice is representing the number of statements and the coverage, respectively.









SVG




















Grid



Each block represents a single file in the project.
The size and color of each block is represented by the number of statements and the coverage, respectively.









SVG
























Learn more about the coverage sunburst graph



























Loading