Commit ⋅ aws/aws-toolkit-vscode

Showing 1 of 5 files from the diff.

39.04% 35.29% +0.33%

...dentials/defaultCredentialSelectionDataProvider.ts changed.

Other files ignored by Codecov

.../Feature-aa840ab7-982f-4c52-a2c5-c6d1513129af.json is new.

...red/credentials/credentialSelectionDataProvider.ts has changed.

src/test/techdebt.test.ts has changed.

...als/defaultCredentialSelectionDataProvider.test.ts has changed.

@@ -11,10 +11,10 @@

Loading

//
// Based on the multiStepInput code in the QuickInput VSCode extension sample.

import * as vscode from 'vscode'
import * as nls from 'vscode-nls'
const localize = nls.loadMessageBundle()

import { ExtensionContext, QuickPickItem } from 'vscode'
import { asString } from '../../credentials/providers/credentials'
import { SharedCredentialsProvider } from '../../credentials/providers/sharedCredentialsProvider'
import { MultiStepInputFlowController } from '../multiStepInputFlowController'

@@ -25,6 +25,7 @@

Loading

import { credentialHelpUrl } from '../constants'
import { createHelpButton } from '../ui/buttons'
import { recentlyUsed } from '../localizedText'
import { getIcon, codicon } from '../icons'

interface ProfileEntry {
    profileName: string

@@ -40,14 +41,39 @@

Loading

    private readonly _credentialsMru: CredentialsProfileMru
    private readonly helpButton = createHelpButton(credentialHelpUrl)

    public constructor(public readonly existingProfileNames: string[], protected context: ExtensionContext) {
    public constructor(public readonly existingProfileNames: string[], protected context: vscode.ExtensionContext) {
        this._credentialsMru = new CredentialsProfileMru(context)
    }

    public async pickCredentialProfile(
        input: MultiStepInputFlowController,
        actions: vscode.QuickPickItem[],
        state: Partial<CredentialSelectionState>
    ): Promise<QuickPickItem> {
    ): Promise<vscode.QuickPickItem> {
        // Remove this stub after we bump minimum to vscode 1.64
        const QuickPickItemKind = (vscode as any).QuickPickItemKind
        const menuTop: vscode.QuickPickItem[] = [
            // vscode 1.64 supports QuickPickItemKind.Separator.
            // https://github.com/microsoft/vscode/commit/eb416b4f9ebfda1c798aa7c8b2f4e81c6ce1984f
            ...(!QuickPickItemKind
                ? []
                : [
                      {
                          label: localize('AWS.menu.actions', 'Actions'),
                          kind: QuickPickItemKind.Separator,
                      } as vscode.QuickPickItem,
                  ]),
            ...actions,
            ...(!QuickPickItemKind
                ? []
                : [
                      {
                          label: localize('AWS.menu.profiles', 'Profiles'),
                          kind: QuickPickItemKind.Separator,
                      } as vscode.QuickPickItem,
                  ]),
        ]

        return await input.showQuickPick({
            title: localize(
                'AWS.title.selectCredentialProfile',

@@ -57,7 +83,7 @@

Loading

            step: 1,
            totalSteps: 1,
            placeholder: localize('AWS.placeHolder.selectProfile', 'Select a credential profile'),
            items: this.getProfileSelectionList(),
            items: menuTop.concat(this.getProfileSelectionList()),
            activeItem: state.credentialProfile,
            shouldResume: this.shouldResume.bind(this),
        })

@@ -163,12 +189,12 @@

Loading

    /**
     * Builds and returns the list of QuickPickItem objects representing the profile names to select from in the UI
     */
    private getProfileSelectionList(): QuickPickItem[] {
    private getProfileSelectionList(): vscode.QuickPickItem[] {
        const orderedProfiles: ProfileEntry[] = this.getOrderedProfiles()

        const selectionList: QuickPickItem[] = []
        const selectionList: vscode.QuickPickItem[] = []
        orderedProfiles.forEach(profile => {
            const selectionItem: QuickPickItem = { label: profile.profileName }
            const selectionItem: vscode.QuickPickItem = { label: profile.profileName }

            if (profile.isRecentlyUsed) {
                selectionItem.description = recentlyUsed

@@ -230,13 +256,24 @@

Loading

        input: MultiStepInputFlowController,
        state: Partial<CredentialSelectionState>
    ) {
        state.credentialProfile = await dataProvider.pickCredentialProfile(input, state)
        const actions = [
            {
                label: localize('AWS.credentials.edit', '{0} Edit Credentials', codicon`${getIcon('vscode-edit')}`),
                alwaysShow: true,
                description: localize('AWS.credentials.edit.desc', 'open ~/.aws/credentials'),
            },
        ]
        const item = await dataProvider.pickCredentialProfile(input, actions, state)
        if (item.label === actions[0].label) {
            vscode.commands.executeCommand('aws.credentials.edit')
        } else {
            state.credentialProfile = item
        }
    }

    async function collectInputs() {
        const state: Partial<CredentialSelectionState> = {}
        await MultiStepInputFlowController.run(async input => await pickCredentialProfile(input, state))

        return state as CredentialSelectionState
    }


Files		•	•	•	Coverage
src	21,742	14,543	0	7,199	66.88%
Project Totals (409 files)	21,742	14,543	0	7,199	66.88%

windows-unittests

View CI Build Download

windows-unittests

View CI Build Download

# To validate:
#   cat codecov.yml | curl --data-binary @- https://codecov.io/validate

codecov:
    notify:
        require_ci_to_pass: no

coverage:
    precision: 2
    round: down
    range: '70...100'

    status:
        project:
            default:
                threshold: 1
                informational: true
        patch: no
        changes: no

comment: off

github_checks:
    annotations: false

Read the docs

Interact now

The inner-most circle is the entire project, moving away from the center are folders then, finally, a single file. The size and color of each slice is representing the number of statements and the coverage, respectively.

SVG

The top section represents the entire project. Proceeding with folders and finally individual files. The size and color of each slice is representing the number of statements and the coverage, respectively.

SVG

Each block represents a single file in the project. The size and color of each block is represented by the number of statements and the coverage, respectively.

SVG

Learn more about the coverage sunburst graph

163	189		/**
164	190		* Builds and returns the list of QuickPickItem objects representing the profile names to select from in the UI
165	191		*/
166		-	private getProfileSelectionList(): QuickPickItem[] {
	192	+	private getProfileSelectionList(): vscode.QuickPickItem[] {
167	193		const orderedProfiles: ProfileEntry[] = this.getOrderedProfiles()
168	194
169		-	const selectionList: QuickPickItem[] = []
	195	+	const selectionList: vscode.QuickPickItem[] = []
170	196		orderedProfiles.forEach(profile => {
171		-	const selectionItem: QuickPickItem = { label: profile.profileName }
	197	+	const selectionItem: vscode.QuickPickItem = { label: profile.profileName }
172	198
173	199		if (profile.isRecentlyUsed) {
174	200		selectionItem.description = recentlyUsed

230	256		input: MultiStepInputFlowController,
231	257		state: Partial<CredentialSelectionState>
232	258		) {
233		-	state.credentialProfile = await dataProvider.pickCredentialProfile(input, state)
	259	+	const actions = [
	260	+	{
	261	+	label: localize('AWS.credentials.edit', '{0} Edit Credentials', codicon`${getIcon('vscode-edit')}`),
	262	+	alwaysShow: true,
	263	+	description: localize('AWS.credentials.edit.desc', 'open ~/.aws/credentials'),
	264	+	},
	265	+	]
	266	+	const item = await dataProvider.pickCredentialProfile(input, actions, state)
	267	+	if (item.label === actions[0].label) {
	268	+	vscode.commands.executeCommand('aws.credentials.edit')
	269	+	} else {
	270	+	state.credentialProfile = item
	271	+	}
234	272		}
235	273
236	274		async function collectInputs() {
237	275		const state: Partial<CredentialSelectionState> = {}
238	276		await MultiStepInputFlowController.run(async input => await pickCredentialProfile(input, state))
239		-
240	277		return state as CredentialSelectionState
241	278		}
242	279

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

11	11		//
12	12		// Based on the multiStepInput code in the QuickInput VSCode extension sample.
13	13
	14	+	import * as vscode from 'vscode'
14	15		import * as nls from 'vscode-nls'
15	16		const localize = nls.loadMessageBundle()
16	17
17		-	import { ExtensionContext, QuickPickItem } from 'vscode'
18	18		import { asString } from '../../credentials/providers/credentials'
19	19		import { SharedCredentialsProvider } from '../../credentials/providers/sharedCredentialsProvider'
20	20		import { MultiStepInputFlowController } from '../multiStepInputFlowController'

25	25		import { credentialHelpUrl } from '../constants'
26	26		import { createHelpButton } from '../ui/buttons'
27	27		import { recentlyUsed } from '../localizedText'
	28	+	import { getIcon, codicon } from '../icons'
28	29
29	30		interface ProfileEntry {
30	31		profileName: string

40	41		private readonly _credentialsMru: CredentialsProfileMru
41	42		private readonly helpButton = createHelpButton(credentialHelpUrl)
42	43
43		-	public constructor(public readonly existingProfileNames: string[], protected context: ExtensionContext) {
	44	+	public constructor(public readonly existingProfileNames: string[], protected context: vscode.ExtensionContext) {
44	45		this._credentialsMru = new CredentialsProfileMru(context)
45	46		}
46	47
47	48		public async pickCredentialProfile(
48	49		input: MultiStepInputFlowController,
	50	+	actions: vscode.QuickPickItem[],
49	51		state: Partial<CredentialSelectionState>
50		-	): Promise<QuickPickItem> {
	52	+	): Promise<vscode.QuickPickItem> {
	53	+	// Remove this stub after we bump minimum to vscode 1.64
	54	+	const QuickPickItemKind = (vscode as any).QuickPickItemKind
	55	+	const menuTop: vscode.QuickPickItem[] = [
	56	+	// vscode 1.64 supports QuickPickItemKind.Separator.
	57	+	// https://github.com/microsoft/vscode/commit/eb416b4f9ebfda1c798aa7c8b2f4e81c6ce1984f
	58	+	...(!QuickPickItemKind
	59	+	? []
	60	+	: [
	61	+	{
	62	+	label: localize('AWS.menu.actions', 'Actions'),
	63	+	kind: QuickPickItemKind.Separator,
	64	+	} as vscode.QuickPickItem,
	65	+	]),
	66	+	...actions,
	67	+	...(!QuickPickItemKind
	68	+	? []
	69	+	: [
	70	+	{
	71	+	label: localize('AWS.menu.profiles', 'Profiles'),
	72	+	kind: QuickPickItemKind.Separator,
	73	+	} as vscode.QuickPickItem,
	74	+	]),
	75	+	]
	76	+
51	77		return await input.showQuickPick({
52	78		title: localize(
53	79		'AWS.title.selectCredentialProfile',

57	83		step: 1,
58	84		totalSteps: 1,
59	85		placeholder: localize('AWS.placeHolder.selectProfile', 'Select a credential profile'),
60		-	items: this.getProfileSelectionList(),
	86	+	items: menuTop.concat(this.getProfileSelectionList()),
61	87		activeItem: state.credentialProfile,
62	88		shouldResume: this.shouldResume.bind(this),
63	89		})

1	# To validate:
2	# cat codecov.yml \| curl --data-binary @- https://codecov.io/validate
3
4	codecov:
5	notify:
6	require_ci_to_pass: no
7
8	coverage:
9	precision: 2
10	round: down
11	range: '70...100'
12
13	status:
14	project:
15	default:
16	threshold: 1
17	informational: true
18	patch: no
19	changes: no
20
21	comment: off
22
23	github_checks:
24	annotations: false

Updating our web app