Compare ⋅ arrow-py/arrow

    def get(self, *args, **kwargs):
        """ Returns an :class:`Arrow <arrow.arrow.Arrow>` object based on flexible inputs.

        :param locale: (optional) a ``str`` specifying a locale for the parser. Defaults to
            'en_us'.
        :param locale: (optional) a ``str`` specifying a locale for the parser. Defaults to 'en_us'.
        :param tzinfo: (optional) a :ref:`timezone expression <tz-expr>` or tzinfo object.
            Replaces the timezone unless using an input form that is explicitly UTC or specifies
            the timezone in a positional argument. Defaults to UTC.
        :param normalize_whitespace: (optional) a ``bool`` specifying whether or not to normalize
            redundant whitespace (spaces, tabs, and newlines) in a datetime string before parsing.
            Defaults to false.

        Usage::


@@ -141,6 +143,7 @@

Loading

        arg_count = len(args)
        locale = kwargs.pop("locale", "en_us")
        tz = kwargs.get("tzinfo", None)
        normalize_whitespace = kwargs.pop("normalize_whitespace", False)

        # if kwargs given, send to constructor unless only tzinfo provided
        if len(kwargs) > 1:

@@ -193,7 +196,7 @@

Loading


            # (str) -> parse.
            elif isstr(arg):
                dt = parser.DateTimeParser(locale).parse_iso(arg)
                dt = parser.DateTimeParser(locale).parse_iso(arg, normalize_whitespace)
                return self.type.fromdatetime(dt, tz)

            # (struct_time) -> from struct_time

@@ -240,7 +243,9 @@

Loading


            # (str, format) -> parse.
            elif isstr(arg_1) and (isstr(arg_2) or isinstance(arg_2, list)):
                dt = parser.DateTimeParser(locale).parse(args[0], args[1])
                dt = parser.DateTimeParser(locale).parse(
                    args[0], args[1], normalize_whitespace
                )
                return self.type.fromdatetime(dt, tzinfo=tz)

            else:

@@ -114,8 +114,11 @@

Loading


    # TODO: since we support more than ISO 8601, we should rename this function
    # IDEA: break into multiple functions
    def parse_iso(self, datetime_string):
        # TODO: add a flag to normalize whitespace (useful in logs, ref issue #421)
    def parse_iso(self, datetime_string, normalize_whitespace=False):

        if normalize_whitespace:
            datetime_string = re.sub(r"\s+", " ", datetime_string.strip())

        has_space_divider = " " in datetime_string
        has_t_divider = "T" in datetime_string


@@ -213,7 +216,10 @@

Loading


        return self._parse_multiformat(datetime_string, formats)

    def parse(self, datetime_string, fmt):
    def parse(self, datetime_string, fmt, normalize_whitespace=False):

        if normalize_whitespace:
            datetime_string = re.sub(r"\s+", " ", datetime_string)

        if isinstance(fmt, list):
            return self._parse_multiformat(datetime_string, fmt)

Everything is accounted for!

No changes detected that need to be reviewed.

What changes does Codecov check for?

Lines, not adjusted in diff, that have changed coverage data.

Files that introduced coverage data that had none before.

Files that have missing coverage data that once were tracked.

100.00% ø ø

Tweak documentation wording based on feedback.

jadchaar

#813 34f2928

CI Passed

100.00% 100.00% ø

Rename kwarg; add documentation; supplement tests.

jadchaar

#813 6cc5b08

CI Passed

100.00% ø ø

Merge branch 'master' into master

jadchaar

#813 4ee4242

CI Passed

100.00% 100.00% ø

Merge branch 'master' into master

jadchaar

#813 63d9258

CI Passed

-1 Files

+14

100.00% 100.00% ø

added normalize_spaces flag to get()

Unknown

#813 5f4d3f7

CI Passed

+1 Files

-9

Pull Request Base Commit

100.00% ø ø

Change Tox terminology from whitelist to allowlist to be more inclusive. (#833)

jadchaar

2cfb2b0

CI Passed

Files		•	•	•	Coverage
arrow	+5	+5	ø	ø	100.00%
Project Totals (9 files)	1,776	1,776	0	0	100.00%

141	143		arg_count = len(args)
142	144		locale = kwargs.pop("locale", "en_us")
143	145		tz = kwargs.get("tzinfo", None)
	146	+	normalize_whitespace = kwargs.pop("normalize_whitespace", False)
144	147
145	148		# if kwargs given, send to constructor unless only tzinfo provided
146	149		if len(kwargs) > 1:

193	196
194	197		# (str) -> parse.
195	198		elif isstr(arg):
196		-	dt = parser.DateTimeParser(locale).parse_iso(arg)
	199	+	dt = parser.DateTimeParser(locale).parse_iso(arg, normalize_whitespace)
197	200		return self.type.fromdatetime(dt, tz)
198	201
199	202		# (struct_time) -> from struct_time

240	243
241	244		# (str, format) -> parse.
242	245		elif isstr(arg_1) and (isstr(arg_2) or isinstance(arg_2, list)):
243		-	dt = parser.DateTimeParser(locale).parse(args[0], args[1])
	246	+	dt = parser.DateTimeParser(locale).parse(
	247	+	args[0], args[1], normalize_whitespace
	248	+	)
244	249		return self.type.fromdatetime(dt, tzinfo=tz)
245	250
246	251		else:

114	114
115	115		# TODO: since we support more than ISO 8601, we should rename this function
116	116		# IDEA: break into multiple functions
117		-	def parse_iso(self, datetime_string):
118		-	# TODO: add a flag to normalize whitespace (useful in logs, ref issue #421)
	117	+	def parse_iso(self, datetime_string, normalize_whitespace=False):
	118	+
	119	+	if normalize_whitespace:
	120	+	datetime_string = re.sub(r"\s+", " ", datetime_string.strip())
	121	+
119	122		has_space_divider = " " in datetime_string
120	123		has_t_divider = "T" in datetime_string
121	124

213	216
214	217		return self._parse_multiformat(datetime_string, formats)
215	218
216		-	def parse(self, datetime_string, fmt):
	219	+	def parse(self, datetime_string, fmt, normalize_whitespace=False):
	220	+
	221	+	if normalize_whitespace:
	222	+	datetime_string = re.sub(r"\s+", " ", datetime_string)
217	223
218	224		if isinstance(fmt, list):
219	225		return self._parse_multiformat(datetime_string, fmt)

#813 Add normalize_spaces flag to arrow.get

No flags found

Everything is accounted for!

What changes does Codecov check for?

5 Commits

34	34		def get(self, args, *kwargs):
35	35		""" Returns an :class:`Arrow <arrow.arrow.Arrow>` object based on flexible inputs.
36	36
37		-	:param locale: (optional) a ``str`` specifying a locale for the parser. Defaults to
38		-	'en_us'.
	37	+	:param locale: (optional) a ``str`` specifying a locale for the parser. Defaults to 'en_us'.
39	38		:param tzinfo: (optional) a :ref:`timezone expression <tz-expr>` or tzinfo object.
40	39		Replaces the timezone unless using an input form that is explicitly UTC or specifies
41	40		the timezone in a positional argument. Defaults to UTC.
	41	+	:param normalize_whitespace: (optional) a ``bool`` specifying whether or not to normalize
	42	+	redundant whitespace (spaces, tabs, and newlines) in a datetime string before parsing.
	43	+	Defaults to false.
42	44
43	45		Usage::
44	46

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits