Compare `ee2672c ... +6 ... f179042`

    private ApiInfo apiInfo() {
        return new ApiInfoBuilder()
                .title("dubbo admin swagger api")
                .description("for more information please visit github page: https://github.com/apache/incubator-dubbo-admin")
                .description("for more information please visit github page: https://github.com/apache/dubbo-admin")
                .version("1.0")
                .build();
    }

@@ -105,6 +105,7 @@


        if (StringUtils.isNotEmpty(configCenter)) {
            configCenterUrl = formUrl(configCenter, configCenterGroup, configCenterGroupNameSpace, username, password);
            logger.info("Admin using config center: " + configCenterUrl);
            dynamicConfiguration = ExtensionLoader.getExtensionLoader(GovernanceConfiguration.class).getDefaultExtension();
            dynamicConfiguration.setUrl(configCenterUrl);
            dynamicConfiguration.init();

@@ -118,6 +119,8 @@

                    } else if (s.startsWith(Constants.METADATA_ADDRESS)) {
                        metadataUrl = formUrl(removerConfigKey(s), metadataGroup, metadataGroupNameSpace, username, password);
                    }
                    logger.info("Registry address found from config center: " + registryUrl);
                    logger.info("Metadata address found from config center: " + registryUrl);
                });
            }
        }

@@ -127,9 +130,9 @@

                dynamicConfiguration = ExtensionLoader.getExtensionLoader(GovernanceConfiguration.class).getDefaultExtension();
                dynamicConfiguration.setUrl(registryUrl);
                dynamicConfiguration.init();
                logger.warn("you are using dubbo.registry.address, which is not recommend, please refer to: https://github.com/apache/incubator-dubbo-admin/wiki/Dubbo-Admin-configuration");
                logger.warn("you are using dubbo.registry.address, which is not recommend, please refer to: https://github.com/apache/dubbo-admin/wiki/Dubbo-Admin-configuration");
            } else {
                throw new ConfigurationException("Either config center or registry address is needed, please refer to https://github.com/apache/incubator-dubbo-admin/wiki/Dubbo-Admin-configuration");
                throw new ConfigurationException("Either config center or registry address is needed, please refer to https://github.com/apache/dubbo-admin/wiki/Dubbo-Admin-configuration");
                //throw exception
            }
        }

@@ -145,10 +148,13 @@

        Registry registry = null;
        if (registryUrl == null) {
            if (StringUtils.isBlank(registryAddress)) {
                throw new ConfigurationException("Either config center or registry address is needed, please refer to https://github.com/apache/incubator-dubbo-admin/wiki/Dubbo-Admin-configuration");
                throw new ConfigurationException("Either config center or registry address is needed, please refer to https://github.com/apache/dubbo-admin/wiki/Dubbo-Admin-configuration");
            }
            registryUrl = formUrl(registryAddress, registryGroup, registryNameSpace, username, password);
        }

        logger.info("Admin using registry address: " + registryUrl);

        RegistryFactory registryFactory = ApplicationModel.defaultModel().getExtensionLoader(RegistryFactory.class).getAdaptiveExtension();
        registry = registryFactory.getRegistry(registryUrl.addParameter(ENABLE_EMPTY_PROTECTION_KEY, String.valueOf(false)));
        return registry;

@@ -166,13 +172,14 @@

                metadataUrl = formUrl(metadataAddress, metadataGroup, metadataGroupNameSpace, username, password);
                metadataUrl = metadataUrl.addParameter(CLUSTER_KEY, cluster);
            }
            logger.info("Admin using metadata address: " + metadataUrl);
        }
        if (metadataUrl != null) {
            metaDataCollector = ApplicationModel.defaultModel().getExtensionLoader(MetaDataCollector.class).getExtension(metadataUrl.getProtocol());
            metaDataCollector.setUrl(metadataUrl);
            metaDataCollector.init();
        } else {
            logger.warn("you are using dubbo.registry.address, which is not recommend, please refer to: https://github.com/apache/incubator-dubbo-admin/wiki/Dubbo-Admin-configuration");
            logger.warn("you are using dubbo.registry.address, which is not recommend, please refer to: https://github.com/apache/dubbo-admin/wiki/Dubbo-Admin-configuration");
        }
        return metaDataCollector;
    }

@@ -97,7 +97,7 @@

        origin.keySet().forEach(providers::remove);

        for (List<InstanceAddressURL> instanceAddressURLs : providers.values()) {
            MetadataService metadataService = MetadataUtils.referProxy(instanceAddressURLs.get(0).getInstance());
            MetadataService metadataService = MetadataUtils.referProxy(instanceAddressURLs.get(0).getInstance()).getProxy();
            try {
                Set<String> subscribedURLs = metadataService.getSubscribedURLs();


@@ -26,12 +26,13 @@

import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.stream.Collectors;

public class AdminServiceInstancesChangedListener extends ServiceInstancesChangedListener {

    private AddressChangeListener addressChangeListener;

    private Map<String, Object> oldServiceUrls;
    private Map<String, List<ServiceInstancesChangedListener.ProtocolServiceKeyWithUrls>> oldServiceUrls;

    public AdminServiceInstancesChangedListener(Set<String> serviceNames, ServiceDiscovery serviceDiscovery, AddressChangeListener addressChangeListener) {
        super(serviceNames, serviceDiscovery);

@@ -43,8 +44,14 @@

        oldServiceUrls.keySet().stream()
                .filter(protocolServiceKey -> !serviceUrls.containsKey(protocolServiceKey))
                .forEach(protocolServiceKey -> addressChangeListener.notifyAddressChanged(protocolServiceKey, new ArrayList<>()));
        serviceUrls.forEach((protocolServiceKey, urls) -> addressChangeListener.notifyAddressChanged(protocolServiceKey, (List<URL>) urls));
        serviceUrls.forEach((protocolServiceKey, urls) -> addressChangeListener.notifyAddressChanged(protocolServiceKey, extractUrls(urls)));

        oldServiceUrls = serviceUrls;
    }

    private List<URL> extractUrls(List<ServiceInstancesChangedListener.ProtocolServiceKeyWithUrls> keyUrls) {
        return keyUrls.stream()
                .flatMap((protocolServiceKeyWithUrls) -> protocolServiceKeyWithUrls.getUrls().stream())
                .collect(Collectors.toList());
    }
}

Learn more Showing 5 files with coverage changes found.

Changes in dubbo-admin-server/src/main/java/org/apache/dubbo/admin/service/RegistryServerSync.java

-2

-1

→

Loading file...

Changes in dubbo-admin-server/src/main/java/org/apache/dubbo/admin/controller/MetricsCollectController.java

→

Loading file...

Changes in dubbo-admin-server/src/main/java/org/apache/dubbo/admin/common/util/RouteUtils.java

→

Loading file...

Changes in dubbo-admin-server/src/main/java/org/apache/dubbo/admin/registry/mapping/AdminMappingListener.java

New

Loading file...

Changes in dubbo-admin-server/src/main/java/org/apache/dubbo/admin/registry/mapping/impl/ZookeeperServiceMapping.java

-3

→

Loading file...

21.30% ø -0.04% 18.88% -0.04%

add storage (#963)

JSCZhongJian

f179042

CI Passed

-2

-1

83e293b

21.34% ø +0.04% 18.92% +0.04%

Update deployment (#960)

b0bf24a

-3

e279afd

21.30% ø -0.04% 18.88% -0.04%

Update README_ZH.md (#951)

wxbty

bd36d09

CI Passed

-2

-1

21.34% ø ø 18.92% ø

adjust port (#948)

RobberPhex

3ae9dfa

21.34% 93.33% +0.13% 18.92% +0.07%

Make Admin easier to deploy (#940)

chickenlj

290126c

CI Passed

+10

+11

-1

21.15% ø ø 18.79% ø

Unable to find commit in GitHub

Unknown

#935 ee2672c

Files		•	•	•	Complexity	Coverage
...dmin-server/src/main/java/org/apache/dubbo/admin/DubboAdminApplication.java	ø	ø	ø	ø	50.00%	33.33%
.../main/java/org/apache/dubbo/admin/authentication/impl/DefaultPreHandle.java	ø	ø	ø	ø	0.00%	0.00%
...dmin-server/src/main/java/org/apache/dubbo/admin/common/CommonResponse.java	ø	ø	ø	ø	28.57%	40.74%
...in/java/org/apache/dubbo/admin/common/exception/ConfigurationException.java	ø	ø	ø	ø	100.00%	100.00%
.../java/org/apache/dubbo/admin/common/exception/ParamValidationException.java	ø	ø	ø	ø	100.00%	100.00%
...java/org/apache/dubbo/admin/common/exception/PermissionDeniedException.java	ø	ø	ø	ø	0.00%	0.00%
...java/org/apache/dubbo/admin/common/exception/ResourceNotFoundException.java	ø	ø	ø	ø	25.00%	25.00%
...src/main/java/org/apache/dubbo/admin/common/exception/ServiceException.java	ø	ø	ø	ø	0.00%	0.00%
.../src/main/java/org/apache/dubbo/admin/common/exception/SystemException.java	ø	ø	ø	ø	25.00%	25.00%
...ava/org/apache/dubbo/admin/common/exception/VersionValidationException.java	ø	ø	ø	ø	100.00%	100.00%
...dmin-server/src/main/java/org/apache/dubbo/admin/common/util/CoderUtil.java	ø	ø	ø	ø	76.92%	83.33%
...dmin-server/src/main/java/org/apache/dubbo/admin/common/util/Constants.java	ø	ø	ø	ø	0.00%	0.00%
...in-server/src/main/java/org/apache/dubbo/admin/common/util/ConvertUtil.java	ø	ø	ø	ø	23.81%	20.45%
...-server/src/main/java/org/apache/dubbo/admin/common/util/OverrideUtils.java	ø	ø	ø	ø	0.00%	0.00%
...bbo-admin-server/src/main/java/org/apache/dubbo/admin/common/util/Pair.java	ø	ø	ø	ø	0.00%	0.00%
...min-server/src/main/java/org/apache/dubbo/admin/common/util/ParseUtils.java	ø	ø	ø	ø	0.00%	0.00%
...min-server/src/main/java/org/apache/dubbo/admin/common/util/RouteUtils.java	+1	ø	ø	+1	^+3.00% 6.00%	^-0.02% 9.11%
...erver/src/main/java/org/apache/dubbo/admin/common/util/ServiceTestUtil.java	ø	ø	ø	ø	0.00%	0.00%
...ver/src/main/java/org/apache/dubbo/admin/common/util/ServiceTestV3Util.java	ø	ø	ø	ø	0.00%	0.00%
...dmin-server/src/main/java/org/apache/dubbo/admin/common/util/SyncUtils.java	ø	ø	ø	ø	0.00%	0.00%
...bbo-admin-server/src/main/java/org/apache/dubbo/admin/common/util/Tool.java	ø	ø	ø	ø	7.14%	15.79%
...admin-server/src/main/java/org/apache/dubbo/admin/common/util/UrlUtils.java	ø	ø	ø	ø	77.78%	90.48%
...min-server/src/main/java/org/apache/dubbo/admin/common/util/YamlParser.java	ø	ø	ø	ø	80.00%	58.33%
...-admin-server/src/main/java/org/apache/dubbo/admin/config/ConfigCenter.java	+5	+5	ø	ø	75.00%	^0.83% 88.16%
...erver/src/main/java/org/apache/dubbo/admin/config/SwaggerConfiguration.java	ø	ø	ø	ø	0.00%	0.00%
...server/src/main/java/org/apache/dubbo/admin/config/WebMvcConfiguration.java	ø	ø	ø	ø	100.00%	100.00%
...ver/src/main/java/org/apache/dubbo/admin/controller/AccessesController.java	ø	ø	ø	ø	73.68%	85.00%
...rver/src/main/java/org/apache/dubbo/admin/controller/ApiDocsController.java	ø	ø	ø	ø	7.89%	8.54%
.../main/java/org/apache/dubbo/admin/controller/ConditionRoutesController.java	ø	ø	ø	ø	68.42%	78.05%
.../src/main/java/org/apache/dubbo/admin/controller/LoadBalanceController.java	ø	ø	ø	ø	77.78%	85.00%
...r/src/main/java/org/apache/dubbo/admin/controller/ManagementController.java	ø	ø	ø	ø	69.23%	77.78%
...er/src/main/java/org/apache/dubbo/admin/controller/MeshRouteController.java	ø	ø	ø	ø	58.33%	62.07%
...c/main/java/org/apache/dubbo/admin/controller/MetricsCollectController.java	+1	ø	ø	+1	10.00%	^-0.25% 11.11%
...ver/src/main/java/org/apache/dubbo/admin/controller/MockRuleController.java	ø	ø	ø	ø	25.00%	16.67%
...er/src/main/java/org/apache/dubbo/admin/controller/OverridesController.java	ø	ø	ø	ø	5.88%	9.76%
...rver/src/main/java/org/apache/dubbo/admin/controller/ServiceController.java	ø	ø	ø	ø	9.09%	10.20%
.../src/main/java/org/apache/dubbo/admin/controller/ServiceTestController.java	ø	ø	ø	ø	9.09%	11.43%
...er/src/main/java/org/apache/dubbo/admin/controller/TagRoutesController.java	ø	ø	ø	ø	6.25%	8.70%
...-server/src/main/java/org/apache/dubbo/admin/controller/UserController.java	ø	ø	ø	ø	9.09%	4.76%
...erver/src/main/java/org/apache/dubbo/admin/controller/WeightController.java	ø	ø	ø	ø	5.88%	10.53%
...java/org/apache/dubbo/admin/controller/beans/DubboApiDocsParamInfoBean.java	ø	ø	ø	ø	0.00%	0.00%
...n/java/org/apache/dubbo/admin/controller/editors/CustomLocalDateEditor.java	ø	ø	ø	ø	0.00%	0.00%
...va/org/apache/dubbo/admin/controller/editors/CustomLocalDateTimeEditor.java	ø	ø	ø	ø	0.00%	0.00%
...er/src/main/java/org/apache/dubbo/admin/handler/CustomExceptionHandler.java	ø	ø	ø	ø	71.43%	64.71%
...erver/src/main/java/org/apache/dubbo/admin/interceptor/AuthInterceptor.java	ø	ø	ø	ø	25.00%	10.53%
...rg/apache/dubbo/admin/model/adapter/BalancingDTO2OverrideConfigAdapter.java	ø	ø	ø	ø	0.00%	0.00%
...g/apache/dubbo/admin/model/adapter/DynamicConfigDTO2OverrideDTOAdapter.java	ø	ø	ø	ø	0.00%	0.00%
.../java/org/apache/dubbo/admin/model/adapter/LoadBalance2OverrideAdapter.java	ø	ø	ø	ø	0.00%	0.00%
...main/java/org/apache/dubbo/admin/model/adapter/WeightToOverrideAdapter.java	ø	ø	ø	ø	0.00%	0.00%
...dmin-server/src/main/java/org/apache/dubbo/admin/model/domain/Consumer.java	ø	ø	ø	ø	0.00%	0.00%
...-admin-server/src/main/java/org/apache/dubbo/admin/model/domain/Entity.java	ø	ø	ø	ø	2.78%	4.88%
...rc/main/java/org/apache/dubbo/admin/model/domain/FullServiceDefinition.java	ø	ø	ø	ø	0.00%	0.00%
...n-server/src/main/java/org/apache/dubbo/admin/model/domain/LoadBalance.java	ø	ø	ø	ø	0.00%	0.00%
...ver/src/main/java/org/apache/dubbo/admin/model/domain/MethodDefinition.java	ø	ø	ø	ø	0.00%	0.00%
...erver/src/main/java/org/apache/dubbo/admin/model/domain/MethodMetadata.java	ø	ø	ø	ø	0.00%	0.00%
...dmin-server/src/main/java/org/apache/dubbo/admin/model/domain/MockRule.java	ø	ø	ø	ø	0.00%	0.00%
...dmin-server/src/main/java/org/apache/dubbo/admin/model/domain/Override.java	ø	ø	ø	ø	0.00%	0.00%
...dmin-server/src/main/java/org/apache/dubbo/admin/model/domain/Provider.java	ø	ø	ø	ø	0.00%	0.00%
...erver/src/main/java/org/apache/dubbo/admin/model/domain/RegistrySource.java	ø	ø	ø	ø	0.00%	0.00%
...o-admin-server/src/main/java/org/apache/dubbo/admin/model/domain/Route.java	ø	ø	ø	ø	40.00%	43.48%
...er/src/main/java/org/apache/dubbo/admin/model/domain/ServiceDefinition.java	ø	ø	ø	ø	0.00%	0.00%
...bbo-admin-server/src/main/java/org/apache/dubbo/admin/model/domain/Tag.java	ø	ø	ø	ø	0.00%	0.00%
...erver/src/main/java/org/apache/dubbo/admin/model/domain/TypeDefinition.java	ø	ø	ø	ø	0.00%	0.00%
...-admin-server/src/main/java/org/apache/dubbo/admin/model/domain/Weight.java	ø	ø	ø	ø	0.00%	0.00%
...-admin-server/src/main/java/org/apache/dubbo/admin/model/dto/AccessDTO.java	ø	ø	ø	ø	100.00%	100.00%
...min-server/src/main/java/org/apache/dubbo/admin/model/dto/BalancingDTO.java	ø	ø	ø	ø	100.00%	100.00%
...bo-admin-server/src/main/java/org/apache/dubbo/admin/model/dto/BaseDTO.java	ø	ø	ø	ø	100.00%	100.00%
...erver/src/main/java/org/apache/dubbo/admin/model/dto/ConditionRouteDTO.java	ø	ø	ø	ø	100.00%	100.00%
...-admin-server/src/main/java/org/apache/dubbo/admin/model/dto/ConfigDTO.java	ø	ø	ø	ø	100.00%	100.00%
...server/src/main/java/org/apache/dubbo/admin/model/dto/DynamicConfigDTO.java	ø	ø	ø	ø	100.00%	100.00%
...min-server/src/main/java/org/apache/dubbo/admin/model/dto/MeshRouteDTO.java	ø	ø	ø	ø	100.00%	100.00%
...-admin-server/src/main/java/org/apache/dubbo/admin/model/dto/MetricDTO.java	ø	ø	ø	ø	0.00%	0.00%
...dmin-server/src/main/java/org/apache/dubbo/admin/model/dto/MockRuleDTO.java	ø	ø	ø	ø	0.00%	0.00%
...dmin-server/src/main/java/org/apache/dubbo/admin/model/dto/RelationDTO.java	ø	ø	ø	ø	0.00%	0.00%
...o-admin-server/src/main/java/org/apache/dubbo/admin/model/dto/RouteDTO.java	ø	ø	ø	ø	100.00%	100.00%
...admin-server/src/main/java/org/apache/dubbo/admin/model/dto/ServiceDTO.java	ø	ø	ø	ø	0.00%	0.00%
...server/src/main/java/org/apache/dubbo/admin/model/dto/ServiceDetailDTO.java	ø	ø	ø	ø	0.00%	0.00%
...n-server/src/main/java/org/apache/dubbo/admin/model/dto/ServiceTestDTO.java	ø	ø	ø	ø	0.00%	0.00%
...dmin-server/src/main/java/org/apache/dubbo/admin/model/dto/TagRouteDTO.java	ø	ø	ø	ø	0.00%	0.00%
...-admin-server/src/main/java/org/apache/dubbo/admin/model/dto/WeightDTO.java	ø	ø	ø	ø	0.00%	0.00%
...ver/src/main/java/org/apache/dubbo/admin/model/dto/docs/ApiInfoRequest.java	ø	ø	ø	ø	0.00%	0.00%
...ain/java/org/apache/dubbo/admin/model/dto/docs/CallDubboServiceRequest.java	ø	ø	ø	ø	0.00%	0.00%
...pache/dubbo/admin/model/dto/docs/CallDubboServiceRequestInterfaceParam.java	ø	ø	ø	ø	0.00%	0.00%
...server/src/main/java/org/apache/dubbo/admin/model/store/OverrideConfig.java	ø	ø	ø	ø	64.71%	64.00%
...in-server/src/main/java/org/apache/dubbo/admin/model/store/OverrideDTO.java	ø	ø	ø	ø	0.00%	0.00%
...in-server/src/main/java/org/apache/dubbo/admin/model/store/RoutingRule.java	ø	ø	ø	ø	100.00%	100.00%
...admin-server/src/main/java/org/apache/dubbo/admin/model/store/TagRoute.java	ø	ø	ø	ø	0.00%	0.00%
...-server/src/main/java/org/apache/dubbo/admin/model/store/mesh/BaseRule.java	ø	ø	ø	ø	50.00%	63.64%
...c/main/java/org/apache/dubbo/admin/model/store/mesh/VsDestinationGroup.java	ø	ø	ø	ø	0.00%	0.00%
...apache/dubbo/admin/model/store/mesh/destination/ConnectionPoolSettings.java	ø	ø	ø	ø	0.00%	0.00%
...va/org/apache/dubbo/admin/model/store/mesh/destination/DestinationRule.java	ø	ø	ø	ø	50.00%	50.00%
...rg/apache/dubbo/admin/model/store/mesh/destination/DestinationRuleSpec.java	ø	ø	ø	ø	50.00%	63.64%
...c/main/java/org/apache/dubbo/admin/model/store/mesh/destination/Subset.java	ø	ø	ø	ø	50.00%	62.50%
...n/java/org/apache/dubbo/admin/model/store/mesh/destination/TCPSettings.java	ø	ø	ø	ø	0.00%	0.00%
.../java/org/apache/dubbo/admin/model/store/mesh/destination/TcpKeepalive.java	ø	ø	ø	ø	0.00%	0.00%
...java/org/apache/dubbo/admin/model/store/mesh/destination/TrafficPolicy.java	ø	ø	ø	ø	50.00%	60.00%
.../dubbo/admin/model/store/mesh/destination/loadbalance/ConsistentHashLB.java	ø	ø	ø	ø	0.00%	0.00%
...bo/admin/model/store/mesh/destination/loadbalance/LoadBalancerSettings.java	ø	ø	ø	ø	33.33%	37.50%
...g/apache/dubbo/admin/model/store/mesh/destination/loadbalance/SimpleLB.java	ø	ø	ø	ø	100.00%	100.00%
...g/apache/dubbo/admin/model/store/mesh/virtualservice/DubboMatchRequest.java	ø	ø	ø	ø	8.70%	9.09%
...java/org/apache/dubbo/admin/model/store/mesh/virtualservice/DubboRoute.java	ø	ø	ø	ø	37.50%	45.45%
...rg/apache/dubbo/admin/model/store/mesh/virtualservice/DubboRouteDetail.java	ø	ø	ø	ø	50.00%	63.64%
.../apache/dubbo/admin/model/store/mesh/virtualservice/VirtualServiceRule.java	ø	ø	ø	ø	50.00%	50.00%
.../apache/dubbo/admin/model/store/mesh/virtualservice/VirtualServiceSpec.java	ø	ø	ø	ø	50.00%	62.50%
...bbo/admin/model/store/mesh/virtualservice/destination/DubboDestination.java	ø	ø	ø	ø	33.33%	38.46%
...dmin/model/store/mesh/virtualservice/destination/DubboRouteDestination.java	ø	ø	ø	ø	40.00%	42.86%
...org/apache/dubbo/admin/model/store/mesh/virtualservice/match/BoolMatch.java	ø	ø	ø	ø	0.00%	0.00%
...g/apache/dubbo/admin/model/store/mesh/virtualservice/match/DoubleMatch.java	ø	ø	ø	ø	0.00%	0.00%
...che/dubbo/admin/model/store/mesh/virtualservice/match/DoubleRangeMatch.java	ø	ø	ø	ø	0.00%	0.00%
...dubbo/admin/model/store/mesh/virtualservice/match/DubboAttachmentMatch.java	ø	ø	ø	ø	0.00%	0.00%
...pache/dubbo/admin/model/store/mesh/virtualservice/match/DubboMethodArg.java	ø	ø	ø	ø	0.00%	0.00%
...che/dubbo/admin/model/store/mesh/virtualservice/match/DubboMethodMatch.java	ø	ø	ø	ø	0.00%	0.00%
...apache/dubbo/admin/model/store/mesh/virtualservice/match/ListBoolMatch.java	ø	ø	ø	ø	0.00%	0.00%
...ache/dubbo/admin/model/store/mesh/virtualservice/match/ListDoubleMatch.java	ø	ø	ø	ø	0.00%	0.00%
...ache/dubbo/admin/model/store/mesh/virtualservice/match/ListStringMatch.java	ø	ø	ø	ø	0.00%	0.00%
...g/apache/dubbo/admin/model/store/mesh/virtualservice/match/StringMatch.java	ø	ø	ø	ø	7.14%	9.38%
...rver/src/main/java/org/apache/dubbo/admin/provider/MockServiceProvider.java	ø	ø	ø	ø	50.00%	50.00%
.../org/apache/dubbo/admin/registry/config/impl/MultiDynamicConfiguration.java	ø	ø	ø	ø	82.35%	88.00%
...ain/java/org/apache/dubbo/admin/registry/config/impl/NoOpConfiguration.java	ø	ø	ø	ø	0.00%	0.00%
...main/java/org/apache/dubbo/admin/registry/mapping/AdminMappingListener.java	ø	ø	ø	ø	44.44%	80.43%
...ache/dubbo/admin/registry/mapping/AdminServiceInstancesChangedListener.java	+3	+3	ø	ø	^+2.00% 100.00%	100.00%
.../java/org/apache/dubbo/admin/registry/mapping/impl/NacosServiceMapping.java	ø	ø	ø	ø	5.26%	6.78%
...n/java/org/apache/dubbo/admin/registry/mapping/impl/NoOpServiceMapping.java	ø	ø	ø	ø	25.00%	25.00%
...a/org/apache/dubbo/admin/registry/mapping/impl/ZookeeperServiceMapping.java	ø	+3	ø	-3	88.24%	^+8.82% 91.18%
.../org/apache/dubbo/admin/registry/metadata/impl/ConsulMetaDataCollector.java	ø	ø	ø	ø	80.00%	68.42%
...a/org/apache/dubbo/admin/registry/metadata/impl/NacosMetaDataCollector.java	ø	ø	ø	ø	6.67%	2.56%
...va/org/apache/dubbo/admin/registry/metadata/impl/NoOpMetadataCollector.java	ø	ø	ø	ø	16.67%	16.67%
...a/org/apache/dubbo/admin/registry/metadata/impl/RedisMetaDataCollector.java	ø	ø	ø	ø	9.09%	2.94%
...g/apache/dubbo/admin/registry/metadata/impl/ZookeeperMetaDataCollector.java	ø	ø	ø	ø	33.33%	48.39%
...dmin-server/src/main/java/org/apache/dubbo/admin/service/RegistryCache.java	ø	ø	ø	ø	0.00%	0.00%
...server/src/main/java/org/apache/dubbo/admin/service/RegistryServerSync.java	ø	-2	-1	+3	67.65%	^-2.70% 85.14%
...rver/src/main/java/org/apache/dubbo/admin/service/impl/AbstractService.java	ø	ø	ø	ø	66.67%	66.67%
.../src/main/java/org/apache/dubbo/admin/service/impl/ConsumerServiceImpl.java	ø	ø	ø	ø	8.33%	3.33%
...r/src/main/java/org/apache/dubbo/admin/service/impl/GenericServiceImpl.java	ø	ø	ø	ø	37.50%	40.00%
...rc/main/java/org/apache/dubbo/admin/service/impl/InstanceRegistryCache.java	ø	ø	ø	ø	63.64%	70.00%
...n/java/org/apache/dubbo/admin/service/impl/InstanceRegistryQueryHelper.java	ø	ø	ø	ø	2.50%	3.03%
...c/main/java/org/apache/dubbo/admin/service/impl/InterfaceRegistryCache.java	ø	ø	ø	ø	75.00%	83.33%
...rc/main/java/org/apache/dubbo/admin/service/impl/ManagementServiceImpl.java	ø	ø	ø	ø	75.00%	71.43%
...src/main/java/org/apache/dubbo/admin/service/impl/MeshRouteServiceImpl.java	ø	ø	ø	ø	90.91%	96.88%
...ain/java/org/apache/dubbo/admin/service/impl/MetrcisCollectServiceImpl.java	ø	ø	ø	ø	0.00%	0.00%
...r/src/main/java/org/apache/dubbo/admin/service/impl/MetricsServiceImpl.java	ø	ø	ø	ø	5.88%	1.89%
.../src/main/java/org/apache/dubbo/admin/service/impl/MockRuleServiceImpl.java	ø	ø	ø	ø	6.25%	2.22%
.../src/main/java/org/apache/dubbo/admin/service/impl/OverrideServiceImpl.java	ø	ø	ø	ø	0.87%	0.28%
.../src/main/java/org/apache/dubbo/admin/service/impl/ProviderServiceImpl.java	ø	ø	ø	ø	1.56%	0.61%
...ver/src/main/java/org/apache/dubbo/admin/service/impl/RouteServiceImpl.java	ø	ø	ø	ø	31.88%	43.67%
...ver/src/main/java/org/apache/dubbo/admin/utils/ApiDocsDubboGenericUtil.java	ø	ø	ø	ø	9.09%	19.12%
...o-admin-server/src/main/java/org/apache/dubbo/admin/utils/JwtTokenUtil.java	ø	ø	ø	ø	40.00%	10.00%
...in-server/src/main/java/org/apache/dubbo/admin/utils/LocalDateTimeUtil.java	ø	ø	ø	ø	80.00%	80.00%
...dmin-server/src/main/java/org/apache/dubbo/admin/utils/SpringBeanUtils.java	ø	ø	ø	ø	66.67%	75.00%
Project Totals (149 files)	4,799	1,022	84	3,693	18.88%	21.30%

105	105
106	106		if (StringUtils.isNotEmpty(configCenter)) {
107	107		configCenterUrl = formUrl(configCenter, configCenterGroup, configCenterGroupNameSpace, username, password);
	108	+	logger.info("Admin using config center: " + configCenterUrl);
108	109		dynamicConfiguration = ExtensionLoader.getExtensionLoader(GovernanceConfiguration.class).getDefaultExtension();
109	110		dynamicConfiguration.setUrl(configCenterUrl);
110	111		dynamicConfiguration.init();

118	119		} else if (s.startsWith(Constants.METADATA_ADDRESS)) {
119	120		metadataUrl = formUrl(removerConfigKey(s), metadataGroup, metadataGroupNameSpace, username, password);
120	121		}
	122	+	logger.info("Registry address found from config center: " + registryUrl);
	123	+	logger.info("Metadata address found from config center: " + registryUrl);
121	124		});
122	125		}
123	126		}

127	130		dynamicConfiguration = ExtensionLoader.getExtensionLoader(GovernanceConfiguration.class).getDefaultExtension();
128	131		dynamicConfiguration.setUrl(registryUrl);
129	132		dynamicConfiguration.init();
130		-	logger.warn("you are using dubbo.registry.address, which is not recommend, please refer to: https://github.com/apache/incubator-dubbo-admin/wiki/Dubbo-Admin-configuration");
	133	+	logger.warn("you are using dubbo.registry.address, which is not recommend, please refer to: https://github.com/apache/dubbo-admin/wiki/Dubbo-Admin-configuration");
131	134		} else {
132		-	throw new ConfigurationException("Either config center or registry address is needed, please refer to https://github.com/apache/incubator-dubbo-admin/wiki/Dubbo-Admin-configuration");
	135	+	throw new ConfigurationException("Either config center or registry address is needed, please refer to https://github.com/apache/dubbo-admin/wiki/Dubbo-Admin-configuration");
133	136		//throw exception
134	137		}
135	138		}

145	148		Registry registry = null;
146	149		if (registryUrl == null) {
147	150		if (StringUtils.isBlank(registryAddress)) {
148		-	throw new ConfigurationException("Either config center or registry address is needed, please refer to https://github.com/apache/incubator-dubbo-admin/wiki/Dubbo-Admin-configuration");
	151	+	throw new ConfigurationException("Either config center or registry address is needed, please refer to https://github.com/apache/dubbo-admin/wiki/Dubbo-Admin-configuration");
149	152		}
150	153		registryUrl = formUrl(registryAddress, registryGroup, registryNameSpace, username, password);
151	154		}
	155	+
	156	+	logger.info("Admin using registry address: " + registryUrl);
	157	+
152	158		RegistryFactory registryFactory = ApplicationModel.defaultModel().getExtensionLoader(RegistryFactory.class).getAdaptiveExtension();
153	159		registry = registryFactory.getRegistry(registryUrl.addParameter(ENABLE_EMPTY_PROTECTION_KEY, String.valueOf(false)));
154	160		return registry;

166	172		metadataUrl = formUrl(metadataAddress, metadataGroup, metadataGroupNameSpace, username, password);
167	173		metadataUrl = metadataUrl.addParameter(CLUSTER_KEY, cluster);
168	174		}
	175	+	logger.info("Admin using metadata address: " + metadataUrl);
169	176		}
170	177		if (metadataUrl != null) {
171	178		metaDataCollector = ApplicationModel.defaultModel().getExtensionLoader(MetaDataCollector.class).getExtension(metadataUrl.getProtocol());
172	179		metaDataCollector.setUrl(metadataUrl);
173	180		metaDataCollector.init();
174	181		} else {
175		-	logger.warn("you are using dubbo.registry.address, which is not recommend, please refer to: https://github.com/apache/incubator-dubbo-admin/wiki/Dubbo-Admin-configuration");
	182	+	logger.warn("you are using dubbo.registry.address, which is not recommend, please refer to: https://github.com/apache/dubbo-admin/wiki/Dubbo-Admin-configuration");
176	183		}
177	184		return metaDataCollector;
178	185		}

Compare `ee2672c ... +6 ... f179042`

Flags

8 Commits

45	45		private ApiInfo apiInfo() {
46	46		return new ApiInfoBuilder()
47	47		.title("dubbo admin swagger api")
48		-	.description("for more information please visit github page: https://github.com/apache/incubator-dubbo-admin")
	48	+	.description("for more information please visit github page: https://github.com/apache/dubbo-admin")
49	49		.version("1.0")
50	50		.build();
51	51		}

97	97		origin.keySet().forEach(providers::remove);
98	98
99	99		for (List<InstanceAddressURL> instanceAddressURLs : providers.values()) {
100		-	MetadataService metadataService = MetadataUtils.referProxy(instanceAddressURLs.get(0).getInstance());
	100	+	MetadataService metadataService = MetadataUtils.referProxy(instanceAddressURLs.get(0).getInstance()).getProxy();
101	101		try {
102	102		Set<String> subscribedURLs = metadataService.getSubscribedURLs();
103	103

26	26		import java.util.List;
27	27		import java.util.Map;
28	28		import java.util.Set;
	29	+	import java.util.stream.Collectors;
29	30
30	31		public class AdminServiceInstancesChangedListener extends ServiceInstancesChangedListener {
31	32
32	33		private AddressChangeListener addressChangeListener;
33	34
34		-	private Map<String, Object> oldServiceUrls;
	35	+	private Map<String, List<ServiceInstancesChangedListener.ProtocolServiceKeyWithUrls>> oldServiceUrls;
35	36
36	37		public AdminServiceInstancesChangedListener(Set<String> serviceNames, ServiceDiscovery serviceDiscovery, AddressChangeListener addressChangeListener) {
37	38		super(serviceNames, serviceDiscovery);

43	44		oldServiceUrls.keySet().stream()
44	45		.filter(protocolServiceKey -> !serviceUrls.containsKey(protocolServiceKey))
45	46		.forEach(protocolServiceKey -> addressChangeListener.notifyAddressChanged(protocolServiceKey, new ArrayList<>()));
46		-	serviceUrls.forEach((protocolServiceKey, urls) -> addressChangeListener.notifyAddressChanged(protocolServiceKey, (List<URL>) urls));
	47	+	serviceUrls.forEach((protocolServiceKey, urls) -> addressChangeListener.notifyAddressChanged(protocolServiceKey, extractUrls(urls)));
47	48
48	49		oldServiceUrls = serviceUrls;
49	50		}
	51	+
	52	+	private List<URL> extractUrls(List<ServiceInstancesChangedListener.ProtocolServiceKeyWithUrls> keyUrls) {
	53	+	return keyUrls.stream()
	54	+	.flatMap((protocolServiceKeyWithUrls) -> protocolServiceKeyWithUrls.getUrls().stream())
	55	+	.collect(Collectors.toList());
	56	+	}
50	57		}

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Compare ee2672c ... +6 ... f179042

Flags

8 Commits

Compare `ee2672c ... +6 ... f179042`