Compare ⋅ apache/dubbo-admin

Flags

Flags have been temporarily removed from this view while the flagging feature is refactored for better performance and user experience.

You can still use flags when viewing individual files. Flag-level thresholds will also remain on pull and merge requests in your repository provider.

More information can be found in our documentation.

Showing 1 of 1 files from the diff.

43.67% 100.00% +0.50% 31.88% ø

...che/dubbo/admin/service/impl/RouteServiceImpl.java changed.

@@ -77,6 +77,7 @@

Loading

        //for 2.6
        if (StringUtils.isNotEmpty(newConditionRoute.getService())) {
            for (Route old : convertRouteToOldRoute(oldConditionRoute)) {
                old.setService(id);
            	registry.unregister(old.toUrl().addParameter(Constants.COMPATIBLE_CONFIG, true));
            }
            for (Route updated : convertRouteToOldRoute(newConditionRoute)) {

@@ -101,6 +102,7 @@

Loading

            RoutingRule originRule = YamlParser.loadObject(config, RoutingRule.class);
            ConditionRouteDTO conditionRouteDTO = RouteUtils.createConditionRouteFromRule(originRule);
            for (Route old : convertRouteToOldRoute(conditionRouteDTO)) {
                old.setService(id);
                URL oldUrl = old.toUrl();
                if(oldUrl.getParameter("rule").contains("host") && oldUrl.getParameter("rule").contains("false")) {
                    registry.unregister(oldUrl);

Learn more Showing 1 files with coverage changes found.

Changes in dubbo-admin-server/src/main/java/org/apache/dubbo/admin/service/RegistryServerSync.java

-1

→

+2

Loading file...

21.58% 100.00% +0.08% 19.06% +0.09%

修复更新，删除service类型的条件路由异常的问题 (#861)

ymybxx

df24d39

CI Passed

+2

+4

-1

21.50% ø -0.11% 18.97% -0.18%

[ISSUE #856] update README.md (#857)

RobberPhex

bc280e5

CI Passed

Files		•	•	•	Complexity	Coverage
dubbo-admin-server/src/main/java/org/apache/dubbo/admin	+2	+4	-1	-1	19.06%	^0.08% 21.58%
Project Totals (149 files)	4,685	1,011	82	3,592	19.06%	21.58%

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Compare `bc280e5 ... +0 ... df24d39`

Flags

2 Commits

77	77		//for 2.6
78	78		if (StringUtils.isNotEmpty(newConditionRoute.getService())) {
79	79		for (Route old : convertRouteToOldRoute(oldConditionRoute)) {
	80	+	old.setService(id);
80	81		registry.unregister(old.toUrl().addParameter(Constants.COMPATIBLE_CONFIG, true));
81	82		}
82	83		for (Route updated : convertRouteToOldRoute(newConditionRoute)) {

101	102		RoutingRule originRule = YamlParser.loadObject(config, RoutingRule.class);
102	103		ConditionRouteDTO conditionRouteDTO = RouteUtils.createConditionRouteFromRule(originRule);
103	104		for (Route old : convertRouteToOldRoute(conditionRouteDTO)) {
	105	+	old.setService(id);
104	106		URL oldUrl = old.toUrl();
105	107		if(oldUrl.getParameter("rule").contains("host") && oldUrl.getParameter("rule").contains("false")) {
106	108		registry.unregister(oldUrl);

Compare bc280e5 ... +0 ... df24d39

Flags

2 Commits

Compare `bc280e5 ... +0 ... df24d39`