Compare ⋅ apache/dubbo-admin

Overview Diff Coverage Changes Files Commits

Flags

Flags have been temporarily removed from this view while the flagging feature is refactored for better performance and user experience.

You can still use flags when viewing individual files. Flag-level thresholds will also remain on pull and merge requests in your repository provider.

More information can be found in our documentation.

Showing 1 of 1 files from the diff.

75.00% 33.33% -0.34% 53.13% ø

...apache/dubbo/admin/service/RegistryServerSync.java changed.

@@ -28,6 +28,7 @@

Loading

import org.apache.dubbo.common.utils.StringUtils;
import org.apache.dubbo.registry.NotifyListener;
import org.apache.dubbo.registry.Registry;

import org.springframework.beans.factory.DisposableBean;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.context.event.ApplicationReadyEvent;

@@ -41,7 +42,6 @@

Loading

import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
import java.util.concurrent.atomic.AtomicLong;

@Component
public class RegistryServerSync implements DisposableBean, NotifyListener {

@@ -60,8 +60,6 @@

Loading

            Constants.ENABLED_KEY, Constants.ANY_VALUE,
            Constants.CHECK_KEY, String.valueOf(false));

    private static final AtomicLong ID = new AtomicLong();

    /**
     * Make sure ID never changed when the same url notified many times
     */

@@ -88,7 +86,7 @@

Loading

        registry.unsubscribe(SUBSCRIBE, this);
    }

    // Notification of of any service with any type (override、subcribe、route、provider) is full.
    // Notification of any service with any type (override、subscribe、route、provider) is full.
    @Override
    public void notify(List<URL> urls) {
        if (urls == null || urls.isEmpty()) {

@@ -157,12 +155,12 @@

Loading

            String category = categoryEntry.getKey();
            ConcurrentMap<String, Map<String, URL>> services = interfaceRegistryCache.get(category);
            if (services == null) {
                services = new ConcurrentHashMap<String, Map<String, URL>>();
                services = new ConcurrentHashMap<>();
                interfaceRegistryCache.put(category, services);
            } else {// Fix map can not be cleared when service is unregistered: when a unique “group/service:version” service is unregistered, but we still have the same services with different version or group, so empty protocols can not be invoked.
                Set<String> keys = new HashSet<String>(services.keySet());
                Set<String> keys = new HashSet<>(services.keySet());
                for (String key : keys) {
                    if (Tool.getInterface(key).equals(interfaceName) && !categoryEntry.getValue().entrySet().contains(key)) {
                    if (Tool.getInterface(key).equals(interfaceName) && !categoryEntry.getValue().containsKey(key)) {
                        services.remove(key);
                    }
                }

Everything is accounted for!

No changes detected that need to be reviewed.

What changes does Codecov check for?

Lines, not adjusted in diff, that have changed coverage data.

Files that introduced coverage data that had none before.

Files that have missing coverage data that once were tracked.

20.80% 33.33% -0.02% 18.69% ø

optimize some code for RegistryServerSync (#822)

BazookaW

cc5e780

CI Passed

-1

20.81% 0.00% -<.01% 18.69% -0.02%

Reduce nacos mapping service storage (#817)

haoyann

0f255b0

CI Passed

Files		•	•	•	Complexity	Coverage
dubbo-admin-server/src/main/java/org/apache/dubbo/admin	-1	-1	ø	ø	18.69%	^-0.02% 20.80%
Project Totals (144 files)	4,775	993	76	3,706	18.69%	20.80%

60	60		Constants.ENABLED_KEY, Constants.ANY_VALUE,
61	61		Constants.CHECK_KEY, String.valueOf(false));
62	62
63		-	private static final AtomicLong ID = new AtomicLong();
64		-
65	63		/**
66	64		* Make sure ID never changed when the same url notified many times
67	65		*/

157	155		String category = categoryEntry.getKey();
158	156		ConcurrentMap<String, Map<String, URL>> services = interfaceRegistryCache.get(category);
159	157		if (services == null) {
160		-	services = new ConcurrentHashMap<String, Map<String, URL>>();
	158	+	services = new ConcurrentHashMap<>();
161	159		interfaceRegistryCache.put(category, services);
162	160		} else {// Fix map can not be cleared when service is unregistered: when a unique “group/service:version” service is unregistered, but we still have the same services with different version or group, so empty protocols can not be invoked.
163		-	Set<String> keys = new HashSet<String>(services.keySet());
	161	+	Set<String> keys = new HashSet<>(services.keySet());
164	162		for (String key : keys) {
165		-	if (Tool.getInterface(key).equals(interfaceName) && !categoryEntry.getValue().entrySet().contains(key)) {
	163	+	if (Tool.getInterface(key).equals(interfaceName) && !categoryEntry.getValue().containsKey(key)) {
166	164		services.remove(key);
167	165		}
168	166		}

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Compare `0f255b0 ... +0 ... cc5e780`

Flags

Everything is accounted for!

What changes does Codecov check for?

2 Commits

28	28		import org.apache.dubbo.common.utils.StringUtils;
29	29		import org.apache.dubbo.registry.NotifyListener;
30	30		import org.apache.dubbo.registry.Registry;
	31	+
31	32		import org.springframework.beans.factory.DisposableBean;
32	33		import org.springframework.beans.factory.annotation.Autowired;
33	34		import org.springframework.boot.context.event.ApplicationReadyEvent;

41	42		import java.util.Set;
42	43		import java.util.concurrent.ConcurrentHashMap;
43	44		import java.util.concurrent.ConcurrentMap;
44		-	import java.util.concurrent.atomic.AtomicLong;
45	45
46	46		@Component
47	47		public class RegistryServerSync implements DisposableBean, NotifyListener {

88	86		registry.unsubscribe(SUBSCRIBE, this);
89	87		}
90	88
91		-	// Notification of of any service with any type (override、subcribe、route、provider) is full.
	89	+	// Notification of any service with any type (override、subscribe、route、provider) is full.
92	90		@Override
93	91		public void notify(List<URL> urls) {
94	92		if (urls == null \|\| urls.isEmpty()) {

Compare 0f255b0 ... +0 ... cc5e780

Flags

Everything is accounted for!

What changes does Codecov check for?

2 Commits

Compare `0f255b0 ... +0 ... cc5e780`