Commit ⋅ apache/dubbo-admin

Showing 1 of 1 files from the diff.

...registry/metadata/impl/RedisMetaDataCollector.java changed.

@@ -44,9 +44,9 @@

Loading

public class RedisMetaDataCollector implements MetaDataCollector {

    private final static Logger logger = LoggerFactory.getLogger(RedisMetaDataCollector.class);
    private final static String REDIS_DATABASE_KEY = "database";
    private URL url;
    private JedisPool pool;
    private static final String META_DATA_SOTRE_TAG = ".metaData";
    Set<HostAndPort> jedisClusterNodes;
    private int timeout;
    private String password;

@@ -73,7 +73,8 @@

Loading

                jedisClusterNodes.add(new HostAndPort(tmpUrl.getHost(), tmpUrl.getPort()));
            }
        } else {
            pool = new JedisPool(new JedisPoolConfig(), url.getHost(), url.getPort(), timeout, url.getPassword());
            int database = url.getParameter(REDIS_DATABASE_KEY, 0);
            pool = new JedisPool(new JedisPoolConfig(), url.getHost(), url.getPort(), timeout, url.getPassword(), database);
        }
    }


@@ -98,7 +99,7 @@

Loading

            }
        } else {
            try (Jedis jedis = pool.getResource()) {
                result = jedis.get(identifier.getUniqueKey(KeyTypeEnum.UNIQUE_KEY) + META_DATA_SOTRE_TAG);
                result = jedis.get(identifier.getUniqueKey(KeyTypeEnum.UNIQUE_KEY));
            } catch (Throwable e) {
                logger.error("Failed to get " + identifier + " from redis, cause: " + e.getMessage(), e);
                throw new RpcException("Failed to get " + identifier + " from redis, cause: " + e.getMessage(), e);

Files		•	•	•	Complexity	Coverage
dubbo-admin-server/src/main/java/org/apache/dubbo/admin	3,839	844	76	2,919	20.30%	21.98%
Project Totals (98 files)	3,839	844	76	2,919	20.30%	21.98%

unit

View CI Build Download

unit

View CI Build Download

No yaml found.

Create your codecov.yml to customize your Codecov experience

Read the docs

Interact now

The inner-most circle is the entire project, moving away from the center are folders then, finally, a single file. The size and color of each slice is representing the number of statements and the coverage, respectively.

SVG

The top section represents the entire project. Proceeding with folders and finally individual files. The size and color of each slice is representing the number of statements and the coverage, respectively.

SVG

Each block represents a single file in the project. The size and color of each block is represented by the number of statements and the coverage, respectively.

SVG

Learn more about the coverage sunburst graph

44	44		public class RedisMetaDataCollector implements MetaDataCollector {
45	45
46	46		private final static Logger logger = LoggerFactory.getLogger(RedisMetaDataCollector.class);
	47	+	private final static String REDIS_DATABASE_KEY = "database";
47	48		private URL url;
48	49		private JedisPool pool;
49		-	private static final String META_DATA_SOTRE_TAG = ".metaData";
50	50		Set<HostAndPort> jedisClusterNodes;
51	51		private int timeout;
52	52		private String password;

73	73		jedisClusterNodes.add(new HostAndPort(tmpUrl.getHost(), tmpUrl.getPort()));
74	74		}
75	75		} else {
76		-	pool = new JedisPool(new JedisPoolConfig(), url.getHost(), url.getPort(), timeout, url.getPassword());
	76	+	int database = url.getParameter(REDIS_DATABASE_KEY, 0);
	77	+	pool = new JedisPool(new JedisPoolConfig(), url.getHost(), url.getPort(), timeout, url.getPassword(), database);
77	78		}
78	79		}
79	80

98	99		}
99	100		} else {
100	101		try (Jedis jedis = pool.getResource()) {
101		-	result = jedis.get(identifier.getUniqueKey(KeyTypeEnum.UNIQUE_KEY) + META_DATA_SOTRE_TAG);
	102	+	result = jedis.get(identifier.getUniqueKey(KeyTypeEnum.UNIQUE_KEY));
102	103		} catch (Throwable e) {
103	104		logger.error("Failed to get " + identifier + " from redis, cause: " + e.getMessage(), e);
104	105		throw new RpcException("Failed to get " + identifier + " from redis, cause: " + e.getMessage(), e);

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Updating our web app

No yaml found.