Commit ⋅ apache/cordova-common

Showing 1 of 3 files from the diff.

Other files ignored by Codecov

spec/PluginInfo/PluginInfo.spec.js has changed.

...ixtures/plugins/org.test.xmlpassthrough/plugin.xml is new.

@@ -64,6 +64,13 @@

Loading

     * @return {Object} { key : default | null}
    */
    getPreferences (platform) {
        // XML passthrough for preferences is not supported because multiple preferences will override each other.
        // https://github.com/apache/cordova-common/issues/182
        // return this._getTags('preference', platform).map(({ attrib }) => {
        //     return Object.assign({}, attrib, {
        //         [attrib.name.toUpperCase()]: attrib.default || null
        //     });
        // })
        return this._getTags('preference', platform).map(({ attrib }) => ({
            [attrib.name.toUpperCase()]: attrib.default || null
        }))

@@ -84,7 +91,9 @@

Loading

                throw new Error(`Malformed <asset> tag. Both "src" and "target" attributes must be specified in ${this.filepath}`);
            }

            return { itemType: 'asset', src, target };
            return Object.assign({}, attrib, {
                itemType: 'asset', src, target
            });
        });
    }


@@ -105,14 +114,14 @@

Loading

                throw new CordovaError(`<dependency> tag is missing id attribute in ${this.filepath}`);
            }

            return {
            return Object.assign({}, attrib, {
                id: attrib.id,
                version: attrib.version || '',
                url: attrib.url || '',
                subdir: attrib.subdir || '',
                commit: attrib.commit,
                git_ref: attrib.commit
            };
            });
        });
    }


@@ -122,15 +131,17 @@

Loading

     * @param {string} platform
     */
    getConfigFiles (platform) {
        return this._getTags('config-file', platform).map(tag => ({
            target: tag.attrib.target,
            parent: tag.attrib.parent,
            after: tag.attrib.after,
            xmls: tag.getchildren(),
            // To support demuxing via versions
            versions: tag.attrib.versions,
            deviceTarget: tag.attrib['device-target']
        }));
        return this._getTags('config-file', platform).map(tag => {
            return Object.assign({}, tag.attrib, {
                target: tag.attrib.target,
                parent: tag.attrib.parent,
                after: tag.attrib.after,
                xmls: tag.getchildren(),
                // To support demuxing via versions
                versions: tag.attrib.versions,
                deviceTarget: tag.attrib['device-target']
            });
        });
    }

    /**

@@ -139,12 +150,14 @@

Loading

     * @param {string} platform
     */
    getEditConfigs (platform) {
        return this._getTags('edit-config', platform).map(tag => ({
            file: tag.attrib.file,
            target: tag.attrib.target,
            mode: tag.attrib.mode,
            xmls: tag.getchildren()
        }));
        return this._getTags('edit-config', platform).map(tag => {
            return Object.assign({}, tag.attrib, {
                file: tag.attrib.file,
                target: tag.attrib.target,
                mode: tag.attrib.mode,
                xmls: tag.getchildren()
            });
        });
    }

    /**

@@ -169,14 +182,16 @@

Loading

     * @param {string} platform
     */
    getSourceFiles (platform) {
        return this._getTagsInPlatform('source-file', platform).map(({ attrib }) => ({
            itemType: 'source-file',
            src: attrib.src,
            framework: isStrTrue(attrib.framework),
            weak: isStrTrue(attrib.weak),
            compilerFlags: attrib['compiler-flags'],
            targetDir: attrib['target-dir']
        }));
        return this._getTagsInPlatform('source-file', platform).map(({ attrib }) => {
            return Object.assign({}, attrib, {
                itemType: 'source-file',
                src: attrib.src,
                framework: isStrTrue(attrib.framework),
                weak: isStrTrue(attrib.weak),
                compilerFlags: attrib['compiler-flags'],
                targetDir: attrib['target-dir']
            });
        });
    }

    /**

@@ -187,12 +202,14 @@

Loading

     * @param {string} platform
     */
    getHeaderFiles (platform) {
        return this._getTagsInPlatform('header-file', platform).map(({ attrib }) => ({
            itemType: 'header-file',
            src: attrib.src,
            targetDir: attrib['target-dir'],
            type: attrib.type
        }));
        return this._getTagsInPlatform('header-file', platform).map(({ attrib }) => {
            return Object.assign({}, attrib, {
                itemType: 'header-file',
                src: attrib.src,
                targetDir: attrib['target-dir'],
                type: attrib.type
            });
        });
    }

    /**

@@ -210,15 +227,17 @@

Loading

     * @param {string} platform
     */
    getResourceFiles (platform) {
        return this._getTagsInPlatform('resource-file', platform).map(({ attrib }) => ({
            itemType: 'resource-file',
            src: attrib.src,
            target: attrib.target,
            versions: attrib.versions,
            deviceTarget: attrib['device-target'],
            arch: attrib.arch,
            reference: attrib.reference
        }));
        return this._getTagsInPlatform('resource-file', platform).map(({ attrib }) => {
            return Object.assign({}, attrib, {
                itemType: 'resource-file',
                src: attrib.src,
                target: attrib.target,
                versions: attrib.versions,
                deviceTarget: attrib['device-target'],
                arch: attrib.arch,
                reference: attrib.reference
            });
        });
    }

    /**

@@ -230,14 +249,16 @@

Loading

     * @param {string} platform
     */
    getLibFiles (platform) {
        return this._getTagsInPlatform('lib-file', platform).map(({ attrib }) => ({
            itemType: 'lib-file',
            src: attrib.src,
            arch: attrib.arch,
            Include: attrib.Include,
            versions: attrib.versions,
            deviceTarget: attrib['device-target'] || attrib.target
        }));
        return this._getTagsInPlatform('lib-file', platform).map(({ attrib }) => {
            return Object.assign({}, attrib, {
                itemType: 'lib-file',
                src: attrib.src,
                arch: attrib.arch,
                Include: attrib.Include,
                versions: attrib.versions,
                deviceTarget: attrib['device-target'] || attrib.target
            });
        });
    }

    /**

@@ -303,27 +324,33 @@

Loading

     * @param {string} platform
     */
    getJsModules (platform) {
        return this._getTags('js-module', platform).map(tag => ({
            itemType: 'js-module',
            name: tag.attrib.name,
            src: tag.attrib.src,
            clobbers: tag.findall('clobbers').map(tag => ({ target: tag.attrib.target })),
            merges: tag.findall('merges').map(tag => ({ target: tag.attrib.target })),
            runs: tag.findall('runs').length > 0
        }));
        return this._getTags('js-module', platform).map(tag => {
            return Object.assign({}, tag.attrib, {
                itemType: 'js-module',
                name: tag.attrib.name,
                src: tag.attrib.src,
                clobbers: tag.findall('clobbers').map(tag => ({ target: tag.attrib.target })),
                merges: tag.findall('merges').map(tag => ({ target: tag.attrib.target })),
                runs: tag.findall('runs').length > 0
            });
        });
    }

    getEngines () {
        return this._et.findall('engines/engine').map(({ attrib }) => ({
            name: attrib.name,
            version: attrib.version,
            platform: attrib.platform,
            scriptSrc: attrib.scriptSrc
        }));
        return this._et.findall('engines/engine').map(({ attrib }) => {
            return Object.assign({}, attrib, {
                name: attrib.name,
                version: attrib.version,
                platform: attrib.platform,
                scriptSrc: attrib.scriptSrc
            });
        });
    }

    getPlatforms () {
        return this._et.findall('platform').map(n => ({ name: n.attrib.name }));
        return this._et.findall('platform').map(n => {
            return Object.assign({}, n.attrib, { name: n.attrib.name });
        });
    }

    getPlatformsArray () {

@@ -346,21 +373,23 @@

Loading

        // Replaces plugin variables in s if they exist
        const expandVars = s => varExpansions.reduce((acc, fn) => fn(acc), s);

        return this._getTags('framework', platform).map(({ attrib }) => ({
            itemType: 'framework',
            type: attrib.type,
            parent: attrib.parent,
            custom: isStrTrue(attrib.custom),
            embed: isStrTrue(attrib.embed),
            src: expandVars(attrib.src),
            spec: attrib.spec,
            weak: isStrTrue(attrib.weak),
            versions: attrib.versions,
            targetDir: attrib['target-dir'],
            deviceTarget: attrib['device-target'] || attrib.target,
            arch: attrib.arch,
            implementation: attrib.implementation
        }));
        return this._getTags('framework', platform).map(({ attrib }) => {
            return Object.assign({}, attrib, {
                itemType: 'framework',
                type: attrib.type,
                parent: attrib.parent,
                custom: isStrTrue(attrib.custom),
                embed: isStrTrue(attrib.embed),
                src: expandVars(attrib.src),
                spec: attrib.spec,
                weak: isStrTrue(attrib.weak),
                versions: attrib.versions,
                targetDir: attrib['target-dir'],
                deviceTarget: attrib['device-target'] || attrib.target,
                arch: attrib.arch,
                implementation: attrib.implementation
            });
        });
    }

    getFilesAndFrameworks (platform, options) {

Files		•	•	Coverage
src	1,124	1,009	115	89.77%
cordova-common.js	17	0	17	0.00%
Project Totals (20 files)	1,141	1,009	132	88.43%

View CI Build Download

No yaml found.

Create your codecov.yml to customize your Codecov experience

Read the docs

Interact now

The inner-most circle is the entire project, moving away from the center are folders then, finally, a single file. The size and color of each slice is representing the number of statements and the coverage, respectively.

SVG

The top section represents the entire project. Proceeding with folders and finally individual files. The size and color of each slice is representing the number of statements and the coverage, respectively.

SVG

Each block represents a single file in the project. The size and color of each block is represented by the number of statements and the coverage, respectively.

SVG

Learn more about the coverage sunburst graph

105	114		throw new CordovaError(`<dependency> tag is missing id attribute in ${this.filepath}`);
106	115		}
107	116
108		-	return {
	117	+	return Object.assign({}, attrib, {
109	118		id: attrib.id,
110	119		version: attrib.version \|\| '',
111	120		url: attrib.url \|\| '',
112	121		subdir: attrib.subdir \|\| '',
113	122		commit: attrib.commit,
114	123		git_ref: attrib.commit
115		-	};
	124	+	});
116	125		});
117	126		}
118	127

187	202		* @param {string} platform
188	203		*/
189	204		getHeaderFiles (platform) {
190		-	return this._getTagsInPlatform('header-file', platform).map(({ attrib }) => ({
191		-	itemType: 'header-file',
192		-	src: attrib.src,
193		-	targetDir: attrib['target-dir'],
194		-	type: attrib.type
195		-	}));
	205	+	return this._getTagsInPlatform('header-file', platform).map(({ attrib }) => {
	206	+	return Object.assign({}, attrib, {
	207	+	itemType: 'header-file',
	208	+	src: attrib.src,
	209	+	targetDir: attrib['target-dir'],
	210	+	type: attrib.type
	211	+	});
	212	+	});
196	213		}
197	214
198	215		/**

210	227		* @param {string} platform
211	228		*/
212	229		getResourceFiles (platform) {
213		-	return this._getTagsInPlatform('resource-file', platform).map(({ attrib }) => ({
214		-	itemType: 'resource-file',
215		-	src: attrib.src,
216		-	target: attrib.target,
217		-	versions: attrib.versions,
218		-	deviceTarget: attrib['device-target'],
219		-	arch: attrib.arch,
220		-	reference: attrib.reference
221		-	}));
	230	+	return this._getTagsInPlatform('resource-file', platform).map(({ attrib }) => {
	231	+	return Object.assign({}, attrib, {
	232	+	itemType: 'resource-file',
	233	+	src: attrib.src,
	234	+	target: attrib.target,
	235	+	versions: attrib.versions,
	236	+	deviceTarget: attrib['device-target'],
	237	+	arch: attrib.arch,
	238	+	reference: attrib.reference
	239	+	});
	240	+	});
222	241		}
223	242
224	243		/**

230	249		* @param {string} platform
231	250		*/
232	251		getLibFiles (platform) {
233		-	return this._getTagsInPlatform('lib-file', platform).map(({ attrib }) => ({
234		-	itemType: 'lib-file',
235		-	src: attrib.src,
236		-	arch: attrib.arch,
237		-	Include: attrib.Include,
238		-	versions: attrib.versions,
239		-	deviceTarget: attrib['device-target'] \|\| attrib.target
240		-	}));
	252	+	return this._getTagsInPlatform('lib-file', platform).map(({ attrib }) => {
	253	+	return Object.assign({}, attrib, {
	254	+	itemType: 'lib-file',
	255	+	src: attrib.src,
	256	+	arch: attrib.arch,
	257	+	Include: attrib.Include,
	258	+	versions: attrib.versions,
	259	+	deviceTarget: attrib['device-target'] \|\| attrib.target
	260	+	});
	261	+	});
241	262		}
242	263
243	264		/**

303	324		* @param {string} platform
304	325		*/
305	326		getJsModules (platform) {
306		-	return this._getTags('js-module', platform).map(tag => ({
307		-	itemType: 'js-module',
308		-	name: tag.attrib.name,
309		-	src: tag.attrib.src,
310		-	clobbers: tag.findall('clobbers').map(tag => ({ target: tag.attrib.target })),
311		-	merges: tag.findall('merges').map(tag => ({ target: tag.attrib.target })),
312		-	runs: tag.findall('runs').length > 0
313		-	}));
	327	+	return this._getTags('js-module', platform).map(tag => {
	328	+	return Object.assign({}, tag.attrib, {
	329	+	itemType: 'js-module',
	330	+	name: tag.attrib.name,
	331	+	src: tag.attrib.src,
	332	+	clobbers: tag.findall('clobbers').map(tag => ({ target: tag.attrib.target })),
	333	+	merges: tag.findall('merges').map(tag => ({ target: tag.attrib.target })),
	334	+	runs: tag.findall('runs').length > 0
	335	+	});
	336	+	});
314	337		}
315	338
316	339		getEngines () {
317		-	return this._et.findall('engines/engine').map(({ attrib }) => ({
318		-	name: attrib.name,
319		-	version: attrib.version,
320		-	platform: attrib.platform,
321		-	scriptSrc: attrib.scriptSrc
322		-	}));
	340	+	return this._et.findall('engines/engine').map(({ attrib }) => {
	341	+	return Object.assign({}, attrib, {
	342	+	name: attrib.name,
	343	+	version: attrib.version,
	344	+	platform: attrib.platform,
	345	+	scriptSrc: attrib.scriptSrc
	346	+	});
	347	+	});
323	348		}
324	349
325	350		getPlatforms () {
326		-	return this._et.findall('platform').map(n => ({ name: n.attrib.name }));
	351	+	return this._et.findall('platform').map(n => {
	352	+	return Object.assign({}, n.attrib, { name: n.attrib.name });
	353	+	});
327	354		}
328	355
329	356		getPlatformsArray () {

64	64		* @return {Object} { key : default \| null}
65	65		*/
66	66		getPreferences (platform) {
	67	+	// XML passthrough for preferences is not supported because multiple preferences will override each other.
	68	+	// https://github.com/apache/cordova-common/issues/182
	69	+	// return this._getTags('preference', platform).map(({ attrib }) => {
	70	+	// return Object.assign({}, attrib, {
	71	+	// [attrib.name.toUpperCase()]: attrib.default \|\| null
	72	+	// });
	73	+	// })
67	74		return this._getTags('preference', platform).map(({ attrib }) => ({
68	75		[attrib.name.toUpperCase()]: attrib.default \|\| null
69	76		}))

84	91		throw new Error(`Malformed <asset> tag. Both "src" and "target" attributes must be specified in ${this.filepath}`);
85	92		}
86	93
87		-	return { itemType: 'asset', src, target };
	94	+	return Object.assign({}, attrib, {
	95	+	itemType: 'asset', src, target
	96	+	});
88	97		});
89	98		}
90	99

122	131		* @param {string} platform
123	132		*/
124	133		getConfigFiles (platform) {
125		-	return this._getTags('config-file', platform).map(tag => ({
126		-	target: tag.attrib.target,
127		-	parent: tag.attrib.parent,
128		-	after: tag.attrib.after,
129		-	xmls: tag.getchildren(),
130		-	// To support demuxing via versions
131		-	versions: tag.attrib.versions,
132		-	deviceTarget: tag.attrib['device-target']
133		-	}));
	134	+	return this._getTags('config-file', platform).map(tag => {
	135	+	return Object.assign({}, tag.attrib, {
	136	+	target: tag.attrib.target,
	137	+	parent: tag.attrib.parent,
	138	+	after: tag.attrib.after,
	139	+	xmls: tag.getchildren(),
	140	+	// To support demuxing via versions
	141	+	versions: tag.attrib.versions,
	142	+	deviceTarget: tag.attrib['device-target']
	143	+	});
	144	+	});
134	145		}
135	146
136	147		/**

139	150		* @param {string} platform
140	151		*/
141	152		getEditConfigs (platform) {
142		-	return this._getTags('edit-config', platform).map(tag => ({
143		-	file: tag.attrib.file,
144		-	target: tag.attrib.target,
145		-	mode: tag.attrib.mode,
146		-	xmls: tag.getchildren()
147		-	}));
	153	+	return this._getTags('edit-config', platform).map(tag => {
	154	+	return Object.assign({}, tag.attrib, {
	155	+	file: tag.attrib.file,
	156	+	target: tag.attrib.target,
	157	+	mode: tag.attrib.mode,
	158	+	xmls: tag.getchildren()
	159	+	});
	160	+	});
148	161		}
149	162
150	163		/**

169	182		* @param {string} platform
170	183		*/
171	184		getSourceFiles (platform) {
172		-	return this._getTagsInPlatform('source-file', platform).map(({ attrib }) => ({
173		-	itemType: 'source-file',
174		-	src: attrib.src,
175		-	framework: isStrTrue(attrib.framework),
176		-	weak: isStrTrue(attrib.weak),
177		-	compilerFlags: attrib['compiler-flags'],
178		-	targetDir: attrib['target-dir']
179		-	}));
	185	+	return this._getTagsInPlatform('source-file', platform).map(({ attrib }) => {
	186	+	return Object.assign({}, attrib, {
	187	+	itemType: 'source-file',
	188	+	src: attrib.src,
	189	+	framework: isStrTrue(attrib.framework),
	190	+	weak: isStrTrue(attrib.weak),
	191	+	compilerFlags: attrib['compiler-flags'],
	192	+	targetDir: attrib['target-dir']
	193	+	});
	194	+	});
180	195		}
181	196
182	197		/**

346	373		// Replaces plugin variables in s if they exist
347	374		const expandVars = s => varExpansions.reduce((acc, fn) => fn(acc), s);
348	375
349		-	return this._getTags('framework', platform).map(({ attrib }) => ({
350		-	itemType: 'framework',
351		-	type: attrib.type,
352		-	parent: attrib.parent,
353		-	custom: isStrTrue(attrib.custom),
354		-	embed: isStrTrue(attrib.embed),
355		-	src: expandVars(attrib.src),
356		-	spec: attrib.spec,
357		-	weak: isStrTrue(attrib.weak),
358		-	versions: attrib.versions,
359		-	targetDir: attrib['target-dir'],
360		-	deviceTarget: attrib['device-target'] \|\| attrib.target,
361		-	arch: attrib.arch,
362		-	implementation: attrib.implementation
363		-	}));
	376	+	return this._getTags('framework', platform).map(({ attrib }) => {
	377	+	return Object.assign({}, attrib, {
	378	+	itemType: 'framework',
	379	+	type: attrib.type,
	380	+	parent: attrib.parent,
	381	+	custom: isStrTrue(attrib.custom),
	382	+	embed: isStrTrue(attrib.embed),
	383	+	src: expandVars(attrib.src),
	384	+	spec: attrib.spec,
	385	+	weak: isStrTrue(attrib.weak),
	386	+	versions: attrib.versions,
	387	+	targetDir: attrib['target-dir'],
	388	+	deviceTarget: attrib['device-target'] \|\| attrib.target,
	389	+	arch: attrib.arch,
	390	+	implementation: attrib.implementation
	391	+	});
	392	+	});
364	393		}
365	394
366	395		getFilesAndFrameworks (platform, options) {

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Updating our web app

No yaml found.