Compare `9066f14 ... +12 ... d93a36a`

    :type at_all: bool
    """

    conn_name_attr = 'dingding_conn_id'
    default_conn_name = 'dingding_default'
    conn_type = 'dingding'
    hook_name = 'Dingding'

    def __init__(
        self,
        dingding_conn_id='dingding_default',

@@ -28,7 +28,7 @@

from airflow.exceptions import AirflowNotFoundException
from airflow.hooks.base import BaseHook
from airflow.models import Connection
from airflow.secrets.local_filesystem import _parse_secret_file
from airflow.secrets.local_filesystem import load_connections_dict
from airflow.utils import cli as cli_utils, yaml
from airflow.utils.cli import suppress_logs_and_warning
from airflow.utils.session import create_session

@@ -247,15 +247,13 @@


def _import_helper(file_path):
    """Load connections from a file and save them to the DB. On collision, skip."""
    connections_dict = _parse_secret_file(file_path)
    connections_dict = load_connections_dict(file_path)
    with create_session() as session:
        for conn_id, conn_dict in connections_dict.items():
        for conn_id, conn in connections_dict.items():
            if session.query(Connection).filter(Connection.conn_id == conn_id).first():
                print(f'Could not import connection {conn_id}: connection already exists.')
                continue

            # Add the connection to the DB
            connection = Connection(conn_id, **dict(conn_dict.items()))
            session.add(connection)
            session.add(conn)
            session.commit()
            print(f'Imported connection {conn_id}')

@@ -41,6 +41,11 @@


    """

    conn_name_attr = 'opsgenie_conn_id'
    default_conn_name = 'opsgenie_default'
    conn_type = 'opsgenie'
    hook_name = 'Opsgenie'

    def __init__(self, opsgenie_conn_id: str = 'opsgenie_default', *args, **kwargs) -> None:
        super().__init__(http_conn_id=opsgenie_conn_id, *args, **kwargs)  # type: ignore[misc]


@@ -61,6 +61,11 @@

    :type proxy: str
    """

    conn_name_attr = 'http_conn_id'
    default_conn_name = 'slack_default'
    conn_type = 'slackwebhook'
    hook_name = 'Slack Webhook'

    # pylint: disable=too-many-arguments
    def __init__(
        self,

@@ -33,6 +33,11 @@

    :type api_version: str
    """

    conn_name_attr = 'airbyte_conn_id'
    default_conn_name = 'airbyte_default'
    conn_type = 'airbyte'
    hook_name = 'Airbyte'

    RUNNING = "running"
    SUCCEEDED = "succeeded"
    CANCELLED = "cancelled"

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Learn more Showing 10 files with coverage changes found.

Changes in airflow/providers/dingding/hooks/dingding.py

→

Loading file...

Changes in airflow/providers/discord/hooks/discord_webhook.py

→

Loading file...

Changes in airflow/providers/slack/hooks/slack_webhook.py

→

Loading file...

Changes in airflow/executors/base_executor.py

-1

→

Loading file...

Changes in airflow/utils/dag_processing.py

-4

→

Loading file...

Changes in airflow/providers/airbyte/hooks/airbyte.py

-3

→

Loading file...

Changes in airflow/jobs/backfill_job.py

-1

→

Loading file...

Changes in airflow/providers/opsgenie/hooks/opsgenie_alert.py

-1

→

Loading file...

Changes in airflow/cli/commands/webserver_command.py

-1

→

Loading file...

Changes in airflow/task/task_runner/base_task_runner.py

-1

→

Loading file...

88.44% 83.33% -0.01%

Merge bacd4a0 into 6fd9c01

natanweinberger

#15425 d93a36a

CI Passed

Hiding 12 contexual commits

-1

-5

88.45% 100.00% ø

Fix connections import CLI

natanweinberger

#15425 9066f14

CI Passed

Files		•	•	•	Coverage
cloudwatch_task_handler.py	ø	ø	ø	ø	100.00%
colored_log.py	ø	ø	ø	ø	50.00%
es_task_handler.py	ø	ø	ø	ø	100.00%
file_processor_handler.py	ø	ø	ø	ø	94.11%
file_task_handler.py	ø	ø	ø	ø	76.78%
gcs_task_handler.py	ø	ø	ø	ø	100.00%
json_formatter.py	ø	ø	ø	ø	90.32%
log_reader.py	ø	ø	ø	ø	100.00%
logging_mixin.py	ø	ø	ø	ø	97.26%
s3_task_handler.py	ø	ø	ø	ø	100.00%
secrets_masker.py	ø	ø	ø	ø	94.89%
stackdriver_task_handler.py	ø	ø	ø	ø	100.00%
wasb_task_handler.py	ø	ø	ø	ø	100.00%
Folder Totals (13 files)	494	429	0	65	86.84%
Project Totals (1243 files)	62,816	55,559	0	7,257	88.44%

247	247
248	248		def _import_helper(file_path):
249	249		"""Load connections from a file and save them to the DB. On collision, skip."""
250		-	connections_dict = _parse_secret_file(file_path)
	250	+	connections_dict = load_connections_dict(file_path)
251	251		with create_session() as session:
252		-	for conn_id, conn_dict in connections_dict.items():
	252	+	for conn_id, conn in connections_dict.items():
253	253		if session.query(Connection).filter(Connection.conn_id == conn_id).first():
254	254		print(f'Could not import connection {conn_id}: connection already exists.')
255	255		continue
256	256
257		-	# Add the connection to the DB
258		-	connection = Connection(conn_id, **dict(conn_dict.items()))
259		-	session.add(connection)
	257	+	session.add(conn)
260	258		session.commit()
261	259		print(f'Imported connection {conn_id}')

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Compare `9066f14 ... +12 ... d93a36a`

No flags found

Show failed CI and contexual commits `c`

14 Commits

48	48		:type at_all: bool
49	49		"""
50	50
	51	+	conn_name_attr = 'dingding_conn_id'
	52	+	default_conn_name = 'dingding_default'
	53	+	conn_type = 'dingding'
	54	+	hook_name = 'Dingding'
	55	+
51	56		def __init__(
52	57		self,
53	58		dingding_conn_id='dingding_default',

28	28		from airflow.exceptions import AirflowNotFoundException
29	29		from airflow.hooks.base import BaseHook
30	30		from airflow.models import Connection
31		-	from airflow.secrets.local_filesystem import _parse_secret_file
	31	+	from airflow.secrets.local_filesystem import load_connections_dict
32	32		from airflow.utils import cli as cli_utils, yaml
33	33		from airflow.utils.cli import suppress_logs_and_warning
34	34		from airflow.utils.session import create_session

41	41
42	42		"""
43	43
	44	+	conn_name_attr = 'opsgenie_conn_id'
	45	+	default_conn_name = 'opsgenie_default'
	46	+	conn_type = 'opsgenie'
	47	+	hook_name = 'Opsgenie'
	48	+
44	49		def __init__(self, opsgenie_conn_id: str = 'opsgenie_default', args, *kwargs) -> None:
45	50		super().__init__(http_conn_id=opsgenie_conn_id, args, *kwargs) # type: ignore[misc]
46	51

61	61		:type proxy: str
62	62		"""
63	63
	64	+	conn_name_attr = 'http_conn_id'
	65	+	default_conn_name = 'slack_default'
	66	+	conn_type = 'slackwebhook'
	67	+	hook_name = 'Slack Webhook'
	68	+
64	69		# pylint: disable=too-many-arguments
65	70		def __init__(
66	71		self,

33	33		:type api_version: str
34	34		"""
35	35
	36	+	conn_name_attr = 'airbyte_conn_id'
	37	+	default_conn_name = 'airbyte_default'
	38	+	conn_type = 'airbyte'
	39	+	hook_name = 'Airbyte'
	40	+
36	41		RUNNING = "running"
37	42		SUCCEEDED = "succeeded"
38	43		CANCELLED = "cancelled"

Compare 9066f14 ... +12 ... d93a36a

No flags found

Show failed CI and contexual commits c 14 Commits

Compare `9066f14 ... +12 ... d93a36a`

Show failed CI and contexual commits `c`

14 Commits