Fix duplicate binding of query placeholders.
Showing 1 of 1 files from the diff.
@@ -5,6 +5,7 @@
Loading
5 | 5 | ||
6 | 6 | use ArrayObject; |
|
7 | 7 | use Cake\Database\Expression\IdentifierExpression; |
|
8 | + | use Cake\Database\ExpressionInterface; |
|
8 | 9 | use Cake\Datasource\EntityInterface; |
|
9 | 10 | use Cake\Event\EventInterface; |
|
10 | 11 | use Cake\ORM\Behavior; |
@@ -133,7 +134,7 @@
Loading
133 | 134 | $path = $this->getConfig('propertiesMap.' . $field); |
|
134 | 135 | ||
135 | 136 | $check = false; |
|
136 | - | $query->traverseExpressions(function ($expression) use (&$check, $field, $query) { |
|
137 | + | $query->traverseExpressions(function (ExpressionInterface $expression) use (&$check, $field, $query) { |
|
137 | 138 | if ($expression instanceof IdentifierExpression) { |
|
138 | 139 | !$check && $check = $expression->getIdentifier() === $field; |
|
139 | 140 |
@@ -142,7 +143,9 @@
Loading
142 | 143 | $alias = $this->_table->aliasField($field); |
|
143 | 144 | !$check && $check = preg_match( |
|
144 | 145 | '/^' . $alias . '/', |
|
145 | - | $expression->sql($query->getValueBinder()) |
|
146 | + | // TODO: Add test to show that cloning is necessary here to avoid issue mentioned in |
|
147 | + | // https://github.com/UseMuffin/Footprint/issues/74 |
|
148 | + | $expression->sql(clone $query->getValueBinder()) |
|
146 | 149 | ); |
|
147 | 150 | }); |
|
148 | 151 |
Files | Complexity | Coverage |
---|---|---|
src | 59 | 90.84% |
Project Totals (3 files) | 59 | 90.84% |
225.5
7.2=.2 TRAVIS_OS_NAME=linux
225.1
7.2=.2 TRAVIS_OS_NAME=linux
226.5
7.2=.2 TRAVIS_OS_NAME=linux
226.1
7.2=.2 TRAVIS_OS_NAME=linux
Sunburst
The inner-most circle is the entire project, moving away from the center are folders then, finally, a single file.
The size and color of each slice is representing the number of statements and the coverage, respectively.
Icicle
The top section represents the entire project. Proceeding with folders and finally individual files.
The size and color of each slice is representing the number of statements and the coverage, respectively.