ThinkR-open / golem

Compare c36505e ... +1 ... 09f4a2a

66.71% 0.00% -1.30%

Overview Diff Coverage Changes Files Commits
Coverage Reach
add_dockerfiles.R add_files.R options.R use_files.R utils.R create_golem.R use_favicon.R config.R add_modules.R desc.R bundle_resources.R reload.R add_rstudio_files.R test_helpers.R add_r_files.R use_recommended.R use_utils.R get_sysreqs.R addins.R run_dev.R with_opt.R js.R browser_button.R add_ressource_path.R make_dev.R yesno.R gobals.R is_running.R

No flags found

Use flags to group coverage reports by test type, project and/or folders.
Then setup custom commit statuses and notifications for each flag.

e.g., #unittest #integration

#production #enterprise

#frontend #backend

Learn more about Codecov Flags here.

Showing 1 of 1 files from the diff.

@@ -21,6 +21,11 @@
Loading
21 21
22 22 
  old <- setwd(path_abs(pkg))
23 23 
  on.exit(setwd(old))
24 +
25 + 
  if (missing(name)){
26 + 
    name <- basename(url)
27 + 
  }
28 +
24 29 
  name <-  file_path_sans_ext(name)
25 30 
  new_file <- sprintf( "%s.js", name )
26 31
@@ -41,6 +46,18 @@
Loading
41 46 
    dir, new_file
42 47 
  )
43 48
49 + 
  if (
50 + 
    fs::file_exists(where)
51 + 
  ){
52 + 
    cat_red_bullet(
53 + 
      sprintf(
54 + 
        "A file named `%s` already exists in %s. You need to delete or rename this file first.",
55 + 
        new_file, dir
56 + 
      )
57 + 
    )
58 + 
    return(invisible(FALSE))
59 + 
  }
60 +
44 61 
  if ( file_ext(url) != "js") {
45 62 
    cat_red_bullet(
46 63 
      "File not added (URL must end with .js extension)"
@@ -78,6 +95,11 @@
Loading
78 95
79 96 
  old <- setwd(path_abs(pkg))
80 97 
  on.exit(setwd(old))
98 +
99 + 
  if (missing(name)){
100 + 
    name <- basename(url)
101 + 
  }
102 +
81 103 
  name <-  file_path_sans_ext(name)
82 104 
  new_file <- sprintf("%s.css", name)
83 105
@@ -98,6 +120,18 @@
Loading
98 120 
    dir, new_file
99 121 
  )
100 122
123 + 
  if (
124 + 
    fs::file_exists(where)
125 + 
  ){
126 + 
    cat_red_bullet(
127 + 
      sprintf(
128 + 
        "A file named `%s` already exists in %s. You need to delete or rename this file first.",
129 + 
        new_file, dir
130 + 
      )
131 + 
    )
132 + 
    return(invisible(FALSE))
133 + 
  }
134 +
101 135 
  if ( file_ext(url) != "css") {
102 136 
    cat_red_bullet(
103 137 
      "File not added (URL must end with .css extension)"
@@ -158,6 +192,18 @@
Loading
158 192 
    dir, new_file
159 193 
  )
160 194
195 + 
  if (
196 + 
    fs::file_exists(where)
197 + 
  ){
198 + 
    cat_red_bullet(
199 + 
      sprintf(
200 + 
        "A file named `%s` already exists in %s. You need to delete or rename this file first.",
201 + 
        new_file, dir
202 + 
      )
203 + 
    )
204 + 
    return(invisible(FALSE))
205 + 
  }
206 +
161 207 
  cat_line("")
162 208 
  cat_rule("Initiating file download")
163 209
@@ -185,7 +231,6 @@
Loading
185 231 
  dir_create = TRUE
186 232 
){
187 233
188 -
189 234 
  if (missing(name)){
190 235 
    name <- basename(url)
191 236 
  }
@@ -210,6 +255,18 @@
Loading
210 255 
    dir, name
211 256 
  )
212 257
258 + 
  if (
259 + 
    fs::file_exists(where)
260 + 
  ){
261 + 
    cat_red_bullet(
262 + 
      sprintf(
263 + 
        "A file named `%s` already exists in %s. You need to delete or rename this file first.",
264 + 
        new_file, dir
265 + 
      )
266 + 
    )
267 + 
    return(invisible(FALSE))
268 + 
  }
269 +
213 270 
  cat_line("")
214 271 
  cat_rule("Initiating file download")
215 272

Everything is accounted for!

No changes detected that need to be reviewed.
What changes does Codecov check for?
Lines, not adjusted in diff, that have changed coverage data.
Files that introduced coverage data that had none before.
Files that have missing coverage data that once were tracked.

3 Commits

Colin Fay
66.71% 0.00% -1.30%
Merge pull request #500 from ThinkR-open/issue-498-497
ColinFay
09f4a2a
CI Passed
Colin Fay
66.71% 0.00% ø
use_external doesn't overwrite pre-existing files, and uses basename(url) as a name if it's missing.
ColinFay
d610ea2
CI Failed
Hiding 1 contexual commits
+28
+28
Colin Fay
68.01% ø ø
warnings are to be expected here
ColinFay
c36505e
CI Passed
Files Coverage
R -1.30% 66.71%
Project Totals (28 files) 66.71%
Loading