Other files ignored by Codecov
Tests/Tests/SDAnimatedImageTest.m
has changed.
Compare
7a21432
... +2 ...
3df06e9
7a21432
... +2 ...
3df06e9
Showing 1 of 2 files from the diff.
@@ -160,14 +160,14 @@
Loading
| 160 | 160 | } |
|
| 161 | 161 | } |
|
| 162 | 162 | ||
| 163 | - | - (void)resetCurrentFrameIndex { |
|
| 164 | - | self.currentFrame = nil; |
|
| 165 | - | self.currentFrameIndex = 0; |
|
| 166 | - | self.currentLoopCount = 0; |
|
| 167 | - | self.currentTime = 0; |
|
| 168 | - | self.bufferMiss = NO; |
|
| 169 | - | self.needsDisplayWhenImageBecomesAvailable = NO; |
|
| 170 | - | [self handleFrameChange]; |
|
| 163 | + | - (void)resetCurrentFrameStatus { |
|
| 164 | + | // These should not trigger KVO, user don't need to receive an `index == 0, image == nil` callback. |
|
| 165 | + | _currentFrame = nil; |
|
| 166 | + | _currentFrameIndex = 0; |
|
| 167 | + | _currentLoopCount = 0; |
|
| 168 | + | _currentTime = 0; |
|
| 169 | + | _bufferMiss = NO; |
|
| 170 | + | _needsDisplayWhenImageBecomesAvailable = NO; |
|
| 171 | 171 | } |
|
| 172 | 172 | ||
| 173 | 173 | - (void)clearFrameBuffer { |
@@ -191,7 +191,8 @@
Loading
| 191 | 191 | [_fetchQueue cancelAllOperations]; |
|
| 192 | 192 | // Using `_displayLink` here because when UIImageView dealloc, it may trigger `[self stopAnimating]`, we already release the display link in SDAnimatedImageView's dealloc method. |
|
| 193 | 193 | [_displayLink stop]; |
|
| 194 | - | [self resetCurrentFrameIndex]; |
|
| 194 | + | // We need to reset the frame status, but not trigger any handle. This can ensure next time's playing status correct. |
|
| 195 | + | [self resetCurrentFrameStatus]; |
|
| 195 | 196 | } |
|
| 196 | 197 | ||
| 197 | 198 | - (void)pausePlaying { |
Learn more Showing 1 files with coverage changes found.
Changes in
→
SDWebImage/Core/SDWebImageManager.m
-1
+1
Loading file...
4
Commits
| Files | Coverage |
|---|---|
| SDWebImage | -0.02% 83.27% |
| SDWebImageMapKit/MapKit/MKAnnotationView+WebCache.m | 65.51% |
| Project Totals (70 files) | 83.20% |
3df06e9718ce147cc90667a21432