Compare 7a21432 ... +2 ... 3df06e9

Coverage Reach
SDWebImage/Core/SDImageCache.m SDWebImage/Core/UIImage+Transform.m SDWebImage/Core/SDImageCoderHelper.m SDWebImage/Core/SDImageIOAnimatedCoder.m SDWebImage/Core/SDWebImageManager.m SDWebImage/Core/SDImageCachesManager.m SDWebImage/Core/SDWebImageDownloader.m SDWebImage/Core/SDWebImageDownloaderOperation.m SDWebImage/Core/UIView+WebCache.m SDWebImage/Core/SDAnimatedImagePlayer.m SDWebImage/Core/SDAnimatedImageView.m SDWebImage/Core/SDAnimatedImage.m SDWebImage/Core/SDDiskCache.m SDWebImage/Core/SDImageIOCoder.m SDWebImage/Core/SDWebImagePrefetcher.m SDWebImage/Core/SDImageLoader.m SDWebImage/Core/SDGraphicsImageRenderer.m SDWebImage/Core/SDImageTransformer.m SDWebImage/Core/SDWebImageIndicator.m SDWebImage/Core/UIButton+WebCache.m SDWebImage/Core/SDWebImageTransition.m SDWebImage/Core/NSData+ImageContentType.m SDWebImage/Core/SDMemoryCache.m SDWebImage/Core/UIImage+Metadata.m SDWebImage/Core/SDAnimatedImageRep.m SDWebImage/Core/NSButton+WebCache.m SDWebImage/Core/NSImage+Compatibility.m SDWebImage/Core/SDWebImageDefine.m SDWebImage/Core/SDImageCodersManager.m SDWebImage/Core/SDImageGraphics.m SDWebImage/Core/SDImageLoadersManager.m SDWebImage/Core/SDImageHEICCoder.m SDWebImage/Core/SDImageCacheDefine.m SDWebImage/Core/UIView+WebCacheOperation.m SDWebImage/Core/SDImageAWebPCoder.m SDWebImage/Core/SDImageCacheConfig.m SDWebImage/Core/SDAnimatedImageView+WebCache.m SDWebImage/Core/UIImageView+HighlightedWebCache.m SDWebImage/Core/SDWebImageDownloaderRequestModifier.m SDWebImage/Core/SDWebImageDownloaderResponseModifier.m SDWebImage/Core/UIImageView+WebCache.m SDWebImage/Core/SDWebImageDownloaderConfig.m SDWebImage/Core/UIImage+MemoryCacheCost.m SDWebImage/Core/SDWebImageDownloaderDecryptor.m SDWebImage/Core/SDImageAPNGCoder.m SDWebImage/Core/SDImageGIFCoder.m SDWebImage/Core/SDWebImageOptionsProcessor.m SDWebImage/Core/UIImage+MultiFormat.m SDWebImage/Core/UIImage+ForceDecode.m SDWebImage/Core/SDWebImageCacheKeyFilter.m SDWebImage/Core/SDWebImageCacheSerializer.m SDWebImage/Core/SDWebImageCompat.h SDWebImage/Core/SDImageFrame.m SDWebImage/Core/UIImage+GIF.m SDWebImage/Core/UIImage+ExtendedCacheData.m SDWebImage/Private/SDImageAssetManager.m SDWebImage/Private/SDFileAttributeHelper.m SDWebImage/Private/SDDisplayLink.m SDWebImage/Private/SDImageCachesManagerOperation.m SDWebImage/Private/SDAsyncBlockOperation.m SDWebImage/Private/SDWeakProxy.m SDWebImage/Private/SDInternalMacros.h SDWebImage/Private/UIColor+SDHexString.m SDWebImage/Private/NSBezierPath+SDRoundedCorners.m SDWebImage/Private/SDDeviceHelper.m SDWebImage/Private/SDAssociatedObject.m SDWebImage/Private/SDmetamacros.h SDWebImage/Private/SDImageIOAnimatedCoderInternal.h SDWebImage/Private/SDInternalMacros.m SDWebImageMapKit/MapKit/MKAnnotationView+WebCache.m

Flags

Flags have been temporarily removed from this view while the flagging feature is refactored for better performance and user experience.

You can still use flags when viewing individual files. Flag-level thresholds will also remain on pull and merge requests in your repository provider.

More information can be found in our documentation.

Showing 1 of 2 files from the diff.

@@ -160,14 +160,14 @@
Loading
160 160
    }
161 161
}
162 162
163 -
- (void)resetCurrentFrameIndex {
164 -
    self.currentFrame = nil;
165 -
    self.currentFrameIndex = 0;
166 -
    self.currentLoopCount = 0;
167 -
    self.currentTime = 0;
168 -
    self.bufferMiss = NO;
169 -
    self.needsDisplayWhenImageBecomesAvailable = NO;
170 -
    [self handleFrameChange];
163 +
- (void)resetCurrentFrameStatus {
164 +
    // These should not trigger KVO, user don't need to receive an `index == 0, image == nil` callback.
165 +
    _currentFrame = nil;
166 +
    _currentFrameIndex = 0;
167 +
    _currentLoopCount = 0;
168 +
    _currentTime = 0;
169 +
    _bufferMiss = NO;
170 +
    _needsDisplayWhenImageBecomesAvailable = NO;
171 171
}
172 172
173 173
- (void)clearFrameBuffer {
@@ -191,7 +191,8 @@
Loading
191 191
    [_fetchQueue cancelAllOperations];
192 192
    // Using `_displayLink` here because when UIImageView dealloc, it may trigger `[self stopAnimating]`, we already release the display link in SDAnimatedImageView's dealloc method.
193 193
    [_displayLink stop];
194 -
    [self resetCurrentFrameIndex];
194 +
    // We need to reset the frame status, but not trigger any handle. This can ensure next time's playing status correct.
195 +
    [self resetCurrentFrameStatus];
195 196
}
196 197
197 198
- (void)pausePlaying {

Learn more Showing 1 files with coverage changes found.

Changes in SDWebImage/Core/SDWebImageManager.m
-1
+1
Loading file...
Files Coverage
SDWebImage -0.02% 83.27%
SDWebImageMapKit/MapKit/MKAnnotationView+WebCache.m 65.51%
Project Totals (70 files) 83.20%
Loading