Compare `7ddede3 ... +10 ... e362c1a`

from dal import autocomplete
from django.conf import settings
from django.contrib import messages
from django.contrib.auth.mixins import PermissionRequiredMixin
from django.contrib.auth.mixins import LoginRequiredMixin, \
    PermissionRequiredMixin
from django.contrib.humanize.templatetags.humanize import ordinal
from django.core.exceptions import MultipleObjectsReturned
from django.core.paginator import Paginator

@@ -22,9 +23,8 @@

from mep.accounts.templatetags.account_tags import as_ranges
from mep.common import SCHEMA_ORG
from mep.common.utils import absolutize_url, alpha_pagelabels
from mep.common.views import (AjaxTemplateMixin, FacetJSONMixin,
                              LabeledPagesMixin, SolrLastModifiedMixin,
                              LoginRequiredOr404Mixin, RdfViewMixin)
from mep.common.views import AjaxTemplateMixin, FacetJSONMixin, \
    LabeledPagesMixin, RdfViewMixin, SolrLastModifiedMixin
from mep.people.forms import MemberSearchForm, PersonMergeForm
from mep.people.geonames import GeoNamesAPI
from mep.people.models import Country, Location, Person

@@ -628,7 +628,7 @@

        return context


class MembershipGraphs(LoginRequiredOr404Mixin, TemplateView):
class MembershipGraphs(LoginRequiredMixin, TemplateView):
    model = Person
    template_name = 'people/member_graphs.html'


@@ -217,8 +217,10 @@

# fallback for all protocols: block it
CSP_DEFAULT_SRC = "'none'"

# allow loading js locally and from google (for analytics)
CSP_SCRIPT_SRC = ("'self'", 'www.googletagmanager.com', '*.google-analytics.com')
# allow loading js locally, from google (for analytics), and
# nytimes github (for svg crowbar)
CSP_SCRIPT_SRC = ("'self'", 'www.googletagmanager.com',
                  '*.google-analytics.com', 'nytimes.github.io')

# allow loading fonts locally only
CSP_FONT_SRC = ("'self'",)

@@ -469,7 +469,17 @@

        'accounts.Event': {
            'post_save': WorkSignalHandlers.event_save,
            'pre_delete': WorkSignalHandlers.event_delete,
        }
        },
        # unfortunately the generic event signals aren't fired
        # when subclass types are edited directly, so bind the same signal
        'accounts.Borrow': {
            'post_save': WorkSignalHandlers.event_save,
            'pre_delete': WorkSignalHandlers.event_delete,
        },
        'accounts.Purchase': {
            'post_save': WorkSignalHandlers.event_save,
            'pre_delete': WorkSignalHandlers.event_delete,
        },
    }

    @classmethod

Everything is accounted for!

No changes detected that need to be reviewed.

What changes does Codecov check for?

Lines, not adjusted in diff, that have changed coverage data.

Files that introduced coverage data that had none before.

Files that have missing coverage data that once were tracked.

Hiding 4 contexual commits

98.01% ø ø

Decrease author width on mobile to avoid overlap with title #671

rlskoeser

90941d4

CI Passed

98.01% ø ø

Bind work event index signal handler to relevant event subclasses #683

rlskoeser

00c940f

CI Passed

98.01% ø ø

Fix membership graphs to use same linear scale for data and y-axis #687

rlskoeser

b5a8382

CI Passed

98.01% 100.00% ø

Make membership graphs login required instead of login required or 404

rlskoeser

02437c3

CI Passed

Hiding 1 contexual commits

98.01% 100.00% ø

Set develop version to 1.3.0-dev

rlskoeser

0239c2f

CI Passed

Hiding 1 contexual commits

-1

98.00% 100.00% ø

Merge branch 'release/1.2.1'

rlskoeser

7ddede3

CI Passed

Files		•	•	•	Coverage
mep	ø	ø	ø	ø	98.43%
srcmedia/ts	ø	ø	ø	ø	86.55%
Project Totals (223 files)	12,231	11,986	0	245	98.00%

628	628		return context
629	629
630	630
631		-	class MembershipGraphs(LoginRequiredOr404Mixin, TemplateView):
	631	+	class MembershipGraphs(LoginRequiredMixin, TemplateView):
632	632		model = Person
633	633		template_name = 'people/member_graphs.html'
634	634

469	469		'accounts.Event': {
470	470		'post_save': WorkSignalHandlers.event_save,
471	471		'pre_delete': WorkSignalHandlers.event_delete,
472		-	}
	472	+	},
	473	+	# unfortunately the generic event signals aren't fired
	474	+	# when subclass types are edited directly, so bind the same signal
	475	+	'accounts.Borrow': {
	476	+	'post_save': WorkSignalHandlers.event_save,
	477	+	'pre_delete': WorkSignalHandlers.event_delete,
	478	+	},
	479	+	'accounts.Purchase': {
	480	+	'post_save': WorkSignalHandlers.event_save,
	481	+	'pre_delete': WorkSignalHandlers.event_delete,
	482	+	},
473	483		}
474	484
475	485		@classmethod

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Compare `7ddede3 ... +10 ... e362c1a`

No flags found

Everything is accounted for!

What changes does Codecov check for?

Show failed CI and contexual commits `c`

12 Commits

3	3		from dal import autocomplete
4	4		from django.conf import settings
5	5		from django.contrib import messages
6		-	from django.contrib.auth.mixins import PermissionRequiredMixin
	6	+	from django.contrib.auth.mixins import LoginRequiredMixin, \
	7	+	PermissionRequiredMixin
7	8		from django.contrib.humanize.templatetags.humanize import ordinal
8	9		from django.core.exceptions import MultipleObjectsReturned
9	10		from django.core.paginator import Paginator

22	23		from mep.accounts.templatetags.account_tags import as_ranges
23	24		from mep.common import SCHEMA_ORG
24	25		from mep.common.utils import absolutize_url, alpha_pagelabels
25		-	from mep.common.views import (AjaxTemplateMixin, FacetJSONMixin,
26		-	LabeledPagesMixin, SolrLastModifiedMixin,
27		-	LoginRequiredOr404Mixin, RdfViewMixin)
	26	+	from mep.common.views import AjaxTemplateMixin, FacetJSONMixin, \
	27	+	LabeledPagesMixin, RdfViewMixin, SolrLastModifiedMixin
28	28		from mep.people.forms import MemberSearchForm, PersonMergeForm
29	29		from mep.people.geonames import GeoNamesAPI
30	30		from mep.people.models import Country, Location, Person

217	217		# fallback for all protocols: block it
218	218		CSP_DEFAULT_SRC = "'none'"
219	219
220		-	# allow loading js locally and from google (for analytics)
221		-	CSP_SCRIPT_SRC = ("'self'", 'www.googletagmanager.com', '*.google-analytics.com')
	220	+	# allow loading js locally, from google (for analytics), and
	221	+	# nytimes github (for svg crowbar)
	222	+	CSP_SCRIPT_SRC = ("'self'", 'www.googletagmanager.com',
	223	+	'*.google-analytics.com', 'nytimes.github.io')
222	224
223	225		# allow loading fonts locally only
224	226		CSP_FONT_SRC = ("'self'",)

Compare 7ddede3 ... +10 ... e362c1a

No flags found

Everything is accounted for!

What changes does Codecov check for?

Show failed CI and contexual commits c 12 Commits

Compare `7ddede3 ... +10 ... e362c1a`

Show failed CI and contexual commits `c`

12 Commits