Compare `0a2bc79 ... +32 ... ae9bbfa`

97.91% 100.00% -<.01%

Showing 9 of 21 files from the diff.

100.00% ø ø

mep/common/__init__.py changed.

100.00% ø ø

mep/books/tests/test_books_models.py changed.

99.43% 100.00% ø

mep/books/views.py changed.

99.47% 100.00% +0.01%

mep/accounts/tests/test_accounts_migrations.py changed.

83.33% 100.00% ø

mep/__init__.py changed.

100.00% 100.00% ø

mep/books/queryset.py changed.

100.00% 100.00% ø

mep/people/tests/test_people_migrations.py changed.

97.32% 100.00% ø

mep/people/views.py changed.

100.00% 100.00% ø

mep/accounts/tests/test_twitterbot_100years.py changed.

Other files ignored by Codecov

mep/books/fixtures/sample_works.json has changed.

CHANGELOG.rst has changed.

ci/testsettings.py has changed.

mep/footnotes/fixtures/sample_cards.json has changed.

mep/local_settings.py.sample has changed.

solr_conf/conf/managed-schema has changed.

mep/accounts/fixtures/test_events.json has changed.

README.rst has changed.

.github/workflows/unit_tests.yml has changed.

requirements.txt has changed.

mep/common/solr.py was deleted.

mep/books/fixtures/multi_creator_work.json has changed.

@@ -9,5 +9,3 @@


default_app_config = 'mep.common.apps.CommonConfig'
SCHEMA_ORG = rdflib.Namespace('http://schema.org/')

from mep.common.solr import SolrSchema

@@ -108,7 +108,7 @@


        # add one each of author, editor, and translator
        Creator.objects.create(
            creator_type=author_type, person=author1, work=work)
            creator_type=author_type, person=author1, work=work, order=1)
        Creator.objects.create(
            creator_type=editor_type, person=editor, work=work)
        Creator.objects.create(

@@ -120,7 +120,7 @@


        # add second author
        Creator.objects.create(creator_type=author_type, person=author2,
                               work=work)
                               work=work, order=2)
        assert len(work.authors) == 2
        assert author1 in work.authors
        assert author2 in work.authors

@@ -267,12 +267,12 @@

        author_type = CreatorType.objects.get(name='Author')
        author1 = Person.objects.create(name='Smith', slug='s')
        Creator.objects.create(
            creator_type=author_type, person=author1, work=work)
            creator_type=author_type, person=author1, work=work, order=1)
        assert work.author_list() == 'Smith'
        # multiple authors
        author2 = Person.objects.create(name='Jones', slug='j')
        Creator.objects.create(
            creator_type=author_type, person=author2, work=work)
            creator_type=author_type, person=author2, work=work, order=2)
        assert work.author_list() == 'Smith; Jones'

    def test_sort_author_list(self):

@@ -111,7 +111,7 @@

    # instead of hard-coding here

    #: bib data query alias field syntax (configured defaults is edismax)
    search_bib_query = '{!qf=$bib_qf pf=$bib_pf v=$bib_query}'
    search_bib_query = '{!type=edismax qf=$bib_qf pf=$bib_pf v=$bib_query}'

    def get_queryset(self):
        # NOTE faceting so that response doesn't register as an error;

@@ -14,6 +14,10 @@

# and from winthrop-django


skipif_postgres = pytest.mark.skipif(settings.DATABASES["default"]["ENGINE"].endswith('postgresql'),
                                      reason="doesn't work on postgres")


@pytest.mark.last
class TestMigrations(TransactionTestCase):


@@ -133,6 +137,8 @@

# to be present by other tests.
# Django test runner runs transaction test cases after simple test cases,
# but pytest / pytest-django do not.

@skipif_postgres
@pytest.mark.second_to_last
class TestCopyPrecisions(DatePrecisionCopies):


@@ -163,6 +169,7 @@

        self.check_copy_precisions(self.old_purchases, Purchase)


@skipif_postgres
@pytest.mark.last
class TestRevertPrecisionCopy(DatePrecisionCopies):
    migrate_from = '0028_generic_event_partial_dates'

@@ -1,4 +1,4 @@

1		-	__version_info__ = (1, 5, 2, None)
	1	+	__version_info__ = (1, 5, 3, None)
2	2
3	3
4	4		# Dot-connect all but the last. Last is dash-connected if not None.

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Click to load this diff.

Loading diff...

Everything is accounted for!

No changes detected that need to be reviewed.

What changes does Codecov check for?

Lines, not adjusted in diff, that have changed coverage data.

Files that introduced coverage data that had none before.

Files that have missing coverage data that once were tracked.

97.91% 100.00% -<.01%

Merge branch 'release/1.5.3' into main

rlskoeser

ae9bbfa

CI Passed

97.91% ø -0.01%

Update readme to reflect postgres/solr/python changes

rlskoeser

b4f2db5

CI Passed

Hiding 1 contexual commits

-1

97.91% ø ø

Merge pull request #753 from Princeton-CDH/chore/test-rdflib-6.0

rlskoeser

29f44df

CI Passed

97.91% ø +11.37%

Pin rdflib version and document changes

rlskoeser

23a7156

CI Passed

+220 Files

+12069

+11868

+201

86.55% ø -11.37%

Test upgrade to rdflib 6.0 with jsonld

rlskoeser

e92f52a

CI Passed

-220 Files

-12069

-11868

-201

97.91% ø -<.01%

Merge pull request #751 from Princeton-CDH/feature/solr-configset

rlskoeser

74955ab

CI Passed

-1 Files

-10

97.92% 100.00% ø

Merge pull request #748 from Princeton-CDH/feature/postgres-solr8

rlskoeser

acca4dc

CI Passed

+1 Files

+10

97.91% ø -<.01%

Move all solr schema management to configset

rlskoeser

e8c697f

CI Passed

-1 Files

-10

97.92% ø ø

Remove unneeded, commented out workflow step

rlskoeser

7056170

CI Passed

97.92% ø +0.45%

Re-enable python3/mysql build matrix

rlskoeser

0449997

CI Passed

+56

-56

97.47% ø +10.92%

Specify host for test database connection

rlskoeser

e1cef89

CI Passed

+221 Files

+12079

+11822

+257

86.55% ø ø

Temporarily disable python3.5 build

rlskoeser

8735a38

CI Passed

86.55% ø ø

Update solr queries for solr 8 compatibility

rlskoeser

22eb55f

CI Passed

Hiding 1 contexual commits

86.55% ø ø

Revise test settings for mysql

rlskoeser

ddd0d61

CI Passed

86.55% ø ø

Skip mysql permissions step; connecting as root

rlskoeser

f16955c

CI Passed

86.55% ø ø

Use previous mysql credential setup for CI

rlskoeser

b18b1a1

CI Passed

86.55% ø ø

Re-enable mysql/python3.5 test env

rlskoeser

63af02e

CI Passed

Hiding 1 contexual commits

86.55% ø ø

Update tests for postgres

rlskoeser

705feeb

CI Passed

Hiding 1 contexual commits

86.55% ø ø

Temporarily disable mysql build to test postrgres

rlskoeser

120d313

CI Passed

86.55% ø ø

Adjust mysql test config & permissions setup

rlskoeser

3cc10be

CI Passed

86.55% ø ø

Disable more test db configuration options

rlskoeser

676041d

CI Passed

86.55% ø ø

Use python3.5 compatible psycopg2 binary

rlskoeser

8b3695d

CI Passed

Hiding 1 contexual commits

86.55% ø ø

Add psycopg2 to python requirements

rlskoeser

4a7e9a4

CI Passed

86.55% ø ø

Correct db backend name; fill in message variables

rlskoeser

dae5642

CI Passed

86.55% ø ø

Revise matrix definition, correct db backend env

3ae02ab

3f47eed

Hiding 1 contexual commits

-221 Files

-12076

-11875

-201

97.92% 100.00% ø

Merge branch 'release/1.5.2' into develop

rlskoeser

ebaafbe

CI Passed

-1

97.91% 100.00% +<.01%

Merge branch 'release/1.5.2' into main

rlskoeser

0a2bc79

CI Passed

Files		•	•	•	Coverage
Project Totals (232 files)	12,515	12,253	0	262	97.91%

120	120
121	121		# add second author
122	122		Creator.objects.create(creator_type=author_type, person=author2,
123		-	work=work)
	123	+	work=work, order=2)
124	124		assert len(work.authors) == 2
125	125		assert author1 in work.authors
126	126		assert author2 in work.authors

267	267		author_type = CreatorType.objects.get(name='Author')
268	268		author1 = Person.objects.create(name='Smith', slug='s')
269	269		Creator.objects.create(
270		-	creator_type=author_type, person=author1, work=work)
	270	+	creator_type=author_type, person=author1, work=work, order=1)
271	271		assert work.author_list() == 'Smith'
272	272		# multiple authors
273	273		author2 = Person.objects.create(name='Jones', slug='j')
274	274		Creator.objects.create(
275		-	creator_type=author_type, person=author2, work=work)
	275	+	creator_type=author_type, person=author2, work=work, order=2)
276	276		assert work.author_list() == 'Smith; Jones'
277	277
278	278		def test_sort_author_list(self):

111	111		# instead of hard-coding here
112	112
113	113		#: bib data query alias field syntax (configured defaults is edismax)
114		-	search_bib_query = '{!qf=$bib_qf pf=$bib_pf v=$bib_query}'
	114	+	search_bib_query = '{!type=edismax qf=$bib_qf pf=$bib_pf v=$bib_query}'
115	115
116	116		def get_queryset(self):
117	117		# NOTE faceting so that response doesn't register as an error;

133	137		# to be present by other tests.
134	138		# Django test runner runs transaction test cases after simple test cases,
135	139		# but pytest / pytest-django do not.
	140	+
	141	+	@skipif_postgres
136	142		@pytest.mark.second_to_last
137	143		class TestCopyPrecisions(DatePrecisionCopies):
138	144

163	169		self.check_copy_precisions(self.old_purchases, Purchase)
164	170
165	171
	172	+	@skipif_postgres
166	173		@pytest.mark.last
167	174		class TestRevertPrecisionCopy(DatePrecisionCopies):
168	175		migrate_from = '0028_generic_event_partial_dates'

Compare `0a2bc79 ... +32 ... ae9bbfa`

Flags

Everything is accounted for!

What changes does Codecov check for?

Show failed CI and contexual commits `c`

34 Commits

9	9
10	10		default_app_config = 'mep.common.apps.CommonConfig'
11	11		SCHEMA_ORG = rdflib.Namespace('http://schema.org/')
12		-
13		-	from mep.common.solr import SolrSchema

108	108
109	109		# add one each of author, editor, and translator
110	110		Creator.objects.create(
111		-	creator_type=author_type, person=author1, work=work)
	111	+	creator_type=author_type, person=author1, work=work, order=1)
112	112		Creator.objects.create(
113	113		creator_type=editor_type, person=editor, work=work)
114	114		Creator.objects.create(

14	14		# and from winthrop-django
15	15
16	16
	17	+	skipif_postgres = pytest.mark.skipif(settings.DATABASES["default"]["ENGINE"].endswith('postgresql'),
	18	+	reason="doesn't work on postgres")
	19	+
	20	+
17	21		@pytest.mark.last
18	22		class TestMigrations(TransactionTestCase):
19	23

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Compare 0a2bc79 ... +32 ... ae9bbfa

Flags

Everything is accounted for!

What changes does Codecov check for?

Show failed CI and contexual commits c 34 Commits

Compare `0a2bc79 ... +32 ... ae9bbfa`

Show failed CI and contexual commits `c`

34 Commits