Commit ⋅ Princeton-CDH/mep-django

Showing 2 of 7 files from the diff.

100.00% 100.00% ø

mep/accounts/tests/test_accounts_commands.py changed.

100.00% 100.00% ø

mep/accounts/management/commands/export_events.py changed.

Other files ignored by Codecov

data-export-meta/full-datapackage.json is new.

data-export-meta/README.rst is new.

data-export-meta/books-datapackage.json is new.

data-export-meta/members-datapackage.json is new.

data-export-meta/events-datapackage.json is new.

@@ -419,7 +419,7 @@

Loading

        member_info = self.cmd.member_info(event)
        assert member_info['sort_names'][0] == person.sort_name
        assert member_info['names'][0] == person.name
        assert member_info['URIs'][0] == \
        assert member_info['uris'][0] == \
            absolutize_url(person.get_absolute_url())

        # event with two members; fixture includes Edel joint account

@@ -428,7 +428,7 @@

Loading


        member_info = self.cmd.member_info(event)
        # each field should have two values
        for field in ('sort_names', 'names', 'URIs'):
        for field in ('sort_names', 'names', 'uris'):
            assert len(member_info[field]) == 2

        # test event with account but no person

@@ -444,10 +444,9 @@

Loading

            .first()
        subs = event.subscription
        info = self.cmd.subscription_info(event)
        assert info['price_paid'] == '%s%.2f' % (subs.currency_symbol(),
                                                 subs.price_paid)
        assert info['price_paid'] == '%.2f' % subs.price_paid
        # test event has no deposit amount
        assert info['deposit'] == '%s0.00' % subs.currency_symbol()
        assert 'deposit' not in info
        assert info['duration'] == subs.readable_duration()
        assert info['duration_days'] == subs.duration
        assert info['volumes'] == subs.volumes

@@ -529,6 +528,19 @@

Loading

        assert info['manifest'] == footnote.bibliography.manifest.uri
        assert info['image'] == str(footnote.image.image)

    def test_get_object_data(self):
        # get a subscription with no subcategory and both dates
        event = Event.objects.filter(
            subscription__isnull=False,
            start_date__isnull=False, end_date__isnull=False,
            subscription__category__isnull=True) \
            .first()
        data = self.cmd.get_object_data(event)
        assert data['event_type'] == event.event_label
        assert data['currency'] == 'FRF'
        assert 'member' in data
        assert 'subscription' in data

    def test_command_line(self):
        # test calling via command line with args
        tempdir = TemporaryDirectory()

@@ -26,7 +26,7 @@

Loading

    csv_fields = [
        'event_type',
        'start_date', 'end_date',
        'member_URIs', 'member_names', 'member_sort_names',
        'member_uris', 'member_names', 'member_sort_names',
        # subscription specific
        'subscription_price_paid', 'subscription_deposit',
        'subscription_duration', 'subscription_duration_days',

@@ -38,6 +38,8 @@

Loading

        'borrow_status',
        # purchase specific
        'purchase_price',
        # currency applies to purchase, borrow, and subscription
        'currency',
        # related book/item
        'item_uri', 'item_title', 'item_volume', 'item_authors',
        'item_year', 'item_notes',

@@ -70,18 +72,19 @@

Loading


        # variable to store footnote reference, if any
        footnote = None
        currency = None

        # subscription-specific data
        if event_type in ['Subscription', 'Supplement', 'Renewal']:
            data['subscription'] = self.subscription_info(obj)
            currency = obj.subscription.currency

        # reimbursement data
        elif event_type in 'Reimbursement' and obj.reimbursement.refund:
            data['reimbursement'] = {
                'refund': '%s%.2f' %
                          (obj.reimbursement.currency_symbol(),
                           obj.reimbursement.refund)
                'refund': '%.2f' % obj.reimbursement.refund
            }
            currency = obj.reimbursement.currency

        # borrow data
        elif event_type == 'Borrow':

@@ -92,9 +95,12 @@

Loading

        # purchase data
        elif event_type == 'Purchase' and obj.purchase.price:
            data['purchase'] = {
                'price': '%s%.2f' %
                         (obj.purchase.currency_symbol(), obj.purchase.price)
                'price': '%.2f' % obj.purchase.price
            }
            currency = obj.purchase.currency

        if currency:
            data['currency'] = currency

        # footnote should always be attached to the base event
        footnote = obj.footnotes.first()

@@ -114,7 +120,7 @@

Loading

            return

        return OrderedDict([
            ('URIs', [absolutize_url(m.get_absolute_url()) for m in members]),
            ('uris', [absolutize_url(m.get_absolute_url()) for m in members]),
            ('names', [m.name for m in members]),
            ('sort_names', [m.sort_name for m in members])
        ])

@@ -127,12 +133,12 @@

Loading

        except ObjectDoesNotExist:
            return

        info = OrderedDict([
            ('price_paid', '%s%.2f' % (subs.currency_symbol(),
                                       subs.price_paid or 0)),
            ('deposit', '%s%.2f' % (subs.currency_symbol(),
                                    subs.deposit or 0))
        ])
        info = OrderedDict()
        if subs.price_paid:
            info['price_paid'] = '%.2f' % subs.price_paid
        if subs.deposit:
            info['deposit'] = '%.2f' % subs.deposit

        if subs.duration:
            info['duration'] = subs.readable_duration()
            info['duration_days'] = subs.duration

Files		•	•	Coverage
mep	11,782	11,598	184	98.44%
srcmedia/ts	446	386	60	86.55%
Project Totals (223 files)	12,228	11,984	244	98.00%

TRAVIS_PYTHON_VERSION=3.5
TRAVIS_OS_NAME=linux

View CI Build Download

No yaml found.

Create your codecov.yml to customize your Codecov experience

Read the docs

Interact now

The inner-most circle is the entire project, moving away from the center are folders then, finally, a single file. The size and color of each slice is representing the number of statements and the coverage, respectively.

SVG

The top section represents the entire project. Proceeding with folders and finally individual files. The size and color of each slice is representing the number of statements and the coverage, respectively.

SVG

Each block represents a single file in the project. The size and color of each block is represented by the number of statements and the coverage, respectively.

SVG

Learn more about the coverage sunburst graph

419	419		member_info = self.cmd.member_info(event)
420	420		assert member_info['sort_names'][0] == person.sort_name
421	421		assert member_info['names'][0] == person.name
422		-	assert member_info['URIs'][0] == \
	422	+	assert member_info['uris'][0] == \
423	423		absolutize_url(person.get_absolute_url())
424	424
425	425		# event with two members; fixture includes Edel joint account

428	428
429	429		member_info = self.cmd.member_info(event)
430	430		# each field should have two values
431		-	for field in ('sort_names', 'names', 'URIs'):
	431	+	for field in ('sort_names', 'names', 'uris'):
432	432		assert len(member_info[field]) == 2
433	433
434	434		# test event with account but no person

529	528		assert info['manifest'] == footnote.bibliography.manifest.uri
530	529		assert info['image'] == str(footnote.image.image)
531	530
	531	+	def test_get_object_data(self):
	532	+	# get a subscription with no subcategory and both dates
	533	+	event = Event.objects.filter(
	534	+	subscription__isnull=False,
	535	+	start_date__isnull=False, end_date__isnull=False,
	536	+	subscription__category__isnull=True) \
	537	+	.first()
	538	+	data = self.cmd.get_object_data(event)
	539	+	assert data['event_type'] == event.event_label
	540	+	assert data['currency'] == 'FRF'
	541	+	assert 'member' in data
	542	+	assert 'subscription' in data
	543	+
532	544		def test_command_line(self):
533	545		# test calling via command line with args
534	546		tempdir = TemporaryDirectory()

114	120		return
115	121
116	122		return OrderedDict([
117		-	('URIs', [absolutize_url(m.get_absolute_url()) for m in members]),
	123	+	('uris', [absolutize_url(m.get_absolute_url()) for m in members]),
118	124		('names', [m.name for m in members]),
119	125		('sort_names', [m.sort_name for m in members])
120	126		])

127	133		except ObjectDoesNotExist:
128	134		return
129	135
130		-	info = OrderedDict([
131		-	('price_paid', '%s%.2f' % (subs.currency_symbol(),
132		-	subs.price_paid or 0)),
133		-	('deposit', '%s%.2f' % (subs.currency_symbol(),
134		-	subs.deposit or 0))
135		-	])
	136	+	info = OrderedDict()
	137	+	if subs.price_paid:
	138	+	info['price_paid'] = '%.2f' % subs.price_paid
	139	+	if subs.deposit:
	140	+	info['deposit'] = '%.2f' % subs.deposit
	141	+
136	142		if subs.duration:
137	143		info['duration'] = subs.readable_duration()
138	144		info['duration_days'] = subs.duration

444	444		.first()
445	445		subs = event.subscription
446	446		info = self.cmd.subscription_info(event)
447		-	assert info['price_paid'] == '%s%.2f' % (subs.currency_symbol(),
448		-	subs.price_paid)
	447	+	assert info['price_paid'] == '%.2f' % subs.price_paid
449	448		# test event has no deposit amount
450		-	assert info['deposit'] == '%s0.00' % subs.currency_symbol()
	449	+	assert 'deposit' not in info
451	450		assert info['duration'] == subs.readable_duration()
452	451		assert info['duration_days'] == subs.duration
453	452		assert info['volumes'] == subs.volumes

26	26		csv_fields = [
27	27		'event_type',
28	28		'start_date', 'end_date',
29		-	'member_URIs', 'member_names', 'member_sort_names',
	29	+	'member_uris', 'member_names', 'member_sort_names',
30	30		# subscription specific
31	31		'subscription_price_paid', 'subscription_deposit',
32	32		'subscription_duration', 'subscription_duration_days',

38	38		'borrow_status',
39	39		# purchase specific
40	40		'purchase_price',
	41	+	# currency applies to purchase, borrow, and subscription
	42	+	'currency',
41	43		# related book/item
42	44		'item_uri', 'item_title', 'item_volume', 'item_authors',
43	45		'item_year', 'item_notes',

70	72
71	73		# variable to store footnote reference, if any
72	74		footnote = None
	75	+	currency = None
73	76
74	77		# subscription-specific data
75	78		if event_type in ['Subscription', 'Supplement', 'Renewal']:
76	79		data['subscription'] = self.subscription_info(obj)
	80	+	currency = obj.subscription.currency
77	81
78	82		# reimbursement data
79	83		elif event_type in 'Reimbursement' and obj.reimbursement.refund:
80	84		data['reimbursement'] = {
81		-	'refund': '%s%.2f' %
82		-	(obj.reimbursement.currency_symbol(),
83		-	obj.reimbursement.refund)
	85	+	'refund': '%.2f' % obj.reimbursement.refund
84	86		}
	87	+	currency = obj.reimbursement.currency
85	88
86	89		# borrow data
87	90		elif event_type == 'Borrow':

92	95		# purchase data
93	96		elif event_type == 'Purchase' and obj.purchase.price:
94	97		data['purchase'] = {
95		-	'price': '%s%.2f' %
96		-	(obj.purchase.currency_symbol(), obj.purchase.price)
	98	+	'price': '%.2f' % obj.purchase.price
97	99		}
	100	+	currency = obj.purchase.currency
	101	+
	102	+	if currency:
	103	+	data['currency'] = currency
98	104
99	105		# footnote should always be attached to the base event
100	106		footnote = obj.footnotes.first()

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Updating our web app

No yaml found.