Commit ⋅ Microsoft/mssql-jdbc

Showing 3 of 10 files from the diff.

73.82% 0.00% -0.40% 42.85% -2.86%

...QLServerColumnEncryptionAzureKeyVaultProvider.java changed.

81.96% 100.00% ø 64.70% ø

...soft/sqlserver/jdbc/SQLServerCertificateUtils.java changed.

49.65% 87.50% +0.97% 45.58% +0.38%

...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java changed.

Other files ignored by Codecov

...rosoft/sqlserver/jdbc/datatypes/DataTypesTest.java has changed.

...m/microsoft/sqlserver/jdbc/NTLMConnectionTest.java has changed.

pom.xml has changed.

...ft/sqlserver/jdbc/unit/lobs/LobsStreamingTest.java has changed.

.../microsoft/sqlserver/jdbc/SQLServerDriverTest.java has changed.

.../java/com/microsoft/sqlserver/jdbc/JDBC43Test.java has changed.

...oft/sqlserver/jdbc/connection/SSLProtocolTest.java has changed.

@@ -667,7 +667,7 @@

        boolean append = true;
        if (null != mssqlJdbcProperties) {
            String endpoints = mssqlJdbcProperties.getProperty(AKV_TRUSTED_ENDPOINTS_KEYWORD);
            if (null != endpoints && !endpoints.isBlank()) {
            if (null != endpoints && !endpoints.trim().isEmpty()) {
                endpoints = endpoints.trim();
                // Append if the list starts with a semicolon.
                if (';' != endpoints.charAt(0)) {

@@ -677,7 +677,7 @@

                }
                String[] entries = endpoints.split(";");
                for (String entry : entries) {
                    if (null != entry && !entry.isBlank()) {
                    if (null != entry && !entry.trim().isEmpty()) {
                        trustedEndpoints.add(entry.trim());
                    }
                }

@@ -14,6 +14,7 @@

import java.io.InputStream;
import java.io.StringReader;
import java.math.BigInteger;
import java.nio.Buffer;
import java.nio.ByteBuffer;
import java.nio.ByteOrder;
import java.nio.file.Files;

@@ -153,7 +154,7 @@

        ByteBuffer buffer = ByteBuffer.allocate((int) f.length());
        try (FileInputStream in = new FileInputStream(f)) {
            in.getChannel().read(buffer);
            buffer.order(ByteOrder.LITTLE_ENDIAN).rewind();
            ((Buffer) buffer.order(ByteOrder.LITTLE_ENDIAN)).rewind();

            long magic = buffer.getInt() & 0xFFFFFFFFL;
            if (PVK_MAGIC != magic) {

@@ -161,14 +162,15 @@

                        "", false);
            }

            buffer.position(buffer.position() + 8); // skip reserved and keytype
            ((Buffer) buffer).position(((Buffer) buffer).position() + 8); // skip reserved and keytype
            boolean encrypted = buffer.getInt() != 0;
            int saltLength = buffer.getInt();
            int keyLength = buffer.getInt();
            byte[] salt = new byte[saltLength];
            buffer.get(salt);

            buffer.position(buffer.position() + 8); // skip btype(1b), version(1b), reserved(2b), and keyalg(4b)
            ((Buffer) buffer).position(((Buffer) buffer).position() + 8); // skip btype(1b), version(1b), reserved(2b),
                                                                          // and keyalg(4b)

            byte[] key = new byte[keyLength - 8];
            buffer.get(key);

@@ -184,7 +186,7 @@

            }

            ByteBuffer buff = ByteBuffer.wrap(key).order(ByteOrder.LITTLE_ENDIAN);
            buff.position(RSA2_MAGIC.length); // skip the header
            ((Buffer) buff).position(RSA2_MAGIC.length); // skip the header

            int byteLength = buff.getInt() / 8;
            BigInteger publicExponent = BigInteger.valueOf(buff.getInt());

@@ -29,7 +29,7 @@



/**
 * Utility class for all Data Dependant Conversions (DDC).
 * Utility class for all Data Dependent Conversions (DDC).
 */

final class DDC {

@@ -348,9 +348,9 @@

            byte[] longbArray = new byte[bLength];
            Util.writeLong(bi.longValue(), longbArray, 0);
            /*
             * TDS 2.2.5.5.1.4 Fixed-Point Numbers
             * Money is represented as a 8 byte signed integer, with one 4-byte integer that represents
             * the more significant half, and one 4-byte integer that represents the less significant half.
             * TDS 2.2.5.5.1.4 Fixed-Point Numbers Money is represented as a 8 byte signed integer, with one 4-byte
             * integer that represents the more significant half, and one 4-byte integer that represents the less
             * significant half.
             */
            System.arraycopy(longbArray, 0, valueBytes, 4, 4);
            System.arraycopy(longbArray, 4, valueBytes, 0, 4);

@@ -653,9 +653,9 @@

        if (firstDash > 0 && secondDash > 0 && secondDash < dividingSpace - 1) {
            if (firstDash == YEAR_LENGTH && (secondDash - firstDash > 1 && secondDash - firstDash <= MONTH_LENGTH + 1)
                    && (dividingSpace - secondDash > 1 && dividingSpace - secondDash <= DAY_LENGTH + 1)) {
                year = Integer.parseInt(s, 0, firstDash, 10);
                month = Integer.parseInt(s, firstDash + 1, secondDash, 10);
                day = Integer.parseInt(s, secondDash + 1, dividingSpace, 10);
                year = Integer.parseInt(s.substring(0, firstDash));
                month = Integer.parseInt(s.substring(firstDash + 1, secondDash));
                day = Integer.parseInt(s.substring(secondDash + 1, dividingSpace));

                if ((month >= 1 && month <= MAX_MONTH) && (day >= 1 && day <= MAX_DAY)) {
                    parsedDate = true;

@@ -669,16 +669,16 @@

        // Convert the time; default missing nanos
        int len = s.length();
        if (firstColon > 0 && secondColon > 0 && secondColon < len - 1) {
            hour = Integer.parseInt(s, dividingSpace + 1, firstColon, 10);
            minute = Integer.parseInt(s, firstColon + 1, secondColon, 10);
            hour = Integer.parseInt(s.substring(dividingSpace + 1, firstColon));
            minute = Integer.parseInt(s.substring(firstColon + 1, secondColon));
            if (period > 0 && period < len - 1) {
                second = Integer.parseInt(s, secondColon + 1, period, 10);
                second = Integer.parseInt(s.substring(secondColon + 1, period));
                int nanoPrecision = len - (period + 1);
                if (nanoPrecision > 9)
                    throw new java.lang.IllegalArgumentException(formatError);
                if (!Character.isDigit(s.charAt(period + 1)))
                    throw new java.lang.IllegalArgumentException(formatError);
                int tmpNanos = Integer.parseInt(s, period + 1, len, 10);
                int tmpNanos = Integer.parseInt(s.substring(period + 1, len));
                while (nanoPrecision < 9) {
                    tmpNanos *= 10;
                    nanoPrecision++;

@@ -687,7 +687,7 @@

            } else if (period > 0) {
                throw new java.lang.IllegalArgumentException(formatError);
            } else {
                second = Integer.parseInt(s, secondColon + 1, len, 10);
                second = Integer.parseInt(s.substring(secondColon + 1, len));
            }
        } else {
            throw new java.lang.IllegalArgumentException(formatError);

Files		•	•	•	Complexity	Coverage
src/main/java	30,172	17,877	2,467	9,828	45.26%	59.25%
Project Totals (133 files)	30,172	17,877	2,467	9,828	45.26%	59.25%

Download

codecov:
  branch: dev
  notify:
    require_ci_to_pass: false
  coverage:
  	range: "10...100"
  comment:

Read the docs

Interact now

The inner-most circle is the entire project, moving away from the center are folders then, finally, a single file. The size and color of each slice is representing the number of statements and the coverage, respectively.

SVG

The top section represents the entire project. Proceeding with folders and finally individual files. The size and color of each slice is representing the number of statements and the coverage, respectively.

SVG

Each block represents a single file in the project. The size and color of each block is represented by the number of statements and the coverage, respectively.

SVG

Learn more about the coverage sunburst graph

677	677		}
678	678		String[] entries = endpoints.split(";");
679	679		for (String entry : entries) {
680		-	if (null != entry && !entry.isBlank()) {
	680	+	if (null != entry && !entry.trim().isEmpty()) {
681	681		trustedEndpoints.add(entry.trim());
682	682		}
683	683		}

153	154		ByteBuffer buffer = ByteBuffer.allocate((int) f.length());
154	155		try (FileInputStream in = new FileInputStream(f)) {
155	156		in.getChannel().read(buffer);
156		-	buffer.order(ByteOrder.LITTLE_ENDIAN).rewind();
	157	+	((Buffer) buffer.order(ByteOrder.LITTLE_ENDIAN)).rewind();
157	158
158	159		long magic = buffer.getInt() & 0xFFFFFFFFL;
159	160		if (PVK_MAGIC != magic) {

161	162		"", false);
162	163		}
163	164
164		-	buffer.position(buffer.position() + 8); // skip reserved and keytype
	165	+	((Buffer) buffer).position(((Buffer) buffer).position() + 8); // skip reserved and keytype
165	166		boolean encrypted = buffer.getInt() != 0;
166	167		int saltLength = buffer.getInt();
167	168		int keyLength = buffer.getInt();
168	169		byte[] salt = new byte[saltLength];
169	170		buffer.get(salt);
170	171
171		-	buffer.position(buffer.position() + 8); // skip btype(1b), version(1b), reserved(2b), and keyalg(4b)
	172	+	((Buffer) buffer).position(((Buffer) buffer).position() + 8); // skip btype(1b), version(1b), reserved(2b),
	173	+	// and keyalg(4b)
172	174
173	175		byte[] key = new byte[keyLength - 8];
174	176		buffer.get(key);

184	186		}
185	187
186	188		ByteBuffer buff = ByteBuffer.wrap(key).order(ByteOrder.LITTLE_ENDIAN);
187		-	buff.position(RSA2_MAGIC.length); // skip the header
	189	+	((Buffer) buff).position(RSA2_MAGIC.length); // skip the header
188	190
189	191		int byteLength = buff.getInt() / 8;
190	192		BigInteger publicExponent = BigInteger.valueOf(buff.getInt());

348	348		byte[] longbArray = new byte[bLength];
349	349		Util.writeLong(bi.longValue(), longbArray, 0);
350	350		/*
351		-	* TDS 2.2.5.5.1.4 Fixed-Point Numbers
352		-	* Money is represented as a 8 byte signed integer, with one 4-byte integer that represents
353		-	* the more significant half, and one 4-byte integer that represents the less significant half.
	351	+	* TDS 2.2.5.5.1.4 Fixed-Point Numbers Money is represented as a 8 byte signed integer, with one 4-byte
	352	+	* integer that represents the more significant half, and one 4-byte integer that represents the less
	353	+	* significant half.
354	354		*/
355	355		System.arraycopy(longbArray, 0, valueBytes, 4, 4);
356	356		System.arraycopy(longbArray, 4, valueBytes, 0, 4);

667	667		boolean append = true;
668	668		if (null != mssqlJdbcProperties) {
669	669		String endpoints = mssqlJdbcProperties.getProperty(AKV_TRUSTED_ENDPOINTS_KEYWORD);
670		-	if (null != endpoints && !endpoints.isBlank()) {
	670	+	if (null != endpoints && !endpoints.trim().isEmpty()) {
671	671		endpoints = endpoints.trim();
672	672		// Append if the list starts with a semicolon.
673	673		if (';' != endpoints.charAt(0)) {

14	14		import java.io.InputStream;
15	15		import java.io.StringReader;
16	16		import java.math.BigInteger;
	17	+	import java.nio.Buffer;
17	18		import java.nio.ByteBuffer;
18	19		import java.nio.ByteOrder;
19	20		import java.nio.file.Files;

29	29
30	30
31	31		/**
32		-	* Utility class for all Data Dependant Conversions (DDC).
	32	+	* Utility class for all Data Dependent Conversions (DDC).
33	33		*/
34	34
35	35		final class DDC {

653	653		if (firstDash > 0 && secondDash > 0 && secondDash < dividingSpace - 1) {
654	654		if (firstDash == YEAR_LENGTH && (secondDash - firstDash > 1 && secondDash - firstDash <= MONTH_LENGTH + 1)
655	655		&& (dividingSpace - secondDash > 1 && dividingSpace - secondDash <= DAY_LENGTH + 1)) {
656		-	year = Integer.parseInt(s, 0, firstDash, 10);
657		-	month = Integer.parseInt(s, firstDash + 1, secondDash, 10);
658		-	day = Integer.parseInt(s, secondDash + 1, dividingSpace, 10);
	656	+	year = Integer.parseInt(s.substring(0, firstDash));
	657	+	month = Integer.parseInt(s.substring(firstDash + 1, secondDash));
	658	+	day = Integer.parseInt(s.substring(secondDash + 1, dividingSpace));
659	659
660	660		if ((month >= 1 && month <= MAX_MONTH) && (day >= 1 && day <= MAX_DAY)) {
661	661		parsedDate = true;

669	669		// Convert the time; default missing nanos
670	670		int len = s.length();
671	671		if (firstColon > 0 && secondColon > 0 && secondColon < len - 1) {
672		-	hour = Integer.parseInt(s, dividingSpace + 1, firstColon, 10);
673		-	minute = Integer.parseInt(s, firstColon + 1, secondColon, 10);
	672	+	hour = Integer.parseInt(s.substring(dividingSpace + 1, firstColon));
	673	+	minute = Integer.parseInt(s.substring(firstColon + 1, secondColon));
674	674		if (period > 0 && period < len - 1) {
675		-	second = Integer.parseInt(s, secondColon + 1, period, 10);
	675	+	second = Integer.parseInt(s.substring(secondColon + 1, period));
676	676		int nanoPrecision = len - (period + 1);
677	677		if (nanoPrecision > 9)
678	678		throw new java.lang.IllegalArgumentException(formatError);
679	679		if (!Character.isDigit(s.charAt(period + 1)))
680	680		throw new java.lang.IllegalArgumentException(formatError);
681		-	int tmpNanos = Integer.parseInt(s, period + 1, len, 10);
	681	+	int tmpNanos = Integer.parseInt(s.substring(period + 1, len));
682	682		while (nanoPrecision < 9) {
683	683		tmpNanos *= 10;
684	684		nanoPrecision++;

687	687		} else if (period > 0) {
688	688		throw new java.lang.IllegalArgumentException(formatError);
689	689		} else {
690		-	second = Integer.parseInt(s, secondColon + 1, len, 10);
	690	+	second = Integer.parseInt(s.substring(secondColon + 1, len));
691	691		}
692	692		} else {
693	693		throw new java.lang.IllegalArgumentException(formatError);

1	codecov:
2	branch: dev
3	notify:
4	require_ci_to_pass: false
5	coverage:
6	range: "10...100"
7	comment:

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Updating our web app